Re: [PATCH v2 2/9] dt-bindings: gpio: Convert mrvl-gpio to json-schema
On Thu, 21 May 2020 11:13:49 +0200, Lubomir Rintel wrote: > This converts the mrvl-gpio binding to DT schema format using json-schema. > > Various fixes were done during the conversion, such as adding more > properties that are in fact mandatory or extending the examples to > include child nodes with extra GPIO blocks. > > The compatible strings are a mess. It is not clear why so many of them > are needed; the driver doesn't really seem to differentiate between the > models. Some of them, like marvell,pxa93x-gpio and marvell,pxa1928-gpio > are not used at all, so it's not known how many interrupts they utilize. > On the other hand, mrvl,pxa-gpio has been seen in the tree, but it > doesn't end up in any actual DTB file. > > In any case -- the schema merely copies whatever was in the original > binding document, so it's hopefully no more wrong that the original. > > Signed-off-by: Lubomir Rintel > > --- > Changes since v1: > - Drop marvell,pxa1928-gpio > - Drop ranges from example with no gcb child nodes > - Add default GPL-2.0-only license tag > - Fill in maintainers from MAINTAINERS file > > .../devicetree/bindings/gpio/mrvl-gpio.txt| 48 - > .../devicetree/bindings/gpio/mrvl-gpio.yaml | 174 ++ > 2 files changed, 174 insertions(+), 48 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/gpio/mrvl-gpio.txt > create mode 100644 Documentation/devicetree/bindings/gpio/mrvl-gpio.yaml > My bot found errors running 'make dt_binding_check' on your patch: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/gpio/mrvl-gpio.example.dt.yaml: gpio@40e0: 'ranges' is a required property See https://patchwork.ozlabs.org/patch/1295044 If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure dt-schema is up to date: pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade Please check and re-submit.
Re: [PATCH v12 1/3] dt-bindings: i2c: npcm7xx: add NPCM I2C controller
On Thu, 21 May 2020 14:09:08 +0300, Tali Perry wrote: > Added device tree binding documentation for Nuvoton BMC > NPCM I2C controller. > > Signed-off-by: Tali Perry > --- > .../bindings/i2c/nuvoton,npcm7xx-i2c.yaml | 62 +++ > 1 file changed, 62 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml > My bot found errors running 'make dt_binding_check' on your patch: Error: Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.example.dts:22.28-29 syntax error FATAL ERROR: Unable to parse input tree scripts/Makefile.lib:312: recipe for target 'Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.example.dt.yaml' failed make[1]: *** [Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.example.dt.yaml] Error 1 make[1]: *** Waiting for unfinished jobs Makefile:1300: recipe for target 'dt_binding_check' failed make: *** [dt_binding_check] Error 2 See https://patchwork.ozlabs.org/patch/1295115 If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure dt-schema is up to date: pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade Please check and re-submit.
Re: [PATCH v8 5/5] dt-bindings: arm: fsl: add different Protonic boards
On Wed, 20 May 2020 17:41:16 +0200, Oleksij Rempel wrote: > Add Protonic PRTI6Q, WD2, RVT, VT7 boards. > > Signed-off-by: Oleksij Rempel > --- > Documentation/devicetree/bindings/arm/fsl.yaml | 4 > 1 file changed, 4 insertions(+) > Please add Acked-by/Reviewed-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply. If a tag was not added on purpose, please state why and what changed.
Re: [PATCH v4 1/2] dt-bindings: mfd: Add ENE KB3930 Embedded Controller binding
On Thu, 21 May 2020 13:54:06 +0200, Lubomir Rintel wrote: > Add binding document for the ENE KB3930 Embedded Controller. > > Signed-off-by: Lubomir Rintel > > --- > Changes since v1: > - Addressed binding validation failure > --- > .../devicetree/bindings/mfd/ene-kb3930.yaml | 55 +++ > 1 file changed, 55 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/ene-kb3930.yaml > Please add Acked-by/Reviewed-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply. If a tag was not added on purpose, please state why and what changed.
