Re: [PATCH 09/23] m68k: do away with ARCH_REQUIRE_GPIOLIB

2016-04-20 Thread Greg Ungerer 
On 20/04/16 18:58, Linus Walleij wrote:
> Replace "select ARCH_REQUIRE_GPIOLIB" with "select GPIOLIB"
> as this can now be selected directly.
> 
> Cc: Michael Büsch 
> Cc: Geert Uytterhoeven 
> Cc: linux-m...@lists.linux-m68k.org
> Signed-off-by: Linus Walleij 

Since this affects ColdFire I am happy to give an ack:

Acked-by: Greg Ungerer 

Regards
Greg


> Various arch maintainers:
> 
> either ACK this and I will merge it into the GPIO tree for v4.7
> anticipating no clashes, or you wait until I have the enabling patch
> upstream (patch 1 in this series, removing deps on
> ARCH_[WANTS_OPTIONAL|REQUIRES]_GPIOLIB), and you will be able to
> merge it to your arch trees yourselves for late v4.7
> (post GPIO tree merge) or for v4.8.
> 
> You can also ask me for an immutable branch if you prefer that, I
> will put the enabling patch on a branch and the patch for your arch
> on top and ask you to pull it.
> 
> Select your option from the menu, silence probably means I will
> merge it to the GPIO tree. Unless you are X86 or ARM in which case
> I will be cautious.
> ---
>  arch/m68k/Kconfig.cpu | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/m68k/Kconfig.cpu b/arch/m68k/Kconfig.cpu
> index 0dfcf1281e9c..c1beb5ae181f 100644
> --- a/arch/m68k/Kconfig.cpu
> +++ b/arch/m68k/Kconfig.cpu
> @@ -22,11 +22,11 @@ config M68KCLASSIC
>  
>  config COLDFIRE
>   bool "Coldfire CPU family support"
> - select ARCH_REQUIRE_GPIOLIB
>   select ARCH_HAVE_CUSTOM_GPIO_H
>   select CPU_HAS_NO_BITFIELDS
>   select CPU_HAS_NO_MULDIV64
>   select GENERIC_CSUM
> + select GPIOLIB
>   select HAVE_CLK
>  
>  endchoice
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] char: Drop bogus dependency of DEVPORT on !M68K

2016-04-20 Thread Al Stone 
On 04/11/2016 02:40 AM, Geert Uytterhoeven wrote:
> According to full-history-linux commit d3794f4fa7c3edc3 ("[PATCH] M68k
> update (part 25)"), port operations are allowed on m68k if CONFIG_ISA is
> defined.
> 
> However, commit 153dcc54df826d2f ("[PATCH] mem driver: fix conditional
> on isa i/o support") accidentally changed an "||" into an "&&",
> disabling it completely on m68k. This logic was retained when
> introducing the DEVPORT symbol in commit 4f911d64e04a44c4 ("Make
> /dev/port conditional on config symbol").
> 
> Drop the bogus dependency on !M68K to fix this.
> 
> Fixes: 153dcc54df826d2f ("[PATCH] mem driver: fix conditional on isa i/o 
> support")
> Signed-off-by: Geert Uytterhoeven 
> ---
>  drivers/char/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
> index d3b8ddc6241cac2d..fa56bc757fe98fd1 100644
> --- a/drivers/char/Kconfig
> +++ b/drivers/char/Kconfig
> @@ -585,7 +585,6 @@ config TELCLOCK
>  
>  config DEVPORT
>   bool
> - depends on !M68K
>   depends on ISA || PCI
>   default y
>  
> 

This solves the particular problem I was running into on an arm64 AMD Seattle
system.  Thanks!

Tested-by: Al Stone 

-- 
ciao,
al
---
Al Stone
Software Engineer
Red Hat, Inc.
a...@redhat.com
---
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 09/23] m68k: do away with ARCH_REQUIRE_GPIOLIB

2016-04-20 Thread Linus Walleij 
Replace "select ARCH_REQUIRE_GPIOLIB" with "select GPIOLIB"
as this can now be selected directly.

Cc: Michael Büsch 
Cc: Geert Uytterhoeven 
Cc: linux-m...@lists.linux-m68k.org
Signed-off-by: Linus Walleij 
---
Various arch maintainers:

either ACK this and I will merge it into the GPIO tree for v4.7
anticipating no clashes, or you wait until I have the enabling patch
upstream (patch 1 in this series, removing deps on
ARCH_[WANTS_OPTIONAL|REQUIRES]_GPIOLIB), and you will be able to
merge it to your arch trees yourselves for late v4.7
(post GPIO tree merge) or for v4.8.

You can also ask me for an immutable branch if you prefer that, I
will put the enabling patch on a branch and the patch for your arch
on top and ask you to pull it.

Select your option from the menu, silence probably means I will
merge it to the GPIO tree. Unless you are X86 or ARM in which case
I will be cautious.
---
 arch/m68k/Kconfig.cpu | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/m68k/Kconfig.cpu b/arch/m68k/Kconfig.cpu
index 0dfcf1281e9c..c1beb5ae181f 100644
--- a/arch/m68k/Kconfig.cpu
+++ b/arch/m68k/Kconfig.cpu
@@ -22,11 +22,11 @@ config M68KCLASSIC
 
 config COLDFIRE
bool "Coldfire CPU family support"
-   select ARCH_REQUIRE_GPIOLIB
select ARCH_HAVE_CUSTOM_GPIO_H
select CPU_HAS_NO_BITFIELDS
select CPU_HAS_NO_MULDIV64
select GENERIC_CSUM
+   select GPIOLIB
select HAVE_CLK
 
 endchoice
-- 
2.4.11

--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html