Re: [PATCH] m68k/gpio: remove arch specific sysfs bus device
On 06/04/16 16:57, Linus Walleij wrote: On Wed, Apr 6, 2016 at 4:32 AM, Greg Ungererwrote: From: Greg Ungerer The ColdFire architecture specific gpio support code registers a sysfs bus device named "gpio". This clashes with the new generic API device added in commit 3c702e99 ("gpio: add a userspace chardev ABI for GPIOs"). The old ColdFire sysfs gpio device was never used for anything specific, and no links or other nodes were created under it. The new API sysfs gpio device has all the same default sysfs links (device, drivers, etc) and they are properly populated. Remove the old ColdFire sysfs gpio registration. Signed-off-by: Greg Ungerer Acked-by: Linus Walleij Thanks Linus. I will push via the m68knommu git tree. Regards Greg -- To unsubscribe from this list: send the line "unsubscribe linux-m68k" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] m68k/gpio: remove arch specific sysfs bus device
On Wed, Apr 6, 2016 at 4:32 AM, Greg Ungererwrote: > From: Greg Ungerer > > The ColdFire architecture specific gpio support code registers a sysfs > bus device named "gpio". This clashes with the new generic API device > added in commit 3c702e99 ("gpio: add a userspace chardev ABI for GPIOs"). > > The old ColdFire sysfs gpio device was never used for anything specific, > and no links or other nodes were created under it. The new API sysfs gpio > device has all the same default sysfs links (device, drivers, etc) and > they are properly populated. > > Remove the old ColdFire sysfs gpio registration. > > Signed-off-by: Greg Ungerer Acked-by: Linus Walleij Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-m68k" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] m68k/gpio: remove arch specific sysfs bus device
From: Greg UngererThe ColdFire architecture specific gpio support code registers a sysfs bus device named "gpio". This clashes with the new generic API device added in commit 3c702e99 ("gpio: add a userspace chardev ABI for GPIOs"). The old ColdFire sysfs gpio device was never used for anything specific, and no links or other nodes were created under it. The new API sysfs gpio device has all the same default sysfs links (device, drivers, etc) and they are properly populated. Remove the old ColdFire sysfs gpio registration. Signed-off-by: Greg Ungerer --- arch/m68k/coldfire/gpio.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/arch/m68k/coldfire/gpio.c b/arch/m68k/coldfire/gpio.c index 8832083..b515809 100644 --- a/arch/m68k/coldfire/gpio.c +++ b/arch/m68k/coldfire/gpio.c @@ -158,11 +158,6 @@ static int mcfgpio_to_irq(struct gpio_chip *chip, unsigned offset) return -EINVAL; } -static struct bus_type mcfgpio_subsys = { - .name = "gpio", - .dev_name = "gpio", -}; - static struct gpio_chip mcfgpio_chip = { .label = "mcfgpio", .request= mcfgpio_request, @@ -178,8 +173,7 @@ static struct gpio_chip mcfgpio_chip = { static int __init mcfgpio_sysinit(void) { - gpiochip_add_data(_chip, NULL); - return subsys_system_register(_subsys, NULL); + return gpiochip_add_data(_chip, NULL); } core_initcall(mcfgpio_sysinit); -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-m68k" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html