Re: [REVIEW PATCH 1/2] OMAP3 ISP-Camera: Added BT656 support
On Wed, 7 Jan 2009 11:37:20 +0530 hvaib...@ti.com wrote: From: Vaibhav Hiremath hvaib...@ti.com Support for BT656 through TVP5146 decoder, works on top of ISP-Camera patches posted by Sergio on 12th Dec 2008. The TVP514x driver patch has been accepted under V4L, will be part of O-L in the next merge window. As of now you can access the patches from - http://markmail.org/search/?q=TVP514x#query:TVP514x%20from%3A%22Hiremath%2C%20Vaibhav%22%20extension%3Apatch+page:1+mid:b5pcj3sriwknm2cv+state:results ToDO List: - Add support for scaling and cropping Signed-off-by: Brijesh Jadav brijes...@ti.com Signed-off-by: Hardik Shah hardik.s...@ti.com Signed-off-by: Manjunath Hadli m...@ti.com Signed-off-by: R Sivaraj siva...@ti.com Signed-off-by: Vaibhav Hiremath hvaib...@ti.com --- drivers/media/video/isp/isp.c | 118 --- drivers/media/video/isp/isp.h |7 +- drivers/media/video/isp/ispccdc.c | 146 +++ drivers/media/video/isp/ispccdc.h |9 ++ drivers/media/video/omap34xxcam.c | 197 + drivers/media/video/omap34xxcam.h |5 + 6 files changed, 428 insertions(+), 54 deletions(-) mode change 100644 = 100755 drivers/media/video/isp/isp.c mode change 100644 = 100755 drivers/media/video/omap34xxcam.c Your patch looks OK, but it touched drivers/media/video/omap34xxcam.c, that doesn't exist yet on my tree, so I can't apply it. Could you please submit first the opam34 patch on linux-media@vger.kernel.org, in order to allow patchwork.kernel.org to track it also, and allow me to merge the files? Cheers, Mauro -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [REVIEW PATCH 2/2] Added OMAP3EVM Multi-Media Daughter Card Support
On Wed, 7 Jan 2009 11:37:50 +0530 hvaib...@ti.com wrote: arch/arm/mach-omap2/Kconfig |4 + arch/arm/mach-omap2/Makefile|1 + arch/arm/mach-omap2/. | 417 +++ arch/arm/mach-omap2/board-omap3evm-dc.h | 43 arch/arm/mach-omap2/mux.c |7 + arch/arm/plat-omap/include/mach/mux.h |4 + +#if defined(CONFIG_VIDEO_TVP514X) || defined(CONFIG_VIDEO_TVP514X_MODULE) +#include linux/videodev2.h +#include media/v4l2-int-device.h +#include media/tvp514x.h This smells like a V4L driver, not an arch driver. We shoud take some care here, to avoid having the drivers on wrong place. The proper place on kernel tree for V4L driver is under drivers/media/video, not under arch/arm. All other architecture-specific V4L drivers are there. +/* include V4L2 camera driver related header file */ +#if defined(CONFIG_VIDEO_OMAP3) || defined(CONFIG_VIDEO_OMAP3_MODULE) +#include ../drivers/media/video/omap34xxcam.h +#include ../drivers/media/video/isp/ispreg.h +#endif /* #ifdef CONFIG_VIDEO_OMAP3 */ +#endif /* #ifdef CONFIG_VIDEO_TVP514X*/ Please, don't use ../* at your includes. IMO, the better is to create a drivers/media/video/omap dir, and put omap2/omap3 files there, including board-omap3evm-dc.c. This will avoid those ugly includes. Btw, drivers/media/video/isp/ currently doesn't exist. Please submit the patch for it first. Cheers, Mauro -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [REVIEW PATCH 1/2] OMAP3 ISP-Camera: Added BT656 support
Thanks, Vaibhav Hiremath -Original Message- From: Mauro Carvalho Chehab [mailto:mche...@infradead.org] Sent: Wednesday, January 07, 2009 3:10 PM To: Hiremath, Vaibhav Cc: linux-o...@vger.kernel.org; video4linux-l...@redhat.com; linux- me...@vger.kernel.org Subject: Re: [REVIEW PATCH 1/2] OMAP3 ISP-Camera: Added BT656 support On Wed, 7 Jan 2009 11:37:20 +0530 hvaib...@ti.com wrote: From: Vaibhav Hiremath hvaib...@ti.com Support for BT656 through TVP5146 decoder, works on top of ISP-Camera patches posted by Sergio on 12th Dec 2008. The TVP514x driver patch has been accepted under V4L, will be part of O-L in the next merge window. As of now you can access the patches from - http://markmail.org/search/?q=TVP514x#query:TVP514x%20from%3A%22Hire math%2C%20Vaibhav%22%20extension%3Apatch+page:1+mid:b5pcj3sriwknm2cv +state:results ToDO List: - Add support for scaling and cropping Signed-off-by: Brijesh Jadav brijes...@ti.com Signed-off-by: Hardik Shah hardik.s...@ti.com Signed-off-by: Manjunath Hadli m...@ti.com Signed-off-by: R Sivaraj siva...@ti.com Signed-off-by: Vaibhav Hiremath hvaib...@ti.com --- drivers/media/video/isp/isp.c | 118 --- drivers/media/video/isp/isp.h |7 +- drivers/media/video/isp/ispccdc.c | 146 +++- --- drivers/media/video/isp/ispccdc.h |9 ++ drivers/media/video/omap34xxcam.c | 197 + drivers/media/video/omap34xxcam.h |5 + 6 files changed, 428 insertions(+), 54 deletions(-) mode change 100644 = 100755 drivers/media/video/isp/isp.c mode change 100644 = 100755 drivers/media/video/omap34xxcam.c Your patch looks OK, but it touched drivers/media/video/omap34xxcam.c, that doesn't exist yet on my tree, so I can't apply it. Could you please submit first the opam34 patch on linux- me...@vger.kernel.org, in order to allow patchwork.kernel.org to track it also, and allow me to merge the files? [Hiremath, Vaibhav] Thanks Mauro for quick review. As I mentioned in the description this patch is build on top of ISP-Camera patches posted by Sergio on 12th Dec 2008. I am following up with Sergio on the same and will post the patches soon with review comment fixes. Cheers, Mauro -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [REVIEW PATCH 2/2] Added OMAP3EVM Multi-Media Daughter Card Support
Thanks, Vaibhav Hiremath -Original Message- From: Mauro Carvalho Chehab [mailto:mche...@infradead.org] Sent: Wednesday, January 07, 2009 3:29 PM To: Hiremath, Vaibhav Cc: linux-o...@vger.kernel.org; video4linux-l...@redhat.com; linux- me...@vger.kernel.org Subject: Re: [REVIEW PATCH 2/2] Added OMAP3EVM Multi-Media Daughter Card Support On Wed, 7 Jan 2009 11:37:50 +0530 hvaib...@ti.com wrote: arch/arm/mach-omap2/Kconfig |4 + arch/arm/mach-omap2/Makefile|1 + arch/arm/mach-omap2/. | 417 +++ arch/arm/mach-omap2/board-omap3evm-dc.h | 43 arch/arm/mach-omap2/mux.c |7 + arch/arm/plat-omap/include/mach/mux.h |4 + +#if defined(CONFIG_VIDEO_TVP514X) || defined(CONFIG_VIDEO_TVP514X_MODULE) +#include linux/videodev2.h +#include media/v4l2-int-device.h +#include media/tvp514x.h This smells like a V4L driver, not an arch driver. We shoud take some care here, to avoid having the drivers on wrong place. The proper place on kernel tree for V4L driver is under drivers/media/video, not under arch/arm. All other architecture-specific V4L drivers are there. [Hiremath, Vaibhav] Mauro, the Daughter card not only supports TVP1546/sensor but also supports USB EHCI. So this driver may not be fit into V4L driver. Daughter card driver (board-omap3evm-dc.c) only does basic initialization which happens during arch_init. The underneath V4L drivers are omap34xxcam.c (drivers/media/video) and TVP514x.c (drivers/media/video). +/* include V4L2 camera driver related header file */ +#if defined(CONFIG_VIDEO_OMAP3) || defined(CONFIG_VIDEO_OMAP3_MODULE) +#include ../drivers/media/video/omap34xxcam.h +#include ../drivers/media/video/isp/ispreg.h +#endif /* #ifdef CONFIG_VIDEO_OMAP3 */ +#endif /* #ifdef CONFIG_VIDEO_TVP514X*/ Please, don't use ../* at your includes. IMO, the better is to create a drivers/media/video/omap dir, and put omap2/omap3 files there, including board-omap3evm-dc.c. This will avoid those ugly includes. [Hiremath, Vaibhav] I do agree with this. I have mentioned this in my TODO list. Btw, drivers/media/video/isp/ currently doesn't exist. Please submit the patch for it first. [Hiremath, Vaibhav] Following up with Sergio on this, and soon will be available. Cheers, Mauro -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[cron job] ERRORS: armv5 armv5-ixp armv5-omap2 i686 m32r mips powerpc64 x86_64 v4l-dvb build
(This message is generated daily by a cron job that builds v4l-dvb for the kernels and architectures in the list below.) Results of the daily build of v4l-dvb: date:Wed Jan 7 19:00:05 CET 2009 path:http://www.linuxtv.org/hg/v4l-dvb changeset: 10191:7c430437c967 gcc version: gcc (GCC) 4.3.1 hardware:x86_64 host os: 2.6.26 linux-2.6.16.61-armv5: OK linux-2.6.17.14-armv5: OK linux-2.6.18.8-armv5: OK linux-2.6.19.5-armv5: OK linux-2.6.20.21-armv5: OK linux-2.6.21.7-armv5: OK linux-2.6.22.19-armv5: OK linux-2.6.23.12-armv5: OK linux-2.6.24.7-armv5: OK linux-2.6.25.11-armv5: OK linux-2.6.26-armv5: ERRORS linux-2.6.27-armv5: WARNINGS linux-2.6.28-armv5: WARNINGS linux-2.6.27-armv5-ixp: WARNINGS linux-2.6.28-armv5-ixp: WARNINGS linux-2.6.27-armv5-omap2: WARNINGS linux-2.6.28-armv5-omap2: WARNINGS linux-2.6.16.61-i686: WARNINGS linux-2.6.17.14-i686: WARNINGS linux-2.6.18.8-i686: WARNINGS linux-2.6.19.5-i686: WARNINGS linux-2.6.20.21-i686: WARNINGS linux-2.6.21.7-i686: WARNINGS linux-2.6.22.19-i686: WARNINGS linux-2.6.23.12-i686: WARNINGS linux-2.6.24.7-i686: WARNINGS linux-2.6.25.11-i686: WARNINGS linux-2.6.26-i686: WARNINGS linux-2.6.27-i686: WARNINGS linux-2.6.28-i686: WARNINGS linux-2.6.16.61-m32r: OK linux-2.6.17.14-m32r: OK linux-2.6.18.8-m32r: OK linux-2.6.19.5-m32r: OK linux-2.6.20.21-m32r: OK linux-2.6.21.7-m32r: OK linux-2.6.23.12-m32r: OK linux-2.6.24.7-m32r: OK linux-2.6.25.11-m32r: OK linux-2.6.26-m32r: OK linux-2.6.27-m32r: OK linux-2.6.28-m32r: OK linux-2.6.16.61-mips: WARNINGS linux-2.6.26-mips: WARNINGS linux-2.6.27-mips: WARNINGS linux-2.6.28-mips: WARNINGS linux-2.6.27-powerpc64: WARNINGS linux-2.6.28-powerpc64: WARNINGS linux-2.6.16.61-x86_64: WARNINGS linux-2.6.17.14-x86_64: WARNINGS linux-2.6.18.8-x86_64: WARNINGS linux-2.6.19.5-x86_64: WARNINGS linux-2.6.20.21-x86_64: WARNINGS linux-2.6.21.7-x86_64: WARNINGS linux-2.6.22.19-x86_64: WARNINGS linux-2.6.23.12-x86_64: WARNINGS linux-2.6.24.7-x86_64: WARNINGS linux-2.6.25.11-x86_64: WARNINGS linux-2.6.26-x86_64: WARNINGS linux-2.6.27-x86_64: WARNINGS linux-2.6.28-x86_64: WARNINGS fw/apps: OK sparse (linux-2.6.28): ERRORS Detailed results are available here: http://www.xs4all.nl/~hverkuil/logs/Wednesday.log Full logs are available here: http://www.xs4all.nl/~hverkuil/logs/Wednesday.tar.bz2 -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [GIT PATCHES for 2.6.29] V4L/DVB fixes
On Wed, 7 Jan 2009 16:05:20 -0800 (PST) Linus Torvalds torva...@linux-foundation.org wrote: On Wed, 7 Jan 2009, Mauro Carvalho Chehab wrote: Please pull from: ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git for_linus MAINTAINERS | 65 ++-- Mauro Carvalho Chehab (8): V4L/DVB (10191a): Update MAINTAINERS entries on media drivers I'm not seeing this one. Forgot to push out? I fact, I didn't notice, but my push got an error, due to a commit that I needed to amend locally. Anyway, it is fixed. I had to rebase for_linus branch. So, please pull from: ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git for_linus The git diff -M --stat --summary is the same as on my previous pull request: MAINTAINERS | 65 ++-- drivers/media/common/tuners/tda8290.c |6 +- drivers/media/dvb/dm1105/Kconfig|1 + drivers/media/dvb/dvb-core/dvb_frontend.c | 26 --- drivers/media/dvb/dvb-usb/anysee.c |2 +- drivers/media/dvb/frontends/cx24116.c |2 +- drivers/media/dvb/frontends/stb0899_algo.c |4 +- drivers/media/dvb/frontends/stb0899_drv.c |6 +- drivers/media/dvb/ttpci/budget-ci.c |2 +- drivers/media/video/cx88/Kconfig|5 + drivers/media/video/cx88/Makefile |3 +- drivers/media/video/cx88/cx88-dvb.c | 46 +++ drivers/media/video/cx88/cx88-i2c.c | 24 +- drivers/media/video/cx88/cx88-mpeg.c| 30 +-- drivers/media/video/cx88/cx88.h |4 +- drivers/media/video/em28xx/em28xx-cards.c |5 +- drivers/media/video/em28xx/em28xx-core.c|2 +- drivers/media/video/em28xx/em28xx-input.c |2 +- drivers/media/video/gspca/m5602/m5602_s5k83a.c |2 +- drivers/media/video/pxa_camera.c|4 +- drivers/media/video/pxa_camera.h| 95 --- drivers/media/video/usbvideo/ibmcam.c |2 +- drivers/media/video/usbvideo/konicawc.c |2 +- drivers/media/video/usbvideo/ultracam.c |2 +- drivers/media/video/usbvision/usbvision-video.c |3 +- drivers/media/video/v4l2-device.c |4 +- drivers/media/video/videobuf-dma-sg.c |3 +- drivers/staging/go7007/go7007-v4l2.c|3 +- 28 files changed, 148 insertions(+), 207 deletions(-) delete mode 100644 drivers/media/video/pxa_camera.h Eric Miao (1): V4L/DVB (10176b): pxa-camera: fix redefinition warnings and missing DMA definitions Guennadi Liakhovetski (1): V4L/DVB (10176a): Switch remaining clear_user_page users over to clear_user_highpage Julia Lawall (1): V4L/DVB (10185): Use negated usb_endpoint_xfer_control, etc Mauro Carvalho Chehab (8): V4L/DVB (10177): Fix sparse warnings on em28xx V4L/DVB (10178): dvb_frontend: Fix some sparse warnings due to static symbols V4L/DVB (10179): tda8290: Fix two sparse warnings V4L/DVB (10180): drivers/media: Fix a number of sparse warnings V4L/DVB (10181): v4l2-device: Fix some sparse warnings V4L/DVB (10189): dm1105: Fix build with INPUT=m and DVB_DM1105=y V4L/DVB (10190): cx88: Fix some Kbuild troubles V4L/DVB (10191a): Update MAINTAINERS entries on media drivers Michael Krufky (1): V4L/DVB (10182): tda8290: fix TDA8290 + TDA18271 initialization Cheers, Mauro -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [linux-dvb] s2-lipliandvb oops (cx88) - cx88 maintainer ?
On Tue, 06 Jan 2009 18:52:56 -0500 Andy Walls awa...@radix.net wrote: Mauro, Please be aware that I am not happy with my own patch. The function should really make sure everything is OK *before* putting the object on the cx8802_devlist. The failure cases are Oopses waiting to happen: the pointer is on the list, but the objects are deallocated in the failure cases - not good. :P Agreed. We should fix it by providing some lock to avoid having udev opening the device before the end of the complete device initialization. As I had to patch that file on the same point, instead of adding your patch, I've added your logic on my patch, and added a comment pointing to your patch at mail archives. Cheers, Mauro -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [linux-dvb] s2-lipliandvb oops (cx88) - cx88 maintainer ?
On Tue, 06 Jan 2009 19:33:36 -0500 Andy Walls awa...@radix.net wrote: Thanks for the report. That's actually exactly what I would expect. The race I think happens should only happen after the first device is added to the cx8802_devlist and while the cx88-dvb module is probing devices a second device is being added to the cx8802_devlist with a pointer not properly set yet. (Of course, I'm not sure why Mauro's recent change didn't work for Gregoire.) Probably because I moved also some code from cx88-mpeg into cx88-dvb. We should rewrite the locks on the drivers to work better after the KBL unlock patches that went on 2.6.27 and 2.6.28. Cheers, Mauro -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: saa7134: race between device initialization and first interrupt
On Sun, 4 Jan 2009 22:57:42 +0100
Marcin Slusarz marcin.slus...@gmail.com wrote:
Hi
There's a race between saa7134 device initialization and first interrupt
handler, which manifests as an oops [1].
saa7134_initdev - request_irq - saa7134_irq -
saa7134_irq_video_signalchange - saa7134_tvaudio_setmute - mute_input_7133
In mute_input_7133 dev-input == NULL and accessing dev-input-amux will
oops,
because dev-input would be initialized later:
saa7134_initdev - saa7134_hwinit2 - saa7134_video_init2 - video_mux -
saa7134_tvaudio_setinput
I'm not sure how it should be fixed correctly, but one of attached patches
should fix the symptom.
Marcin
Hi Marcin,
Probably, it is some locking trouble on saa7134 driver that appeared on 2.6.27,
with the lack of KBL on newer kernels. cx88 driver is suffering similar
troubles starting with 2.6.27.
I'll try to find some time to review, but it would be better if someone
volunteer himself to take a look on cx88 and saa7134 locks.
Cheers,
Mauro.
[1]
http://kerneloops.org/guilty.php?guilty=mute_input_7133version=2.6.27-releasestart=1802240end=1835007class=oops
---
diff --git a/drivers/media/video/saa7134/saa7134-video.c
b/drivers/media/video/saa7134/saa7134-video.c
index 02bb674..fcb0b17 100644
--- a/drivers/media/video/saa7134/saa7134-video.c
+++ b/drivers/media/video/saa7134/saa7134-video.c
@@ -2585,7 +2585,8 @@ void saa7134_irq_video_signalchange(struct saa7134_dev
*dev)
/* no video signal - mute audio */
if (dev-ctl_automute)
dev-automute = 1;
- saa7134_tvaudio_setmute(dev);
+ if (dev-input)
+ saa7134_tvaudio_setmute(dev);
} else {
/* wake up tvaudio audio carrier scan thread */
saa7134_tvaudio_do_scan(dev);
---
or
---
diff --git a/drivers/media/video/saa7134/saa7134-tvaudio.c
b/drivers/media/video/saa7134/saa7134-tvaudio.c
index 76b1640..75ee085 100644
--- a/drivers/media/video/saa7134/saa7134-tvaudio.c
+++ b/drivers/media/video/saa7134/saa7134-tvaudio.c
@@ -917,6 +917,8 @@ int saa7134_tvaudio_rx2mode(u32 rx)
void saa7134_tvaudio_setmute(struct saa7134_dev *dev)
{
+ if (!dev-input)
+ return;
switch (dev-pci-device) {
case PCI_DEVICE_ID_PHILIPS_SAA7130:
case PCI_DEVICE_ID_PHILIPS_SAA7134:
---
--
Cheers,
Mauro
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
