RE: [PATCHv2 3/4] V4L2 New IOCTLs for OMAP V4L2 Display Driver
-Original Message-
From: Shah, Hardik
Sent: Friday, October 24, 2008 3:23 PM
To: linux-o...@vger.kernel.org; linux-fbdev-de...@lists.sourceforge.net;
video4linux-l...@redhat.com
Cc: Shah, Hardik
Subject: [PATCHv2 3/4] V4L2 New IOCTLs for OMAP V4L2 Display Driver
New IOCTLs added to the V4L2 framework according to the
comments received from the open source.
Signed-off-by: Brijesh Jadav brijes...@ti.com
Hari Nagalla hnaga...@ti.com
Hardik Shah hardik.s...@ti.com
Manjunath Hadli m...@ti.com
R Sivaraj siva...@ti.com
Vaibhav Hiremath hvaib...@ti.com
---
drivers/media/video/v4l2-ioctl.c | 19 +++
include/linux/videodev2.h| 18 +-
include/media/v4l2-ioctl.h |4
3 files changed, 40 insertions(+), 1 deletions(-)
diff --git a/drivers/media/video/v4l2-ioctl.c b/drivers/media/video/v4l2-
ioctl.c
index 140ef92..39d1d6d 100644
--- a/drivers/media/video/v4l2-ioctl.c
+++ b/drivers/media/video/v4l2-ioctl.c
@@ -269,6 +269,8 @@ static const char *v4l2_ioctls[] = {
[_IOC_NR(VIDIOC_G_CHIP_IDENT)] = VIDIOC_G_CHIP_IDENT,
[_IOC_NR(VIDIOC_S_HW_FREQ_SEEK)] = VIDIOC_S_HW_FREQ_SEEK,
#endif
+ [_IOC_NR(VIDIOC_S_COLOR_SPACE_CONV)] = VIDIOC_S_COLOR_SPACE_CONV,
+ [_IOC_NR(VIDIOC_G_COLOR_SPACE_CONV)] = VIDIOC_G_COLOR_SPACE_CONV,
};
#define V4L2_IOCTLS ARRAY_SIZE(v4l2_ioctls)
@@ -1761,6 +1763,23 @@ static int __video_do_ioctl(struct inode *inode, struct
file *file,
ret = ops-vidioc_s_hw_freq_seek(file, fh, p);
break;
}
+ /*---Color space conversion--*/
+ case VIDIOC_S_COLOR_SPACE_CONV:
+ {
+ struct v4l2_color_space_conversion *p = arg;
+ if (!ops-vidioc_s_color_space_conv)
+ break;
+ ret = ops-vidioc_s_color_space_conv(file, fh, p);
+ break;
+ }
+ case VIDIOC_G_COLOR_SPACE_CONV:
+ {
+ struct v4l2_color_space_conversion *p = arg;
+ if (!ops-vidioc_g_color_space_conv)
+ break;
+ ret = ops-vidioc_g_color_space_conv(file, fh, p);
+ break;
+ }
default:
{
if (!ops-vidioc_default)
diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h
index 303d93f..3112cc0 100644
--- a/include/linux/videodev2.h
+++ b/include/linux/videodev2.h
@@ -869,8 +869,10 @@ enum v4l2_power_line_frequency {
#define V4L2_CID_BACKLIGHT_COMPENSATION (V4L2_CID_BASE+28)
#define V4L2_CID_CHROMA_AGC (V4L2_CID_BASE+29)
#define V4L2_CID_COLOR_KILLER (V4L2_CID_BASE+30)
+#define V4L2_CID_ROTATION(V4L2_CID_BASE+31)
+#define V4L2_CID_BG_COLOR(V4L2_CID_BASE+32)
/* last CID + 1 */
-#define V4L2_CID_LASTP1 (V4L2_CID_BASE+31)
+#define V4L2_CID_LASTP1 (V4L2_CID_BASE+33)
/* MPEG-class control IDs defined by V4L2 */
#define V4L2_CID_MPEG_BASE (V4L2_CTRL_CLASS_MPEG | 0x900)
@@ -1150,6 +1152,18 @@ struct v4l2_hw_freq_seek {
};
/*
+ * Color conversion
+ * User needs to pass pointer to color conversion matrix
+ * defined by hardware
+ */
+struct v4l2_color_space_conversion {
+ __s32 coefficients[3][3];
+ __s32 const_factor;
+ __s32 input_offs[3];
+ __s32 output_offs[3];
+};
+
+/*
* A U D I O
*/
struct v4l2_audio {
@@ -1425,6 +1439,8 @@ struct v4l2_chip_ident {
#define VIDIOC_G_CHIP_IDENT _IOWR('V', 81, struct v4l2_chip_ident)
#endif
#define VIDIOC_S_HW_FREQ_SEEK _IOW('V', 82, struct v4l2_hw_freq_seek)
+#define VIDIOC_S_COLOR_SPACE_CONV _IOW('V', 83, struct
v4l2_color_space_conversion)
+#define VIDIOC_G_COLOR_SPACE_CONV _IOR('V', 84, struct
v4l2_color_space_conversion)
#ifdef __OLD_VIDIOC_
/* for compatibility, will go away some day */
diff --git a/include/media/v4l2-ioctl.h b/include/media/v4l2-ioctl.h
index dc64046..62771af 100644
--- a/include/media/v4l2-ioctl.h
+++ b/include/media/v4l2-ioctl.h
@@ -240,6 +240,10 @@ struct v4l2_ioctl_ops {
/* For other private ioctls */
int (*vidioc_default) (struct file *file, void *fh,
int cmd, void *arg);
+ int (*vidioc_s_color_space_conv) (struct file *file, void *fh,
+ struct v4l2_color_space_conversion *a);
+ int (*vidioc_g_color_space_conv) (struct file *file, void *fh,
+ struct v4l2_color_space_conversion *a);
};
--
1.5.6
[Shah, Hardik]
Hi,
I had sent the above patch long back. But because of the new DSS library on
OMAP and other issues I was not able to follow up on the above patch. This is
discussed in detail in the following
Re: Confusion in usr/include/linux/videodev.h
On Wed, 21 Jan 2009, Jaswinder Singh Rajput wrote: On Wed, Jan 21, 2009 at 7:20 AM, Mauro Carvalho Chehab mche...@infradead.org wrote: On Wed, 21 Jan 2009 07:10:38 +0530 Jaswinder Singh Rajput jaswin...@kernel.org wrote: usr/include/linux/videodev.h is giving 2 warnings in 'make headers_check': usr/include/linux/videodev.h:19: leaks CONFIG_VIDEO to userspace where it is not valid usr/include/linux/videodev.h:314: leaks CONFIG_VIDEO to userspace where it is not valid Whole file is covered with #if defined(CONFIG_VIDEO_V4L1_COMPAT) || !defined (__KERNEL__) It means this file is only valid for kernel mode if CONFIG_VIDEO_V4L1_COMPAT is defined but in user mode it is always valid. V4L1 is the old deprecated userspace API for video devices. It is still required by some userspace applications. So, on userspace, it should be included. Also, this allows that one userspace app to be compatible with both V4L2 API (the current one) and the legacy V4L1 one. It should be noticed that are still a few drivers using the legacy API yet to be converted. If you have no objections then I will make a patchset which do followings: 1. Remove #if defined(CONFIG_VIDEO_V4L1_COMPAT) || !defined (__KERNEL__) from include/linux/videodev.h 2. cover all #include linux/videodev.h with #ifdef CONFIG_VIDEO_V4L1_COMPAT in kernel By this way, we can satisfy both kernel space and userspace issue and also get rid of above warnings. If you have better suggestion then let me know. That sounds like it will add a mess of #if's. How about this? diff -r 29c5787efcda linux/include/linux/videodev.h --- a/linux/include/linux/videodev.hThu Jan 15 09:07:03 2009 -0800 +++ b/linux/include/linux/videodev.hWed Jan 21 00:51:45 2009 -0800 @@ -15,7 +15,8 @@ #include linux/ioctl.h #include linux/videodev2.h -#if defined(CONFIG_VIDEO_V4L1_COMPAT) || !defined (__KERNEL__) +#if (defined(__KERNEL__) defined(CONFIG_VIDEO_V4L1_COMPAT)) \ +|| !defined (__KERNEL__) #define VID_TYPE_CAPTURE 1 /* Can capture */ #define VID_TYPE_TUNER 2 /* Can tune */ Now CONFIG_VIDEO_V4L1_COMPAT will only be used in the kernel. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Confusion in usr/include/linux/videodev.h
On Wed, Jan 21, 2009 at 2:24 PM, Trent Piepho xy...@speakeasy.org wrote: On Wed, 21 Jan 2009, Jaswinder Singh Rajput wrote: On Wed, Jan 21, 2009 at 7:20 AM, Mauro Carvalho Chehab mche...@infradead.org wrote: On Wed, 21 Jan 2009 07:10:38 +0530 Jaswinder Singh Rajput jaswin...@kernel.org wrote: usr/include/linux/videodev.h is giving 2 warnings in 'make headers_check': usr/include/linux/videodev.h:19: leaks CONFIG_VIDEO to userspace where it is not valid usr/include/linux/videodev.h:314: leaks CONFIG_VIDEO to userspace where it is not valid Whole file is covered with #if defined(CONFIG_VIDEO_V4L1_COMPAT) || !defined (__KERNEL__) It means this file is only valid for kernel mode if CONFIG_VIDEO_V4L1_COMPAT is defined but in user mode it is always valid. V4L1 is the old deprecated userspace API for video devices. It is still required by some userspace applications. So, on userspace, it should be included. Also, this allows that one userspace app to be compatible with both V4L2 API (the current one) and the legacy V4L1 one. It should be noticed that are still a few drivers using the legacy API yet to be converted. If you have no objections then I will make a patchset which do followings: 1. Remove #if defined(CONFIG_VIDEO_V4L1_COMPAT) || !defined (__KERNEL__) from include/linux/videodev.h 2. cover all #include linux/videodev.h with #ifdef CONFIG_VIDEO_V4L1_COMPAT in kernel By this way, we can satisfy both kernel space and userspace issue and also get rid of above warnings. If you have better suggestion then let me know. That sounds like it will add a mess of #if's. How about this? diff -r 29c5787efcda linux/include/linux/videodev.h --- a/linux/include/linux/videodev.hThu Jan 15 09:07:03 2009 -0800 +++ b/linux/include/linux/videodev.hWed Jan 21 00:51:45 2009 -0800 @@ -15,7 +15,8 @@ #include linux/ioctl.h #include linux/videodev2.h -#if defined(CONFIG_VIDEO_V4L1_COMPAT) || !defined (__KERNEL__) +#if (defined(__KERNEL__) defined(CONFIG_VIDEO_V4L1_COMPAT)) \ +|| !defined (__KERNEL__) #define VID_TYPE_CAPTURE 1 /* Can capture */ #define VID_TYPE_TUNER 2 /* Can tune */ Now CONFIG_VIDEO_V4L1_COMPAT will only be used in the kernel. No, this will still give warnings. Please run 'make headers_check' -- JSR -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Confusion in usr/include/linux/videodev.h
On Wednesday 21 January 2009, Jaswinder Singh Rajput wrote: diff -r 29c5787efcda linux/include/linux/videodev.h --- a/linux/include/linux/videodev.hThu Jan 15 09:07:03 2009 -0800 +++ b/linux/include/linux/videodev.hWed Jan 21 00:51:45 2009 -0800 @@ -15,7 +15,8 @@ #include linux/ioctl.h #include linux/videodev2.h -#if defined(CONFIG_VIDEO_V4L1_COMPAT) || !defined (__KERNEL__) +#if (defined(__KERNEL__) defined(CONFIG_VIDEO_V4L1_COMPAT)) \ +|| !defined (__KERNEL__) #define VID_TYPE_CAPTURE 1 /* Can capture */ #define VID_TYPE_TUNER 2 /* Can tune */ Now CONFIG_VIDEO_V4L1_COMPAT will only be used in the kernel. No, this will still give warnings. You could #define another conditional, like this: #ifndef __KERNEL__ # define __V4L1_COMPAT_API /* Always provide definitions to user space */ #else /* __KERNEL__ */ # ifdef CONFIG_VIDEO_V4L1_COMPAT # define __V4L1_COMPAT_API # endif /* CONFIG_VIDEO_V4L1_COMPAT /* #endif /* __KERNEL__ */ Arnd -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Confusion in usr/include/linux/videodev.h
On Wed, 21 Jan 2009, Arnd Bergmann wrote: On Wednesday 21 January 2009, Jaswinder Singh Rajput wrote: diff -r 29c5787efcda linux/include/linux/videodev.h --- a/linux/include/linux/videodev.hThu Jan 15 09:07:03 2009 -0800 +++ b/linux/include/linux/videodev.hWed Jan 21 00:51:45 2009 -0800 @@ -15,7 +15,8 @@ #include linux/ioctl.h #include linux/videodev2.h -#if defined(CONFIG_VIDEO_V4L1_COMPAT) || !defined (__KERNEL__) +#if (defined(__KERNEL__) defined(CONFIG_VIDEO_V4L1_COMPAT)) \ +|| !defined (__KERNEL__) #define VID_TYPE_CAPTURE 1 /* Can capture */ #define VID_TYPE_TUNER 2 /* Can tune */ Now CONFIG_VIDEO_V4L1_COMPAT will only be used in the kernel. No, this will still give warnings. You could #define another conditional, like this: #ifndef __KERNEL__ # define __V4L1_COMPAT_API /* Always provide definitions to user space */ #else /* __KERNEL__ */ # ifdef CONFIG_VIDEO_V4L1_COMPAT # define __V4L1_COMPAT_API # endif /* CONFIG_VIDEO_V4L1_COMPAT /* #endif /* __KERNEL__ */ I see what the real problem is now, the unifdef program isn't smart enough to realize that it knows the result of !defined(__KERNEL__) || defined(FOO) and so it keeps those ifdefs in when it should be able to remove them. This works too: #ifndef __KERNEL__ # define __V4L1_COMPAT_API /* Always provide definitions to user space */ #elif defined(CONFIG_VIDEO_V4L1_COMPAT) /* __KERNEL__ */ # define __V4L1_COMPAT_API #endif /* CONFIG_VIDEO_V4L1_COMPAT */ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [linux-dvb] SAA716x
Many thanks for the link, but it concerns device 1822:0037 and the supported device is 1822:0027 Anyway, I think that it can help. Michel. Konstantin Dimitrov a écrit : VP6090 output from lspci -vvv and lspci -vvvn is here: http://www.interlink.com.au/rad/quattros/ On Wed, Jan 21, 2009 at 10:59 AM, Catimimi catim...@libertysurf.fr wrote: Hi all, I'm trying to add my Pinnacle 3010i to the driver found here : http://jusst.de/hg/saa716x I already got some preliminary results but in order to understand what I'm doing it would be great to get the result of lspci -vvxxx for at least one of the supported cards : - Twinhan/Azurewave VP-6090 - Avermedia HC82 - Avermedia H788 I didn't find this test in the WIKI, so thanks in advance for posting this information. Michel. ___ linux-dvb users mailing list For V4L/DVB development, please use instead linux-media@vger.kernel.org linux-...@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [linux-dvb] getting started with msi tv card
Daniel Dalton wrote: On Wed, Jan 21, 2009 at 12:46:32AM +0200, Antti Palosaari wrote: Yes, should work out of the box. No need to install any driver, driver is included in your Kernel. /dev/dvb/adapter0/ is created. so does this mean the right modules have been loaded? Yes, drivers and firmware loaded. It should be all functional. I've been googling, and have played with w_scan and me-tv. Kaffeine unfortunately is qt and won't work with braille/speech, but me-tv does. So I got sighted help to scan for channels in kaffeine, the scan didn't find any channels. Next, I ran the w_scan program, and that as well failed to find any channels. Finally, I ran me-tv and that as well failed. (I selected my location for me-tv). So, how do I get w_scan or me-tv to find some channels? It's probably not worth talking about kaffeine as I won't be able to use this. I'm plugging my usb receiver into a tv connection in my home which a standard tv would plug into. Any ideas? I think the problem is poor QT1010 tuning performance. You cannot do much for that now. I recommended to get other stick. regards Antti -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] New V4L2 ioctls for OMAP class of Devices
1. Control ID added for rotation. Same as HFLIP.
2. Control ID added for setting background color on
output device.
3. New ioctl added for setting the color space conversion from
YUV to RGB.
Signed-off-by: Brijesh Jadav brijes...@ti.com
Signed-off-by: Hari Nagalla hnaga...@ti.com
Signed-off-by: Hardik Shah hardik.s...@ti.com
Signed-off-by: Manjunath Hadli m...@ti.com
Signed-off-by: R Sivaraj siva...@ti.com
Signed-off-by: Vaibhav Hiremath hvaib...@ti.com
---
linux/drivers/media/video/v4l2-ioctl.c | 19 ++-
linux/include/linux/videodev2.h| 19 ++-
linux/include/media/v4l2-ioctl.h |4
3 files changed, 40 insertions(+), 2 deletions(-)
diff --git a/linux/drivers/media/video/v4l2-ioctl.c
b/linux/drivers/media/video/v4l2-ioctl.c
index 165bc90..7599da8 100644
--- a/linux/drivers/media/video/v4l2-ioctl.c
+++ b/linux/drivers/media/video/v4l2-ioctl.c
@@ -270,6 +270,8 @@ static const char *v4l2_ioctls[] = {
[_IOC_NR(VIDIOC_DBG_G_CHIP_IDENT)] = VIDIOC_DBG_G_CHIP_IDENT,
[_IOC_NR(VIDIOC_S_HW_FREQ_SEEK)] = VIDIOC_S_HW_FREQ_SEEK,
#endif
+ [_IOC_NR(VIDIOC_S_COLOR_SPACE_CONV)] = VIDIOC_S_COLOR_SPACE_CONV,
+ [_IOC_NR(VIDIOC_G_COLOR_SPACE_CONV)] = VIDIOC_G_COLOR_SPACE_CONV,
};
#define V4L2_IOCTLS ARRAY_SIZE(v4l2_ioctls)
@@ -1838,7 +1840,22 @@ static long __video_do_ioctl(struct file *file,
}
break;
}
-
+ case VIDIOC_S_COLOR_SPACE_CONV:
+ {
+ struct v4l2_color_space_conversion *p = arg;
+ if (!ops-vidioc_s_color_space_conv)
+ break;
+ ret = ops-vidioc_s_color_space_conv(file, fh, p);
+ break;
+ }
+ case VIDIOC_G_COLOR_SPACE_CONV:
+ {
+ struct v4l2_color_space_conversion *p = arg;
+ if (!ops-vidioc_g_color_space_conv)
+ break;
+ ret = ops-vidioc_g_color_space_conv(file, fh, p);
+ break;
+ }
default:
{
if (!ops-vidioc_default)
diff --git a/linux/include/linux/videodev2.h b/linux/include/linux/videodev2.h
index b0c5010..9fbc3b0 100644
--- a/linux/include/linux/videodev2.h
+++ b/linux/include/linux/videodev2.h
@@ -879,8 +879,10 @@ enum v4l2_power_line_frequency {
#define V4L2_CID_BACKLIGHT_COMPENSATION(V4L2_CID_BASE+28)
#define V4L2_CID_CHROMA_AGC (V4L2_CID_BASE+29)
#define V4L2_CID_COLOR_KILLER (V4L2_CID_BASE+30)
+#define V4L2_CID_ROTATION (V4L2_CID_BASE+31)
+#define V4L2_CID_BG_COLOR (V4L2_CID_BASE+32)
/* last CID + 1 */
-#define V4L2_CID_LASTP1 (V4L2_CID_BASE+31)
+#define V4L2_CID_LASTP1 (V4L2_CID_BASE+33)
/* MPEG-class control IDs defined by V4L2 */
#define V4L2_CID_MPEG_BASE (V4L2_CTRL_CLASS_MPEG | 0x900)
@@ -1192,6 +1194,17 @@ struct v4l2_hw_freq_seek {
};
/*
+ * Color conversion
+ * User needs to pass pointer to color conversion matrix
+ * defined by hardware
+ */
+struct v4l2_color_space_conversion {
+ __s32 coefficients[3][3];
+ __s32 const_factor;
+ __s32 offsets[3];
+};
+
+/*
* A U D I O
*/
struct v4l2_audio {
@@ -1493,9 +1506,13 @@ struct v4l2_chip_ident_old {
#endif
#define VIDIOC_S_HW_FREQ_SEEK _IOW('V', 82, struct v4l2_hw_freq_seek)
+
+#define VIDIOC_S_COLOR_SPACE_CONV _IOW('V', 83, struct
v4l2_color_space_conversion)
+#define VIDIOC_G_COLOR_SPACE_CONV _IOR('V', 84, struct
v4l2_color_space_conversion)
/* Reminder: when adding new ioctls please add support for them to
drivers/media/video/v4l2-compat-ioctl32.c as well! */
+
#ifdef __OLD_VIDIOC_
/* for compatibility, will go away some day */
#define VIDIOC_OVERLAY_OLD _IOWR('V', 14, int)
diff --git a/linux/include/media/v4l2-ioctl.h b/linux/include/media/v4l2-ioctl.h
index b01c044..0c44ecf 100644
--- a/linux/include/media/v4l2-ioctl.h
+++ b/linux/include/media/v4l2-ioctl.h
@@ -241,6 +241,10 @@ struct v4l2_ioctl_ops {
/* For other private ioctls */
long (*vidioc_default) (struct file *file, void *fh,
int cmd, void *arg);
+ int (*vidioc_s_color_space_conv) (struct file *file, void *fh,
+ struct v4l2_color_space_conversion *a);
+ int (*vidioc_g_color_space_conv) (struct file *file, void *fh,
+ struct v4l2_color_space_conversion *a);
};
--
1.5.6
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PULL] http://linuxtv.org/hg/~mcisely/pvrusb2
Am Mon, 19 Jan 2009 04:25:54 +0100
schrieb Carsten Meier c...@trexity.de:
Am Mon, 19 Jan 2009 06:11:33 +0300
schrieb Alexey Klimov klimov.li...@gmail.com:
On Mon, Jan 19, 2009 at 6:09 AM, Alexey Klimov
klimov.li...@gmail.com wrote:
On Mon, 2009-01-19 at 03:55 +0100, Carsten Meier wrote:
Am Mon, 19 Jan 2009 05:25:15 +0300
schrieb Alexey Klimov klimov.li...@gmail.com:
On Sun, 2009-01-18 at 23:36 -0200, Mauro Carvalho Chehab wrote:
On Sat, 17 Jan 2009 19:09:51 +0100
Carsten Meier c...@trexity.de wrote:
Am Fri, 16 Jan 2009 02:47:50 -0200
schrieb Mauro Carvalho Chehab mche...@infradead.org:
For usb devices, usb_make_path() provide a canonical name
for the device. For PCI ones, we have pci_name() for the
same function. in the case of pci devices, I suspect that
all use pci_name(). We just need to use usb_make_path()
at the usb ones.
I looked at the sources for what string gets generated for
bus_info by usb_make_path(). If it gets used by pvrusb2, my
problems are solved, because it is constant across
standby-wake-up-cycles. The pvrusb2's implementation
currently delivers usb 7-2 address 6 here. address 6
corresponds to devnum which gets constantly increased,
which results in always changing strings here. Sorry for my
unneccessary complaints.
Mike, Thierry, Jean-Francois, Laurent and others:
IMO, we should patch all usb drivers to use usb_make_path().
It will be more transparent to userspace, if all drivers
provide the bus_info using the same notation. Comments?
I did this thing to dsbr100.c usb radio driver:
diff -r de513684aca2 linux/drivers/media/radio/dsbr100.c
--- a/linux/drivers/media/radio/dsbr100.c Sun Jan 18 23:06:34
2009 -0200 +++ b/linux/drivers/media/radio/dsbr100.cMon
Jan 19 05:18:36 2009 +0300 @@ -393,9 +393,12 @@
static int vidioc_querycap(struct file *file, void *priv,
struct v4l2_capability *v)
{
+ struct dsbr100_device *radio = video_drvdata(file);
+
strlcpy(v-driver, dsbr100, sizeof(v-driver));
strlcpy(v-card, D-Link R-100 USB FM Radio,
sizeof(v-card));
- sprintf(v-bus_info, USB);
+ usb_make_path(radio-usbdev, v-bus_info,
sizeof(v-bus_info));
+ printk(KERN_INFO %s\n, v-bus_info);
v-version = RADIO_VERSION;
v-capabilities = V4L2_CAP_TUNER;
return 0;
And get such dmesg messages for different usb ports:
usb-:00:1d.2-2
usb-:00:1d.0-1
Looks okay to my eyes or may be i missed something. Anyway it's
more useful than just simple USB string.
Do you get the same string if you unplug and then replug the same
device to the same port? If not, I have the same problems than
before, otherwise I'll be happy with it.
To be sure that i did that you want me to: i plug device in, run
application that use it, close application, unplug device, and
then plug device in (and i didn't reload the kernel module during
this), run app again..
Yes, i have the same string in this case. btw, kernel 2.6.29-rc2.
Oh, i forget to tell you that it was the same usb port and the same
usb device. :)
Yes, that's what I meant. :) Userspace-land would be very happy if
usb_make_path() is used by all usb-device-drivers.
Hi,
now I want to translate bus_info into a sysfs-path to obtain
device-info like serial numbers. Given a device reports
usb-:00:1d.2-2 as bus_info, then the device-info is located
under /sys/bus/usb/devices/2-2, which is a symlink to the
appropriate /sys/devices/ directory, right?
All I have to do is to compare the first 4 chars of bus_info against
usb-, get the chars after . and append it to
/sys/bus/usb/devices/ to obatin a sysfs-path, right?
Is there a more elegant solution or already a function for this? Can
the . appear more than once before the last one?
Thaks,
Carsten
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [linux-dvb] SAA716x
Am Mittwoch, den 21.01.2009, 12:43 +0200 schrieb Konstantin Dimitrov: VP6090 output from lspci -vvv and lspci -vvvn is here: http://www.interlink.com.au/rad/quattros/ On Wed, Jan 21, 2009 at 10:59 AM, Catimimi catim...@libertysurf.fr wrote: Hi all, I'm trying to add my Pinnacle 3010i to the driver found here : http://jusst.de/hg/saa716x I already got some preliminary results but in order to understand what I'm doing it would be great to get the result of lspci -vvxxx for at least one of the supported cards : - Twinhan/Azurewave VP-6090 - Avermedia HC82 - Avermedia H788 I didn't find this test in the WIKI, so thanks in advance for posting this information. Michel. ___ linux-dvb users mailing list For V4L/DVB development, please use instead linux-media@vger.kernel.org linux-...@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb ___ linux-dvb users mailing list For V4L/DVB development, please use instead linux-media@vger.kernel.org linux-...@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb hi, unfortunately at last for me and some other guys the HC82 is not working with the 716x driver. but you can find my lspci output at: http://www.linuxtv.org/wiki/index.php/AVerMedia_AVerTV_Hybrid_NanoExpress_(HC82) martin -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/5] gspca: use usb_make_path to report bus info
On Tue, 20 Jan 2009 22:40:38 +0100 Thierry Merle thierry.me...@free.fr wrote: usb_make_path reports canonical bus info. Use it when reporting bus info in VIDIOC_QUERYCAP. Signed-off-by: Thierry MERLE thierry.me...@free.fr Applied. Thanks. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Add support for sq905 based cameras to gspca
On Wed, 21 Jan 2009, Jean-Francois Moine wrote: snip Hello Adam and Theodore, I looked at your two versions, and I think the first one (work queue) is the simplest. So, I am ready to put your driver in my repository for inclusion in a next linux kernel. Thank you. I have just a few remarks and a request. The remarks need close attention, which will be applied. Thank you again for attention to detail. The request I can deal with right now. Now, the request: some guys asked for support of their webcams based on sq930x chips. A SANE backend driver exists, written by Gerard Klaver (http://gkall.hobby.nl/sq930x.html). May you have a look and say if handling these chips may be done in your driver? In a word, no. Sorry. The only real resemblance of either of these devices to the other is that they share the same Vendor number. Now, thanks again for the comments. Adam and I will get busy on them. Theodore Kilgore -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[cron job] WARNINGS: armv5 armv5-ixp armv5-omap2 i686 m32r mips powerpc64 x86_64 v4l-dvb build
(This message is generated daily by a cron job that builds v4l-dvb for the kernels and architectures in the list below.) Results of the daily build of v4l-dvb: date:Wed Jan 21 19:00:03 CET 2009 path:http://www.linuxtv.org/hg/v4l-dvb changeset: 10265:f4d7d0b84940 gcc version: gcc (GCC) 4.3.1 hardware:x86_64 host os: 2.6.26 linux-2.6.16.61-armv5: OK linux-2.6.17.14-armv5: OK linux-2.6.18.8-armv5: OK linux-2.6.19.5-armv5: OK linux-2.6.20.21-armv5: OK linux-2.6.21.7-armv5: OK linux-2.6.22.19-armv5: OK linux-2.6.23.12-armv5: OK linux-2.6.24.7-armv5: OK linux-2.6.25.11-armv5: OK linux-2.6.26-armv5: OK linux-2.6.27-armv5: WARNINGS linux-2.6.28-armv5: WARNINGS linux-2.6.29-rc2-armv5: OK linux-2.6.27-armv5-ixp: OK linux-2.6.28-armv5-ixp: OK linux-2.6.29-rc2-armv5-ixp: OK linux-2.6.27-armv5-omap2: OK linux-2.6.28-armv5-omap2: OK linux-2.6.29-rc2-armv5-omap2: OK linux-2.6.16.61-i686: OK linux-2.6.17.14-i686: OK linux-2.6.18.8-i686: OK linux-2.6.19.5-i686: OK linux-2.6.20.21-i686: OK linux-2.6.21.7-i686: OK linux-2.6.22.19-i686: OK linux-2.6.23.12-i686: OK linux-2.6.24.7-i686: OK linux-2.6.25.11-i686: OK linux-2.6.26-i686: OK linux-2.6.27-i686: OK linux-2.6.28-i686: OK linux-2.6.29-rc2-i686: OK linux-2.6.16.61-m32r: OK linux-2.6.17.14-m32r: OK linux-2.6.18.8-m32r: OK linux-2.6.19.5-m32r: OK linux-2.6.20.21-m32r: OK linux-2.6.21.7-m32r: OK linux-2.6.23.12-m32r: OK linux-2.6.24.7-m32r: OK linux-2.6.25.11-m32r: OK linux-2.6.26-m32r: OK linux-2.6.27-m32r: OK linux-2.6.28-m32r: OK linux-2.6.29-rc2-m32r: OK linux-2.6.16.61-mips: OK linux-2.6.26-mips: OK linux-2.6.27-mips: OK linux-2.6.28-mips: OK linux-2.6.29-rc2-mips: OK linux-2.6.27-powerpc64: OK linux-2.6.28-powerpc64: OK linux-2.6.29-rc2-powerpc64: OK linux-2.6.16.61-x86_64: OK linux-2.6.17.14-x86_64: OK linux-2.6.18.8-x86_64: OK linux-2.6.19.5-x86_64: OK linux-2.6.20.21-x86_64: OK linux-2.6.21.7-x86_64: OK linux-2.6.22.19-x86_64: OK linux-2.6.23.12-x86_64: OK linux-2.6.24.7-x86_64: OK linux-2.6.25.11-x86_64: OK linux-2.6.26-x86_64: OK linux-2.6.27-x86_64: OK linux-2.6.28-x86_64: OK linux-2.6.29-rc2-x86_64: OK fw/apps: OK sparse (linux-2.6.28): ERRORS sparse (linux-2.6.29-rc2): ERRORS Detailed results are available here: http://www.xs4all.nl/~hverkuil/logs/Wednesday.log Full logs are available here: http://www.xs4all.nl/~hverkuil/logs/Wednesday.tar.bz2 -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb
Hi Mauro, Please pull from http://www.linuxtv.org/hg/~hverkuil/v4l-dvb for the following: - hg: improve hgignore patterns - em28xx: fix VIDIOC_G_CTRL when there is no msp34xx device. Thanks, Hans diffstat: .hgignore |3 ++- linux/drivers/media/video/em28xx/em28xx-video.c |7 ++- 2 files changed, 8 insertions(+), 2 deletions(-) -- Hans Verkuil - video4linux developer - sponsored by TANDBERG -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Fwd: dvb-t scan file Belgium - Brussels
-- Forwarded message -- From: Xavier Neyt xavier.n...@gmail.com Date: 2009/1/21 Subject: dvb-t scan file Belgium - Brussels To: pfis...@linuxtv.org Dear Christoph, As you seem to be able to add scan files to the dvb-apps, would you be so kind to add the scan file for be-Brussels provided in attachment? Regards. Xavier. be-Brussels Description: Binary data
