Re: [IR RC, REGRESSION] Didn't work IR RC
On Wed, 10 Mar 2010 13:02:25 +0900, Dmitri Belimov wrote: Sorry for the late reply. Is the problem solved by now, or is my help still needed? Yes. I found what happens and solve this regression. Patch already comitted. diff -r 37ff78330942 linux/drivers/media/video/saa7134/saa7134-input.c --- a/linux/drivers/media/video/saa7134/saa7134-input.c Sun Feb 28 16:59:57 2010 -0300 +++ b/linux/drivers/media/video/saa7134/saa7134-input.c Thu Mar 04 08:35:15 2010 +0900 @@ -947,6 +947,7 @@ dev-init_data.name = BeholdTV; dev-init_data.get_key = get_key_beholdm6xx; dev-init_data.ir_codes = ir_codes_behold_table; + dev-init_data.type = IR_TYPE_NEC; info.addr = 0x2d; #endif break; None of my patches removed this statement, and IR_TYPE_NEC itself seems to be new in kernel 2.6.33, so I admit I don't quite understand how I my i2c changes could be responsible for the regression. Anyway, glad that you managed to fix it. -- Jean Delvare -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Proposed patch for libv4l-0.6.4 to support Asus K70AD where webcam is upsid down
I installed Ubuntu Karmic on a Asus laptop PRO79A equipped with a motherboard K70AD. However, with the original libv4l-0.6.4 library, the image of the webcam is upside down. I suggest you this little patch that solved the problem on my machine. !--- libv4lcontrol.diff -- --- libv4l-0.6.4/libv4lconvert/control/libv4lcontrol.c2010-01-16 03:37:23.0 +0100 +++ libv4l-0.6.4-2/libv4lconvert/control/libv4lcontrol.c2010-03-10 09:59:09.0 +0100 @@ -128,6 +128,10 @@ V4LCONTROL_HFLIPPED|V4LCONTROL_VFLIPPED }, { 0x04f2, 0xb071, 0, ASUSTeK Computer Inc., K70AB , V4LCONTROL_HFLIPPED|V4LCONTROL_VFLIPPED }, + /* Ajout Asus PRO79A: Motherboard K70AD ici... */ + { 0x04f2, 0xb071, 0, ASUSTeK Computer Inc., K70AD , +V4LCONTROL_HFLIPPED|V4LCONTROL_VFLIPPED }, + /* Webcam Chicony CNF7129 */ { 0x04f2, 0xb071, 0, ASUSTeK Computer Inc., K70IC , V4LCONTROL_HFLIPPED|V4LCONTROL_VFLIPPED }, { 0x04f2, 0xb071, 0, ASUSTeK Computer Inc., K70IJ , !-- END libv4lcontrol.diff -- Thank you for the interest you will bring to this suggestion. Luc BRUNINX (Belgium) -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[patch] omap24xxcam: potential buffer overflow
The previous loop goes until last == VIDEO_MAX_FRAME, so this could potentially go one past the end of the loop. Signed-off-by: Dan Carpenter erro...@gmail.com diff --git a/drivers/media/video/omap24xxcam.c b/drivers/media/video/omap24xxcam.c index 142c327..bedbee9 100644 --- a/drivers/media/video/omap24xxcam.c +++ b/drivers/media/video/omap24xxcam.c @@ -1404,7 +1404,7 @@ static int omap24xxcam_mmap_buffers(struct file *file, } size = 0; - for (i = first; i = last; i++) { + for (i = first; i = last i VIDEO_MAX_FRAME; i++) { struct videobuf_dmabuf *dma = videobuf_to_dma(vbq-bufs[i]); for (j = 0; j dma-sglen; j++) { -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] saa7134: add capture boards Hawell HW-404M7 and HW-808M7
This patch adds new capture boards Hawell HW-404M7 and HW-808M7. Those cards have 4 or 8 SAA7130 chips and for the work it only needs initialize registers. The value of those registers were dumped under Windows using flytest. But board haven't EEPROM. For the first chip: SAA7130 (0x7130, SubVenID:1131, SubDevID:, Rev: 01) I2C slave devices found: No devices GPIO pins: Mode : 0x00389C00 Value: 0x00016C00 Video input: 3 Audio input: Analog Line1 For other chips: SAA7130 (0x7130, SubVenID:1131, SubDevID:, Rev: 01) I2C slave devices found: No devices GPIO pins: Mode : 0x00389200 Value: 0x0001 Video input: 3 Audio input: Analog Line1 Signed-off-by: Vladimir Ermakov vooon...@gmail.com # HG changeset patch # User Vladimir Ermakov vooon...@gmail.com # Date 1268232221 -10800 # Node ID 072cd67c6aabe0e700a9e4727b50ad6424cb59f5 # Parent 7a58d924fb049ff1d318514939b3a7e416670c13 saa7134: add Hawell HW-404M7 HW-808M7 diff -r 7a58d924fb04 -r 072cd67c6aab linux/Documentation/video4linux/CARDLIST.saa7134 --- a/linux/Documentation/video4linux/CARDLIST.saa7134 Tue Mar 09 23:00:59 2010 -0300 +++ b/linux/Documentation/video4linux/CARDLIST.saa7134 Wed Mar 10 17:43:41 2010 +0300 @@ -175,3 +175,4 @@ 174 - Asus Europa Hybrid OEM [1043:4847] 175 - Leadtek Winfast DTV1000S [107d:6655] 176 - Beholder BeholdTV 505 RDS[:5051] +177 - Hawell HW-404M7 / HW-808M7 diff -r 7a58d924fb04 -r 072cd67c6aab linux/drivers/media/video/saa7134/saa7134-cards.c --- a/linux/drivers/media/video/saa7134/saa7134-cards.c Tue Mar 09 23:00:59 2010 -0300 +++ b/linux/drivers/media/video/saa7134/saa7134-cards.c Wed Mar 10 17:43:41 2010 +0300 @@ -5394,6 +5394,23 @@ .amux = LINE2, }, }, + [SAA7134_BOARD_HAWELL_HW_404M7] = { + /* Hawell HW-404M7 Hawell HW-808M7 */ + /* Bogoslovskiy Viktor bogo...@bk.ru */ + .name = Hawell HW-404M7, + .audio_clock = 0x0020, + .tuner_type= UNSET, + .radio_type= UNSET, + .tuner_addr = ADDR_UNSET, + .radio_addr = ADDR_UNSET, + .gpiomask = 0x01fc00, + .inputs = {{ + .name = name_comp1, + .vmux = 3, + .amux = LINE1, + .gpio = 0x389c00, + } }, + }, }; diff -r 7a58d924fb04 -r 072cd67c6aab linux/drivers/media/video/saa7134/saa7134-input.c --- a/linux/drivers/media/video/saa7134/saa7134-input.c Tue Mar 09 23:00:59 2010 -0300 +++ b/linux/drivers/media/video/saa7134/saa7134-input.c Wed Mar 10 17:43:41 2010 +0300 @@ -529,6 +529,7 @@ switch (dev-board) { case SAA7134_BOARD_FLYVIDEO2000: case SAA7134_BOARD_FLYVIDEO3000: + case SAA7134_BOARD_HAWELL_HW_404M7: case SAA7134_BOARD_FLYTVPLATINUM_FM: case SAA7134_BOARD_FLYTVPLATINUM_MINI2: case SAA7134_BOARD_ROVERMEDIA_LINK_PRO_FM: diff -r 7a58d924fb04 -r 072cd67c6aab linux/drivers/media/video/saa7134/saa7134.h --- a/linux/drivers/media/video/saa7134/saa7134.h Tue Mar 09 23:00:59 2010 -0300 +++ b/linux/drivers/media/video/saa7134/saa7134.h Wed Mar 10 17:43:41 2010 +0300 @@ -301,6 +301,7 @@ #define SAA7134_BOARD_ASUS_EUROPA_HYBRID 174 #define SAA7134_BOARD_LEADTEK_WINFAST_DTV1000S 175 #define SAA7134_BOARD_BEHOLD_505RDS_MK3 176 +#define SAA7134_BOARD_HAWELL_HW_404M7 177 #define SAA7134_MAXBOARDS 32 #define SAA7134_INPUT_MAX 8 -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PULL] http://endr...@linuxtv.org/hg/~endriss/ngene
Mauro, Please pull from http://endr...@linuxtv.org/hg/~endriss/ngene for the following changeset: 01/01: ngene: Add support for cineS2 v5 and SaTiX-S2 Dual v2 http://endr...@linuxtv.org/hg/~endriss/ngene?cmd=changeset;node=510e37da759e ngene-core.c | 32 ++-- 1 file changed, 30 insertions(+), 2 deletions(-) Thanks, Oliver -- VDR Remote Plugin 0.4.0: http://www.escape-edv.de/endriss/vdr/ 4 MByte Mod: http://www.escape-edv.de/endriss/dvb-mem-mod/ Full-TS Mod: http://www.escape-edv.de/endriss/dvb-full-ts-mod/ li -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH - FIX] V4L: vpfe_capture - free ccdc_lock when memory allocation fails
Hi, If there are no comments, I will send a pull request for merging this. Murali Karicheri Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 phone: 301-407-9583 email: m-kariche...@ti.com -Original Message- From: Karicheri, Muralidharan Sent: Tuesday, March 09, 2010 3:08 PM To: linux-media@vger.kernel.org Cc: Karicheri, Muralidharan Subject: [PATCH - FIX] V4L: vpfe_capture - free ccdc_lock when memory allocation fails From: Murali Karicheri m-kariche...@ti.com This patch fixes a bug in vpfe_probe() that doesn't call mutex_unlock() if memory allocation for ccdc_cfg fails. See also the smatch warning report from Dan Carpenter that shows this as an issue. Signed-off-by: Murali Karicheri m-kariche...@ti.com --- drivers/media/video/davinci/vpfe_capture.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media/video/davinci/vpfe_capture.c b/drivers/media/video/davinci/vpfe_capture.c index 885cd54..91f665b 100644 --- a/drivers/media/video/davinci/vpfe_capture.c +++ b/drivers/media/video/davinci/vpfe_capture.c @@ -1829,7 +1829,7 @@ static __init int vpfe_probe(struct platform_device *pdev) if (NULL == ccdc_cfg) { v4l2_err(pdev-dev.driver, Memory allocation failed for ccdc_cfg\n); - goto probe_free_dev_mem; + goto probe_free_lock; } strncpy(ccdc_cfg-name, vpfe_cfg-ccdc, 32); @@ -1981,8 +1981,9 @@ probe_out_video_release: probe_out_release_irq: free_irq(vpfe_dev-ccdc_irq0, vpfe_dev); probe_free_ccdc_cfg_mem: - mutex_unlock(ccdc_lock); kfree(ccdc_cfg); +probe_free_lock: + mutex_unlock(ccdc_lock); probe_free_dev_mem: kfree(vpfe_dev); return ret; -- 1.6.0.4 -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] tm6000: add new hybrid-stick
From: Stefan Ringel stefan.rin...@arcor.de -add Hauppauge WinTV HVR 900H/WinTV USB2-Stick vid/pid 0x2040/6601 0x2040/6610 0x2040/6611 -add Terratec Cinergy Hybrid-Stick vid/pid 0x0ccd/0x00a5 -add Twinhan TU501(704D1) vid/pid 0x13d3/0x3240 0x13d3/0x3241 0x13d3/0x3243 0x13d3/0x3264 Signed-off-by: Stefan Ringel stefan.rin...@arcor.de --- drivers/staging/tm6000/tm6000-cards.c | 39 +++- 1 files changed, 33 insertions(+), 6 deletions(-) diff --git a/drivers/staging/tm6000/tm6000-cards.c b/drivers/staging/tm6000/tm6000-cards.c index 83cb4b9..2053008 100644 --- a/drivers/staging/tm6000/tm6000-cards.c +++ b/drivers/staging/tm6000/tm6000-cards.c @@ -47,6 +47,7 @@ #define TM6010_BOARD_BEHOLD_WANDER 10 #define TM6010_BOARD_BEHOLD_VOYAGER11 #define TM6010_BOARD_TERRATEC_CINERGY_HYBRID_XE12 +#define TM6010_BOARD_TWINHAN_TU501 13 #define TM6000_MAXBOARDS16 static unsigned int card[] = {[0 ... (TM6000_MAXBOARDS - 1)] = UNSET }; @@ -169,7 +170,7 @@ struct tm6000_board tm6000_boards[] = { .gpio_addr_tun_reset = TM6000_GPIO_4, }, [TM6010_BOARD_HAUPPAUGE_900H] = { - .name = Hauppauge HVR-900H, + .name = Hauppauge WinTV HVR-900H / WinTV USB2-Stick, .tuner_type = TUNER_XC2028, /* has a XC3028 */ .tuner_addr = 0xc2 1, .demod_addr = 0x1e 1, @@ -180,7 +181,7 @@ struct tm6000_board tm6000_boards[] = { .has_zl10353 = 1, .has_eeprom = 1, }, - .gpio_addr_tun_reset = TM6000_GPIO_2, + .gpio_addr_tun_reset = TM6010_GPIO_2, }, [TM6010_BOARD_BEHOLD_WANDER] = { .name = Beholder Wander DVB-T/TV/FM USB2.0, @@ -212,7 +213,22 @@ struct tm6000_board tm6000_boards[] = { .gpio_addr_tun_reset = TM6000_GPIO_2, }, [TM6010_BOARD_TERRATEC_CINERGY_HYBRID_XE] = { - .name = Terratec Cinergy Hybrid XE, + .name = Terratec Cinergy Hybrid XE / Cinergy Hybrid-Stick, + .tuner_type = TUNER_XC2028, /* has a XC3028 */ + .tuner_addr = 0xc2 1, + .demod_addr = 0x1e 1, + .type = TM6010, + .caps = { + .has_tuner= 1, + .has_dvb = 1, + .has_zl10353 = 1, + .has_eeprom = 1, + .has_remote = 1, + }, + .gpio_addr_tun_reset = TM6010_GPIO_2, + }, + [TM6010_BOARD_TWINHAN_TU501] = { + .name = Twinhan TU501(704D1), .tuner_type = TUNER_XC2028, /* has a XC3028 */ .tuner_addr = 0xc2 1, .demod_addr = 0x1e 1, @@ -236,9 +252,17 @@ struct usb_device_id tm6000_id_table [] = { { USB_DEVICE(0x14aa, 0x0620), .driver_info = TM6000_BOARD_FREECOM_AND_SIMILAR }, { USB_DEVICE(0x06e1, 0xb339), .driver_info = TM6000_BOARD_ADSTECH_MINI_DUAL_TV }, { USB_DEVICE(0x2040, 0x6600), .driver_info = TM6010_BOARD_HAUPPAUGE_900H }, + { USB_DEVICE(0x2040, 0x6601), .driver_info = TM6010_BOARD_HAUPPAUGE_900H }, + { USB_DEVICE(0x2040, 0x6610), .driver_info = TM6010_BOARD_HAUPPAUGE_900H }, + { USB_DEVICE(0x2040, 0x6611), .driver_info = TM6010_BOARD_HAUPPAUGE_900H }, { USB_DEVICE(0x6000, 0xdec0), .driver_info = TM6010_BOARD_BEHOLD_WANDER }, { USB_DEVICE(0x6000, 0xdec1), .driver_info = TM6010_BOARD_BEHOLD_VOYAGER }, { USB_DEVICE(0x0ccd, 0x0086), .driver_info = TM6010_BOARD_TERRATEC_CINERGY_HYBRID_XE }, + { USB_DEVICE(0x0ccd, 0x00A5), .driver_info = TM6010_BOARD_TERRATEC_CINERGY_HYBRID_XE }, + { USB_DEVICE(0x13d3, 0x3240), .driver_info = TM6010_BOARD_TWINHAN_TU501 }, + { USB_DEVICE(0x13d3, 0x3241), .driver_info = TM6010_BOARD_TWINHAN_TU501 }, + { USB_DEVICE(0x13d3, 0x3243), .driver_info = TM6010_BOARD_TWINHAN_TU501 }, + { USB_DEVICE(0x13d3, 0x3264), .driver_info = TM6010_BOARD_TWINHAN_TU501 }, { }, }; @@ -271,7 +295,9 @@ int tm6000_tuner_callback(void *ptr, int component, int command, int arg) case 0: /* newer tuner can faster reset */ switch (dev-model) { + case TM6010_BOARD_HAUPPAUGE_900H: case TM6010_BOARD_TERRATEC_CINERGY_HYBRID_XE: + case TM6010_BOARD_TWINHAN_TU501: tm6000_set_reg(dev, REQ_03_SET_GET_MCU_PIN, dev-tuner_reset_gpio, 0x01); msleep(60); @@ -328,11 +354,11 @@ int tm6000_cards_setup(struct
Hauppauge WinTV-HVR-2200 - support analog ?
Hi, support drivers for linux analog part WinTV-HVR-2200 ? if yes is possible watch/record two analog source at the same time ? thanks -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: OK
This message is generated daily by a cron job that builds v4l-dvb for the kernels and architectures in the list below. Results of the daily build of v4l-dvb: date:Wed Mar 10 19:00:24 CET 2010 path:http://www.linuxtv.org/hg/v4l-dvb changeset: 14412:7a58d924fb04 git master: f6760aa024199cfbce564311dc4bc4d47b6fb349 git media-master: 8c69c6ed6c74c94fa7ad6fa24eda452e4b212d81 gcc version: i686-linux-gcc (GCC) 4.4.3 host hardware:x86_64 host os: 2.6.32.5 linux-2.6.32.6-armv5: OK linux-2.6.33-armv5: OK linux-2.6.34-rc1-armv5: OK linux-2.6.32.6-armv5-davinci: OK linux-2.6.33-armv5-davinci: OK linux-2.6.34-rc1-armv5-davinci: OK linux-2.6.32.6-armv5-ixp: OK linux-2.6.33-armv5-ixp: OK linux-2.6.34-rc1-armv5-ixp: OK linux-2.6.32.6-armv5-omap2: OK linux-2.6.33-armv5-omap2: OK linux-2.6.34-rc1-armv5-omap2: OK linux-2.6.22.19-i686: WARNINGS linux-2.6.23.17-i686: WARNINGS linux-2.6.24.7-i686: WARNINGS linux-2.6.25.20-i686: WARNINGS linux-2.6.26.8-i686: WARNINGS linux-2.6.27.44-i686: WARNINGS linux-2.6.28.10-i686: WARNINGS linux-2.6.29.1-i686: WARNINGS linux-2.6.30.10-i686: WARNINGS linux-2.6.31.12-i686: WARNINGS linux-2.6.32.6-i686: WARNINGS linux-2.6.33-i686: WARNINGS linux-2.6.34-rc1-i686: WARNINGS linux-2.6.32.6-m32r: OK linux-2.6.33-m32r: OK linux-2.6.34-rc1-m32r: OK linux-2.6.32.6-mips: OK linux-2.6.33-mips: OK linux-2.6.34-rc1-mips: OK linux-2.6.32.6-powerpc64: WARNINGS linux-2.6.33-powerpc64: WARNINGS linux-2.6.34-rc1-powerpc64: WARNINGS linux-2.6.22.19-x86_64: WARNINGS linux-2.6.23.17-x86_64: WARNINGS linux-2.6.24.7-x86_64: WARNINGS linux-2.6.25.20-x86_64: WARNINGS linux-2.6.26.8-x86_64: WARNINGS linux-2.6.27.44-x86_64: WARNINGS linux-2.6.28.10-x86_64: WARNINGS linux-2.6.29.1-x86_64: WARNINGS linux-2.6.30.10-x86_64: WARNINGS linux-2.6.31.12-x86_64: WARNINGS linux-2.6.32.6-x86_64: WARNINGS linux-2.6.33-x86_64: WARNINGS linux-2.6.34-rc1-x86_64: WARNINGS linux-git-armv5: OK linux-git-armv5-davinci: OK linux-git-armv5-ixp: OK linux-git-armv5-omap2: OK linux-git-i686: WARNINGS linux-git-m32r: OK linux-git-mips: OK linux-git-powerpc64: WARNINGS linux-git-x86_64: WARNINGS spec: ERRORS spec-git: OK sparse: ERRORS linux-2.6.16.62-i686: OK linux-2.6.17.14-i686: OK linux-2.6.18.8-i686: OK linux-2.6.19.7-i686: OK linux-2.6.20.21-i686: OK linux-2.6.21.7-i686: OK linux-2.6.16.62-x86_64: OK linux-2.6.17.14-x86_64: OK linux-2.6.18.8-x86_64: OK linux-2.6.19.7-x86_64: OK linux-2.6.20.21-x86_64: OK linux-2.6.21.7-x86_64: OK Detailed results are available here: http://www.xs4all.nl/~hverkuil/logs/Wednesday.log Full logs are available here: http://www.xs4all.nl/~hverkuil/logs/Wednesday.tar.bz2 The V4L-DVB specification from this daily build is here: http://www.xs4all.nl/~hverkuil/spec/media.html -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: s2-liplianin, mantis: sysfs: cannot create duplicate filename '/devices/virtual/irrcv'
On 9 марта 2010 22:09:48 VDR User wrote: 2010/3/9 Igor M. Liplianin liplia...@me.by: On 8 марта 2010 22:41:26 VDR User wrote: This isn't an answer to your questions but I don't recommend using the s2-liplianin tree as it contains timing patches which can cause serious damage to your tuner. This has also been confirmed by the manufacturer as well and to my knowledge has unfortunately not been reverted in that tree. Funny enough. VDR User, you are wrong for years. Look here http://mercurial.intuxication.org/hg/s2-liplianin/rev/c15f31375c53 Sorry, I was unaware you finally removed the dangerous code. It's too bad it was left there as long as it was but at least it's gone now. Btw, looking at the changelog, it was only removed one year ago, not years. I strongly urge you to use either of these _safe_ trees: http://jusst.de/hg/mantis-v4l-dvb (for development drivers, which may still be stable) http://linuxtv.org/hg/v4l-dvb (for more stable drivers) MartinG, I'm already planning to replace mantis related part with linuxtv one, so please use http://linuxtv.org/hg/v4l-dvb. But not get wrong, this tree isn't panacea, your reports are welcome. I'm glad to hear you're going to rebase the mantis driver with the up-to-date code rather then keeping the old outdated stuff that's currently in there! Do you know when you'll be doing this?? I know when. But please, don't discuss much my tree here, I consider it like experimental, like my sandbox. -- Igor M. Liplianin Microsoft Windows Free Zone - Linux used for all Computing Tasks -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: s2-liplianin, mantis: sysfs: cannot create duplicate filename '/devices/virtual/irrcv'
2010/3/10 Igor M. Liplianin liplia...@me.by: I'm glad to hear you're going to rebase the mantis driver with the up-to-date code rather then keeping the old outdated stuff that's currently in there! Do you know when you'll be doing this?? I know when. Ok...when? But please, don't discuss much my tree here, I consider it like experimental, like my sandbox. If you make your tree publicly available and people ask questions about it on mailing lists, do you really expect nobody to respond? The OP MartinG was given only good advice. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [patch] omap24xxcam: potential buffer overflow
Dan Carpenter wrote: The previous loop goes until last == VIDEO_MAX_FRAME, so this could potentially go one past the end of the loop. Hi Dan, Thanks for the patch! Signed-off-by: Dan Carpenter erro...@gmail.com diff --git a/drivers/media/video/omap24xxcam.c b/drivers/media/video/omap24xxcam.c index 142c327..bedbee9 100644 --- a/drivers/media/video/omap24xxcam.c +++ b/drivers/media/video/omap24xxcam.c @@ -1404,7 +1404,7 @@ static int omap24xxcam_mmap_buffers(struct file *file, } size = 0; - for (i = first; i = last; i++) { + for (i = first; i = last i VIDEO_MAX_FRAME; i++) { struct videobuf_dmabuf *dma = videobuf_to_dma(vbq-bufs[i]); for (j = 0; j dma-sglen; j++) { That function is quite an ugly piece of code... This patch fixes an obvious bug in it. Acked-by: Sakari Ailus sakari.ai...@maxwell.research.nokia.com -- Sakari Ailus sakari.ai...@maxwell.research.nokia.com -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
How to test s-video em28xx card input?
Hi, I would like to know how can I test the svideo input of a em28xx usb card. The svideo has a round 9-pin female connector so, if I'm not wrong, it should have also the audio in. Is it correct? Thank you, Andrea -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] DTV2000 H Plus issues
I have finally received some feedback on DVB-T, and it reportedly works, although with a minor bug: it was necessary to use the cable connector instead of the antenna one. There is an updated patch at the web page http://www.sharemation.com/IstvanV/v4l/xc4000.html that attempts to correct this problem. It also includes a few CX88 changes that are not related to adding support for XC4000 based cards, and could possibly be released as separate patches: - implements a sharpness control using the CX2388x peaking filter and changing the notch filter - in two places (cx88-core.c and cx88-video.c) code that checked for CX88_VMUX_TELEVISION did not also check for CX88_VMUX_CABLE; this was the reason why selecting the audio standard did not work for the cable input - in cx88-mpeg.c, there was code that set core-input to CX88_VMUX_DVB; this does not seem to make sense, since core-input is an index to an array (core-board.input), while the CX88_VMUX_* values are not intended to be used as indexes, but rather values of the 'type' member of struct cx88_input. But it is also not obvious if this has any actual effect other than what is reported as the current input when queried by an application. In any case, I changed the code to search for an input of type CX88_VMUX_DVB, or set the input to 0 if it is not found -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
USB TechnoTrend Connect S2-3650 CI + CAM's
Hello, I was just wondering, as there seem a complete driver available for this tuner and its CI interface, is anybody actually using this HW with MythTV or any other Linux TV solution? For now, the best CI option card has been the TT-S2-3200, but if this relatively new USB card works with HW CAM's too, it would be great news. I've been waiting for it for some time, it's a good add-on card for the few extra pay-services requiring non-standard CAM's (like DRE for Penthouse HD :)). Do share your experience... -- David Kubicek -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
cx23885_wakeup: 32 buffers handled (should be 1)
I see messages like : cx23885_wakeup: 32 buffers handled (should be 1) in my logs on my mythtv box. I take it they're coming from my DVICO dual express 7 tuner card. The message always contains those numbers (32 and should be 1). It doesn't seem to cause me any troubles, I'm just curious about the message. A quick perusal of the code in cx23885-core.c doesn't look like this is an actual error condition--i.e. it looks like the driver is handling multiple messages. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html