Confusing dmx_pes_type_t in dmx.h

2010-10-04 Thread Jan Hoogenraad
The file dmx.h declares dmx_pes_type_t which is ONLY used in this header 
file.
It is easy to make mistakes, as its member DMX_PES_OTHER resembles a 
similar symbol in demux.h from enum dmx_ts_pes:  DMX_TS_PES_OTHER


One problem was found because of Hans' compiler upgrade.

I think it would be safer (because it is easy to make mistakes) to 
remove  dmx_pes_type_t from dmx.h.


Who knows more on this driver ?

The found bug is fixed in the patch on:
http://linuxtv.org/hg/~jhoogenraad/ubuntu-firedtv/rev/44751f6fba2f

--
Jan Hoogenraad
Hoogenraad Interface Services
Postbus 2717
3500 GS Utrecht

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


tm6000 and new TV card

2010-10-04 Thread Dmitri Belimov
Hi 

Some times a go I received mail from Yogesh S .
He has TV card based on the tm5600 chip. His card is 
http://www.zebronics.net/Usb_tvtuners.asp
and has USB ID as (vid:6000,pid:0001). This IDs already captured by 
10MOONS_UT821 TV card.
Who has the 10MOONS_UT821 TV card and can make some photos inside??

If this cards is different how we can add support zebronics TV tuner?

With my best regards, Dmitry.
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: Help adding support for Hauppauge HVR-850 (latest version w/ USB ID 2040:b140)

2010-10-04 Thread Devin Heitmueller
On Mon, Oct 4, 2010 at 8:07 PM, Seth Jennings  wrote:
> Hi,
>
> The most recent version of the Hauppauge WinTV HVR-850 is currently
> not supported.  The previous two hardware versions with USB ID
> 2040:651f and 2040:7240 are supported but the most recent version with
> USB ID 2040:b140 is not.

I've got a tree here with support for the device.  More info can be found here:

Hauppauge USBLive2 and new HVR-850 support
http://www.kernellabs.com/blog/?p=1445

Cheers,

Devin

-- 
Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [linux-dvb] Asus MyCinema P7131 Dual support

2010-10-04 Thread hermann pitton

Am Montag, den 04.10.2010, 19:59 -0400 schrieb Devin Heitmueller:
> On Mon, Oct 4, 2010 at 7:21 PM, hermann pitton  
> wrote:
> > thanks for the report and pointing to the details again.
> >
> > We can see, that my testings on four different machines and Dmitri's
> > tests have not been enough. Mauro had the Dual card=78 version from me
> > too at least for analog TV testing.
> >
> > And, that was on hg with most backward compat as possible.
> >
> > How good are our chances, to run in such and similar troubles in the
> > future, in fact staying only on latest -rc, rc-git and in best case on
> > -next stuff previously?
> >
> > It will all come down to the distros and such a bug fix might take just
> > a year in the future regularly ...
> >
> > So, if the quality control was not even sufficient on hg, what will
> > happen on latest -rc git stuff for that?
> >
> > Obviously zillions of people do much more prefer to crash around there
> > than on hg ... ;)
> 
> I think it's been made pretty clear:  we don't give a crap about
> whether users' PCs crash.  Getting the code into the bleeding edge
> kernel is the most important thing.  Reducing maintainership overhead
> is clearly more important than whether the code actually works.
> 
> Forget about the hg backport system.  We would rather get crap code
> into the bleeding edge kernel where almost zero users will test it
> than to put it into HG where there is actually a chance for users to
> see the problems before it goes into the mainline kernel (except for
> the 0.1% of users who are willing to install the latest bleeding edge
> kernel and make it work with all their other hardware).
> 
> Yes, we should all be prepared for lots of regressions being
> introduced, and nobody notices them until the code is already in the
> distros and has reached the masses.  And then maybe if the users are
> lucky the distro maintainers will backport fixes.
> 
> It's been made pretty clear that reducing merge overhead is more
> important than delivering a quality product.
> 
> I'll stop hijacking the thread now.
> 
> Devin


Devin,

you are always very welcome!

I know for sure, that you know what you are talking about.

Thanks,
Hermann


--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Help adding support for Hauppauge HVR-850 (latest version w/ USB ID 2040:b140)

2010-10-04 Thread Seth Jennings
Hi,

The most recent version of the Hauppauge WinTV HVR-850 is currently
not supported.  The previous two hardware versions with USB ID
2040:651f and 2040:7240 are supported but the most recent version with
USB ID 2040:b140 is not.

I have identified the components in this new version (through a
combination of reading the .inf file for the Windows driver and
cracking the device open):

Interface Bridge: CX23100
Tuner: LGDT3305
Demodulator: TDA18271HDC2

More details in my post on the discussion page for the device on the
v4l-dvb wiki:
http://linuxtv.org/wiki/index.php/Talk:Hauppauge_WinTV-HVR-850#Possibly_Valuable_Information

I believe that all these components already have drivers available.  I
just don't have the experience to get them together in the cx231xx
module.

All previous HVR-850 and 950(Q) USB devices used the em28xx or au0828
bridge interface, so I don't have a template to work from in the
cx231xx module.  Discovering the gpio configuration is also beyond my
experience.

Any help?  Or any existing development on this that I don't know about?

Thanks,
Seth
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [linux-dvb] Asus MyCinema P7131 Dual support

2010-10-04 Thread Devin Heitmueller
On Mon, Oct 4, 2010 at 7:21 PM, hermann pitton  wrote:
> thanks for the report and pointing to the details again.
>
> We can see, that my testings on four different machines and Dmitri's
> tests have not been enough. Mauro had the Dual card=78 version from me
> too at least for analog TV testing.
>
> And, that was on hg with most backward compat as possible.
>
> How good are our chances, to run in such and similar troubles in the
> future, in fact staying only on latest -rc, rc-git and in best case on
> -next stuff previously?
>
> It will all come down to the distros and such a bug fix might take just
> a year in the future regularly ...
>
> So, if the quality control was not even sufficient on hg, what will
> happen on latest -rc git stuff for that?
>
> Obviously zillions of people do much more prefer to crash around there
> than on hg ... ;)

I think it's been made pretty clear:  we don't give a crap about
whether users' PCs crash.  Getting the code into the bleeding edge
kernel is the most important thing.  Reducing maintainership overhead
is clearly more important than whether the code actually works.

Forget about the hg backport system.  We would rather get crap code
into the bleeding edge kernel where almost zero users will test it
than to put it into HG where there is actually a chance for users to
see the problems before it goes into the mainline kernel (except for
the 0.1% of users who are willing to install the latest bleeding edge
kernel and make it work with all their other hardware).

Yes, we should all be prepared for lots of regressions being
introduced, and nobody notices them until the code is already in the
distros and has reached the masses.  And then maybe if the users are
lucky the distro maintainers will backport fixes.

It's been made pretty clear that reducing merge overhead is more
important than delivering a quality product.

I'll stop hijacking the thread now.

Devin

-- 
Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [linux-dvb] Asus MyCinema P7131 Dual support

2010-10-04 Thread hermann pitton
Hi Giorgio,

Am Montag, den 04.10.2010, 18:11 +0200 schrieb Giorgio:
> On 04/10/2010 01:48, Dejan Rodiger wrote:
> > Hi Hermann,
> > 
> > I finally found the time to wire analog antena and I checked it with
> > my TV if it is working correctly.
> > Since I am using local cable provider which didn't upgrade their
> > system in 10 years and they are still broadcast in analog, I had a
> > problem off finding channel list, so in the end I tried tvtime-scanner
> > and it found about 58 channels. But, out of this 58 most of them were
> > not good (no signal). I was able to finetune few programs. My main
> > programs (local Croatian TV stations) were not found. Maybe I need to
> > finetune every found station.
> > 
> > I also tried zapping which crashed my X.
> > 
> > I am also lost in setting mythtv. I set analog tunner on /dev/video0.
> > But I think I have a problem of setting the channel list for my local
> > cable provider. Is it possible to scan whole list or something. If you
> > have any reading recommendation to set this, I would be helpfull
> 
> Dejan,
> 
> I have the exact same card:
> 
> # sudo lpci -vnn
> 02:07.0 Multimedia controller [0480]: Philips Semiconductors 
> SAA7131/SAA7133/SAA7135 Video Broadcast Decoder [1131:7133] (rev d1)
>   Subsystem: ASUSTeK Computer Inc. Device [1043:4876]
>   Flags: bus master, medium devsel, latency 64, IRQ 20
>   Memory at fbfff800 (32-bit, non-prefetchable) [size=2K]
>   Capabilities: [40] Power Management version 2
>   Kernel driver in use: saa7134
>   Kernel modules: saa7134
> 
> and I can confirm you that it's autodetected and works very well (both the
> analog and the digital part) on 2.6.35.
> 2.6.32 has a problem with dvb-t reception, but I have reported it and 
> hopefully
> it will be fixed soon upstream: 
> http://article.gmane.org/gmane.linux.drivers.video-input-infrastructure/23604

thanks for the report and pointing to the details again.

We can see, that my testings on four different machines and Dmitri's
tests have not been enough. Mauro had the Dual card=78 version from me
too at least for analog TV testing.

And, that was on hg with most backward compat as possible.

How good are our chances, to run in such and similar troubles in the
future, in fact staying only on latest -rc, rc-git and in best case on
-next stuff previously?

It will all come down to the distros and such a bug fix might take just
a year in the future regularly ...

So, if the quality control was not even sufficient on hg, what will
happen on latest -rc git stuff for that?

Obviously zillions of people do much more prefer to crash around there
than on hg ... ;)

Likely, I only have to read the LKML daily ...

Despite of that, we need a good analysis of course, and a way how to
avoid such.

Cheers,
Hermann


> 
> If you want to test the analog part, install MPlayer and run the following 
> command:
> 
> mplayer tv:// -tv 
> driver=v4l2:device=/dev/video0:norm=PAL:input=0:chanlist=europe-west
> 
> and then press 'k' or 'h' to select previous/next channel (after you switch
> channel, wait some seconds until the card tunes, for some channels I need
> 5 seconds here, for others about 1 second). Now, with some patience, explore
> all the channels and you should be able to find your local tv stations.
> Also, you might need to adjust mplayer options, like norm= or chanlist=
> (you could try chanlist=europe-east).
> 
> The command line above doesn't grab audio though, so you won't hear a thing.
> If you want to hear the audio you need to make sure saa7134-alsa is loaded
> and run something like:
> 
> mplayer tv:// -tv 
> driver=v4l2:device=/dev/video0:norm=PAL:input=0:alsa:adevice=hw.1,0:amode=1:immediatemode=0:chanlist=europe-west
> 
> (make sure you select the right alsa device in adevice=)
> 
> The wiki has a good page about MPlayer:
> 
> http://www.linuxtv.org/wiki/index.php/MPlayer
> 
> and of course the MPlayer man page explain all the options too.
> 
> These pages are also useful (but some things might be a bit outdated):
> 
> http://www.linuxtv.org/wiki/index.php/ASUS_My_Cinema-P7131_Hybrid
> http://www.linuxtv.org/wiki/index.php/Saa7134-alsa
> 
> I hope this can help you and others reading this ML.
> 
> Regards,
> Giorgio Vazzana
> 
> > Thanks
> > --
> > Dejan Rodiger
> > S: callto://drodiger
> > 
> > 
> > 
> > On Thu, Sep 23, 2010 at 00:46,   wrote:
> >>
> >>
> >> Hi Dejan,
> >>
> >> - Original Nachricht 
> >> Von: Dejan Rodiger 
> >> An:  hermann pitton 
> >> Datum:   22.09.2010 13:20
> >> Betreff: Re: [linux-dvb] Asus MyCinema P7131 Dual support
> >>
> >>> Hi Herman,
> >>>
> >>> here is dmesg output without forcing card=78.
> >>> As I see it uses card=112, autodetected
> >>>
> >>> [   16.043345] IR RC6 protocol handler initialized
> >>> [   16.173473] IR JVC protocol handler initialized
> >>> [   16.236641] IR Sony protocol handler initialized
> >>> [   16.433187] lirc_dev: IR Remote Control driver registered, major 250
> >>> [   16.5

Re: [PATCH] v4l/dvb: add support for AVerMedia AVerTV Red HD+ (A850T)

2010-10-04 Thread Antti Palosaari

On 10/04/2010 11:55 PM, Yann E. MORIN wrote:

All,

On Friday 01 October 2010 21:55:43 Yann E. MORIN wrote:

The AVerTV Red HD+ (A850T) is basically the same as the existing
AVerTV Volar Black HD (A850), but is specific to the french market.
The A850T identifies itself as a A850, but has its own PID. It even
suffers from the same EEPROM deficiencies.


Ping? Is there something that I should still work on?


No. I will pick it up and forward to the master.

thanks
Antti




Regards,
Yann E. MORIN.




--
http://palosaari.fi/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] v4l/dvb: add support for AVerMedia AVerTV Red HD+ (A850T)

2010-10-04 Thread Yann E. MORIN
All,

On Friday 01 October 2010 21:55:43 Yann E. MORIN wrote:
> The AVerTV Red HD+ (A850T) is basically the same as the existing
> AVerTV Volar Black HD (A850), but is specific to the french market.
> The A850T identifies itself as a A850, but has its own PID. It even
> suffers from the same EEPROM deficiencies.

Ping? Is there something that I should still work on?

Regards,
Yann E. MORIN.

-- 
.-..--..
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN |  ___   |
| +33 223 225 172 `.---:  X  AGAINST  |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL|   v   conspiracy.  |
'--^---^--^'


--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH] Terratec Cinergy Hybrid T USB XS FR

2010-10-04 Thread Catimimi

 New gpio definitions.
XC3028_FE_ZARLINK456 was not loaded.

Signed-off-by: Michel Garnier

---

diff -Nru v4l-dvb-1da5fed5c8b2-orig/linux/drivers/media/video/em28xx/em28xx-cards.c 
v4l-dvb-1da5fed5c8b2-new/linux/drivers/media/video/em28xx/em28xx-cards.c

--- v4l-dvb-1da5fed5c8b2-orig/linux/drivers/media/video/em28xx/em28xx-cards.c   
 2010-09-19 07:23:09.0 +0200
+++ v4l-dvb-1da5fed5c8b2-new/linux/drivers/media/video/em28xx/em28xx-cards.c
2010-10-04 19:05:11.0 +0200
@@ -200,6 +200,18 @@
 {-1,-1,-1,-1},
 };

+static struct em28xx_reg_seq terratec_cinergy_USB_XS_analog[] = {
+{EM28XX_R08_GPIO,0x6d,~EM_GPIO_4,10},
+{EM2880_R04_GPO,0x00,0xff,10},
+{ -1,-1,-1,-1},
+};
+
+static struct em28xx_reg_seq terratec_cinergy_USB_XS_digital[] = {
+{EM28XX_R08_GPIO,0x6e,~EM_GPIO_4,10},
+{EM2880_R04_GPO,0x08,0xff,10},
+{ -1,-1,-1,-1},
+};
+
 /* eb1a:2868 Reddo DVB-C USB TV Box
GPIO4 - CU1216L NIM
Other GPIOs seems to be don't care. */
@@ -824,22 +836,22 @@
 .tuner_gpio   = default_tuner_gpio,
 .decoder  = EM28XX_TVP5150,
 .has_dvb  = 1,
-.dvb_gpio = default_digital,
+.dvb_gpio = terratec_cinergy_USB_XS_digital,
 .input= { {
 .type = EM28XX_VMUX_TELEVISION,
 .vmux = TVP5150_COMPOSITE0,
 .amux = EM28XX_AMUX_VIDEO,
-.gpio = default_analog,
+.gpio = terratec_cinergy_USB_XS_analog,
 }, {
 .type = EM28XX_VMUX_COMPOSITE1,
 .vmux = TVP5150_COMPOSITE1,
 .amux = EM28XX_AMUX_LINE_IN,
-.gpio = default_analog,
+.gpio = terratec_cinergy_USB_XS_analog,
 }, {
 .type = EM28XX_VMUX_SVIDEO,
 .vmux = TVP5150_SVIDEO,
 .amux = EM28XX_AMUX_LINE_IN,
-.gpio = default_analog,
+.gpio = terratec_cinergy_USB_XS_analog,
 } },
 },
 [EM2880_BOARD_HAUPPAUGE_WINTV_HVR_900] = {
@@ -2259,6 +2271,7 @@
 ctl->demod = XC3028_FE_ZARLINK456;
 break;
 case EM2880_BOARD_TERRATEC_HYBRID_XS:
+case EM2880_BOARD_TERRATEC_HYBRID_XS_FR:
 case EM2881_BOARD_PINNACLE_HYBRID_PRO:
 ctl->demod = XC3028_FE_ZARLINK456;
 break;

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: udev-161 dvbT kernel-2.6.35.5

2010-10-04 Thread sibu xolo
On Monday 04 October 2010 01:16:35 sibu xolo wrote:
> Greetings,
> 
> I am attempting to set up DVBT on a computer with these:
> 
> cpu:  amd64 2 cores, gpu nvidia gforce  nouveau drm
> o/s cblfslinux 64-bit kernel-2.6.35.5 udev-161  kde-4.4.5
> dvb device  Hauppauge wintvNovaT DVBT usb2
> 
> I have  the foollowing in /lib/firmware
> 
> 
> dvb-usb-dib0700-01.fw
> dvb-usb-dib0700-1.20.fw
> 
> 
> #  my udev rule looks like so:-
> 
> KERNEL="dvb*",
> PROGRAM="/etc/udev/scripts/dvb.sh %k",
> ATTRS{serial}=="123456789a",
> ATTRS{product}=="Nova-T Stick",
> GROUP="video",
> MODE="0660",
> SYMLINK+="Nova-T-usb2"
> 
> ## the machine dwells a litle   on booting
> ## lsmod yoelds:-
> 
> root [ ~teeveey ]# lsmod
> Module  Size  Used by
> snd_hda_codec_realtek   294785  1
> dvb_usb_dib070077625  0
> dib7000p   15705  1 dvb_usb_dib0700
> dib009012297  1 dvb_usb_dib0700
> dib7000m   12868  1 dvb_usb_dib0700
> dib0070 7510  1 dvb_usb_dib0700
> dvb_usb16683  1 dvb_usb_dib0700
> dib800023992  1 dvb_usb_dib0700
> dvb_core   87312  3 dib7000p,dvb_usb,dib8000
> dib3000mc  11061  1 dvb_usb_dib0700
> dibx000_common  3213  4 dib7000p,dib7000m,dib8000,dib3000mc
> nouveau   387642  2
> ttm53985  1 nouveau
> drm_kms_helper 25234  1 nouveau
> snd_hda_intel  24006  3
> snd_hda_codec  82672  2 snd_hda_codec_realtek,snd_hda_intel
> pcspkr  1854  0
> ohci_hcd   33354  0
> cfbcopyarea 3037  1 nouveau
> cfbimgblt   2205  1 nouveau
> cfbfillrect 3113  1 nouveau
> snd_hwdep   6048  1 snd_hda_codec
> root [ ~teeveey ]#
> 
> 
> 
> #  but ls   for /dev/dvb*  yields nought like so:-
> 
> root [ ~teeveey ]# ls -l  /dev/dvb*
> ls: cannot access /dev/dvb*: No such file or directory
> root [ ~teeveey ]#
> 
> I used the said device successfully  in a build wih 2,6.28.8/udev-113 last
> year  but it appears   the setup for DVB on linux has changed recently.
> Accordingly guidance on where I am gping wrong would be much appreciated.
> 
> Yours sincerely
> 
> sibuXolo


I sent the email above  to the list  a day or so ago and received no response. 
If I am on the wrong list I would be grateful if someone  aufaitinform me 
of the appropriate list.   Otherwise suggestions   of where I am going wrong  
would be much apprecuated.

as an update:-
I tested  the setup described above  on  a machine with kernel-2.6.31.6 and 
/dev/dvb/adapter0 is generated

I recall a  while back when DVB  drivers were not in the kernel.   Then they  
were  integrated within  thus requiring only a kernel compilation.  I came 
across the somewhat  ubuntified  wiki
( http://www.linuxtv.org/wiki/index.php/Bug_Report )
(which seems  to suggest the old methodis now needed..  I would  thus be 
grateful for some clarity  as per:-

Is  compiling the kernel  as up to 2.6.28.8 and  with prior selection of the 
appropriate devices under device/drivers/multimedia/video   sufficient or does 
one  now need  to follow the recipe given by the link above.

sx
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH] dabusb: remove the BKL

2010-10-04 Thread Arnd Bergmann
The dabusb device driver is sufficiently serialized using
its own mutex, no need for the big kernel lock here
in addition.

Signed-off-by: Arnd Bergmann 
Cc: Mauro Carvalho Chehab 
---

Hi Mauro,

I just realized that the dabusb driver is not actually a v4l driver,
when I did more test builds with allyesconfig and CONFIG_BKL disabled.

I've added this patch to my bkl/config queue for now, but if you want to carry
it in your tree, I'll drop it from mine.

diff --git a/drivers/media/video/dabusb.c b/drivers/media/video/dabusb.c
index 5b176bd..f3e25e9 100644
--- a/drivers/media/video/dabusb.c
+++ b/drivers/media/video/dabusb.c
@@ -32,7 +32,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -621,7 +620,6 @@ static int dabusb_open (struct inode *inode, struct file 
*file)
if (devnum < DABUSB_MINOR || devnum >= (DABUSB_MINOR + NRDABUSB))
return -EIO;
 
-   lock_kernel();
s = &dabusb[devnum - DABUSB_MINOR];
 
dbg("dabusb_open");
@@ -630,21 +628,17 @@ static int dabusb_open (struct inode *inode, struct file 
*file)
while (!s->usbdev || s->opened) {
mutex_unlock(&s->mutex);
 
-   if (file->f_flags & O_NONBLOCK) {
+   if (file->f_flags & O_NONBLOCK)
return -EBUSY;
-   }
msleep_interruptible(500);
 
-   if (signal_pending (current)) {
-   unlock_kernel();
+   if (signal_pending (current))
return -EAGAIN;
-   }
mutex_lock(&s->mutex);
}
if (usb_set_interface (s->usbdev, _DABUSB_IF, 1) < 0) {
mutex_unlock(&s->mutex);
dev_err(&s->usbdev->dev, "set_interface failed\n");
-   unlock_kernel();
return -EINVAL;
}
s->opened = 1;
@@ -654,7 +648,6 @@ static int dabusb_open (struct inode *inode, struct file 
*file)
file->private_data = s;
 
r = nonseekable_open(inode, file);
-   unlock_kernel();
return r;
 }
 
@@ -689,17 +682,13 @@ static long dabusb_ioctl (struct file *file, unsigned int 
cmd, unsigned long arg
 
dbg("dabusb_ioctl");
 
-   lock_kernel();
-   if (s->remove_pending) {
-   unlock_kernel();
+   if (s->remove_pending)
return -EIO;
-   }
 
mutex_lock(&s->mutex);
 
if (!s->usbdev) {
mutex_unlock(&s->mutex);
-   unlock_kernel();
return -EIO;
}
 
@@ -735,7 +724,6 @@ static long dabusb_ioctl (struct file *file, unsigned int 
cmd, unsigned long arg
break;
}
mutex_unlock(&s->mutex);
-   unlock_kernel();
return ret;
 }
 
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[patch] V4L/DVB: saa7134: add test after for loop

2010-10-04 Thread Dan Carpenter
Add a check after the for loops to see if we found what we were looking
for or if we reached the end of the list.

Signed-off-by: Dan Carpenter 

diff --git a/drivers/media/video/saa7134/saa7134-video.c 
b/drivers/media/video/saa7134/saa7134-video.c
index 45f0ac8..24c3a78 100644
--- a/drivers/media/video/saa7134/saa7134-video.c
+++ b/drivers/media/video/saa7134/saa7134-video.c
@@ -1871,9 +1871,12 @@ int saa7134_s_std_internal(struct saa7134_dev *dev, 
struct saa7134_fh *fh, v4l2_
else
fixup = V4L2_STD_SECAM;
}
-   for (i = 0; i < TVNORMS; i++)
+   for (i = 0; i < TVNORMS; i++) {
if (fixup == tvnorms[i].id)
break;
+   }
+   if (i == TVNORMS)
+   return -EINVAL;
}
 
*id = tvnorms[i].id;
@@ -1997,9 +2000,12 @@ static int saa7134_g_tuner(struct file *file, void *priv,
if (0 != t->index)
return -EINVAL;
memset(t, 0, sizeof(*t));
-   for (n = 0; n < SAA7134_INPUT_MAX; n++)
+   for (n = 0; n < SAA7134_INPUT_MAX; n++) {
if (card_in(dev, n).tv)
break;
+   }
+   if (n == SAA7134_INPUT_MAX)
+   return -EINVAL;
if (NULL != card_in(dev, n).name) {
strcpy(t->name, "Television");
t->type = V4L2_TUNER_ANALOG_TV;
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


tt usb s2-3600 does not work anymore

2010-10-04 Thread Jochen Georges
Hello,

is this the right place to ask?
sorry, i read lots of internet sites, tried a lot of things, and got a
bit confused.
so i hope this is the right place...

my technotrend usb s2 3600 worked fine with s2-liplianin and ubuntu
lucid lynx.

but then it did not work anymore.
it happened a few weeks ago, i am not sure but I think there was an
update of the kernel-headers.

the device itself is ok, i checked it on windows.

does anyone has a hint?

thanks a lot in advance!

beste gruesse
jochen

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[cron job] v4l-dvb daily build 2.6.26 and up: ERRORS

2010-10-04 Thread Hans Verkuil
This message is generated daily by a cron job that builds v4l-dvb for
the kernels and architectures in the list below.

Results of the daily build of v4l-dvb:

date:Mon Oct  4 19:00:08 CEST 2010
path:http://www.linuxtv.org/hg/v4l-dvb
changeset:   15164:1da5fed5c8b2
git master:   3e6dce76d99b328716b43929b9195adfee1de00c
git media-master: c8dd732fd119ce6d562d5fa82a10bbe75a376575
gcc version:  i686-linux-gcc (GCC) 4.5.1
host hardware:x86_64
host os:  2.6.32.5

linux-git-armv5: WARNINGS
linux-git-armv5-davinci: WARNINGS
linux-git-armv5-ixp: WARNINGS
linux-git-armv5-omap2: WARNINGS
linux-git-i686: WARNINGS
linux-git-m32r: WARNINGS
linux-git-mips: WARNINGS
linux-git-powerpc64: WARNINGS
linux-git-x86_64: WARNINGS
linux-2.6.32.6-armv5: WARNINGS
linux-2.6.33-armv5: WARNINGS
linux-2.6.34-armv5: WARNINGS
linux-2.6.35.3-armv5: WARNINGS
linux-2.6.32.6-armv5-davinci: ERRORS
linux-2.6.33-armv5-davinci: ERRORS
linux-2.6.34-armv5-davinci: ERRORS
linux-2.6.35.3-armv5-davinci: ERRORS
linux-2.6.32.6-armv5-ixp: ERRORS
linux-2.6.33-armv5-ixp: ERRORS
linux-2.6.34-armv5-ixp: ERRORS
linux-2.6.35.3-armv5-ixp: ERRORS
linux-2.6.32.6-armv5-omap2: ERRORS
linux-2.6.33-armv5-omap2: ERRORS
linux-2.6.34-armv5-omap2: ERRORS
linux-2.6.35.3-armv5-omap2: ERRORS
linux-2.6.26.8-i686: WARNINGS
linux-2.6.27.44-i686: WARNINGS
linux-2.6.28.10-i686: WARNINGS
linux-2.6.29.1-i686: WARNINGS
linux-2.6.30.10-i686: WARNINGS
linux-2.6.31.12-i686: WARNINGS
linux-2.6.32.6-i686: WARNINGS
linux-2.6.33-i686: WARNINGS
linux-2.6.34-i686: WARNINGS
linux-2.6.35.3-i686: WARNINGS
linux-2.6.32.6-m32r: WARNINGS
linux-2.6.33-m32r: WARNINGS
linux-2.6.34-m32r: WARNINGS
linux-2.6.35.3-m32r: WARNINGS
linux-2.6.32.6-mips: WARNINGS
linux-2.6.33-mips: WARNINGS
linux-2.6.34-mips: WARNINGS
linux-2.6.35.3-mips: WARNINGS
linux-2.6.32.6-powerpc64: WARNINGS
linux-2.6.33-powerpc64: WARNINGS
linux-2.6.34-powerpc64: WARNINGS
linux-2.6.35.3-powerpc64: WARNINGS
linux-2.6.26.8-x86_64: WARNINGS
linux-2.6.27.44-x86_64: WARNINGS
linux-2.6.28.10-x86_64: WARNINGS
linux-2.6.29.1-x86_64: WARNINGS
linux-2.6.30.10-x86_64: WARNINGS
linux-2.6.31.12-x86_64: WARNINGS
linux-2.6.32.6-x86_64: WARNINGS
linux-2.6.33-x86_64: WARNINGS
linux-2.6.34-x86_64: WARNINGS
linux-2.6.35.3-x86_64: WARNINGS
spec-git: OK
sparse: ERRORS

Detailed results are available here:

http://www.xs4all.nl/~hverkuil/logs/Monday.log

Full logs are available here:

http://www.xs4all.nl/~hverkuil/logs/Monday.tar.bz2

The V4L-DVB specification from this daily build is here:

http://www.xs4all.nl/~hverkuil/spec/media.html
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH update2] V4L/DVB: firedtv: support for PSK8 for S2 devices. To watch HD.

2010-10-04 Thread Stefan Richter
Date: Sun, 12 Sep 2010 21:03:45 +0200
From: Tommy Jonsson 

This is the first i have ever developed for linux, cant really wrap my
head around how to submit this..
Hope im sending this correctly, diff made with 'hg diff' from latest
"hg clone http://linuxtv.org/hg/v4l-dvb";

It adds support for tuning with PSK8 modulation, pilot and rolloff
with the S2 versions of firedtv.

Signed-off-by: Tommy Jonsson 
Signed-off-by: Stefan Richter  (trivial 
simplification)
---
Sorry, missed two space-before-tab.

 drivers/media/dvb/firewire/firedtv-avc.c |   30 +--
 drivers/media/dvb/firewire/firedtv-fe.c  |   36 ++-
 2 files changed, 60 insertions(+), 6 deletions(-)

Index: b/drivers/media/dvb/firewire/firedtv-avc.c
===
--- a/drivers/media/dvb/firewire/firedtv-avc.c
+++ b/drivers/media/dvb/firewire/firedtv-avc.c
@@ -24,6 +24,8 @@
 #include 
 #include 
 
+#include 
+
 #include "firedtv.h"
 
 #define FCP_COMMAND_REGISTER   0xfb00ULL
@@ -368,10 +370,30 @@ static int avc_tuner_tuneqpsk(struct fir
c->operand[12] = 0;
 
if (fdtv->type == FIREDTV_DVB_S2) {
-   c->operand[13] = 0x1;
-   c->operand[14] = 0xff;
-   c->operand[15] = 0xff;
-
+   if (fdtv->fe.dtv_property_cache.delivery_system == SYS_DVBS2) {
+   switch (fdtv->fe.dtv_property_cache.modulation) {
+   case QAM_16:c->operand[13] = 0x1; break;
+   case QPSK:  c->operand[13] = 0x2; break;
+   case PSK_8: c->operand[13] = 0x3; break;
+   default:c->operand[13] = 0x2; break;
+   }
+   switch (fdtv->fe.dtv_property_cache.rolloff) {
+   case ROLLOFF_AUTO:  c->operand[14] = 0x2; break;
+   case ROLLOFF_35:c->operand[14] = 0x2; break;
+   case ROLLOFF_20:c->operand[14] = 0x0; break;
+   case ROLLOFF_25:c->operand[14] = 0x1; break;
+   /* case ROLLOFF_NONE:   c->operand[14] = 0xff; break; */
+   }
+   switch (fdtv->fe.dtv_property_cache.pilot) {
+   case PILOT_AUTO:c->operand[15] = 0x0; break;
+   case PILOT_OFF: c->operand[15] = 0x0; break;
+   case PILOT_ON:  c->operand[15] = 0x1; break;
+   }
+   } else {
+   c->operand[13] = 0x1;  /* auto modulation */
+   c->operand[14] = 0xff; /* disable rolloff */
+   c->operand[15] = 0xff; /* disable pilot */
+   }
return 16;
} else {
return 13;
Index: b/drivers/media/dvb/firewire/firedtv-fe.c
===
--- a/drivers/media/dvb/firewire/firedtv-fe.c
+++ b/drivers/media/dvb/firewire/firedtv-fe.c
@@ -155,6 +155,16 @@ static int fdtv_get_frontend(struct dvb_
return -EOPNOTSUPP;
 }
 
+static int fdtv_get_property(struct dvb_frontend *fe, struct dtv_property *tvp)
+{
+   return 0;
+}
+
+static int fdtv_set_property(struct dvb_frontend *fe, struct dtv_property *tvp)
+{
+   return 0;
+}
+
 void fdtv_frontend_init(struct firedtv *fdtv)
 {
struct dvb_frontend_ops *ops = &fdtv->fe.ops;
@@ -166,6 +176,9 @@ void fdtv_frontend_init(struct firedtv *
ops->set_frontend   = fdtv_set_frontend;
ops->get_frontend   = fdtv_get_frontend;
 
+   ops->get_property   = fdtv_get_property;
+   ops->set_property   = fdtv_set_property;
+
ops->read_status= fdtv_read_status;
ops->read_ber   = fdtv_read_ber;
ops->read_signal_strength   = fdtv_read_signal_strength;
@@ -179,7 +192,6 @@ void fdtv_frontend_init(struct firedtv *
 
switch (fdtv->type) {
case FIREDTV_DVB_S:
-   case FIREDTV_DVB_S2:
fi->type= FE_QPSK;
 
fi->frequency_min   = 95;
@@ -188,7 +200,7 @@ void fdtv_frontend_init(struct firedtv *
fi->symbol_rate_min = 100;
fi->symbol_rate_max = 4000;
 
-   fi->caps= FE_CAN_INVERSION_AUTO |
+   fi->caps= FE_CAN_INVERSION_AUTO |
  FE_CAN_FEC_1_2|
  FE_CAN_FEC_2_3|
  FE_CAN_FEC_3_4|
@@ -198,6 +210,26 @@ void fdtv_frontend_init(struct firedtv *
  FE_CAN_QPSK;
break;
 
+   case FIREDTV_DVB_S2:
+   fi->type

[PATCH update] V4L/DVB: firedtv: support for PSK8 for S2 devices. To watch HD.

2010-10-04 Thread Stefan Richter
Date: Sun, 12 Sep 2010 21:03:45 +0200
From: Tommy Jonsson 

This is the first i have ever developed for linux, cant really wrap my
head around how to submit this..
Hope im sending this correctly, diff made with 'hg diff' from latest
"hg clone http://linuxtv.org/hg/v4l-dvb";

It adds support for tuning with PSK8 modulation, pilot and rolloff
with the S2 versions of firedtv.

Signed-off-by: Tommy Jonsson 
Signed-off-by: Stefan Richter  (trivial 
simplification)
---
Update: resend with whitespace preserved, fe pointer does not have to be
put into function parameter lists, copyright notice removed (authorship
of smaller changes like this is tracked in the git changelog)

 drivers/media/dvb/firewire/firedtv-avc.c |   30 +--
 drivers/media/dvb/firewire/firedtv-fe.c  |   36 ++-
 2 files changed, 60 insertions(+), 6 deletions(-)

Index: b/drivers/media/dvb/firewire/firedtv-avc.c
===
--- a/drivers/media/dvb/firewire/firedtv-avc.c
+++ b/drivers/media/dvb/firewire/firedtv-avc.c
@@ -24,6 +24,8 @@
 #include 
 #include 
 
+#include 
+
 #include "firedtv.h"
 
 #define FCP_COMMAND_REGISTER   0xfb00ULL
@@ -368,10 +370,30 @@ static int avc_tuner_tuneqpsk(struct fir
c->operand[12] = 0;
 
if (fdtv->type == FIREDTV_DVB_S2) {
-   c->operand[13] = 0x1;
-   c->operand[14] = 0xff;
-   c->operand[15] = 0xff;
-
+   if (fdtv->fe.dtv_property_cache.delivery_system == SYS_DVBS2) {
+   switch (fdtv->fe.dtv_property_cache.modulation) {
+   case QAM_16:c->operand[13] = 0x1; break;
+   case QPSK:  c->operand[13] = 0x2; break;
+   case PSK_8: c->operand[13] = 0x3; break;
+   default:c->operand[13] = 0x2; break;
+   }
+   switch (fdtv->fe.dtv_property_cache.rolloff) {
+   case ROLLOFF_AUTO:  c->operand[14] = 0x2; break;
+   case ROLLOFF_35:c->operand[14] = 0x2; break;
+   case ROLLOFF_20:c->operand[14] = 0x0; break;
+   case ROLLOFF_25:c->operand[14] = 0x1; break;
+   /* case ROLLOFF_NONE:   c->operand[14] = 0xff; break; */
+   }
+   switch (fdtv->fe.dtv_property_cache.pilot) {
+   case PILOT_AUTO:c->operand[15] = 0x0; break;
+   case PILOT_OFF: c->operand[15] = 0x0; break;
+   case PILOT_ON:  c->operand[15] = 0x1; break;
+   }
+   } else {
+   c->operand[13] = 0x1;  /* auto modulation */
+   c->operand[14] = 0xff; /* disable rolloff */
+   c->operand[15] = 0xff; /* disable pilot */
+   }
return 16;
} else {
return 13;
Index: b/drivers/media/dvb/firewire/firedtv-fe.c
===
--- a/drivers/media/dvb/firewire/firedtv-fe.c
+++ b/drivers/media/dvb/firewire/firedtv-fe.c
@@ -155,6 +155,16 @@ static int fdtv_get_frontend(struct dvb_
return -EOPNOTSUPP;
 }
 
+static int fdtv_get_property(struct dvb_frontend *fe, struct dtv_property *tvp)
+{
+   return 0;
+}
+
+static int fdtv_set_property(struct dvb_frontend *fe, struct dtv_property *tvp)
+{
+   return 0;
+}
+
 void fdtv_frontend_init(struct firedtv *fdtv)
 {
struct dvb_frontend_ops *ops = &fdtv->fe.ops;
@@ -166,6 +176,9 @@ void fdtv_frontend_init(struct firedtv *
ops->set_frontend   = fdtv_set_frontend;
ops->get_frontend   = fdtv_get_frontend;
 
+   ops->get_property   = fdtv_get_property;
+   ops->set_property   = fdtv_set_property;
+
ops->read_status= fdtv_read_status;
ops->read_ber   = fdtv_read_ber;
ops->read_signal_strength   = fdtv_read_signal_strength;
@@ -179,7 +192,6 @@ void fdtv_frontend_init(struct firedtv *
 
switch (fdtv->type) {
case FIREDTV_DVB_S:
-   case FIREDTV_DVB_S2:
fi->type= FE_QPSK;
 
fi->frequency_min   = 95;
@@ -188,7 +200,7 @@ void fdtv_frontend_init(struct firedtv *
fi->symbol_rate_min = 100;
fi->symbol_rate_max = 4000;
 
-   fi->caps= FE_CAN_INVERSION_AUTO |
+   fi->caps= FE_CAN_INVERSION_AUTO |
  FE_CAN_FEC_1_2|
  FE_CAN_FEC_2_3|
  FE_CAN_FEC_3_4|
@@ -198,6 +210,26 @@ void fdtv_f

Re: [linux-dvb] Asus MyCinema P7131 Dual support

2010-10-04 Thread Giorgio
On 04/10/2010 01:48, Dejan Rodiger wrote:
> Hi Hermann,
> 
> I finally found the time to wire analog antena and I checked it with
> my TV if it is working correctly.
> Since I am using local cable provider which didn't upgrade their
> system in 10 years and they are still broadcast in analog, I had a
> problem off finding channel list, so in the end I tried tvtime-scanner
> and it found about 58 channels. But, out of this 58 most of them were
> not good (no signal). I was able to finetune few programs. My main
> programs (local Croatian TV stations) were not found. Maybe I need to
> finetune every found station.
> 
> I also tried zapping which crashed my X.
> 
> I am also lost in setting mythtv. I set analog tunner on /dev/video0.
> But I think I have a problem of setting the channel list for my local
> cable provider. Is it possible to scan whole list or something. If you
> have any reading recommendation to set this, I would be helpfull

Dejan,

I have the exact same card:

# sudo lpci -vnn
02:07.0 Multimedia controller [0480]: Philips Semiconductors 
SAA7131/SAA7133/SAA7135 Video Broadcast Decoder [1131:7133] (rev d1)
Subsystem: ASUSTeK Computer Inc. Device [1043:4876]
Flags: bus master, medium devsel, latency 64, IRQ 20
Memory at fbfff800 (32-bit, non-prefetchable) [size=2K]
Capabilities: [40] Power Management version 2
Kernel driver in use: saa7134
Kernel modules: saa7134

and I can confirm you that it's autodetected and works very well (both the
analog and the digital part) on 2.6.35.
2.6.32 has a problem with dvb-t reception, but I have reported it and hopefully
it will be fixed soon upstream: 
http://article.gmane.org/gmane.linux.drivers.video-input-infrastructure/23604

If you want to test the analog part, install MPlayer and run the following 
command:

mplayer tv:// -tv 
driver=v4l2:device=/dev/video0:norm=PAL:input=0:chanlist=europe-west

and then press 'k' or 'h' to select previous/next channel (after you switch
channel, wait some seconds until the card tunes, for some channels I need
5 seconds here, for others about 1 second). Now, with some patience, explore
all the channels and you should be able to find your local tv stations.
Also, you might need to adjust mplayer options, like norm= or chanlist=
(you could try chanlist=europe-east).

The command line above doesn't grab audio though, so you won't hear a thing.
If you want to hear the audio you need to make sure saa7134-alsa is loaded
and run something like:

mplayer tv:// -tv 
driver=v4l2:device=/dev/video0:norm=PAL:input=0:alsa:adevice=hw.1,0:amode=1:immediatemode=0:chanlist=europe-west

(make sure you select the right alsa device in adevice=)

The wiki has a good page about MPlayer:

http://www.linuxtv.org/wiki/index.php/MPlayer

and of course the MPlayer man page explain all the options too.

These pages are also useful (but some things might be a bit outdated):

http://www.linuxtv.org/wiki/index.php/ASUS_My_Cinema-P7131_Hybrid
http://www.linuxtv.org/wiki/index.php/Saa7134-alsa

I hope this can help you and others reading this ML.

Regards,
Giorgio Vazzana

> Thanks
> --
> Dejan Rodiger
> S: callto://drodiger
> 
> 
> 
> On Thu, Sep 23, 2010 at 00:46,   wrote:
>>
>>
>> Hi Dejan,
>>
>> - Original Nachricht 
>> Von: Dejan Rodiger 
>> An:  hermann pitton 
>> Datum:   22.09.2010 13:20
>> Betreff: Re: [linux-dvb] Asus MyCinema P7131 Dual support
>>
>>> Hi Herman,
>>>
>>> here is dmesg output without forcing card=78.
>>> As I see it uses card=112, autodetected
>>>
>>> [   16.043345] IR RC6 protocol handler initialized
>>> [   16.173473] IR JVC protocol handler initialized
>>> [   16.236641] IR Sony protocol handler initialized
>>> [   16.433187] lirc_dev: IR Remote Control driver registered, major 250
>>> [   16.572705] IR LIRC bridge handler initialized
>>> [   16.894983] Linux video capture interface: v2.00
>>> [   16.957585] saa7130/34: v4l2 driver version 0.2.16 loaded
>>> [   16.958300] ACPI: PCI Interrupt Link [APC3] enabled at IRQ 18
>>> [   16.958306]   alloc irq_desc for 18 on node 0
>>> [   16.958309]   alloc kstat_irqs on node 0
>>> [   16.958320] saa7134 :01:06.0: PCI INT A -> Link[APC3] -> GSI 18
>>> (level, low) -> IRQ 18
>>> [   16.958327] saa7133[0]: found at :01:06.0, rev: 209, irq: 18,
>>> latency: 32, mmio: 0xfdeff000
>>> [   16.958334] saa7133[0]: subsystem: 1043:4876, board: ASUSTeK P7131
>>> Hybrid [card=112,autodetected]
>>> [   16.958378] saa7133[0]: board init: gpio is 0
>>> [   17.010075] Registered IR keymap rc-asus-pc39
>>> [   17.010197] input: saa7134 IR (ASUSTeK P7131 Hybri as
>>> /devices/pci:00/:00:09.0/:01:06.0/rc/rc0/input4
>>> [   17.010268] rc0: saa7134 IR (ASUSTeK P7131 Hybri as
>>> /devices/pci:00/:00:09.0/:01:06.0/rc/rc0
>>> [   17.190477] saa7133[0]: i2c eeprom 00: 43 10 76 48 54 20 1c 00 43
>>> 43 a9 1c 55 d2 b2 92
>>> [   17.190490] saa7133[0]: i2c eeprom 10: ff ff ff 0f ff 20 ff ff ff
>>> ff ff ff ff ff f

Re: [PATCH v3] SoC Camera: add driver for OMAP1 camera interface

2010-10-04 Thread Janusz Krzysztofik
Sunday 03 October 2010 04:42:53 Guennadi Liakhovetski napisał(a):
> On Sat, 2 Oct 2010, Janusz Krzysztofik wrote:
> > Saturday 02 October 2010 08:07:28 Guennadi Liakhovetski napisał(a):
> > > Same with this one - let's take it as is and address a couple of
> > > clean-ups later.
> >
> > Guennadi,
> > Thanks for taking them both.
> >
> > BTW, what are your intentions about the last patch from my series still
> > left not commented, "SoC Camera: add support for g_parm / s_parm
> > operations", http://www.spinics.net/lists/linux-media/msg22887.html ?
>
> Yes, taking that one too, thanks. I see it right, that I have to apply 3
> of your patches: omap1 camera driver, ov6650 and default .[gs]_fmt for
> soc_camera, the rest will go via the OMAP / ARM tree, right?

Right.
Janusz
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] lirc: Make struct file_operations pointer const

2010-10-04 Thread Jarod Wilson
On Thu, Sep 30, 2010 at 09:55:07PM +0200, Geert Uytterhoeven wrote:
> struct file_operations was made const in the drivers, but not in struct
> lirc_driver:
> 
> drivers/staging/lirc/lirc_it87.c:365: warning: initialization discards 
> qualifiers from pointer target type
> drivers/staging/lirc/lirc_parallel.c:571: warning: initialization discards 
> qualifiers from pointer target type
> drivers/staging/lirc/lirc_serial.c:1073: warning: initialization discards 
> qualifiers from pointer target type
> drivers/staging/lirc/lirc_sir.c:482: warning: initialization discards 
> qualifiers from pointer target type
> drivers/staging/lirc/lirc_zilog.c:1284: warning: assignment discards 
> qualifiers from pointer target type
> 
> Signed-off-by: Geert Uytterhoeven 

Whoops, yeah, obvious fix.

Acked-by: Jarod Wilson 


-- 
Jarod Wilson
ja...@redhat.com

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html