Re: [PATCH 2/2] uvcvideo: Allow userptr IO mode.
Hi Laurent, FYI Marek has already merged 1/2 into his vb2-fixes branch. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Possible regression in 3.2 kernel with PCTV Nanostick T2 (em28xx, cxd2820r and tda18271)
On 10 January 2012 13:28, Jim Darby uberscuba...@gmail.com wrote: I've been using a PCTV Nanostick T2 USB DVB-T2 receiver (one of the few that supports DVB-T2) for over six months with a 3.0 kernel with no problems. Seeing the 3.2 kernel I thought I'd upgrade and now I seem to have hit a problem. This is running on a 32-bit system. Everything works fine if I boot with the 3.0.0 kernel. I have this tuner in Arch x64, with 2 Dual DVB-T and a dual DVB-S2 (Tevii S660), kernel 3.2 rc7 working perfect. I do have it in a usb3 port due to an issue with the usb drivers for the motherboard I have, I found that there is bugs in the drivers for usb2 chipset so the work around is I use usb3. I have had this tuner work in 3.0 and 3.1 kernel as well, no issues -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: cx23885[0]: videobuf_dvb_register_frontend failed (errno = -12)
I have the same Problem. Did you find any solution? -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: cx23885[0]: videobuf_dvb_register_frontend failed (errno = -12)
On Thu, Jan 12, 2012 at 9:42 AM, Markus Golser elmar...@googlemail.com wrote: I have the same Problem. Did you find any solution? Assuming you compiled your kernel from source, enable CONFIG_DVB_NET in your .config. Devin -- Devin J. Heitmueller - Kernel Labs http://www.kernellabs.com -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PULL FOR v3.3] Add decoder API to V4L2
Hi Mauro, Here is my pull request for the decoder API. The code is the same as the RFCv3 patch series: http://www.mail-archive.com/linux-media@vger.kernel.org/msg40516.html except for being rebased to the latest for_v3.3 branch. There is no urgency, so if you prefer then this can also be applied to 3.4. Regards, Hans The following changes since commit 240ab508aa9fb7a294b0ecb563b19ead000b2463: [media] [PATCH] don't reset the delivery system on DTV_CLEAR (2012-01-10 23:44:07 -0200) are available in the git repository at: git://linuxtv.org/hverkuil/media_tree.git decoder5 Hans Verkuil (8): v4l2: add VIDIOC_(TRY_)DECODER_CMD. v4l spec: document VIDIOC_(TRY_)DECODER_CMD. ivtv: implement new decoder command ioctls. v4l2-ctrls: add new controls for MPEG decoder devices. Document decoder controls. ivtv: implement new decoder controls. cx18/ddbridge: remove unused headers. ivtv: add IVTV_IOC_PASSTHROUGH_MODE. Documentation/DocBook/media/v4l/controls.xml | 59 + Documentation/DocBook/media/v4l/v4l2.xml |1 + .../DocBook/media/v4l/vidioc-decoder-cmd.xml | 256 .../DocBook/media/v4l/vidioc-encoder-cmd.xml |9 +- drivers/media/dvb/ddbridge/ddbridge.h |2 - drivers/media/video/cx18/cx18-driver.h |2 - drivers/media/video/ivtv/ivtv-controls.c | 62 + drivers/media/video/ivtv/ivtv-controls.h |2 + drivers/media/video/ivtv/ivtv-driver.c | 37 +++- drivers/media/video/ivtv/ivtv-driver.h | 12 +- drivers/media/video/ivtv/ivtv-fileops.c|2 +- drivers/media/video/ivtv/ivtv-ioctl.c | 181 +++--- drivers/media/video/ivtv/ivtv-streams.c|9 +- drivers/media/video/v4l2-compat-ioctl32.c |2 + drivers/media/video/v4l2-ctrls.c | 23 ++ drivers/media/video/v4l2-ioctl.c | 28 +++ include/linux/ivtv.h |6 +- include/linux/videodev2.h | 66 + include/media/v4l2-ioctl.h |4 + 19 files changed, 652 insertions(+), 111 deletions(-) create mode 100644 Documentation/DocBook/media/v4l/vidioc-decoder-cmd.xml -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Possible regression in 3.2 kernel with PCTV Nanostick T2 (em28xx, cxd2820r and tda18271)
Il 11/01/2012 20:19, Jim Darby ha scritto: On 11/01/12 01:05, Antti Palosaari wrote: [snip] Also latest LinuxTV.org devel could be interesting to see. There is one patch that changes em28xx driver endpoint configuration. But as that patch is going for 3.3 it should not be cause of issue, but I wonder if it could fix... Use media_build.git if possible. Well, I built the kernel and installed it. Sadly I get entries of the form: dvb_frontend_ioctl_legacy: doesn't know how to handle a DVBv3 call to delivery system 0 which isn't what I was looking for. I guess there's a new API? It would appear this is from the set frontend call. This is most annoying as I'd like to try out the newest code. Is there a v3 to v3 transition document anywhere? Best regards, Jim. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Hi Jim, you spotted a regression in the latest media_build release from 11/01/2012. I had the same problem here: dvb_frontend_ioctl_legacy: doesn't know how to handle a DVBv3 call to delivery system 0 with 3 totally different sticks (em28xx, dvb-usb, as102). Everything was working fine with media_build drivers from 08/01/2011, so the problem originates from a patch committed in the last few days. In fact, I reverted this patch: http://patchwork.linuxtv.org/patch/9443/ and Kaffeine started working again with all my DVB-T sticks. Best regards, Gianluca -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Possible regression in 3.2 kernel with PCTV Nanostick T2 (em28xx, cxd2820r and tda18271)
On 12/01/12 16:22, Gianluca Gennari wrote: Hi Jim, you spotted a regression in the latest media_build release from 11/01/2012. I had the same problem here: dvb_frontend_ioctl_legacy: doesn't know how to handle a DVBv3 call to delivery system 0 with 3 totally different sticks (em28xx, dvb-usb, as102). Everything was working fine with media_build drivers from 08/01/2011, so the problem originates from a patch committed in the last few days. In fact, I reverted this patch: http://patchwork.linuxtv.org/patch/9443/ and Kaffeine started working again with all my DVB-T sticks. Best regards, Gianluca I think that we need to be careful about two different problems here. The first is the regression that I originally reported. In this case the device stops sending data after a variable period of time and we get to miss the end of the programme that we're watching. The second, which is the one that Gianluca has spotted as well, is that there seems to be some form of API change in the latest linux-media which is causing kaffeine to stop working. I'm still unsure about the first. It might be a 32/64-bit problem (based on evidence from Simon Jones), it might be flaky hardware or it might be a real problem. I'm planning to build the 3.2.0 kernel (minus the linux-media patches) for 64-bit on different hardware and see what happens. As for the second I suspect it might be a kaffeine problem. It might just need recompiling with the new headers or it might need some work on it. I'll investigate that after I've solved the first regression. Pedant mode: the kaffeine problem isn't really a regression as such. It's more of a API versioning issue. More on this later. Hope this helps, Jim. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Possible regression in 3.2 kernel with PCTV Nanostick T2 (em28xx, cxd2820r and tda18271)
I'm still unsure about the first. It might be a 32/64-bit problem (based on evidence from Simon Jones), it might be flaky hardware or it might be a real problem. I'm planning to build the 3.2.0 kernel (minus the linux-media patches) for 64-bit on different hardware and see what happens. As for the second I suspect it might be a kaffeine problem. It might just need recompiling with the new headers or it might need some work on it. I'll investigate that after I've solved the first regression. Might have been a bit prem on the working perfect cam home to the wife saying the system has crashed... looked in the logs and this is reported: Jan 12 05:27:59 localhost kernel: [308040.577546] xhci_hcd :02:00.0: WARN: buffer overrun event on endpoint --- This error has occured since I built the system at christmas, have been ignoring it because it didn't seem to cause any issues. Jan 12 05:33:03 localhost kernel: [308344.766507] xhci_hcd :02:00.0: WARN: babble error on endpoint Jan 12 05:33:03 localhost kernel: [308344.766541] hub 1-0:1.0: port 1 disabled by hub (EMI?), re-enabling... Jan 12 05:33:03 localhost kernel: [308344.766546] usb 1-1: USB disconnect, device number 2 Jan 12 05:33:03 localhost kernel: [308344.766602] em28xx #0: disconnecting em28xx #0 video Jan 12 05:33:04 localhost kernel: [308344.805942] cxd2820r: i2c rd failed ret:-19 reg:10 len:1 Jan 12 05:33:04 localhost kernel: [308344.849191] cxd2820r: i2c rd failed ret:-19 reg:26 len:2 Jan 12 05:33:04 localhost kernel: [308344.859414] em28xx #0: V4L2 device video0 deregistered Jan 12 05:33:04 localhost kernel: [308344.889276] cxd2820r: i2c rd failed ret:-19 reg:28 len:2 Jan 12 05:36:00 localhost kernel: [308521.689250] INFO: task khubd:140 blocked for more than 120 seconds. Jan 12 05:36:00 localhost kernel: [308521.689256] echo 0 /proc/sys/kernel/hung_task_timeout_secs disables this message. Jan 12 05:36:00 localhost kernel: [308521.689262] khubd D 000105821dfa 0 140 2 0x Jan 12 05:36:00 localhost kernel: [308521.689272] 8804227e9b80 0046 8804 435d27dc Jan 12 05:36:00 localhost kernel: [308521.689282] 880423637200 8804227e9fd8 8804227e9fd8 8804227e9fd8 Jan 12 05:36:00 localhost kernel: [308521.689290] 8804244cf200 880423637200 8804227e9b30 814156f8 Jan 12 05:36:00 localhost kernel: [308521.689299] Call Trace: Jan 12 05:36:00 localhost kernel: [308521.689311] [814156f8] ? wait_for_common+0x128/0x160 Jan 12 05:36:00 localhost kernel: [308521.689323] [8105cf70] ? try_to_wake_up+0x290/0x290 Jan 12 05:36:00 localhost kernel: [308521.689330] [8141574d] ? wait_for_completion+0x1d/0x20 Jan 12 05:36:00 localhost kernel: [308521.689337] [8141640f] schedule+0x3f/0x60 Jan 12 05:36:00 localhost kernel: [308521.689366] [a028f2c5] dvb_unregister_frontend+0xc5/0x110 [dvb_core] Jan 12 05:36:00 localhost kernel: [308521.689376] [810868f0] ? abort_exclusive_wait+0xb0/0xb0 Jan 12 05:36:00 localhost kernel: [308521.689386] [a01fda22] em28xx_dvb_fini+0xf2/0x150 [em28xx_dvb] Jan 12 05:36:00 localhost kernel: [308521.689400] [a037606e] em28xx_close_extension+0x3e/0xa0 [em28xx] Jan 12 05:36:00 localhost kernel: [308521.689410] [a0373ef5] em28xx_usb_disconnect+0xe5/0x190 [em28xx] Jan 12 05:36:00 localhost kernel: [308521.689436] [a0011242] usb_unbind_interface+0x52/0x180 [usbcore] Jan 12 05:36:00 localhost kernel: [308521.689448] [8130071c] __device_release_driver+0x7c/0xe0 Jan 12 05:36:00 localhost kernel: [308521.689456] [813007ac] device_release_driver+0x2c/0x40 Jan 12 05:36:00 localhost kernel: [308521.689463] [81300258] bus_remove_device+0x78/0xb0 Jan 12 05:36:00 localhost kernel: [308521.689475] [812fdb5d] device_del+0x12d/0x1b0 Jan 12 05:36:00 localhost kernel: [308521.689482] [a000ef9f] usb_disable_device+0xaf/0x1d0 [usbcore] Jan 12 05:36:00 localhost kernel: [308521.689489] [a00073a8] usb_disconnect+0x98/0x130 [usbcore] Jan 12 05:36:00 localhost kernel: [308521.689497] [a00092fc] hub_thread+0xa4c/0x12d0 [usbcore] Jan 12 05:36:00 localhost kernel: [308521.689500] [810868f0] ? abort_exclusive_wait+0xb0/0xb0 Jan 12 05:36:00 localhost kernel: [308521.689507] [a00088b0] ? usb_remote_wakeup+0x40/0x40 [usbcore] Jan 12 05:36:00 localhost kernel: [308521.689510] [81085fac] kthread+0x8c/0xa0 Jan 12 05:36:00 localhost kernel: [308521.689513] [8141bd74] kernel_thread_helper+0x4/0x10 Jan 12 05:36:00 localhost kernel: [308521.689516] [81085f20] ? kthread_worker_fn+0x190/0x190 Jan 12 05:36:00 localhost kernel: [308521.689519] [8141bd70] ? gs_change+0x13/0x13 It goes on longer than this, but think it's the same repeated information and call stack trace etc. But this could just be related to the usb drivers being a bit unstable on this motherboard. -- To unsubscribe from
Re: Possible regression in 3.2 kernel with PCTV Nanostick T2 (em28xx, cxd2820r and tda18271)
Il 12/01/2012 17:35, Jim Darby ha scritto: On 12/01/12 16:22, Gianluca Gennari wrote: Hi Jim, you spotted a regression in the latest media_build release from 11/01/2012. I had the same problem here: dvb_frontend_ioctl_legacy: doesn't know how to handle a DVBv3 call to delivery system 0 with 3 totally different sticks (em28xx, dvb-usb, as102). Everything was working fine with media_build drivers from 08/01/2011, so the problem originates from a patch committed in the last few days. In fact, I reverted this patch: http://patchwork.linuxtv.org/patch/9443/ and Kaffeine started working again with all my DVB-T sticks. Best regards, Gianluca I think that we need to be careful about two different problems here. The first is the regression that I originally reported. In this case the device stops sending data after a variable period of time and we get to miss the end of the programme that we're watching. The second, which is the one that Gianluca has spotted as well, is that there seems to be some form of API change in the latest linux-media which is causing kaffeine to stop working. I'm still unsure about the first. It might be a 32/64-bit problem (based on evidence from Simon Jones), it might be flaky hardware or it might be a real problem. I'm planning to build the 3.2.0 kernel (minus the linux-media patches) for 64-bit on different hardware and see what happens. Yes, of course reverting that patch is not going to affect your first issue. As for the second I suspect it might be a kaffeine problem. It might just need recompiling with the new headers or it might need some work on it. I'll investigate that after I've solved the first regression. Pedant mode: the kaffeine problem isn't really a regression as such. It's more of a API versioning issue. More on this later. Hope this helps, Jim. I don't think the intention of that patch was to broke support for DVBv3 applications when using a tuner with a single delivery system. That would be quite a big API change. Best regards, Gianluca -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Problem with WinTV HVR-930C
Hello, i am running Fedora 16 64bit and have no luck to get working the WinTV HVR-930C. Invoked command lsusb told me: Bus 001 Device 002: ID 2040:1605 Hauppauge. Installed from update-testing-repository is the most recent kernel version kernel-3.1.8-2.fc16.x86_64. Loaded the em28xx by hand and shows up this in dmesg: [ 482.220534] IR NEC protocol handler initialized [ 482.228352] IR RC5(x) protocol handler initialized [ 482.229710] Linux media interface: v0.10 [ 482.235907] Linux video capture interface: v2.00 [ 482.240601] IR RC6 protocol handler initialized [ 482.257921] IR JVC protocol handler initialized [ 482.263175] IR Sony protocol handler initialized [ 482.268460] IR MCE Keyboard/mouse protocol handler initialized [ 482.273807] usbcore: registered new interface driver em28xx [ 482.273816] em28xx driver loaded [ 482.275215] lirc_dev: IR Remote Control driver registered, major 249 [ 482.285327] IR LIRC bridge handler initialized I am in doubt that the newest development is included in this kernel release. Or maybe i have do something wrong. Your help is much appreciated. Thanks Daniel -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
cron job: media_tree daily build: ERRORS
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Thu Jan 12 19:00:25 CET 2012 git hash:240ab508aa9fb7a294b0ecb563b19ead000b2463 gcc version: i686-linux-gcc (GCC) 4.6.1 host hardware:x86_64 host os: 3.1-2.slh.1-amd64 linux-git-arm-eabi-enoxys: ERRORS linux-git-arm-eabi-omap: ERRORS linux-git-armv5-ixp: WARNINGS linux-git-i686: WARNINGS linux-git-m32r: OK linux-git-mips: WARNINGS linux-git-powerpc64: OK linux-git-x86_64: WARNINGS linux-2.6.31.12-i686: ERRORS linux-2.6.32.6-i686: WARNINGS linux-2.6.33-i686: WARNINGS linux-2.6.34-i686: WARNINGS linux-2.6.35.3-i686: WARNINGS linux-2.6.36-i686: WARNINGS linux-2.6.37-i686: WARNINGS linux-2.6.38.2-i686: WARNINGS linux-2.6.39.1-i686: WARNINGS linux-3.0-i686: WARNINGS linux-3.1-i686: WARNINGS linux-3.2-rc1-i686: WARNINGS linux-2.6.31.12-x86_64: ERRORS linux-2.6.32.6-x86_64: WARNINGS linux-2.6.33-x86_64: WARNINGS linux-2.6.34-x86_64: WARNINGS linux-2.6.35.3-x86_64: WARNINGS linux-2.6.36-x86_64: WARNINGS linux-2.6.37-x86_64: WARNINGS linux-2.6.38.2-x86_64: WARNINGS linux-2.6.39.1-x86_64: WARNINGS linux-3.0-x86_64: WARNINGS linux-3.1-x86_64: WARNINGS linux-3.2-rc1-x86_64: WARNINGS spec-git: WARNINGS sparse: ERRORS Detailed results are available here: http://www.xs4all.nl/~hverkuil/logs/Thursday.log Full logs are available here: http://www.xs4all.nl/~hverkuil/logs/Thursday.tar.bz2 The V4L-DVB specification from this daily build is here: http://www.xs4all.nl/~hverkuil/spec/media.html -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 4/4] drivers/media/video/s5p-mfc/s5p_mfc.c: adjust double test
From: Julia Lawall julia.law...@lip6.fr Rewrite a duplicated test to test the correct value The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @@ expression E; @@ ( * E || ... || E | * E ... E ) // /smpl Signed-off-by: Julia Lawall julia.law...@lip6.fr --- drivers/media/video/s5p-mfc/s5p_mfc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/video/s5p-mfc/s5p_mfc.c b/drivers/media/video/s5p-mfc/s5p_mfc.c index 8be8b54..53126f2 100644 --- a/drivers/media/video/s5p-mfc/s5p_mfc.c +++ b/drivers/media/video/s5p-mfc/s5p_mfc.c @@ -475,7 +475,7 @@ static void s5p_mfc_handle_seq_done(struct s5p_mfc_ctx *ctx, ctx-mv_size = 0; } ctx-dpb_count = s5p_mfc_get_dpb_count(); - if (ctx-img_width == 0 || ctx-img_width == 0) + if (ctx-img_width == 0 || ctx-img_height == 0) ctx-state = MFCINST_ERROR; else ctx-state = MFCINST_HEAD_PARSED; -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 4/5] drivers/media/video/s5p-mfc/s5p_mfc.c: adjust double test
From: Julia Lawall julia.law...@lip6.fr Rewrite a duplicated test to test the correct value The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @@ expression E; @@ ( * E || ... || E | * E ... E ) // /smpl Signed-off-by: Julia Lawall julia.law...@lip6.fr --- There is an img_height field, so it is my guess that that should be tested instead of testing the img_width field again. drivers/media/video/s5p-mfc/s5p_mfc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/video/s5p-mfc/s5p_mfc.c b/drivers/media/video/s5p-mfc/s5p_mfc.c index 8be8b54..53126f2 100644 --- a/drivers/media/video/s5p-mfc/s5p_mfc.c +++ b/drivers/media/video/s5p-mfc/s5p_mfc.c @@ -475,7 +475,7 @@ static void s5p_mfc_handle_seq_done(struct s5p_mfc_ctx *ctx, ctx-mv_size = 0; } ctx-dpb_count = s5p_mfc_get_dpb_count(); - if (ctx-img_width == 0 || ctx-img_width == 0) + if (ctx-img_width == 0 || ctx-img_height == 0) ctx-state = MFCINST_ERROR; else ctx-state = MFCINST_HEAD_PARSED; -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v2 2/5] drivers/media/video/s5p-fimc/fimc-capture.c: adjust double test
From: Julia Lawall julia.law...@lip6.fr
Rewrite a duplicated test to test the correct value
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// smpl
@@
expression E;
@@
(
* E
|| ... || E
|
* E
... E
)
// /smpl
Signed-off-by: Julia Lawall julia.law...@lip6.fr
---
There is a height field, so it is my guess that that should be tested
instead of testing the width field again.
drivers/media/video/s5p-fimc/fimc-capture.c |7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/media/video/s5p-fimc/fimc-capture.c
b/drivers/media/video/s5p-fimc/fimc-capture.c
index 2cc3b91..13dd598 100644
--- a/drivers/media/video/s5p-fimc/fimc-capture.c
+++ b/drivers/media/video/s5p-fimc/fimc-capture.c
@@ -689,7 +689,7 @@ static int fimc_pipeline_try_format(struct fimc_ctx *ctx,
mf-code = 0;
continue;
}
- if (mf-width != tfmt-width || mf-width != tfmt-width) {
+ if (mf-width != tfmt-width || mf-height != tfmt-height) {
u32 fcc = ffmt-fourcc;
tfmt-width = mf-width;
tfmt-height = mf-height;
@@ -698,7 +698,8 @@ static int fimc_pipeline_try_format(struct fimc_ctx *ctx,
NULL, fcc, FIMC_SD_PAD_SOURCE);
if (ffmt ffmt-mbus_code)
mf-code = ffmt-mbus_code;
- if (mf-width != tfmt-width || mf-width !=
tfmt-width)
+ if (mf-width != tfmt-width ||
+ mf-height != tfmt-height)
continue;
tfmt-code = mf-code;
}
@@ -706,7 +707,7 @@ static int fimc_pipeline_try_format(struct fimc_ctx *ctx,
ret = v4l2_subdev_call(csis, pad, set_fmt, NULL, sfmt);
if (mf-code == tfmt-code
- mf-width == tfmt-width mf-width == tfmt-width)
+ mf-width == tfmt-width mf-height == tfmt-height)
break;
}
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/2] uvcvideo: Allow userptr IO mode.
Hi Javier, On Thursday 12 January 2012 13:16:19 javier Martin wrote: Hi Laurent, FYI Marek has already merged 1/2 into his vb2-fixes branch. I've queued 2/2 to my tree and will push it to v3.4. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 4/4] drivers/media/video/s5p-mfc/s5p_mfc.c: adjust double test
All patches. Acked-by: Kyungmin Park kyungmin.p...@samsung.com To Marek, Please collect all patches and send git request pull. Thank you, Kyungmin Park On 1/13/12, Julia Lawall julia.law...@lip6.fr wrote: From: Julia Lawall julia.law...@lip6.fr Rewrite a duplicated test to test the correct value The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @@ expression E; @@ ( * E || ... || E | * E ... E ) // /smpl Signed-off-by: Julia Lawall julia.law...@lip6.fr --- drivers/media/video/s5p-mfc/s5p_mfc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/video/s5p-mfc/s5p_mfc.c b/drivers/media/video/s5p-mfc/s5p_mfc.c index 8be8b54..53126f2 100644 --- a/drivers/media/video/s5p-mfc/s5p_mfc.c +++ b/drivers/media/video/s5p-mfc/s5p_mfc.c @@ -475,7 +475,7 @@ static void s5p_mfc_handle_seq_done(struct s5p_mfc_ctx *ctx, ctx-mv_size = 0; } ctx-dpb_count = s5p_mfc_get_dpb_count(); - if (ctx-img_width == 0 || ctx-img_width == 0) + if (ctx-img_width == 0 || ctx-img_height == 0) ctx-state = MFCINST_ERROR; else ctx-state = MFCINST_HEAD_PARSED; ___ linux-arm-kernel mailing list linux-arm-ker...@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[patch] [media] mb86a20s: fix off by one checks
Clearly = was intended here instead of . Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/media/dvb/frontends/mb86a20s.c b/drivers/media/dvb/frontends/mb86a20s.c index 38778a8..4e6f836 100644 --- a/drivers/media/dvb/frontends/mb86a20s.c +++ b/drivers/media/dvb/frontends/mb86a20s.c @@ -535,7 +535,7 @@ static int mb86a20s_get_modulation(struct mb86a20s_state *state, [2] = 0x8e, /* Layer C */ }; - if (layer ARRAY_SIZE(reg)) + if (layer = ARRAY_SIZE(reg)) return -EINVAL; rc = mb86a20s_writereg(state, 0x6d, reg[layer]); if (rc 0) @@ -568,7 +568,7 @@ static int mb86a20s_get_fec(struct mb86a20s_state *state, [2] = 0x8f, /* Layer C */ }; - if (layer ARRAY_SIZE(reg)) + if (layer = ARRAY_SIZE(reg)) return -EINVAL; rc = mb86a20s_writereg(state, 0x6d, reg[layer]); if (rc 0) @@ -603,7 +603,7 @@ static int mb86a20s_get_interleaving(struct mb86a20s_state *state, [2] = 0x90, /* Layer C */ }; - if (layer ARRAY_SIZE(reg)) + if (layer = ARRAY_SIZE(reg)) return -EINVAL; rc = mb86a20s_writereg(state, 0x6d, reg[layer]); if (rc 0) @@ -627,7 +627,7 @@ static int mb86a20s_get_segment_count(struct mb86a20s_state *state, [2] = 0x91, /* Layer C */ }; - if (layer ARRAY_SIZE(reg)) + if (layer = ARRAY_SIZE(reg)) return -EINVAL; rc = mb86a20s_writereg(state, 0x6d, reg[layer]); if (rc 0) -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[patch] [media] cx231xx: dereferencing NULL after allocation failure
dev is NULL here so we should use nr instead of dev-devno.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/media/video/cx231xx/cx231xx-cards.c
b/drivers/media/video/cx231xx/cx231xx-cards.c
index 919ed77..875a7ce 100644
--- a/drivers/media/video/cx231xx/cx231xx-cards.c
+++ b/drivers/media/video/cx231xx/cx231xx-cards.c
@@ -1052,7 +1052,7 @@ static int cx231xx_usb_probe(struct usb_interface
*interface,
dev = kzalloc(sizeof(*dev), GFP_KERNEL);
if (dev == NULL) {
cx231xx_err(DRIVER_NAME : out of memory!\n);
- clear_bit(dev-devno, cx231xx_devused);
+ clear_bit(nr, cx231xx_devused);
return -ENOMEM;
}
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] [media] s5p-fimc: Fix incorrect control ID assignment
Acked-by: Kyungmin Park kyungmin.p...@samsung.com On 1/10/12, Sachin Kamat sachin.ka...@linaro.org wrote: This patch fixes the mismatch between control IDs (CID) and controls for hflip, vflip and rotate. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/media/video/s5p-fimc/fimc-core.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/video/s5p-fimc/fimc-core.c b/drivers/media/video/s5p-fimc/fimc-core.c index 07c6254..170f791 100644 --- a/drivers/media/video/s5p-fimc/fimc-core.c +++ b/drivers/media/video/s5p-fimc/fimc-core.c @@ -811,11 +811,11 @@ int fimc_ctrls_create(struct fimc_ctx *ctx) v4l2_ctrl_handler_init(ctx-ctrl_handler, 3); ctx-ctrl_rotate = v4l2_ctrl_new_std(ctx-ctrl_handler, fimc_ctrl_ops, - V4L2_CID_HFLIP, 0, 1, 1, 0); + V4L2_CID_ROTATE, 0, 270, 90, 0); ctx-ctrl_hflip = v4l2_ctrl_new_std(ctx-ctrl_handler, fimc_ctrl_ops, - V4L2_CID_VFLIP, 0, 1, 1, 0); + V4L2_CID_HFLIP, 0, 1, 1, 0); ctx-ctrl_vflip = v4l2_ctrl_new_std(ctx-ctrl_handler, fimc_ctrl_ops, - V4L2_CID_ROTATE, 0, 270, 90, 0); + V4L2_CID_VFLIP, 0, 1, 1, 0); ctx-ctrls_rdy = ctx-ctrl_handler.error == 0; return ctx-ctrl_handler.error; -- 1.7.4.1 -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
