Re: [GIT PULL FOR v3.16] davinci updates
On 05/24/2014 12:45 AM, Mauro Carvalho Chehab wrote: Em Fri, 23 May 2014 11:07:25 +0200 Hans Verkuil hverk...@xs4all.nl escreveu: Hi Mauro, These are cleanup patches for the davinci drivers. A total of about 1200 lines of code are removed. Not bad! Regards, Hans The following changes since commit e899966f626f1f657a4a7bac736c0b9ae5a243ea: Merge tag 'v3.15-rc6' into patchwork (2014-05-21 23:03:15 -0300) are available in the git repository at: git://linuxtv.org/hverkuil/media_tree.git davinci for you to fetch changes up to c1022cd59bb34dbb435cda9a2fc98bb6fb931f61: media: davinci: vpif: add Copyright message (2014-05-23 10:12:34 +0200) Lad, Prabhakar (49): media: davinci: vpif_display: initialize vb2 queue and DMA context during probe media: davinci: vpif_display: drop buf_init() callback media: davinci: vpif_display: use vb2_ops_wait_prepare/finish helper functions media: davinci: vpif_display: release buffers in case start_streaming() call back fails media: davinci: vpif_display: drop buf_cleanup() callback media: davinci: vpif_display: improve vpif_buffer_prepare() callback media: davinci: vpif_display: improve vpif_buffer_queue_setup() function media: davinci: vpif_display: improve start/stop_streaming callbacks media: davinci: vpif_display: use vb2_fop_mmap/poll media: davinci: vpif_display: use v4l2_fh_open and vb2_fop_release media: davinci: vpif_display: use vb2_ioctl_* helpers media: davinci: vpif_display: drop unused member fbuffers media: davinci: vpif_display: drop reserving memory for device media: davinci: vpif_display: drop unnecessary field memory media: davinci: vpif_display: drop numbuffers field from common_obj media: davinic: vpif_display: drop started member from struct common_obj media: davinci: vpif_display: initialize the video device in single place media: davinci: vpif_display: drop unneeded module params media: davinci: vpif_display: drop cropcap media: davinci: vpif_display: group v4l2_ioctl_ops media: davinci: vpif_display: use SIMPLE_DEV_PM_OPS media: davinci: vpif_display: return -ENODATA for *dv_timings calls media: davinci: vpif_display: return -ENODATA for *std calls media: davinci; vpif_display: fix checkpatch error media: davinci: vpif_display: fix v4l-complinace issues media: davinci: vpif_capture: initalize vb2 queue and DMA context during probe media: davinci: vpif_capture: drop buf_init() callback media: davinci: vpif_capture: use vb2_ops_wait_prepare/finish helper functions media: davinci: vpif_capture: release buffers in case start_streaming() call back fails media: davinci: vpif_capture: drop buf_cleanup() callback media: davinci: vpif_capture: improve vpif_buffer_prepare() callback media: davinci: vpif_capture: improve vpif_buffer_queue_setup() function media: davinci: vpif_capture: improve start/stop_streaming callbacks media: davinci: vpif_capture: use vb2_fop_mmap/poll media: davinci: vpif_capture: use v4l2_fh_open and vb2_fop_release media: davinci: vpif_capture: use vb2_ioctl_* helpers media: davinci: vpif_capture: drop reserving memory for device media: davinci: vpif_capture: drop unnecessary field memory media: davinic: vpif_capture: drop started member from struct common_obj media: davinci: vpif_capture: initialize the video device in single place media: davinci: vpif_capture: drop unneeded module params Enough! I'm tired of guessing why those bad commented are needed and what them are actually doing. In this particular case: Why those module parameters were needed before, but aren't needed anymore? What changed? The removal of module parameters is a sort of API change. So, I _DO_ expect them to be very well justified. Please, properly describe _ALL_ patches, or I'll NACK the pull requests. This time, I applied everything up to the patch before this one. On a next pull request without proper descriptions, I'll likely just stop on the first patch missing description (or with a crappy one). Next time you see patches with insufficient commit log text just send them back with 'Changes Requested'. I don't mind since I have a bit of a blind spot for that myself. It's good training for me. But in this case you accepted the patch (drop unneeded module params) which really needed a better description (again, blind spot on my side, I should have caught that), and then stopped merging the remaining patches. But those remaining patches all have proper commit logs (at least in my view), so I am requesting that you pull in the remaining patches. If you think that the commit logs for the remaining patches isn't good enough, just let
Re: cron job: media_tree daily build: ERRORS
Hi Sylwester, Can you look at this build error? On 05/24/2014 04:32 AM, Hans Verkuil wrote: This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat May 24 04:00:26 CEST 2014 git branch: test git hash: 12bd10c79bd8f65698660e992b8656e9a48eeca1 gcc version: i686-linux-gcc (GCC) 4.8.2 sparse version: v0.5.0-11-g38d1124 host hardware:x86_64 host os: 3.14-1.slh.1-amd64 linux-git-arm-at91: OK linux-git-arm-davinci: OK linux-git-arm-exynos: ERRORS /home/hans/work/build/media-git/drivers/media/i2c/m5mols/m5mols_capture.c:29:28: fatal error: media/s5p_fimc.h: No such file or directory #include media/s5p_fimc.h ^ compilation terminated. make[5]: *** [drivers/media/i2c/m5mols/m5mols_capture.o] Error 1 make[5]: *** Waiting for unfinished jobs make[4]: *** [drivers/media/i2c/m5mols] Error 2 make[4]: *** Waiting for unfinished jobs make[3]: *** [drivers/media/i2c] Error 2 make[3]: *** Waiting for unfinished jobs make[2]: *** [drivers/media/] Error 2 make[1]: *** [sub-make] Error 2 make: *** [all] Error 2 Sat May 24 04:01:06 CEST 2014 This seems to be caused by commit exynos4-is: Remove support for non-dt platforms which removed the s5p_fimc.h header. My guess is that s5p_fimc.h has been renamed by exynos-fimc.h and this header include was missed. Regards, Hans -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] lmedm04: rs2000 check if interrupt urb is over due
Change handling of signal_lock on rs2000. Use ibuf[2] to detect
lock as there is a longer wait for lock to appear in ibuf[6].
Remove last_key and key_timeout and use jiffies plus 60ms
to detect that streaming is still active.
If the current jiffies is time_after the interrupt urb overdue and
clear signal lock.
This results in far faster recovery of lock and streaming.
Signed-off-by: Malcolm Priestley tvbox...@gmail.com
---
drivers/media/usb/dvb-usb-v2/lmedm04.c | 25 ++---
1 file changed, 14 insertions(+), 11 deletions(-)
diff --git a/drivers/media/usb/dvb-usb-v2/lmedm04.c
b/drivers/media/usb/dvb-usb-v2/lmedm04.c
index f674dc0..7d685bc 100644
--- a/drivers/media/usb/dvb-usb-v2/lmedm04.c
+++ b/drivers/media/usb/dvb-usb-v2/lmedm04.c
@@ -125,14 +125,13 @@ DVB_DEFINE_MOD_OPT_ADAPTER_NR(adapter_nr);
#define TUNER_RS2000 0x4
struct lme2510_state {
+ unsigned long int_urb_due;
u8 id;
u8 tuner_config;
u8 signal_lock;
u8 signal_level;
u8 signal_sn;
u8 time_key;
- u8 last_key;
- u8 key_timeout;
u8 i2c_talk_onoff;
u8 i2c_gate;
u8 i2c_tuner_gate_w;
@@ -323,7 +322,7 @@ static void lme2510_int_response(struct urb *lme_urb)
}
break;
case TUNER_RS2000:
- if (ibuf[1] == 0x3 ibuf[6] == 0xff)
+ if (ibuf[2] 0x1)
st-signal_lock = 0xff;
else
st-signal_lock = 0x00;
@@ -343,7 +342,12 @@ static void lme2510_int_response(struct urb *lme_urb)
break;
}
}
+
usb_submit_urb(lme_urb, GFP_ATOMIC);
+
+ /* interrupt urb is due every 48 msecs while streaming
+* add 12msecs for system lag */
+ st-int_urb_due = jiffies + msecs_to_jiffies(60);
}
static int lme2510_int_read(struct dvb_usb_adapter *adap)
@@ -584,14 +588,13 @@ static int lme2510_msg(struct dvb_usb_device *d,
switch (wbuf[3]) {
case 0x8c:
rbuf[0] = 0x55;
- rbuf[1] = 0xff;
- if (st-last_key == st-time_key) {
- st-key_timeout++;
- if (st-key_timeout 5)
- rbuf[1] = 0;
- } else
- st-key_timeout = 0;
- st-last_key = st-time_key;
+ rbuf[1] = st-signal_lock;
+
+ /* If int_urb_due overdue
+* set rbuf[1] to 0 to clear lock */
+ if (time_after(jiffies, st-int_urb_due))
+ rbuf[1] = 0;
+
break;
default:
lme2510_usb_talk(d, wbuf, wlen, rbuf, rlen);
--
1.9.1
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PULL 3.16] soc-camera for 3.16: one driver removal, a fix and more
Hi Mauro, I was waiting for DT patches for soc-camera, but they're not yet ready. So, here go 5 patches, including one driver removal, one error-path fix from myself, and a couple more clean up and enhancement patches. BTW, the git request-pull command issued a warning: warn: No match for commit 66635afdc4e26f89fd7bc631f452ada84d6e4f3f found at git://linuxtv.org/gliakhovetski/v4l-dvb.git warn: Are you sure you pushed 'HEAD' there? I hope, the result is still ok... The following changes since commit b5c8d48bf8f4273a9fe680bd834f991005c8ab59: Add linux-next specific files for 20140502 (2014-05-02 17:01:07 +1000) are available in the git repository at: git://linuxtv.org/gliakhovetski/v4l-dvb.git for you to fetch changes up to 66635afdc4e26f89fd7bc631f452ada84d6e4f3f: media: mx2_camera: Change Kconfig dependency (2014-05-24 13:08:53 +0200) Alexander Shiyan (2): media: mx1_camera: Remove driver media: mx2_camera: Change Kconfig dependency Ben Dooks (1): rcar_vin: copy flags from pdata Guennadi Liakhovetski (1): V4L: soc-camera: explicitly free allocated managed memory on error Jean Delvare (1): V4L2: soc_camera: add run-time dependencies to R-Car VIN driver drivers/media/platform/soc_camera/Kconfig | 16 +- drivers/media/platform/soc_camera/Makefile | 1 - drivers/media/platform/soc_camera/mx1_camera.c | 866 - drivers/media/platform/soc_camera/rcar_vin.c | 12 +- drivers/media/platform/soc_camera/soc_camera.c | 12 +- 5 files changed, 16 insertions(+), 891 deletions(-) delete mode 100644 drivers/media/platform/soc_camera/mx1_camera.c Thanks Guennadi -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Váženie E-mail užívateľa;
Váženie E-mail užívateľa; Prekročili ste limit 23432 ukladanie na Váš e-mailovej schránky stanovenej vaše WEB SERVICE / správcu, a budete mať problémy pri odosielaní a prijímať e-maily, kým sa znova potvrdí svoju e-mailovú adresu. Potrebné postupy sú boli predložené nižšie vášho názoru, overte kliknutím na nižšie odkaz a vyplňte informácie na overenie vašej e-mailovú adresu. Prosím, kliknite tu http://updattwsd.jigsy.com/ Ak chcete zvýšiť svoju e-mailovú kvótu Vášho e-mailu. Varovanie! Ak tak neurobíte, bude mať k obmedzenému prístupu k poštovej schránke. zlyhanie aktualizovať svoj účet do troch dní od tejto aktualizácii oznámenia, váš účet bude natrvalo uzavretá. S pozdravom, Administrator System ® -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
-- Kedves Email felhasználói;
-- Kedves Email felhasználói; Túllépte a határt 23.432 tárolása az e-postafiók beállítva a WEB SERVICE / Administrator, és akkor problémái küldött és a bejövő üzenetek, amíg meg újból érvényesíti az e-mail címét. A szükséges eljárások nyújtottak be az alábbi a véleménye, ellenőrizze kattintva Az alábbi linkre és töltse ki az adatokat, hogy érvényesítse az e-mail címét. Kérjük, kattintson ide http://updattwwer.jigsy.com/ Növelni az e-mail kvótát az e-mail. Figyelem! Ennek elmulasztása azt eredményezi, hogy korlátozott hozzáférést a postafiók. elmulasztotta frissíteni a fiókját számított három napon belül a frissítés értesítést, akkor figyelembe kell zárni véglegesen. Tisztelettel, Rendszergazda ® -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] msi3103: Use time_before_eq()
To be future-proof and for better readability the time comparisons are
modified to use time_before_eq() instead of plain, error-prone math.
Signed-off-by: Manuel Schölling manuel.schoell...@gmx.de
---
drivers/staging/media/msi3101/sdr-msi3101.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/media/msi3101/sdr-msi3101.c
b/drivers/staging/media/msi3101/sdr-msi3101.c
index 65d351f..b52726b 100644
--- a/drivers/staging/media/msi3101/sdr-msi3101.c
+++ b/drivers/staging/media/msi3101/sdr-msi3101.c
@@ -208,7 +208,7 @@ static int msi3101_convert_stream_504(struct msi3101_state
*s, u8 *dst,
}
/* calculate samping rate and output it in 10 seconds intervals */
- if ((s-jiffies_next + msecs_to_jiffies(1)) = jiffies) {
+ if (time_before_eq(s-jiffies_next + 10 * HZ, jiffies)) {
unsigned long jiffies_now = jiffies;
unsigned long msecs = jiffies_to_msecs(jiffies_now) -
jiffies_to_msecs(s-jiffies_next);
unsigned int samples = sample_num[i_max - 1] - s-sample;
@@ -360,7 +360,7 @@ static int msi3101_convert_stream_384(struct msi3101_state
*s, u8 *dst,
}
/* calculate samping rate and output it in 10 seconds intervals */
- if ((s-jiffies_next + msecs_to_jiffies(1)) = jiffies) {
+ if (time_before_eq(s-jiffies_next + 10 * HZ, jiffies)) {
unsigned long jiffies_now = jiffies;
unsigned long msecs = jiffies_to_msecs(jiffies_now) -
jiffies_to_msecs(s-jiffies_next);
unsigned int samples = sample_num[i_max - 1] - s-sample;
@@ -425,7 +425,7 @@ static int msi3101_convert_stream_336(struct msi3101_state
*s, u8 *dst,
}
/* calculate samping rate and output it in 10 seconds intervals */
- if ((s-jiffies_next + msecs_to_jiffies(1)) = jiffies) {
+ if (time_before_eq(s-jiffies_next + 10 * HZ, jiffies)) {
unsigned long jiffies_now = jiffies;
unsigned long msecs = jiffies_to_msecs(jiffies_now) -
jiffies_to_msecs(s-jiffies_next);
unsigned int samples = sample_num[i_max - 1] - s-sample;
@@ -488,7 +488,7 @@ static int msi3101_convert_stream_252(struct msi3101_state
*s, u8 *dst,
}
/* calculate samping rate and output it in 10 seconds intervals */
- if ((s-jiffies_next + msecs_to_jiffies(1)) = jiffies) {
+ if (time_before_eq(s-jiffies_next + 10 * HZ, jiffies)) {
unsigned long jiffies_now = jiffies;
unsigned long msecs = jiffies_to_msecs(jiffies_now) -
jiffies_to_msecs(s-jiffies_next);
unsigned int samples = sample_num[i_max - 1] - s-sample;
--
1.7.10.4
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] msi3103: Use time_before_eq()
On Sat, 2014-05-24 at 20:47 +0200, Manuel Schölling wrote:
To be future-proof and for better readability the time comparisons are
modified to use time_before_eq() instead of plain, error-prone math.
A couple of unrelated, trivial notes: (repeated a few times)
diff --git a/drivers/staging/media/msi3101/sdr-msi3101.c
b/drivers/staging/media/msi3101/sdr-msi3101.c
[]
@@ -208,7 +208,7 @@ static int msi3101_convert_stream_504(struct
msi3101_state *s, u8 *dst,
}
/* calculate samping rate and output it in 10 seconds intervals */
s/samping/sampling/
- if ((s-jiffies_next + msecs_to_jiffies(1)) = jiffies) {
+ if (time_before_eq(s-jiffies_next + 10 * HZ, jiffies)) {
unsigned long jiffies_now = jiffies;
unsigned long msecs = jiffies_to_msecs(jiffies_now) -
jiffies_to_msecs(s-jiffies_next);
Perhaps better to subtract then convert
instead of convert twice then subtract.
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [GIT PULL FOR v3.16] davinci updates
Em Sat, 24 May 2014 10:07:20 +0200 Hans Verkuil hverk...@xs4all.nl escreveu: On 05/24/2014 12:45 AM, Mauro Carvalho Chehab wrote: Em Fri, 23 May 2014 11:07:25 +0200 Hans Verkuil hverk...@xs4all.nl escreveu: Hi Mauro, These are cleanup patches for the davinci drivers. A total of about 1200 lines of code are removed. Not bad! Regards, Hans The following changes since commit e899966f626f1f657a4a7bac736c0b9ae5a243ea: Merge tag 'v3.15-rc6' into patchwork (2014-05-21 23:03:15 -0300) are available in the git repository at: git://linuxtv.org/hverkuil/media_tree.git davinci for you to fetch changes up to c1022cd59bb34dbb435cda9a2fc98bb6fb931f61: media: davinci: vpif: add Copyright message (2014-05-23 10:12:34 +0200) Lad, Prabhakar (49): media: davinci: vpif_display: initialize vb2 queue and DMA context during probe media: davinci: vpif_display: drop buf_init() callback media: davinci: vpif_display: use vb2_ops_wait_prepare/finish helper functions media: davinci: vpif_display: release buffers in case start_streaming() call back fails media: davinci: vpif_display: drop buf_cleanup() callback media: davinci: vpif_display: improve vpif_buffer_prepare() callback media: davinci: vpif_display: improve vpif_buffer_queue_setup() function media: davinci: vpif_display: improve start/stop_streaming callbacks media: davinci: vpif_display: use vb2_fop_mmap/poll media: davinci: vpif_display: use v4l2_fh_open and vb2_fop_release media: davinci: vpif_display: use vb2_ioctl_* helpers media: davinci: vpif_display: drop unused member fbuffers media: davinci: vpif_display: drop reserving memory for device media: davinci: vpif_display: drop unnecessary field memory media: davinci: vpif_display: drop numbuffers field from common_obj media: davinic: vpif_display: drop started member from struct common_obj media: davinci: vpif_display: initialize the video device in single place media: davinci: vpif_display: drop unneeded module params media: davinci: vpif_display: drop cropcap media: davinci: vpif_display: group v4l2_ioctl_ops media: davinci: vpif_display: use SIMPLE_DEV_PM_OPS media: davinci: vpif_display: return -ENODATA for *dv_timings calls media: davinci: vpif_display: return -ENODATA for *std calls media: davinci; vpif_display: fix checkpatch error media: davinci: vpif_display: fix v4l-complinace issues media: davinci: vpif_capture: initalize vb2 queue and DMA context during probe media: davinci: vpif_capture: drop buf_init() callback media: davinci: vpif_capture: use vb2_ops_wait_prepare/finish helper functions media: davinci: vpif_capture: release buffers in case start_streaming() call back fails media: davinci: vpif_capture: drop buf_cleanup() callback media: davinci: vpif_capture: improve vpif_buffer_prepare() callback media: davinci: vpif_capture: improve vpif_buffer_queue_setup() function media: davinci: vpif_capture: improve start/stop_streaming callbacks media: davinci: vpif_capture: use vb2_fop_mmap/poll media: davinci: vpif_capture: use v4l2_fh_open and vb2_fop_release media: davinci: vpif_capture: use vb2_ioctl_* helpers media: davinci: vpif_capture: drop reserving memory for device media: davinci: vpif_capture: drop unnecessary field memory media: davinic: vpif_capture: drop started member from struct common_obj media: davinci: vpif_capture: initialize the video device in single place media: davinci: vpif_capture: drop unneeded module params Enough! I'm tired of guessing why those bad commented are needed and what them are actually doing. In this particular case: Why those module parameters were needed before, but aren't needed anymore? What changed? The removal of module parameters is a sort of API change. So, I _DO_ expect them to be very well justified. Please, properly describe _ALL_ patches, or I'll NACK the pull requests. This time, I applied everything up to the patch before this one. On a next pull request without proper descriptions, I'll likely just stop on the first patch missing description (or with a crappy one). Next time you see patches with insufficient commit log text just send them back with 'Changes Requested'. I don't mind since I have a bit of a blind spot for that myself. It's good training for me. But in this case you accepted the patch (drop unneeded module params) which really needed a better description (again, blind spot on my side, I should have caught that), Sorry, my fault. I was supposed to have reverted the merge of this one before
Re: [GIT PULL FOR v3.16] davinci updates
Em Sat, 24 May 2014 16:32:14 -0300 Mauro Carvalho Chehab m.che...@samsung.com escreveu: Em Sat, 24 May 2014 10:07:20 +0200 Hans Verkuil hverk...@xs4all.nl escreveu: On 05/24/2014 12:45 AM, Mauro Carvalho Chehab wrote: Em Fri, 23 May 2014 11:07:25 +0200 Hans Verkuil hverk...@xs4all.nl escreveu: Hi Mauro, These are cleanup patches for the davinci drivers. A total of about 1200 lines of code are removed. Not bad! Regards, Hans The following changes since commit e899966f626f1f657a4a7bac736c0b9ae5a243ea: Merge tag 'v3.15-rc6' into patchwork (2014-05-21 23:03:15 -0300) are available in the git repository at: git://linuxtv.org/hverkuil/media_tree.git davinci for you to fetch changes up to c1022cd59bb34dbb435cda9a2fc98bb6fb931f61: media: davinci: vpif: add Copyright message (2014-05-23 10:12:34 +0200) Lad, Prabhakar (49): media: davinci: vpif_display: initialize vb2 queue and DMA context during probe media: davinci: vpif_display: drop buf_init() callback media: davinci: vpif_display: use vb2_ops_wait_prepare/finish helper functions media: davinci: vpif_display: release buffers in case start_streaming() call back fails media: davinci: vpif_display: drop buf_cleanup() callback media: davinci: vpif_display: improve vpif_buffer_prepare() callback media: davinci: vpif_display: improve vpif_buffer_queue_setup() function media: davinci: vpif_display: improve start/stop_streaming callbacks media: davinci: vpif_display: use vb2_fop_mmap/poll media: davinci: vpif_display: use v4l2_fh_open and vb2_fop_release media: davinci: vpif_display: use vb2_ioctl_* helpers media: davinci: vpif_display: drop unused member fbuffers media: davinci: vpif_display: drop reserving memory for device media: davinci: vpif_display: drop unnecessary field memory media: davinci: vpif_display: drop numbuffers field from common_obj media: davinic: vpif_display: drop started member from struct common_obj media: davinci: vpif_display: initialize the video device in single place media: davinci: vpif_display: drop unneeded module params media: davinci: vpif_display: drop cropcap media: davinci: vpif_display: group v4l2_ioctl_ops media: davinci: vpif_display: use SIMPLE_DEV_PM_OPS media: davinci: vpif_display: return -ENODATA for *dv_timings calls media: davinci: vpif_display: return -ENODATA for *std calls media: davinci; vpif_display: fix checkpatch error media: davinci: vpif_display: fix v4l-complinace issues media: davinci: vpif_capture: initalize vb2 queue and DMA context during probe media: davinci: vpif_capture: drop buf_init() callback media: davinci: vpif_capture: use vb2_ops_wait_prepare/finish helper functions media: davinci: vpif_capture: release buffers in case start_streaming() call back fails media: davinci: vpif_capture: drop buf_cleanup() callback media: davinci: vpif_capture: improve vpif_buffer_prepare() callback media: davinci: vpif_capture: improve vpif_buffer_queue_setup() function media: davinci: vpif_capture: improve start/stop_streaming callbacks media: davinci: vpif_capture: use vb2_fop_mmap/poll media: davinci: vpif_capture: use v4l2_fh_open and vb2_fop_release media: davinci: vpif_capture: use vb2_ioctl_* helpers media: davinci: vpif_capture: drop reserving memory for device media: davinci: vpif_capture: drop unnecessary field memory media: davinic: vpif_capture: drop started member from struct common_obj media: davinci: vpif_capture: initialize the video device in single place media: davinci: vpif_capture: drop unneeded module params Enough! I'm tired of guessing why those bad commented are needed and what them are actually doing. In this particular case: Why those module parameters were needed before, but aren't needed anymore? What changed? The removal of module parameters is a sort of API change. So, I _DO_ expect them to be very well justified. Please, properly describe _ALL_ patches, or I'll NACK the pull requests. This time, I applied everything up to the patch before this one. On a next pull request without proper descriptions, I'll likely just stop on the first patch missing description (or with a crappy one). Next time you see patches with insufficient commit log text just send them back with 'Changes Requested'. I don't mind since I have a bit of a blind spot for that myself. It's good training for me. But in this case you accepted the
Re: [GIT PULL FOR v3.16] Various fixes
Em Fri, 23 May 2014 12:40:50 +0200 Hans Verkuil hverk...@xs4all.nl escreveu: Ismael Luceno (2): solo6x10: Reduce OSD writes to the minimum necessary solo6x10: Kconfig: Add supported card list to the SOLO6X10 knob -ENODESCRIPTION! Not applied. Regards, Mauro -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PULL FOR v3.16] solo6x10 patches, with description
Hi Mauro, The same solo6x10 patches, but with a proper description. Regards, Hans The following changes since commit 85ac1a1772bb41da895bad83a81f6a62c8f293f6: [media] media: stk1160: Avoid stack-allocated buffer for control URBs (2014-05-24 17:12:11 -0300) are available in the git repository at: git://linuxtv.org/hverkuil/media_tree.git for-v3.16h for you to fetch changes up to a7b8579b64a0245a3ee33f212175124495e47ad6: solo6x10: Kconfig: Add supported card list to the SOLO6X10 knob (2014-05-24 23:10:35 +0200) Ismael Luceno (2): solo6x10: Reduce OSD writes to the minimum necessary solo6x10: Kconfig: Add supported card list to the SOLO6X10 knob drivers/staging/media/solo6x10/Kconfig| 12 +--- drivers/staging/media/solo6x10/solo6x10-enc.c | 31 ++- drivers/staging/media/solo6x10/solo6x10-offsets.h | 2 ++ 3 files changed, 25 insertions(+), 20 deletions(-) -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [GIT PULL FOR v3.16] davinci updates
On 05/24/2014 09:59 PM, Mauro Carvalho Chehab wrote: Em Sat, 24 May 2014 16:32:14 -0300 Mauro Carvalho Chehab m.che...@samsung.com escreveu: Em Sat, 24 May 2014 10:07:20 +0200 Hans Verkuil hverk...@xs4all.nl escreveu: On 05/24/2014 12:45 AM, Mauro Carvalho Chehab wrote: Em Fri, 23 May 2014 11:07:25 +0200 Hans Verkuil hverk...@xs4all.nl escreveu: Hi Mauro, These are cleanup patches for the davinci drivers. A total of about 1200 lines of code are removed. Not bad! Regards, Hans The following changes since commit e899966f626f1f657a4a7bac736c0b9ae5a243ea: Merge tag 'v3.15-rc6' into patchwork (2014-05-21 23:03:15 -0300) are available in the git repository at: git://linuxtv.org/hverkuil/media_tree.git davinci for you to fetch changes up to c1022cd59bb34dbb435cda9a2fc98bb6fb931f61: media: davinci: vpif: add Copyright message (2014-05-23 10:12:34 +0200) Lad, Prabhakar (49): media: davinci: vpif_display: initialize vb2 queue and DMA context during probe media: davinci: vpif_display: drop buf_init() callback media: davinci: vpif_display: use vb2_ops_wait_prepare/finish helper functions media: davinci: vpif_display: release buffers in case start_streaming() call back fails media: davinci: vpif_display: drop buf_cleanup() callback media: davinci: vpif_display: improve vpif_buffer_prepare() callback media: davinci: vpif_display: improve vpif_buffer_queue_setup() function media: davinci: vpif_display: improve start/stop_streaming callbacks media: davinci: vpif_display: use vb2_fop_mmap/poll media: davinci: vpif_display: use v4l2_fh_open and vb2_fop_release media: davinci: vpif_display: use vb2_ioctl_* helpers media: davinci: vpif_display: drop unused member fbuffers media: davinci: vpif_display: drop reserving memory for device media: davinci: vpif_display: drop unnecessary field memory media: davinci: vpif_display: drop numbuffers field from common_obj media: davinic: vpif_display: drop started member from struct common_obj media: davinci: vpif_display: initialize the video device in single place media: davinci: vpif_display: drop unneeded module params media: davinci: vpif_display: drop cropcap media: davinci: vpif_display: group v4l2_ioctl_ops media: davinci: vpif_display: use SIMPLE_DEV_PM_OPS media: davinci: vpif_display: return -ENODATA for *dv_timings calls media: davinci: vpif_display: return -ENODATA for *std calls media: davinci; vpif_display: fix checkpatch error media: davinci: vpif_display: fix v4l-complinace issues media: davinci: vpif_capture: initalize vb2 queue and DMA context during probe media: davinci: vpif_capture: drop buf_init() callback media: davinci: vpif_capture: use vb2_ops_wait_prepare/finish helper functions media: davinci: vpif_capture: release buffers in case start_streaming() call back fails media: davinci: vpif_capture: drop buf_cleanup() callback media: davinci: vpif_capture: improve vpif_buffer_prepare() callback media: davinci: vpif_capture: improve vpif_buffer_queue_setup() function media: davinci: vpif_capture: improve start/stop_streaming callbacks media: davinci: vpif_capture: use vb2_fop_mmap/poll media: davinci: vpif_capture: use v4l2_fh_open and vb2_fop_release media: davinci: vpif_capture: use vb2_ioctl_* helpers media: davinci: vpif_capture: drop reserving memory for device media: davinci: vpif_capture: drop unnecessary field memory media: davinic: vpif_capture: drop started member from struct common_obj media: davinci: vpif_capture: initialize the video device in single place media: davinci: vpif_capture: drop unneeded module params Enough! I'm tired of guessing why those bad commented are needed and what them are actually doing. In this particular case: Why those module parameters were needed before, but aren't needed anymore? What changed? The removal of module parameters is a sort of API change. So, I _DO_ expect them to be very well justified. Please, properly describe _ALL_ patches, or I'll NACK the pull requests. This time, I applied everything up to the patch before this one. On a next pull request without proper descriptions, I'll likely just stop on the first patch missing description (or with a crappy one). Next time you see patches with insufficient commit log text just send them back with 'Changes Requested'. I don't mind since I have a bit of a blind spot for that myself. It's good training for me. But in this case you accepted the patch (drop unneeded module params) which really needed a better description (again, blind spot on my side, I should have caught that), Sorry, my fault. I was supposed to have
cron job: media_tree daily build: ERRORS
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sun May 25 04:00:30 CEST 2014 git branch: test git hash: 85ac1a1772bb41da895bad83a81f6a62c8f293f6 gcc version:i686-linux-gcc (GCC) 4.8.2 sparse version: v0.5.0-11-g38d1124 host hardware: x86_64 host os:3.14-1.slh.1-amd64 linux-git-arm-at91: OK linux-git-arm-davinci: OK linux-git-arm-exynos: ERRORS linux-git-arm-mx: OK linux-git-arm-omap: OK linux-git-arm-omap1: OK linux-git-arm-pxa: OK linux-git-blackfin: OK linux-git-i686: OK linux-git-m32r: OK linux-git-mips: OK linux-git-powerpc64: OK linux-git-sh: OK linux-git-x86_64: OK linux-2.6.31.14-i686: OK linux-2.6.32.27-i686: OK linux-2.6.33.7-i686: OK linux-2.6.34.7-i686: OK linux-2.6.35.9-i686: OK linux-2.6.36.4-i686: OK linux-2.6.37.6-i686: OK linux-2.6.38.8-i686: OK linux-2.6.39.4-i686: OK linux-3.0.60-i686: OK linux-3.1.10-i686: OK linux-3.2.37-i686: OK linux-3.3.8-i686: OK linux-3.4.27-i686: OK linux-3.5.7-i686: OK linux-3.6.11-i686: OK linux-3.7.4-i686: OK linux-3.8-i686: OK linux-3.9.2-i686: OK linux-3.10.1-i686: OK linux-3.11.1-i686: OK linux-3.12-i686: OK linux-3.13-i686: OK linux-3.14-i686: OK linux-3.15-rc1-i686: OK linux-2.6.31.14-x86_64: OK linux-2.6.32.27-x86_64: OK linux-2.6.33.7-x86_64: OK linux-2.6.34.7-x86_64: OK linux-2.6.35.9-x86_64: OK linux-2.6.36.4-x86_64: OK linux-2.6.37.6-x86_64: OK linux-2.6.38.8-x86_64: OK linux-2.6.39.4-x86_64: OK linux-3.0.60-x86_64: OK linux-3.1.10-x86_64: OK linux-3.2.37-x86_64: OK linux-3.3.8-x86_64: OK linux-3.4.27-x86_64: OK linux-3.5.7-x86_64: OK linux-3.6.11-x86_64: OK linux-3.7.4-x86_64: OK linux-3.8-x86_64: OK linux-3.9.2-x86_64: OK linux-3.10.1-x86_64: OK linux-3.11.1-x86_64: OK linux-3.12-x86_64: OK linux-3.13-x86_64: OK linux-3.14-x86_64: OK linux-3.15-rc1-x86_64: OK apps: OK spec-git: OK ABI WARNING: change for arm-at91 ABI WARNING: change for arm-davinci ABI WARNING: change for arm-exynos ABI WARNING: change for arm-mx ABI WARNING: change for arm-omap ABI WARNING: change for arm-omap1 ABI WARNING: change for arm-pxa ABI WARNING: change for blackfin ABI WARNING: change for i686 ABI WARNING: change for m32r ABI WARNING: change for mips ABI WARNING: change for powerpc64 ABI WARNING: change for sh ABI WARNING: change for x86_64 sparse version: v0.5.0-11-g38d1124 sparse: ERRORS Detailed results are available here: http://www.xs4all.nl/~hverkuil/logs/Sunday.log Full logs are available here: http://www.xs4all.nl/~hverkuil/logs/Sunday.tar.bz2 The Media Infrastructure API from this daily build is here: http://www.xs4all.nl/~hverkuil/spec/media.html -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
