Re: [RFC] [PATCH 0/3] media: an attempt to refresh omap1_camera driver

2016-07-03 Thread Aaro Koskinen
Hi,

On Fri, Jun 17, 2016 at 09:04:52AM +0200, Hans Verkuil wrote:
> Out of curiosity: is supporting the Amstrad Delta something you do as a hobby
> or are there other reasons?

Out of curiousity, why should this matter?

A.
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCHv24 00/16] Contiguous Memory Allocator

2012-04-10 Thread Aaro Koskinen

Hi,

On Tue, 3 Apr 2012, Marek Szyprowski wrote:

This is (yet another) update of CMA patches.


How well CMA is supposed to work if you have mlocked processes? I've
been testing these patches, and noticed that by creating a small mlocked
process you start to get plenty of test_pages_isolated() failure warnings,
and bigger allocations will always fail.

A.
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCHv22 13/16] drivers: add Contiguous Memory Allocator

2012-02-21 Thread Aaro Koskinen

Hi,

On Fri, 17 Feb 2012, Marek Szyprowski wrote:

+/**
+ * dma_release_from_contiguous() - release allocated pages
+ * @dev:   Pointer to device for which the pages were allocated.
+ * @pages: Allocated pages.
+ * @count: Number of allocated pages.
+ *
+ * This function releases memory allocated by dma_alloc_from_contiguous().
+ * It returns false when provided pages do not belong to contiguous area and
+ * true otherwise.
+ */
+bool dma_release_from_contiguous(struct device *dev, struct page *pages,
+int count)
+{
+   struct cma *cma = dev_get_cma_area(dev);
+   unsigned long pfn;
+
+   if (!cma || !pages)
+   return false;
+
+   pr_debug(%s(page %p)\n, __func__, (void *)pages);
+
+   pfn = page_to_pfn(pages);
+
+   if (pfn  cma-base_pfn || pfn = cma-base_pfn + cma-count)
+   return false;
+
+   VM_BUG_ON(pfn + count  cma-base_pfn);


Are you sure the VM_BUG_ON() condition is correct here?


+   mutex_lock(cma_mutex);
+   bitmap_clear(cma-bitmap, pfn - cma-base_pfn, count);
+   free_contig_range(pfn, count);
+   mutex_unlock(cma_mutex);
+
+   return true;
+}


A.
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html