[PATCH] media: pci: smipcie: Fix dependency for DVB_SMIPCIE
In smipcie.c, the function i2c_bit_add_bus() is called. This function is defined by the I2C bit-banging interfaces enabled with CONFIG_I2C_ALGOBIT. As there was no dependency in Kconfig, CONFIG_I2C_ALGOBIT could be set to m while CONFIG_DVB_SMIPCIE was set to y, resulting in a build error due to an undefined reference. This patch adds the dependency on CONFIG_I2C_ALGOBIT in Kconfig. Signed-off-by: Andreas Ruprecht rup...@einserver.de Reported-by: Jim Davis jim.ep...@gmail.com --- drivers/media/pci/smipcie/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/smipcie/Kconfig b/drivers/media/pci/smipcie/Kconfig index 75a2992..c728721 100644 --- a/drivers/media/pci/smipcie/Kconfig +++ b/drivers/media/pci/smipcie/Kconfig @@ -1,6 +1,6 @@ config DVB_SMIPCIE tristate SMI PCIe DVBSky cards - depends on DVB_CORE PCI I2C + depends on DVB_CORE PCI I2C I2C_ALGOBIT select DVB_M88DS3103 if MEDIA_SUBDRV_AUTOSELECT select MEDIA_TUNER_M88TS2022 if MEDIA_SUBDRV_AUTOSELECT select MEDIA_TUNER_M88RS6000T if MEDIA_SUBDRV_AUTOSELECT -- 1.9.1 -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] media: pci: smipcie: Fix dependency for DVB_SMIPCIE
On 21.11.2014 19:13, Mauro Carvalho Chehab wrote: Em Fri, 21 Nov 2014 18:51:59 +0100 Andreas Ruprecht rup...@einserver.de escreveu: In smipcie.c, the function i2c_bit_add_bus() is called. This function is defined by the I2C bit-banging interfaces enabled with CONFIG_I2C_ALGOBIT. As there was no dependency in Kconfig, CONFIG_I2C_ALGOBIT could be set to m while CONFIG_DVB_SMIPCIE was set to y, resulting in a build error due to an undefined reference. This patch adds the dependency on CONFIG_I2C_ALGOBIT in Kconfig. Signed-off-by: Andreas Ruprecht rup...@einserver.de Reported-by: Jim Davis jim.ep...@gmail.com --- drivers/media/pci/smipcie/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/smipcie/Kconfig b/drivers/media/pci/smipcie/Kconfig index 75a2992..c728721 100644 --- a/drivers/media/pci/smipcie/Kconfig +++ b/drivers/media/pci/smipcie/Kconfig @@ -1,6 +1,6 @@ config DVB_SMIPCIE tristate SMI PCIe DVBSky cards -depends on DVB_CORE PCI I2C +depends on DVB_CORE PCI I2C I2C_ALGOBIT IMHO, the best would be, instead, to select I2C_ALGOBIT. Okay, I'll change that and submit a new version of this patch. Regards, Andreas Ruprecht -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v2] media: pci: smipcie: Fix dependency for DVB_SMIPCIE
In smipcie.c, the function i2c_bit_add_bus() is called. This function is defined by the I2C bit-banging interfaces enabled with CONFIG_I2C_ALGOBIT. As there was no dependency in Kconfig, CONFIG_I2C_ALGOBIT could be set to m while CONFIG_DVB_SMIPCIE was set to y, resulting in a build error due to an undefined reference. This patch adds the dependency on CONFIG_I2C_ALGOBIT in Kconfig by selecting it when CONFIG_DVB_SMIPCIE is selected. Signed-off-by: Andreas Ruprecht rup...@einserver.de Reported-by: Jim Davis jim.ep...@gmail.com --- drivers/media/pci/smipcie/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/pci/smipcie/Kconfig b/drivers/media/pci/smipcie/Kconfig index 75a2992..57dd124 100644 --- a/drivers/media/pci/smipcie/Kconfig +++ b/drivers/media/pci/smipcie/Kconfig @@ -1,6 +1,7 @@ config DVB_SMIPCIE tristate SMI PCIe DVBSky cards depends on DVB_CORE PCI I2C + select I2C_ALGOBIT select DVB_M88DS3103 if MEDIA_SUBDRV_AUTOSELECT select MEDIA_TUNER_M88TS2022 if MEDIA_SUBDRV_AUTOSELECT select MEDIA_TUNER_M88RS6000T if MEDIA_SUBDRV_AUTOSELECT -- 1.9.1 -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: randconfig build error with next-20141020, in drivers/media/platform/marvell-ccic/mcam-core.c
Hi, after a lot of staring at the configuration it seems like this boils down to an issue within the Kconfig constraint description. Broken down to the important bits: - CONFIG_VIDEO_TW68 and CONFIG_VIDEO_SAA7134 *select* CONFIG_VIDEOBUF2_DMA_SG - Both of these options are set to *m* in the configuration provided, which means that CONFIG_VIDEOBUF2_DMA_SG will also be selected as m. According to Documentation/kbuild/kconfig-language.txt, line 101, m is set as the minimal value for CONFIG_VIDEOBUF2_DMA_SG by the selects, and as no other options select it as y, it stays m. - CONFIG_VIDEO_CAFE_CCIC is set to *y*. The header file at drivers/media/platform/marvell-ccic/mcam-core.h then sets an internal preprocessor variable in line 28: #if IS_ENABLED(CONFIG_VIDEOBUF2_DMA_SG) #define MCAM_MODE_DMA_SG 1 #endif The source code right around line 1299 in drivers/media/platform/marvell-ccic/mcam-core.c, where the undefined reference occurs, depends on MCAM_MODE_DMA_SG. This means that CONFIG_VIDEOBUF2_DMA_SG is compiled as an LKM, thus the reference for vb2_dma_sg_memops from mcam-core.c (which is statically compiled) can not be resolved in the builtin.o files and vmlinux. Unfortunately, I haven't got a solution on how to resolve that, but maybe this summary helps someone else to come up with one. Best regards, Andreas On 20.10.2014 19:52, Jim Davis wrote: Building with the attached random configuration file, drivers/built-in.o: In function `mcam_setup_vb2': /home/jim/linux/drivers/media/platform/marvell-ccic/mcam-core.c:1299: undefined reference to `vb2_dma_sg_memops' make: *** [vmlinux] Error 1 -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] drivers: media: platform: Makefile: Add build dependency for davinci/
In the davinci/ subdirectory, all drivers but one depend on CONFIG_ARCH_DAVINCI. The only exception, selected by CONFIG_VIDEO_DM6446_CCDC, is also available on CONFIG_ARCH_OMAP3. Thus, it is not necessary to always descend into davinci/. It is sufficient to do this only if CONFIG_ARCH_OMAP3 or CONFIG_ARCH_DAVINCI is selected. While the latter is already present, this patch changes the dependency from obj-y to obj-$(CONFIG_ARCH_OMAP3). Signed-off-by: Andreas Ruprecht rup...@einserver.de --- drivers/media/platform/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/Makefile b/drivers/media/platform/Makefile index e5269da..d32e79a 100644 --- a/drivers/media/platform/Makefile +++ b/drivers/media/platform/Makefile @@ -47,7 +47,7 @@ obj-$(CONFIG_SOC_CAMERA) += soc_camera/ obj-$(CONFIG_VIDEO_RENESAS_VSP1) += vsp1/ -obj-y += davinci/ +obj-$(CONFIG_ARCH_OMAP3) += davinci/ obj-$(CONFIG_ARCH_OMAP)+= omap/ -- 1.9.1 -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] drivers: media: pci: Makefile: Remove duplicate subdirectory from obj-y
In the list of subdirectories compiled, b2c2/ appears twice. This patch removes one of the appearances. Signed-off-by: Andreas Ruprecht rup...@einserver.de --- drivers/media/pci/Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/pci/Makefile b/drivers/media/pci/Makefile index e5b53fb..dc2ebbe 100644 --- a/drivers/media/pci/Makefile +++ b/drivers/media/pci/Makefile @@ -10,7 +10,6 @@ obj-y+= ttpci/ \ mantis/ \ ngene/ \ ddbridge/ \ - b2c2/ \ saa7146/ obj-$(CONFIG_VIDEO_IVTV) += ivtv/ -- 1.9.1 -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
