Re: [PATCH 2/2] sound/usb: Update ALSA driver to use media controller API
Shuah Khan wrote:
> @@ -541,13 +591,19 @@ int snd_usb_create_quirk(struct snd_usb_audio *chip,
> [QUIRK_AUDIO_ALIGN_TRANSFER] = create_align_transfer_quirk,
> [QUIRK_AUDIO_STANDARD_MIXER] = create_standard_mixer_quirk,
> };
> + int ret;
>
> + if (quirk->media_device) {
> + /* don't want to fail when media_device_init() doesn't work */
> + ret = media_device_init(iface);
> + }
> if (quirk->type < QUIRK_TYPE_COUNT) {
> - return quirk_funcs[quirk->type](chip, iface, driver, quirk);
> + ret = quirk_funcs[quirk->type](chip, iface, driver, quirk);
> } else {
> usb_audio_err(chip, "invalid quirk type %d\n", quirk->type);
> return -ENXIO;
> }
> + return ret;
> }
What is the point of saving 'ret' of media_device_init if it'll
only be clobbered or ignored for ENXIO?
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
AVerMedia AVerTV Hybrid+FM Cardbus (E506) driver problem on Xubuntu 14.04
apparmor="STATUS" operation="profile_replace" profile="unconfined" name="/usr/sbin/cups-browsed" pid=820 comm="apparmor_parser" [ 27.023625] type=1400 audit(1410949980.277:42): apparmor="STATUS" operation="profile_replace" profile="unconfined" name="/usr/lib/cups/backend/cups-pdf" pid=698 comm="apparmor_parser" [ 27.033047] type=1400 audit(1410949980.289:43): apparmor="STATUS" operation="profile_replace" profile="unconfined" name="/usr/sbin/cupsd" pid=698 comm="apparmor_parser" [ 27.066406] type=1400 audit(1410949980.321:44): apparmor="STATUS" operation="profile_load" profile="unconfined" name="/usr/sbin/tcpdump" pid=826 comm="apparmor_parser" [ 33.530805] init: plymouth-upstart-bridge main process ended, respawning [ 33.573435] init: plymouth-upstart-bridge main process (1191) terminated with status 1 [ 33.573465] init: plymouth-upstart-bridge main process ended, respawning [ 329.072173] usb 2-2: USB disconnect, device number 2 [ 329.628106] usb 2-2: new low-speed USB device number 3 using uhci_hcd [ 611.773019] saa7133[0]: dsp access error [ 611.773033] saa7133[0]: dsp access error [ 611.773052] saa7133[0]: dsp access error [ 611.773059] saa7133[0]: dsp access error [ 611.773075] saa7133[0]: dsp access error [ 611.773082] saa7133[0]: dsp access error [ 611.773098] saa7133[0]: dsp access error [ 611.773105] saa7133[0]: dsp access error [ 611.773121] saa7133[0]: dsp access error [ 611.773128] saa7133[0]: dsp access error [ 611.773144] saa7133[0]: dsp access error [ 611.773151] saa7133[0]: dsp access error [ 611.773167] saa7133[0]: dsp access error [ 611.773174] saa7133[0]: dsp access error [ 611.773190] saa7133[0]: dsp access error [ 611.773197] saa7133[0]: dsp access error [ 611.773213] saa7133[0]: dsp access error [ 611.773220] saa7133[0]: dsp access error [ 611.773236] saa7133[0]: dsp access error [ 611.773243] saa7133[0]: dsp access error [ 611.773259] saa7133[0]/irq[10,77943]: r=0xfff7 s=0x DONE_RA0 DONE_RA1 DONE_RA2 AR PE PWR_ON RDCAP INTL FIDT MMC TRIG_ERR CONF_ERR LOAD_ERR GPIO16 GPIO18 GPIO22 GPIO23 | RA0=vbi,b,odd,15 [ 611.773299] saa7133[0]/irq: looping -- clearing PE (parity error!) enable bit Maybe some recent changes in kernel somehow broke support for this tuner card? I don't know. Please advice if you know what the problem is or how this can be solved. Thanks -- Eric Wong -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
