[PATCH 1/1] [media] uvcvideo: quirk PROBE_DEF for Dell SP2008WFP monitor.

2013-08-29 Thread Joseph Salisbury 
BugLink: http://bugs.launchpad.net/bugs/1217957

Add quirk for Dell SP2008WFP monitor: 05a9:2641

Signed-off-by: Joseph Salisbury joseph.salisb...@canonical.com
Tested-by: Christopher Townsend christopher.towns...@canonical.com
Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com
Cc: Mauro Carvalho Chehab m.che...@samsung.com 
Cc: linux-media@vger.kernel.org
Cc: linux-ker...@vger.kernel.org
Cc: sta...@vger.kernel.org
---
 drivers/media/usb/uvc/uvc_driver.c |9 +
 1 file changed, 9 insertions(+)

diff --git a/drivers/media/usb/uvc/uvc_driver.c 
b/drivers/media/usb/uvc/uvc_driver.c
index ed123f4..8c1826c 100644
--- a/drivers/media/usb/uvc/uvc_driver.c
+++ b/drivers/media/usb/uvc/uvc_driver.c
@@ -2174,6 +2174,15 @@ static struct usb_device_id uvc_ids[] = {
  .bInterfaceSubClass   = 1,
  .bInterfaceProtocol   = 0,
  .driver_info  = UVC_QUIRK_PROBE_DEF },
+   /* Dell SP2008WFP Monitor */
+   { .match_flags  = USB_DEVICE_ID_MATCH_DEVICE
+   | USB_DEVICE_ID_MATCH_INT_INFO,
+ .idVendor = 0x05a9,
+ .idProduct= 0x2641,
+ .bInterfaceClass  = USB_CLASS_VIDEO,
+ .bInterfaceSubClass   = 1,
+ .bInterfaceProtocol   = 0,
+ .driver_info  = UVC_QUIRK_PROBE_DEF },
/* Dell Alienware X51 */
{ .match_flags  = USB_DEVICE_ID_MATCH_DEVICE
| USB_DEVICE_ID_MATCH_INT_INFO,
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] [media] uvcvideo: quirk PROBE_DEF for Alienware X51 OmniVision webcam

2013-05-16 Thread Joseph Salisbury 
On 05/16/2013 08:03 AM, Laurent Pinchart wrote:
 Hi Joseph,

 Thank you for the patch.
Thanks for the feedback.


 On Wednesday 15 May 2013 16:38:48 joseph.salisb...@canonical.com wrote:
 From: Joseph Salisbury joseph.salisb...@canonical.com

 BugLink: http://bugs.launchpad.net/bugs/1180409

 OminiVision webcam 0x05a9:0x2643 needs the same UVC_QUIRK_PROBE_DEF as other
 OmniVision models to work properly.

 Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com
 Cc: Mauro Carvalho Chehab mche...@redhat.com
 Cc: linux-media@vger.kernel.org
 Cc: sta...@vger.kernel.org
 Signed-off-by: Joseph Salisbury joseph.salisb...@canonical.com
 There's already a 05a9:2643 webcam model, found in a Dell monitor, that has 
 been reported to work properly without the UVC_QUIRK_PROBE_DEF. Enabling the 
 quirk shouldn't hurt, but I'd like to check differences between the two 
 devices. Could you please send me the output of

 lsusb -v -d 05a9:2643

 (running as root if possible) ?
The lsusb output can be seen at:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1180409/comments/10/+download

I can also send this to you as an attachment if needed.


 ---
  drivers/media/usb/uvc/uvc_driver.c |9 +
  1 file changed, 9 insertions(+)

 diff --git a/drivers/media/usb/uvc/uvc_driver.c
 b/drivers/media/usb/uvc/uvc_driver.c index 5dbefa6..411682c 100644
 --- a/drivers/media/usb/uvc/uvc_driver.c
 +++ b/drivers/media/usb/uvc/uvc_driver.c
 @@ -2163,6 +2163,15 @@ static struct usb_device_id uvc_ids[] = {
.bInterfaceSubClass   = 1,
.bInterfaceProtocol   = 0,
.driver_info  = UVC_QUIRK_PROBE_DEF },
 +/* Alienware X51*/
 +{ .match_flags  = USB_DEVICE_ID_MATCH_DEVICE
 +| USB_DEVICE_ID_MATCH_INT_INFO,
 +  .idVendor = 0x05a9,
 +  .idProduct= 0x2643,
 +  .bInterfaceClass  = USB_CLASS_VIDEO,
 +  .bInterfaceSubClass   = 1,
 +  .bInterfaceProtocol   = 0,
 +  .driver_info  = UVC_QUIRK_PROBE_DEF },
 Your mailer messed up formatting. As the patch is small I've fixed it 
 manually, but please make sure to use a proper mail client next time. I 
 advise 
 using git-send-email to send patches.

Thanks.  I did in fact use git-send-email, which is what I use to send
all patches.  Can you point out the bad formatting.  Is it that   '|
USB_DEVICE_ID_MATCH_INT_INFO,' was not indented?  If so, I'll
investigate why that happened.

  /* Apple Built-In iSight */
  { .match_flags  = USB_DEVICE_ID_MATCH_DEVICE

  | USB_DEVICE_ID_MATCH_INT_INFO,

Thanks again for reviewing this patch.
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/1] [media] uvcvideo: quirk PROBE_DEF for Alienware X51 OmniVision webcam

2013-05-15 Thread joseph . salisbury 
From: Joseph Salisbury joseph.salisb...@canonical.com

BugLink: http://bugs.launchpad.net/bugs/1180409

OminiVision webcam 0x05a9:0x2643 needs the same UVC_QUIRK_PROBE_DEF as other 
OmniVision models to work properly.

Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com
Cc: Mauro Carvalho Chehab mche...@redhat.com
Cc: linux-media@vger.kernel.org
Cc: sta...@vger.kernel.org
Signed-off-by: Joseph Salisbury joseph.salisb...@canonical.com
---
 drivers/media/usb/uvc/uvc_driver.c |9 +
 1 file changed, 9 insertions(+)

diff --git a/drivers/media/usb/uvc/uvc_driver.c 
b/drivers/media/usb/uvc/uvc_driver.c
index 5dbefa6..411682c 100644
--- a/drivers/media/usb/uvc/uvc_driver.c
+++ b/drivers/media/usb/uvc/uvc_driver.c
@@ -2163,6 +2163,15 @@ static struct usb_device_id uvc_ids[] = {
  .bInterfaceSubClass   = 1,
  .bInterfaceProtocol   = 0,
  .driver_info  = UVC_QUIRK_PROBE_DEF },
+   /* Alienware X51*/
+{ .match_flags  = USB_DEVICE_ID_MATCH_DEVICE
+| USB_DEVICE_ID_MATCH_INT_INFO,
+  .idVendor = 0x05a9,
+  .idProduct= 0x2643,
+  .bInterfaceClass  = USB_CLASS_VIDEO,
+  .bInterfaceSubClass   = 1,
+  .bInterfaceProtocol   = 0,
+  .driver_info  = UVC_QUIRK_PROBE_DEF },
/* Apple Built-In iSight */
{ .match_flags  = USB_DEVICE_ID_MATCH_DEVICE
| USB_DEVICE_ID_MATCH_INT_INFO,
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html