Re: [PATCH] staging: media: go7007: Adlink MPG24 board issues

[Justin P. Mattock]

 = V4L2_CTRL_TYPE_INTEGER;
-   strncpy(ctrl-name, Saturation, sizeof(ctrl-name));
-   ctrl-minimum = 0;
-   ctrl-maximum = 255;
-   ctrl-step = 1;
-   ctrl-default_value = 128;
-   ctrl-flags = 0;
-   break;
-   case V4L2_CID_HUE:
-   ctrl-type = V4L2_CTRL_TYPE_INTEGER;
-   strncpy(ctrl-name, Hue, sizeof(ctrl-name));
-   ctrl-minimum = 0;
-   ctrl-maximum = 255;
-   ctrl-step = 1;
-   ctrl-default_value = 128;
-   ctrl-flags = 0;
-   break;
-   }
-   break;
-   }
-   case VIDIOC_S_CTRL:
-   {
-   struct v4l2_control *ctrl = arg;
-
-   switch (ctrl-id) {
-   case V4L2_CID_BRIGHTNESS:
-   if (ctrl-value  255)
-   dec-brightness = 255;
-   else if (ctrl-value  0)
-   dec-brightness = 0;
-   else
-   dec-brightness = ctrl-value;
-   write_reg(client, 0x12, dec-brightness, dec-channel);
-   break;
-   case V4L2_CID_CONTRAST:
-   if (ctrl-value  255)
-   dec-contrast = 255;
-   else if (ctrl-value  0)
-   dec-contrast = 0;
-   else
-   dec-contrast = ctrl-value;
-   write_reg(client, 0x11, dec-contrast, dec-channel);
-   break;
-   case V4L2_CID_SATURATION:
-   if (ctrl-value  255)
-   dec-saturation = 255;
-   else if (ctrl-value  0)
-   dec-saturation = 0;
-   else
-   dec-saturation = ctrl-value;
-   write_reg(client, 0x10, dec-saturation, dec-channel);
-   break;
-   case V4L2_CID_HUE:
-   if (ctrl-value  255)
-   dec-hue = 255;
-   else if (ctrl-value  0)
-   dec-hue = 0;
-   else
-   dec-hue = ctrl-value;
-   write_reg(client, 0x0f, dec-hue, dec-channel);
-   break;
-   }
-   break;
-   }
-   case VIDIOC_G_CTRL:
-   {
-   struct v4l2_control *ctrl = arg;
-
-   switch (ctrl-id) {
-   case V4L2_CID_BRIGHTNESS:
-   ctrl-value = dec-brightness;
-   break;
-   case V4L2_CID_CONTRAST:
-   ctrl-value = dec-contrast;
-   break;
-   case V4L2_CID_SATURATION:
-   ctrl-value = dec-saturation;
-   break;
-   case V4L2_CID_HUE:
-   ctrl-value = dec-hue;
-   break;
-   }
-   break;
-   }
-   default:
-   break;
-   }
return 0;
  }

@@ -295,21 +503,28 @@ static int wis_tw2804_probe(struct i2c_client *client,
  {
struct i2c_adapter *adapter = client-adapter;
struct wis_tw2804 *dec;
+   struct v4l2_subdev *sd;

if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA))
return -ENODEV;

-   dec = kmalloc(sizeof(struct wis_tw2804), GFP_KERNEL);
+   dec = kzalloc(sizeof(struct wis_tw2804), GFP_KERNEL);
+
if (dec == NULL)
return -ENOMEM;
-
+   sd =dec-sd;
+   dec-update = 1;
dec-channel = -1;
dec-norm = V4L2_STD_NTSC;
dec-brightness = 128;
dec-contrast = 128;
dec-saturation = 128;
dec-hue = 128;
-   i2c_set_clientdata(client, dec);
+   dec-gain = 128;
+   dec-cr_gain = 128;
+   dec-b_balance = 122;
+   dec-r_balance = 122;
+   v4l2_i2c_subdev_init(sd, client,tw2804_ops);

printk(KERN_DEBUG wis-tw2804: creating TW2804 at address %d on %s\n,
client-addr, adapter-name);
@@ -319,9 +534,10 @@ static int wis_tw2804_probe(struct i2c_client *client,

  static int wis_tw2804_remove(struct i2c_client *client)
  {
-   struct wis_tw2804 *dec = i2c_get_clientdata(client);
+   struct v4l2_subdev *sd = i2c_get_clientdata(client);

-   kfree(dec);
+   v4l2_device_unregister_subdev(sd);
+   kfree(to_state(sd));
return 0;
  }





Justin P. Mattock
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo

Re: [PATCH V2]NEXT:drivers:staging:media Fix comments and some typos in staging/media/*

[Justin P. Mattock]

before I forget about this patch, what was the status of this one?

On 03/06/2012 06:55 AM, Justin P. Mattock wrote:

From: Justin P. Mattockjustinmatt...@gmail.com

linux-next:
I like to spend some time reading code, in doing so I have found some typos in 
some of the comments.
The patch below fixes what I have found.

Signed-off-by: Justin P. Mattockjustinmatt...@gmail.com

---
  drivers/staging/media/Kconfig  |2 +-
  drivers/staging/media/as102/as102_drv.c|2 +-
  drivers/staging/media/as102/as102_fe.c |4 ++--
  drivers/staging/media/go7007/go7007-v4l2.c |8 
  drivers/staging/media/lirc/lirc_serial.c   |2 +-
  drivers/staging/media/solo6x10/Kconfig |2 +-
  6 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/media/Kconfig b/drivers/staging/media/Kconfig
index 7e5caa3..4f4b7d6 100644
--- a/drivers/staging/media/Kconfig
+++ b/drivers/staging/media/Kconfig
@@ -6,7 +6,7 @@ menuconfig STAGING_MEDIA
  don't have the normal Linux kernel quality level.
  Most of them don't follow properly the V4L, DVB and/or RC API's,
  so, they won't likely work fine with the existing applications.
- That also means that, one fixed, their API's will change to match
+ That also means that, once fixed, their API's will change to match
  the existing ones.

If you wish to work on these drivers, to help improve them, or
diff --git a/drivers/staging/media/as102/as102_drv.c 
b/drivers/staging/media/as102/as102_drv.c
index aae0505..ea4f992 100644
--- a/drivers/staging/media/as102/as102_drv.c
+++ b/drivers/staging/media/as102/as102_drv.c
@@ -27,7 +27,7 @@
  #includelinux/uaccess.h
  #includelinux/usb.h

-/* header file for Usb device driver*/
+/* header file for usb device driver*/
  #include as102_drv.h
  #include as102_fw.h
  #include dvbdev.h
diff --git a/drivers/staging/media/as102/as102_fe.c 
b/drivers/staging/media/as102/as102_fe.c
index bdc5a38..57daa8c 100644
--- a/drivers/staging/media/as102/as102_fe.c
+++ b/drivers/staging/media/as102/as102_fe.c
@@ -337,7 +337,7 @@ int as102_dvb_register_fe(struct as102_dev_t *as102_dev,
strncpy(dvb_fe-ops.info.name, as102_dev-name,
sizeof(dvb_fe-ops.info.name));

-   /* register dbvb frontend */
+   /* register dvb frontend */
errno = dvb_register_frontend(dvb_adap, dvb_fe);
if (errno == 0)
dvb_fe-tuner_priv = as102_dev;
@@ -349,7 +349,7 @@ static void as10x_fe_copy_tps_parameters(struct 
dtv_frontend_properties *fe_tps,
 struct as10x_tps *as10x_tps)
  {

-   /* extract consteallation */
+   /* extract constellation */
switch (as10x_tps-modulation) {
case CONST_QPSK:
fe_tps-modulation = QPSK;
diff --git a/drivers/staging/media/go7007/go7007-v4l2.c 
b/drivers/staging/media/go7007/go7007-v4l2.c
index 2b27d8d..f916586 100644
--- a/drivers/staging/media/go7007/go7007-v4l2.c
+++ b/drivers/staging/media/go7007/go7007-v4l2.c
@@ -1050,15 +1050,15 @@ static int vidioc_s_parm(struct file *filp, void *priv,
return 0;
  }

-/* VIDIOC_ENUMSTD on go7007 were used for enumberating the supported fps and
+/* VIDIOC_ENUMSTD on go7007 were used for enumerating the supported fps and
 its resolution, when the device is not connected to TV.
-   This were an API abuse, probably used by the lack of specific IOCTL's to
-   enumberate it, by the time the driver were written.
+   This is were an API abuse, probably used by the lack of specific IOCTL's to
+   enumerate it, by the time the driver was written.

 However, since kernel 2.6.19, two new ioctls (VIDIOC_ENUM_FRAMEINTERVALS
 and VIDIOC_ENUM_FRAMESIZES) were added for this purpose.

-   The two functions bellow implements the newer ioctls
+   The two functions below implement the newer ioctls
  */
  static int vidioc_enum_framesizes(struct file *filp, void *priv,
  struct v4l2_frmsizeenum *fsize)
diff --git a/drivers/staging/media/lirc/lirc_serial.c 
b/drivers/staging/media/lirc/lirc_serial.c
index 8dd8897..97352cf 100644
--- a/drivers/staging/media/lirc/lirc_serial.c
+++ b/drivers/staging/media/lirc/lirc_serial.c
@@ -1282,7 +1282,7 @@ MODULE_PARM_DESC(iommap, physical base for memory mapped 
I/O
  /*
   * some architectures (e.g. intel xscale) align the 8bit serial registers
   * on 32bit word boundaries.
- * See linux-kernel/serial/8250.c serial_in()/out()
+ * See linux-kernel/drivers/tty/serial/8250/8250.c serial_in()/out()
   */
  module_param(ioshift, int, S_IRUGO);
  MODULE_PARM_DESC(ioshift, shift I/O register offset (0 = no shift));
diff --git a/drivers/staging/media/solo6x10/Kconfig 
b/drivers/staging/media/solo6x10/Kconfig
index 03dcac4..63352de 100644
--- a/drivers/staging/media/solo6x10/Kconfig
+++ b/drivers/staging/media/solo6x10/Kconfig
@@ -5,4 +5,4 @@ config SOLO6X10
select SND_PCM
---help

Re: [PATCH V2]NEXT:drivers:staging:media Fix comments and some typos in staging/media/*

[Justin P. Mattock]

On 03/16/2012 08:45 AM, Jiri Kosina wrote:

On Fri, 16 Mar 2012, Justin P. Mattock wrote:


before I forget about this patch, what was the status of this one?


As previously announced multiple times, I am ignoring patches that go to
drivers/staging and letting Greg pick them up if he wants to.

Greg, if you want to have this changed, just let me know.



so any typos in staging are not sent to trivial. I might have not have 
received that announcement because of not being on any lists.

thanks for letting me know!

Justin P. Mattock
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH V2]NEXT:drivers:staging:media Fix comments and some typos in staging/media/*

[Justin P. Mattock]

On 03/16/2012 08:58 AM, Greg KH wrote:

On Fri, Mar 16, 2012 at 04:45:03PM +0100, Jiri Kosina wrote:

On Fri, 16 Mar 2012, Justin P. Mattock wrote:


before I forget about this patch, what was the status of this one?


As previously announced multiple times, I am ignoring patches that go to
drivers/staging and letting Greg pick them up if he wants to.

Greg, if you want to have this changed, just let me know.


No, no objection from me, but patches to drivers/staging/media/ do not
go through me, please see the MAINTAINERS file for the owner of those
(hint, it's Mauro...)

thanks,

greg k-h



ahh!! I got it now.. your in charge of the staging tree but for each 
branch there is an owner(I thought to just send to greg KH and thats it)


adding Mauro to the Cc's so he can view the patch, then on any other 
patch I send to staging I will send it to the maintainer then the rest 
as follows with a cc's.


Thanks for the help on this.

Justin P. Mattock
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH V2]NEXT:drivers:staging:media Fix comments and some typos in staging/media/*

[Justin P. Mattock]

On 03/16/2012 09:06 AM, Justin P. Mattock wrote:

On 03/16/2012 08:58 AM, Greg KH wrote:

On Fri, Mar 16, 2012 at 04:45:03PM +0100, Jiri Kosina wrote:

On Fri, 16 Mar 2012, Justin P. Mattock wrote:


before I forget about this patch, what was the status of this one?


As previously announced multiple times, I am ignoring patches that go to
drivers/staging and letting Greg pick them up if he wants to.

Greg, if you want to have this changed, just let me know.


No, no objection from me, but patches to drivers/staging/media/ do not
go through me, please see the MAINTAINERS file for the owner of those
(hint, it's Mauro...)

thanks,

greg k-h



ahh!! I got it now.. your in charge of the staging tree but for each
branch there is an owner(I thought to just send to greg KH and thats it)

adding Mauro to the Cc's so he can view the patch, then on any other
patch I send to staging I will send it to the maintainer then the rest
as follows with a cc's.

Thanks for the help on this.

Justin P. Mattock


and of course pressed send without the Maintainer on it.. duh!

Justin P. Mattock

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH V2]NEXT:drivers:staging:media Fix comments and some typos in staging/media/*

[Justin P. Mattock]

From: Justin P. Mattock justinmatt...@gmail.com

linux-next:
I like to spend some time reading code, in doing so I have found some typos in 
some of the comments.
The patch below fixes what I have found.

Signed-off-by: Justin P. Mattock justinmatt...@gmail.com

---
 drivers/staging/media/Kconfig  |2 +-
 drivers/staging/media/as102/as102_drv.c|2 +-
 drivers/staging/media/as102/as102_fe.c |4 ++--
 drivers/staging/media/go7007/go7007-v4l2.c |8 
 drivers/staging/media/lirc/lirc_serial.c   |2 +-
 drivers/staging/media/solo6x10/Kconfig |2 +-
 6 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/media/Kconfig b/drivers/staging/media/Kconfig
index 7e5caa3..4f4b7d6 100644
--- a/drivers/staging/media/Kconfig
+++ b/drivers/staging/media/Kconfig
@@ -6,7 +6,7 @@ menuconfig STAGING_MEDIA
  don't have the normal Linux kernel quality level.
  Most of them don't follow properly the V4L, DVB and/or RC API's,
  so, they won't likely work fine with the existing applications.
- That also means that, one fixed, their API's will change to match
+ That also means that, once fixed, their API's will change to match
  the existing ones.
 
   If you wish to work on these drivers, to help improve them, or
diff --git a/drivers/staging/media/as102/as102_drv.c 
b/drivers/staging/media/as102/as102_drv.c
index aae0505..ea4f992 100644
--- a/drivers/staging/media/as102/as102_drv.c
+++ b/drivers/staging/media/as102/as102_drv.c
@@ -27,7 +27,7 @@
 #include linux/uaccess.h
 #include linux/usb.h
 
-/* header file for Usb device driver*/
+/* header file for usb device driver*/
 #include as102_drv.h
 #include as102_fw.h
 #include dvbdev.h
diff --git a/drivers/staging/media/as102/as102_fe.c 
b/drivers/staging/media/as102/as102_fe.c
index bdc5a38..57daa8c 100644
--- a/drivers/staging/media/as102/as102_fe.c
+++ b/drivers/staging/media/as102/as102_fe.c
@@ -337,7 +337,7 @@ int as102_dvb_register_fe(struct as102_dev_t *as102_dev,
strncpy(dvb_fe-ops.info.name, as102_dev-name,
sizeof(dvb_fe-ops.info.name));
 
-   /* register dbvb frontend */
+   /* register dvb frontend */
errno = dvb_register_frontend(dvb_adap, dvb_fe);
if (errno == 0)
dvb_fe-tuner_priv = as102_dev;
@@ -349,7 +349,7 @@ static void as10x_fe_copy_tps_parameters(struct 
dtv_frontend_properties *fe_tps,
 struct as10x_tps *as10x_tps)
 {
 
-   /* extract consteallation */
+   /* extract constellation */
switch (as10x_tps-modulation) {
case CONST_QPSK:
fe_tps-modulation = QPSK;
diff --git a/drivers/staging/media/go7007/go7007-v4l2.c 
b/drivers/staging/media/go7007/go7007-v4l2.c
index 2b27d8d..f916586 100644
--- a/drivers/staging/media/go7007/go7007-v4l2.c
+++ b/drivers/staging/media/go7007/go7007-v4l2.c
@@ -1050,15 +1050,15 @@ static int vidioc_s_parm(struct file *filp, void *priv,
return 0;
 }
 
-/* VIDIOC_ENUMSTD on go7007 were used for enumberating the supported fps and
+/* VIDIOC_ENUMSTD on go7007 were used for enumerating the supported fps and
its resolution, when the device is not connected to TV.
-   This were an API abuse, probably used by the lack of specific IOCTL's to
-   enumberate it, by the time the driver were written.
+   This is were an API abuse, probably used by the lack of specific IOCTL's to
+   enumerate it, by the time the driver was written.
 
However, since kernel 2.6.19, two new ioctls (VIDIOC_ENUM_FRAMEINTERVALS
and VIDIOC_ENUM_FRAMESIZES) were added for this purpose.
 
-   The two functions bellow implements the newer ioctls
+   The two functions below implement the newer ioctls
 */
 static int vidioc_enum_framesizes(struct file *filp, void *priv,
  struct v4l2_frmsizeenum *fsize)
diff --git a/drivers/staging/media/lirc/lirc_serial.c 
b/drivers/staging/media/lirc/lirc_serial.c
index 8dd8897..97352cf 100644
--- a/drivers/staging/media/lirc/lirc_serial.c
+++ b/drivers/staging/media/lirc/lirc_serial.c
@@ -1282,7 +1282,7 @@ MODULE_PARM_DESC(iommap, physical base for memory mapped 
I/O
 /*
  * some architectures (e.g. intel xscale) align the 8bit serial registers
  * on 32bit word boundaries.
- * See linux-kernel/serial/8250.c serial_in()/out()
+ * See linux-kernel/drivers/tty/serial/8250/8250.c serial_in()/out()
  */
 module_param(ioshift, int, S_IRUGO);
 MODULE_PARM_DESC(ioshift, shift I/O register offset (0 = no shift));
diff --git a/drivers/staging/media/solo6x10/Kconfig 
b/drivers/staging/media/solo6x10/Kconfig
index 03dcac4..63352de 100644
--- a/drivers/staging/media/solo6x10/Kconfig
+++ b/drivers/staging/media/solo6x10/Kconfig
@@ -5,4 +5,4 @@ config SOLO6X10
select SND_PCM
---help---
  This driver supports the Softlogic based MPEG-4 and h.264 codec
- codec cards.
+ cards.
-- 
1.7.5.4

[PATCH]NEXT:drivers:staging:media Fix comments and some typos in staging/media/*

[Justin P. Mattock]

From: Justin P. Mattock justinmatt...@gmail.com

linux-next:
I like to spend some time reading code, in doing so I have found some typos in 
some of the comments.
The patch below fixes what I have found.

Signed-off-by: Justin P. Mattock justinmatt...@gmail.com

---
 drivers/staging/media/Kconfig  |2 +-
 drivers/staging/media/as102/as102_drv.c|2 +-
 drivers/staging/media/as102/as102_fe.c |4 ++--
 drivers/staging/media/go7007/go7007-v4l2.c |8 
 drivers/staging/media/lirc/lirc_serial.c   |2 +-
 drivers/staging/media/solo6x10/Kconfig |2 +-
 6 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/media/Kconfig b/drivers/staging/media/Kconfig
index 7e5caa3..4f4b7d6 100644
--- a/drivers/staging/media/Kconfig
+++ b/drivers/staging/media/Kconfig
@@ -6,7 +6,7 @@ menuconfig STAGING_MEDIA
  don't have the normal Linux kernel quality level.
  Most of them don't follow properly the V4L, DVB and/or RC API's,
  so, they won't likely work fine with the existing applications.
- That also means that, one fixed, their API's will change to match
+ That also means that, once fixed, their API's will change to match
  the existing ones.
 
   If you wish to work on these drivers, to help improve them, or
diff --git a/drivers/staging/media/as102/as102_drv.c 
b/drivers/staging/media/as102/as102_drv.c
index aae0505..ea4f992 100644
--- a/drivers/staging/media/as102/as102_drv.c
+++ b/drivers/staging/media/as102/as102_drv.c
@@ -27,7 +27,7 @@
 #include linux/uaccess.h
 #include linux/usb.h
 
-/* header file for Usb device driver*/
+/* header file for usb device driver*/
 #include as102_drv.h
 #include as102_fw.h
 #include dvbdev.h
diff --git a/drivers/staging/media/as102/as102_fe.c 
b/drivers/staging/media/as102/as102_fe.c
index bdc5a38..57daa8c 100644
--- a/drivers/staging/media/as102/as102_fe.c
+++ b/drivers/staging/media/as102/as102_fe.c
@@ -337,7 +337,7 @@ int as102_dvb_register_fe(struct as102_dev_t *as102_dev,
strncpy(dvb_fe-ops.info.name, as102_dev-name,
sizeof(dvb_fe-ops.info.name));
 
-   /* register dbvb frontend */
+   /* register dvb frontend */
errno = dvb_register_frontend(dvb_adap, dvb_fe);
if (errno == 0)
dvb_fe-tuner_priv = as102_dev;
@@ -349,7 +349,7 @@ static void as10x_fe_copy_tps_parameters(struct 
dtv_frontend_properties *fe_tps,
 struct as10x_tps *as10x_tps)
 {
 
-   /* extract consteallation */
+   /* extract constellation */
switch (as10x_tps-modulation) {
case CONST_QPSK:
fe_tps-modulation = QPSK;
diff --git a/drivers/staging/media/go7007/go7007-v4l2.c 
b/drivers/staging/media/go7007/go7007-v4l2.c
index 2b27d8d..8054378 100644
--- a/drivers/staging/media/go7007/go7007-v4l2.c
+++ b/drivers/staging/media/go7007/go7007-v4l2.c
@@ -1050,15 +1050,15 @@ static int vidioc_s_parm(struct file *filp, void *priv,
return 0;
 }
 
-/* VIDIOC_ENUMSTD on go7007 were used for enumberating the supported fps and
+/* VIDIOC_ENUMSTD on go7007 were used for enumerating the supported fps and
its resolution, when the device is not connected to TV.
-   This were an API abuse, probably used by the lack of specific IOCTL's to
-   enumberate it, by the time the driver were written.
+   This is were an API abuse, probably used by the lack of specific IOCTL's to
+   enumerate it, by the time the driver was written.
 
However, since kernel 2.6.19, two new ioctls (VIDIOC_ENUM_FRAMEINTERVALS
and VIDIOC_ENUM_FRAMESIZES) were added for this purpose.
 
-   The two functions bellow implements the newer ioctls
+   The two functions bellow implement the newer ioctls
 */
 static int vidioc_enum_framesizes(struct file *filp, void *priv,
  struct v4l2_frmsizeenum *fsize)
diff --git a/drivers/staging/media/lirc/lirc_serial.c 
b/drivers/staging/media/lirc/lirc_serial.c
index 8dd8897..97352cf 100644
--- a/drivers/staging/media/lirc/lirc_serial.c
+++ b/drivers/staging/media/lirc/lirc_serial.c
@@ -1282,7 +1282,7 @@ MODULE_PARM_DESC(iommap, physical base for memory mapped 
I/O
 /*
  * some architectures (e.g. intel xscale) align the 8bit serial registers
  * on 32bit word boundaries.
- * See linux-kernel/serial/8250.c serial_in()/out()
+ * See linux-kernel/drivers/tty/serial/8250/8250.c serial_in()/out()
  */
 module_param(ioshift, int, S_IRUGO);
 MODULE_PARM_DESC(ioshift, shift I/O register offset (0 = no shift));
diff --git a/drivers/staging/media/solo6x10/Kconfig 
b/drivers/staging/media/solo6x10/Kconfig
index 03dcac4..63352de 100644
--- a/drivers/staging/media/solo6x10/Kconfig
+++ b/drivers/staging/media/solo6x10/Kconfig
@@ -5,4 +5,4 @@ config SOLO6X10
select SND_PCM
---help---
  This driver supports the Softlogic based MPEG-4 and h.264 codec
- codec cards.
+ cards.
-- 
1.7.5.4

Re: [PATCH]NEXT:drivers:staging:media Fix comments and some typos in staging/media/*

[Justin P. Mattock]

On 03/05/2012 09:28 AM, David Santinoli wrote:

On Mon, Mar 05, 2012 at 07:49:26AM -0800, Justin P. Mattock wrote:

-   The two functions bellow implements the newer ioctls
+   The two functions bellow implement the newer ioctls


There's still some room for improvement here. :-)

Cheers,
  David



I can change bellow to below but is this intentional? i.e. a loud noise 
from the newer ioctl or something.


Justin P. Mattock
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH]drivers:media:dvb:frontends:s5h1420.c Change: clock_settting to clock_setting

[Justin P. Mattock]

From: Justin P. Mattock justinmatt...@gmail.com

The below patch, changes clock_settting to clock_setting. 
Note: This could be intentionally set this way from the beginning and/or is a 
typo.

Signed-off-by: Justin P. Mattock justinmatt...@gmail.com

---
 drivers/media/dvb/frontends/s5h1420.c |   12 ++--
 1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/media/dvb/frontends/s5h1420.c 
b/drivers/media/dvb/frontends/s5h1420.c
index 17f8cdf..3879d2e 100644
--- a/drivers/media/dvb/frontends/s5h1420.c
+++ b/drivers/media/dvb/frontends/s5h1420.c
@@ -634,7 +634,7 @@ static int s5h1420_set_frontend(struct dvb_frontend* fe,
struct s5h1420_state* state = fe-demodulator_priv;
int frequency_delta;
struct dvb_frontend_tune_settings fesettings;
-   uint8_t clock_settting;
+   uint8_t clock_setting;
 
dprintk(enter %s\n, __func__);
 
@@ -684,19 +684,19 @@ static int s5h1420_set_frontend(struct dvb_frontend* fe,
switch (state-fclk) {
default:
case 8800:
-   clock_settting = 80;
+   clock_setting = 80;
break;
case 8600:
-   clock_settting = 78;
+   clock_setting = 78;
break;
case 8000:
-   clock_settting = 72;
+   clock_setting = 72;
break;
case 5900:
-   clock_settting = 51;
+   clock_setting = 51;
break;
case 4400:
-   clock_settting = 36;
+   clock_setting = 36;
break;
}
dprintk(pll01: %d, ToneFreq: %d\n, state-fclk/100 - 8, 
(state-fclk + (TONE_FREQ * 32) - 1) / (TONE_FREQ * 32));
-- 
1.7.5.2

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 06/21]drivers:media:cx23418.h remove one to many l's in the word.

[Justin P. Mattock]

The patch below removes an extra l in the word.

Signed-off-by: Justin P. Mattock justinmatt...@gmail.com

---
 drivers/media/video/cx18/cx23418.h |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/media/video/cx18/cx23418.h 
b/drivers/media/video/cx18/cx23418.h
index 7e40035..935f557 100644
--- a/drivers/media/video/cx18/cx23418.h
+++ b/drivers/media/video/cx18/cx23418.h
@@ -477,7 +477,7 @@
 /* The are no buffers ready. Try again soon! */
 #define CXERR_NODATA_AGAIN  0x1E
 
-/* The stream is stopping. Function not alllowed now! */
+/* The stream is stopping. Function not allowed now! */
 #define CXERR_STOPPING_STATUS   0x1F
 
 /* Trying to access hardware when the power is turned OFF */
-- 
1.7.4.1

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 07/21]drivers:media:cx231xx.h remove one to many l's in the word.

[Justin P. Mattock]

The patch below removes an extra l in the word.

Signed-off-by: Justin P. Mattock justinmatt...@gmail.com

---
 drivers/media/video/cx231xx/cx231xx.h |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/media/video/cx231xx/cx231xx.h 
b/drivers/media/video/cx231xx/cx231xx.h
index 72bbea2..82a810a 100644
--- a/drivers/media/video/cx231xx/cx231xx.h
+++ b/drivers/media/video/cx231xx/cx231xx.h
@@ -464,7 +464,7 @@ struct cx231xx_fh {
 #define I2C_STOP0x0
 /* 1-- do not transmit STOP at end of transaction */
 #define I2C_NOSTOP  0x1
-/* 1--alllow slave to insert clock wait states */
+/* 1--allow slave to insert clock wait states */
 #define I2C_SYNC0x1
 
 struct cx231xx_i2c {
-- 
1.7.4.1

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 14/15]include:media:davinci:vpss.h Typo change diable to disable.

[Justin P. Mattock]

On 01/03/2011 07:01 AM, Jiri Kosina wrote:

On Fri, 31 Dec 2010, Mauro Carvalho Chehab wrote:


Em 30-12-2010 21:08, Justin P. Mattock escreveu:

The below patch fixes a typo diable to disable. Please let me know if this
is correct or not.

Signed-off-by: Justin P. Mattockjustinmatt...@gmail.com

Acked-by: Mauro Carvalho Chehabmche...@redhat.com


Applied.



PS.: Next time, please c/c linux-media ONLY on patches related to media
drivers (/drivers/video and the corresponding include files). Having to
dig into a series of 15 patches to just actually look on 3 patches
is not nice.


Absolutely.

Justin, no kernel developer should be afraid of being CCed. But try to
avoid really unnecessary spamming (which this was).



alright..

Justin P. Mattock
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 03/15]drivers:staging:rtl8187se:r8180_hw.h Typo change diable to disable.

[Justin P. Mattock]

On 01/01/2011 01:09 AM, Dan Carpenter wrote:

On Fri, Dec 31, 2010 at 11:43:30PM -0800, Justin P. Mattock wrote:

On 12/31/2010 10:48 PM, Finn Thain wrote:

-/*  BIT[8-9] is for SW Antenna Diversity. Only the value EEPROM_SW_AD_ENABLE 
means enable, other values are diable.*/
+/*  BIT[8-9] is for SW Antenna Diversity. Only the value EEPROM_SW_AD_ENABLE 
means enable, other values are disabled.  */


I think, other values disable was what you meant?

Finn


  #define EEPROM_SW_AD_MASK 0x0300
  #define EEPROM_SW_AD_ENABLE   0x0100






no! I changed it to disabled to make it proper..


Finn is obviously right, but maybe a compromise would be:

Only the value EEPROM_SW_AD_ENABLE means enable, other values mean
disable.

regards,
dan carpenter



ahh.. I see what you your saying now.. alright let me send this out that 
way..


Justin P. Mattock
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 14/15]include:media:davinci:vpss.h Typo change diable to disable.

[Justin P. Mattock]

On 12/31/2010 02:27 AM, Mauro Carvalho Chehab wrote:

Em 30-12-2010 21:08, Justin P. Mattock escreveu:

The below patch fixes a typo diable to disable. Please let me know if this
is correct or not.

Signed-off-by: Justin P. Mattockjustinmatt...@gmail.com

Acked-by: Mauro Carvalho Chehabmche...@redhat.com

PS.: Next time, please c/c linux-media ONLY on patches related to media
drivers (/drivers/video and the corresponding include files). Having to
dig into a series of 15 patches to just actually look on 3 patches
is not nice.



alright...



---
  include/media/davinci/vpss.h |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/media/davinci/vpss.h b/include/media/davinci/vpss.h
index c59cc02..b586495 100644
--- a/include/media/davinci/vpss.h
+++ b/include/media/davinci/vpss.h
@@ -44,7 +44,7 @@ struct vpss_pg_frame_size {
short pplen;
  };

-/* Used for enable/diable VPSS Clock */
+/* Used for enable/disable VPSS Clock */
  enum vpss_clock_sel {
/* DM355/DM365 */
VPSS_CCDC_CLOCK,





Justin P. Mattock
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.

[Justin P. Mattock]

On 12/31/2010 01:11 AM, Dan Carpenter wrote:

On Thu, Dec 30, 2010 at 10:52:30PM -0800, Justin P. Mattock wrote:

On 12/30/2010 10:45 PM, Grant Likely wrote:

On Thu, Dec 30, 2010 at 03:07:51PM -0800, Justin P. Mattock wrote:

The below patch fixes a typo diable to disable. Please let me know if this
is correct or not.

Signed-off-by: Justin P. Mattockjustinmatt...@gmail.com


applied, thanks.

g.


ahh.. thanks.. just cleared up the left out diabled that I had
thought I forgotten(ended up separating comments and code and
forgot)


This is really just defensiveness and random grumbling and grumpiness on
my part, but one reason I may have missed the first patch is because
your subject lines are crap.

Wrong:  [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.

Right:  [PATCH 02/15] spi/dw_spi: Typo change diable to disable

regards,
dan carpenter



alright.. so having the backlash is alright for the subject

Thanks for the pointer on this..

Justin P. Mattock
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 04/15]drivers:staging:comedi:drivers:das800.c Typo change diable to disable.

[Justin P. Mattock]

The below patch fixes a typo diable to disable. Please let me know if this 
is correct or not.

Signed-off-by: Justin P. Mattock justinmatt...@gmail.com

---
 drivers/staging/comedi/drivers/das800.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/comedi/drivers/das800.c 
b/drivers/staging/comedi/drivers/das800.c
index aecaedc..3ecae47 100644
--- a/drivers/staging/comedi/drivers/das800.c
+++ b/drivers/staging/comedi/drivers/das800.c
@@ -450,7 +450,7 @@ static irqreturn_t das800_interrupt(int irq, void *d)
/* otherwise, stop taking data */
} else {
spin_unlock_irqrestore(dev-spinlock, irq_flags);
-   disable_das800(dev);/* diable hardware triggered 
conversions */
+   disable_das800(dev);/* disable hardware triggered 
conversions */
async-events |= COMEDI_CB_EOA;
}
comedi_event(dev, s);
-- 
1.6.5.2.180.gc5b3e

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 06/15]drivers:staging:xgifb:vb_setmode.c Typo change diable to disable.

[Justin P. Mattock]

The below patch fixes a typo diable to disable. Please let me know if this 
is correct or not.

Signed-off-by: Justin P. Mattock justinmatt...@gmail.com

---
 drivers/staging/xgifb/vb_setmode.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/xgifb/vb_setmode.c 
b/drivers/staging/xgifb/vb_setmode.c
index 7016fdd..fb49641 100644
--- a/drivers/staging/xgifb/vb_setmode.c
+++ b/drivers/staging/xgifb/vb_setmode.c
@@ -1920,7 +1920,7 @@ void XGI_SetCRT1FIFO(unsigned short ModeNo,
 
data = XGINew_GetReg1(pVBInfo-P3c4, 0x3D);
data = 0xfe;
-   XGINew_SetReg1(pVBInfo-P3c4, 0x3D, data); /* diable auto-threshold */
+   XGINew_SetReg1(pVBInfo-P3c4, 0x3D, data); /* disable auto-threshold */
 
if (ModeNo  0x13) {
XGINew_SetReg1(pVBInfo-P3c4, 0x08, 0x34);
-- 
1.6.5.2.180.gc5b3e

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 05/15]drivers:staging:vt6655:rf.c Typo change diable to disable.

[Justin P. Mattock]

The below patch fixes a typo diable to disable. Please let me know if this 
is correct or not.

Signed-off-by: Justin P. Mattock justinmatt...@gmail.com

---
 drivers/staging/vt6655/rf.c |6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/vt6655/rf.c b/drivers/staging/vt6655/rf.c
index b8ec783..cdd9165 100644
--- a/drivers/staging/vt6655/rf.c
+++ b/drivers/staging/vt6655/rf.c
@@ -496,11 +496,11 @@ bool s_bAL7230Init (unsigned long dwIoBase)
 
 //Calibration
 MACvTimer0MicroSDelay(dwIoBase, 150);//150us
-bResult = IFRFbWriteEmbeded(dwIoBase, 
(0x9ABA8F00+(BY_AL7230_REG_LEN3)+IFREGCTL_REGW)); //TXDCOC:active, RCK:diable
+bResult = IFRFbWriteEmbeded(dwIoBase, 
(0x9ABA8F00+(BY_AL7230_REG_LEN3)+IFREGCTL_REGW)); //TXDCOC:active, RCK:disable
 MACvTimer0MicroSDelay(dwIoBase, 30);//30us
-bResult = IFRFbWriteEmbeded(dwIoBase, 
(0x3ABA8F00+(BY_AL7230_REG_LEN3)+IFREGCTL_REGW)); //TXDCOC:diable, RCK:active
+bResult = IFRFbWriteEmbeded(dwIoBase, 
(0x3ABA8F00+(BY_AL7230_REG_LEN3)+IFREGCTL_REGW)); //TXDCOC:disable, RCK:active
 MACvTimer0MicroSDelay(dwIoBase, 30);//30us
-bResult = IFRFbWriteEmbeded(dwIoBase, 
dwAL7230InitTable[CB_AL7230_INIT_SEQ-1]); //TXDCOC:diable, RCK:diable
+bResult = IFRFbWriteEmbeded(dwIoBase, 
dwAL7230InitTable[CB_AL7230_INIT_SEQ-1]); //TXDCOC:diable, RCK:disable
 
 MACvWordRegBitsOn(dwIoBase, MAC_REG_SOFTPWRCTL, (SOFTPWRCTL_SWPE3|
  SOFTPWRCTL_SWPE2|
-- 
1.6.5.2.180.gc5b3e

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 08/15]drivers:scsi:lpfc:lpfc_init.c Typo change diable to disable.

[Justin P. Mattock]

The below patch fixes a typo diable to disable. Please let me know if this 
is correct or not.

Signed-off-by: Justin P. Mattock justinmatt...@gmail.com

---
 drivers/scsi/lpfc/lpfc_init.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
index b306579..a921f16 100644
--- a/drivers/scsi/lpfc/lpfc_init.c
+++ b/drivers/scsi/lpfc/lpfc_init.c
@@ -7661,7 +7661,7 @@ lpfc_pci_remove_one_s3(struct pci_dev *pdev)
 * the HBA.
 */
 
-   /* HBA interrupt will be diabled after this call */
+   /* HBA interrupt will be disabled after this call */
lpfc_sli_hba_down(phba);
/* Stop kthread signal shall trigger work_done one more time */
kthread_stop(phba-worker_thread);
-- 
1.6.5.2.180.gc5b3e

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 10/15]drivers:usb:gadget:langwell Typo change diable to disable.

[Justin P. Mattock]

The below patch fixes a typo diable to disable. Please let me know if this 
is correct or not. 

Signed-off-by: Justin P. Mattock justinmatt...@gmail.com

---
 drivers/usb/gadget/langwell_udc.c |4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/gadget/langwell_udc.c 
b/drivers/usb/gadget/langwell_udc.c
index b8ec954..dad278f 100644
--- a/drivers/usb/gadget/langwell_udc.c
+++ b/drivers/usb/gadget/langwell_udc.c
@@ -3063,7 +3063,7 @@ static void langwell_udc_remove(struct pci_dev *pdev)
 
kfree(dev-ep);
 
-   /* diable IRQ handler */
+   /* disable IRQ handler */
if (dev-got_irq)
free_irq(pdev-irq, dev);
 
@@ -3383,7 +3383,7 @@ static int langwell_udc_suspend(struct pci_dev *pdev, 
pm_message_t state)
/* disable interrupt and set controller to stop state */
langwell_udc_stop(dev);
 
-   /* diable IRQ handler */
+   /* disable IRQ handler */
if (dev-got_irq)
free_irq(pdev-irq, dev);
dev-got_irq = 0;
-- 
1.6.5.2.180.gc5b3e

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 11/15]drivers:media:video:cx18:cx23418.h Typo change diable to disable.

[Justin P. Mattock]

The below patch fixes a typo diable to disable. Please let me know if this 
is correct or not.

Signed-off-by: Justin P. Mattock justinmatt...@gmail.com

---
 drivers/media/video/cx18/cx23418.h |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/media/video/cx18/cx23418.h 
b/drivers/media/video/cx18/cx23418.h
index 2c00980..7e40035 100644
--- a/drivers/media/video/cx18/cx23418.h
+++ b/drivers/media/video/cx18/cx23418.h
@@ -177,7 +177,7 @@
IN[0] - Task handle.
IN[1] - luma type: 0 = disable, 1 = 1D horizontal only, 2 = 1D vertical 
only,
  3 = 2D H/V separable, 4 = 2D symmetric non-separable
-   IN[2] - chroma type: 0 - diable, 1 = 1D horizontal
+   IN[2] - chroma type: 0 - disable, 1 = 1D horizontal
ReturnCode - One of the ERR_CAPTURE_... */
 #define CX18_CPU_SET_SPATIAL_FILTER_TYPE   (CPU_CMD_MASK_CAPTURE | 0x000C)
 
-- 
1.6.5.2.180.gc5b3e

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 12/15]drivers:media:video:tvp7002.c Typo change diable to disable.

[Justin P. Mattock]

The below patch fixes a typo diable to disable. Please let me know if this 
is correct or not.

Signed-off-by: Justin P. Mattock justinmatt...@gmail.com

---
 drivers/media/video/tvp7002.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/media/video/tvp7002.c b/drivers/media/video/tvp7002.c
index e63b40f..c799e4e 100644
--- a/drivers/media/video/tvp7002.c
+++ b/drivers/media/video/tvp7002.c
@@ -789,7 +789,7 @@ static int tvp7002_query_dv_preset(struct v4l2_subdev *sd,
  * Get the value of a TVP7002 decoder device register.
  * Returns zero when successful, -EINVAL if register read fails or
  * access to I2C client fails, -EPERM if the call is not allowed
- * by diabled CAP_SYS_ADMIN.
+ * by disabled CAP_SYS_ADMIN.
  */
 static int tvp7002_g_register(struct v4l2_subdev *sd,
struct v4l2_dbg_register *reg)
-- 
1.6.5.2.180.gc5b3e

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 14/15]include:media:davinci:vpss.h Typo change diable to disable.

[Justin P. Mattock]

The below patch fixes a typo diable to disable. Please let me know if this 
is correct or not.

Signed-off-by: Justin P. Mattock justinmatt...@gmail.com

---
 include/media/davinci/vpss.h |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/media/davinci/vpss.h b/include/media/davinci/vpss.h
index c59cc02..b586495 100644
--- a/include/media/davinci/vpss.h
+++ b/include/media/davinci/vpss.h
@@ -44,7 +44,7 @@ struct vpss_pg_frame_size {
short pplen;
 };
 
-/* Used for enable/diable VPSS Clock */
+/* Used for enable/disable VPSS Clock */
 enum vpss_clock_sel {
/* DM355/DM365 */
VPSS_CCDC_CLOCK,
-- 
1.6.5.2.180.gc5b3e

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 15/15]drivers:spi:dw_spi.c Typo change diable to disable.

[Justin P. Mattock]

The below patch fixes a typo diable to disable. Please let me know if this
is correct or not.

Signed-off-by: Justin P. Mattock justinmatt...@gmail.com

---
 drivers/spi/dw_spi.c |6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/spi/dw_spi.c b/drivers/spi/dw_spi.c
index 7c3cf21..a3a065f 100644
--- a/drivers/spi/dw_spi.c
+++ b/drivers/spi/dw_spi.c
@@ -910,12 +910,12 @@ int __devinit dw_spi_add_host(struct dw_spi *dws)
ret = init_queue(dws);
if (ret) {
dev_err(master-dev, problem initializing queue\n);
-   goto err_diable_hw;
+   goto err_disable_hw;
}
ret = start_queue(dws);
if (ret) {
dev_err(master-dev, problem starting queue\n);
-   goto err_diable_hw;
+   goto err_disable_hw;
}
 
spi_master_set_devdata(master, dws);
@@ -930,7 +930,7 @@ int __devinit dw_spi_add_host(struct dw_spi *dws)
 
 err_queue_alloc:
destroy_queue(dws);
-err_diable_hw:
+err_disable_hw:
spi_enable_chip(dws, 0);
free_irq(dws-irq, dws);
 err_free_master:
-- 
1.6.5.2.180.gc5b3e

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 13/15]drivers:isdn:mISDN:dsp_cmx.c Typo change diable to disable.

[Justin P. Mattock]

The below patch fixes a typo diable to disable. Please let me know if this 
is correct or not.

Signed-off-by: Justin P. Mattock justinmatt...@gmail.com

---
 drivers/isdn/mISDN/dsp_cmx.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/isdn/mISDN/dsp_cmx.c b/drivers/isdn/mISDN/dsp_cmx.c
index 76d9e67..309bacf 100644
--- a/drivers/isdn/mISDN/dsp_cmx.c
+++ b/drivers/isdn/mISDN/dsp_cmx.c
@@ -112,7 +112,7 @@
  * Disable rx-data:
  * If cmx is realized in hardware, rx data will be disabled if requested by
  * the upper layer. If dtmf decoding is done by software and enabled, rx data
- * will not be diabled but blocked to the upper layer.
+ * will not be disabled but blocked to the upper layer.
  *
  * HFC conference engine:
  * If it is possible to realize all features using hardware, hardware will be
-- 
1.6.5.2.180.gc5b3e

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 09/15]drivers:usb:host Typo change diable to disable.

[Justin P. Mattock]

The below patch fixes a typo diable to disable and also fixes another typo 
in a comment. 
Please let me know if this is correct or not.

Signed-off-by: Justin P. Mattock justinmatt...@gmail.com

---
 drivers/usb/host/fhci-hcd.c |4 ++--
 drivers/usb/host/fhci-tds.c |4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/host/fhci-hcd.c b/drivers/usb/host/fhci-hcd.c
index 20092a2..12fd184 100644
--- a/drivers/usb/host/fhci-hcd.c
+++ b/drivers/usb/host/fhci-hcd.c
@@ -98,13 +98,13 @@ void fhci_usb_enable_interrupt(struct fhci_usb *usb)
usb-intr_nesting_cnt--;
 }
 
-/* diable the usb interrupt */
+/* disable the usb interrupt */
 void fhci_usb_disable_interrupt(struct fhci_usb *usb)
 {
struct fhci_hcd *fhci = usb-fhci;
 
if (usb-intr_nesting_cnt == 0) {
-   /* diable the timer interrupt */
+   /* disable the timer interrupt */
disable_irq_nosync(fhci-timer-irq);
 
/* disable the usb interrupt */
diff --git a/drivers/usb/host/fhci-tds.c b/drivers/usb/host/fhci-tds.c
index 7be548c..38fe058 100644
--- a/drivers/usb/host/fhci-tds.c
+++ b/drivers/usb/host/fhci-tds.c
@@ -271,8 +271,8 @@ void fhci_init_ep_registers(struct fhci_usb *usb, struct 
endpoint *ep,
 
 /*
  * Collect the submitted frames and inform the application about them
- * It is also prepearing the TDs for new frames. If the Tx interrupts
- * are diabled, the application should call that routine to get
+ * It is also preparing the TDs for new frames. If the Tx interrupts
+ * are disabled, the application should call that routine to get
  * confirmation about the submitted frames. Otherwise, the routine is
  * called frome the interrupt service routine during the Tx interrupt.
  * In that case the application is informed by calling the application
-- 
1.6.5.2.180.gc5b3e

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 07/15]drivers:net:wireless:iwlwifi Typo change diable to disable.

[Justin P. Mattock]

The below patch fixes a typo diable to disable. Please let me know if this 
is correct or not.

Signed-off-by: Justin P. Mattock justinmatt...@gmail.com

---
 drivers/net/wireless/iwlwifi/iwl-agn-ict.c |2 +-
 drivers/net/wireless/iwlwifi/iwl-agn.c |4 ++--
 drivers/net/wireless/iwlwifi/iwl-core.c|2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-ict.c 
b/drivers/net/wireless/iwlwifi/iwl-agn-ict.c
index a5dbfea..b5cb3be 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn-ict.c
+++ b/drivers/net/wireless/iwlwifi/iwl-agn-ict.c
@@ -197,7 +197,7 @@ static irqreturn_t iwl_isr(int irq, void *data)
 
  none:
/* re-enable interrupts here since we don't have anything to service. */
-   /* only Re-enable if diabled by irq  and no schedules tasklet. */
+   /* only Re-enable if disabled by irq  and no schedules tasklet. */
if (test_bit(STATUS_INT_ENABLED, priv-status)  !priv-_agn.inta)
iwl_enable_interrupts(priv);
 
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn.c 
b/drivers/net/wireless/iwlwifi/iwl-agn.c
index c2636a7..9b912c0 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn.c
+++ b/drivers/net/wireless/iwlwifi/iwl-agn.c
@@ -1316,7 +1316,7 @@ static void iwl_irq_tasklet_legacy(struct iwl_priv *priv)
}
 
/* Re-enable all interrupts */
-   /* only Re-enable if diabled by irq */
+   /* only Re-enable if disabled by irq */
if (test_bit(STATUS_INT_ENABLED, priv-status))
iwl_enable_interrupts(priv);
 
@@ -1530,7 +1530,7 @@ static void iwl_irq_tasklet(struct iwl_priv *priv)
}
 
/* Re-enable all interrupts */
-   /* only Re-enable if diabled by irq */
+   /* only Re-enable if disabled by irq */
if (test_bit(STATUS_INT_ENABLED, priv-status))
iwl_enable_interrupts(priv);
 }
diff --git a/drivers/net/wireless/iwlwifi/iwl-core.c 
b/drivers/net/wireless/iwlwifi/iwl-core.c
index 25fb391..8700ab3 100644
--- a/drivers/net/wireless/iwlwifi/iwl-core.c
+++ b/drivers/net/wireless/iwlwifi/iwl-core.c
@@ -1304,7 +1304,7 @@ irqreturn_t iwl_isr_legacy(int irq, void *data)
 
  none:
/* re-enable interrupts here since we don't have anything to service. */
-   /* only Re-enable if diabled by irq */
+   /* only Re-enable if disabled by irq */
if (test_bit(STATUS_INT_ENABLED, priv-status))
iwl_enable_interrupts(priv);
spin_unlock_irqrestore(priv-lock, flags);
-- 
1.6.5.2.180.gc5b3e

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 01/15]arch:m68k:ifpsp060:src:fpsp.S Typo change diable to disable.

[Justin P. Mattock]

The below patch fixes a typo diable to disable. Please let me know if this 
is correct or not.

Signed-off-by: Justin P. Mattock justinmatt...@gmail.com

---
 arch/m68k/ifpsp060/src/fpsp.S |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/m68k/ifpsp060/src/fpsp.S b/arch/m68k/ifpsp060/src/fpsp.S
index 73613b5..26e85e2 100644
--- a/arch/m68k/ifpsp060/src/fpsp.S
+++ b/arch/m68k/ifpsp060/src/fpsp.S
@@ -3881,7 +3881,7 @@ _fpsp_fline:
 # FP Unimplemented Instruction stack frame and jump to that entry
 # point.
 #
-# but, if the FPU is disabled, then we need to jump to the FPU diabled
+# but, if the FPU is disabled, then we need to jump to the FPU disabled
 # entry point.
movc%pcr,%d0
btst0x1,%d0
-- 
1.6.5.2.180.gc5b3e

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.

[Justin P. Mattock]

The below patch fixes a typo diable to disable. Please let me know if this 
is correct or not.

Signed-off-by: Justin P. Mattock justinmatt...@gmail.com

---
 drivers/spi/dw_spi.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/spi/dw_spi.c b/drivers/spi/dw_spi.c
index 0838c79..7c3cf21 100644
--- a/drivers/spi/dw_spi.c
+++ b/drivers/spi/dw_spi.c
@@ -592,7 +592,7 @@ static void pump_transfers(unsigned long data)
spi_set_clk(dws, clk_div ? clk_div : chip-clk_div);
spi_chip_sel(dws, spi-chip_select);
 
-   /* Set the interrupt mask, for poll mode just diable all int */
+   /* Set the interrupt mask, for poll mode just disable all int */
spi_mask_intr(dws, 0xff);
if (imask)
spi_umask_intr(dws, imask);
-- 
1.6.5.2.180.gc5b3e

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 03/15]drivers:staging:rtl8187se:r8180_hw.h Typo change diable to disable.

[Justin P. Mattock]

The below patch fixes a typo diable to disable. Please let me know if this 
is correct or not.

Signed-off-by: Justin P. Mattock justinmatt...@gmail.com

---
 drivers/staging/rtl8187se/r8180_hw.h |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/rtl8187se/r8180_hw.h 
b/drivers/staging/rtl8187se/r8180_hw.h
index 3fca144..2911d40 100644
--- a/drivers/staging/rtl8187se/r8180_hw.h
+++ b/drivers/staging/rtl8187se/r8180_hw.h
@@ -554,7 +554,7 @@
 /* by amy for power save   */
 /* by amy for antenna  */
 #define EEPROM_SW_REVD_OFFSET 0x3f
-/*  BIT[8-9] is for SW Antenna Diversity. Only the value EEPROM_SW_AD_ENABLE 
means enable, other values are diable.*/
+/*  BIT[8-9] is for SW Antenna Diversity. Only the value EEPROM_SW_AD_ENABLE 
means enable, other values are disabled.  */
 #define EEPROM_SW_AD_MASK  0x0300
 #define EEPROM_SW_AD_ENABLE0x0100
 
-- 
1.6.5.2.180.gc5b3e

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.

[Justin P. Mattock]

On 12/30/2010 10:45 PM, Grant Likely wrote:

On Thu, Dec 30, 2010 at 03:07:51PM -0800, Justin P. Mattock wrote:

The below patch fixes a typo diable to disable. Please let me know if this
is correct or not.

Signed-off-by: Justin P. Mattockjustinmatt...@gmail.com


applied, thanks.

g.


ahh.. thanks.. just cleared up the left out diabled that I had thought I 
forgotten(ended up separating comments and code and forgot)




---
  drivers/spi/dw_spi.c |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/spi/dw_spi.c b/drivers/spi/dw_spi.c
index 0838c79..7c3cf21 100644
--- a/drivers/spi/dw_spi.c
+++ b/drivers/spi/dw_spi.c
@@ -592,7 +592,7 @@ static void pump_transfers(unsigned long data)
spi_set_clk(dws, clk_div ? clk_div : chip-clk_div);
spi_chip_sel(dws, spi-chip_select);

-   /* Set the interrupt mask, for poll mode just diable all int */
+   /* Set the interrupt mask, for poll mode just disable all int */
spi_mask_intr(dws, 0xff);
if (imask)
spi_umask_intr(dws, imask);
--
1.6.5.2.180.gc5b3e


--
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and,
should the need arise, upgrade to a full multi-node Oracle RAC database
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
___
spi-devel-general mailing list
spi-devel-gene...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general




Justin P. Mattock
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH]video:gspca.c Fix warning: case value '7' not in enumerated type 'enum v4l2_memory'

[Justin P. Mattock]

On 07/07/2010 11:40 PM, Jean-Francois Moine wrote:

On Wed,  7 Jul 2010 21:46:18 -0700
Justin P. Mattockjustinmatt...@gmail.com  wrote:


This fixes a warning I'm seeing when building:
   CC [M]  drivers/media/video/gspca/gspca.o
drivers/media/video/gspca/gspca.c: In function 'vidioc_reqbufs':
drivers/media/video/gspca/gspca.c:1508:2: warning: case value '7' not
in enumerated type 'enum v4l2_memory'


Hi Justin,

I don't agree with your patch: the value GSPCA_MEMORY_READ must not be
seen by user applications.

The warning may be simply fixed by (change the line numbers):

--- gspca.c~2010-07-08 08:15:14.0 +0200
+++ gspca.c 2010-07-08 08:28:52.0 +0200
@@ -1467,7 +1467,8 @@ static int vidioc_reqbufs(struct file *f
struct gspca_dev *gspca_dev = priv;
int i, ret = 0, streaming;

-   switch (rb-memory) {
+   i = rb-memory;  /* (avoid compilation warning) */
+   switch (i) {
case GSPCA_MEMORY_READ: /* (internal call) */
case V4L2_MEMORY_MMAP:
case V4L2_MEMORY_USERPTR:

Cheers.




o.k. buddy.. make sense with the userspace etc..
Anyways looks good, builds without a warning..

Tested-By: Justin P. Mattock justinmatt...@gmail.com

cheers as well,

Justin P. Mattock
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH]video:gspca.c Fix warning: case value '7' not in enumerated type 'enum v4l2_memory'

[Justin P. Mattock]

This fixes a warning I'm seeing when building:
  CC [M]  drivers/media/video/gspca/gspca.o
drivers/media/video/gspca/gspca.c: In function 'vidioc_reqbufs':
drivers/media/video/gspca/gspca.c:1508:2: warning: case value '7' not in 
enumerated type 'enum v4l2_memory'

Signed-off-by: Justin P. Mattock justinmatt...@gmail.com

---
 drivers/media/video/gspca/gspca.c |1 -
 include/linux/videodev2.h |1 +
 2 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/media/video/gspca/gspca.c 
b/drivers/media/video/gspca/gspca.c
index 678675b..a9b4d97 100644
--- a/drivers/media/video/gspca/gspca.c
+++ b/drivers/media/video/gspca/gspca.c
@@ -84,7 +84,6 @@ static void PDEBUG_MODE(char *txt, __u32 pixfmt, int w, int h)
 
 /* specific memory types - !! should be different from V4L2_MEMORY_xxx */
 #define GSPCA_MEMORY_NO 0  /* V4L2_MEMORY_xxx starts from 1 */
-#define GSPCA_MEMORY_READ 7
 
 #define BUF_ALL_FLAGS (V4L2_BUF_FLAG_QUEUED | V4L2_BUF_FLAG_DONE)
 
diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h
index 047f7e6..b73aa18 100644
--- a/include/linux/videodev2.h
+++ b/include/linux/videodev2.h
@@ -170,6 +170,7 @@ enum v4l2_memory {
V4L2_MEMORY_MMAP = 1,
V4L2_MEMORY_USERPTR  = 2,
V4L2_MEMORY_OVERLAY  = 3,
+   GSPCA_MEMORY_READ= 7,
 };
 
 /* see also http://vektor.theorem.ca/graphics/ycbcr/ */
-- 
1.7.1.rc1.21.gf3bd6

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 8/8 v2]tuners:tuner-simple Fix warning: variable 'tun' set but not used

[Justin P. Mattock]

Resend due to a whitespace issue I created by mistake.
The below patch fixes a warning message create by gcc 4.6.0
 
 CC [M]  drivers/media/common/tuners/tuner-simple.o
drivers/media/common/tuners/tuner-simple.c: In function 'simple_set_tv_freq':
drivers/media/common/tuners/tuner-simple.c:548:20: warning: variable 'tun' set 
but not used

 Signed-off-by: Justin P. Mattock justinmatt...@gmail.com
 Reviewed-By: Mauro Carvalho Chehab mche...@redhat.com

---
 drivers/media/common/tuners/tuner-simple.c |3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/drivers/media/common/tuners/tuner-simple.c 
b/drivers/media/common/tuners/tuner-simple.c
index 8abbcc5..84900fa 100644
--- a/drivers/media/common/tuners/tuner-simple.c
+++ b/drivers/media/common/tuners/tuner-simple.c
@@ -545,14 +545,11 @@ static int simple_set_tv_freq(struct dvb_frontend *fe,
struct tuner_simple_priv *priv = fe-tuner_priv;
u8 config, cb;
u16 div;
-   struct tunertype *tun;
u8 buffer[4];
int rc, IFPCoff, i;
enum param_type desired_type;
struct tuner_params *t_params;
 
-   tun = priv-tun;
-
/* IFPCoff = Video Intermediate Frequency - Vif:
940  =16*58.75  NTSC/J (Japan)
732  =16*45.75  M/N STD
-- 
1.7.1.rc1.21.gf3bd6

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 8/8 v2]tuners:tuner-simple Fix warning: variable 'tun' set but not used

[Justin P. Mattock]

On 06/21/2010 05:34 AM, Mauro Carvalho Chehab wrote:

Em Mon, 14 Jun 2010 22:48:34 -0700
Justin P. Mattockjustinmatt...@gmail.com  escreveu:


Resend due to a whitespace issue I created by mistake.
The below patch fixes a warning message create by gcc 4.6.0


It seems OK for me, but you shouldn't be sending it to be applied at 
reiserfs-devel ML.
Instead, it should be sent to linux-media ML, and applied via my tree.



I should of used get_maintainer.pl to find the correct list to send this 
too(instead I just looked into the MAINTAINERS file).

I'll resend.



  CC [M]  drivers/media/common/tuners/tuner-simple.o
drivers/media/common/tuners/tuner-simple.c: In function 'simple_set_tv_freq':
drivers/media/common/tuners/tuner-simple.c:548:20: warning: variable 'tun' set 
but not used

  Signed-off-by: Justin P. Mattockjustinmatt...@gmail.com
  Reviewed-By: Mauro Carvalho Chehabmche...@redhat.com

---
  drivers/media/common/tuners/tuner-simple.c |3 ---
  1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/drivers/media/common/tuners/tuner-simple.c 
b/drivers/media/common/tuners/tuner-simple.c
index 8abbcc5..84900fa 100644
--- a/drivers/media/common/tuners/tuner-simple.c
+++ b/drivers/media/common/tuners/tuner-simple.c
@@ -545,14 +545,11 @@ static int simple_set_tv_freq(struct dvb_frontend *fe,
struct tuner_simple_priv *priv = fe-tuner_priv;
u8 config, cb;
u16 div;
-   struct tunertype *tun;
u8 buffer[4];
int rc, IFPCoff, i;
enum param_type desired_type;
struct tuner_params *t_params;

-   tun = priv-tun;
-
/* IFPCoff = Video Intermediate Frequency - Vif:
940  =16*58.75  NTSC/J (Japan)
732  =16*45.75  M/N STD





Justin P. Mattock
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/8]drivers:tmp.c Fix warning: variable 'rc' set but not used

[Justin P. Mattock]

On 06/15/2010 02:19 AM, Jean Delvare wrote:

On Tue, 15 Jun 2010 07:29:44 +0200, Peter Stuge wrote:

Justin P. Mattock wrote:

*baffled* Why did you think that would work? transmit_cmd()s signature
has 4 parameters.


I have no manual in front of me. Did a quick google, but came up with
(no hits) info on what that function does. grep showed too many entries
to really see why/what this is.


Justin, I think you're on the wrong track here. You seem to be in a
hurry to fix all these warnings generated by gcc 4.6. There is no hurry
at all. Most warnings are false positives, and actual bugs may take
some thinking and knowledge. So rushing is not needed and not
desirable. Going too fast, you might even introduce new bugs, or
prevent old bugs from being properly fixed.

Warnings are a chance to make the code better. The goal is not to fix
them quickly, but to fix them properly. If this is not your intent,
then please stop immediately and let others deal with these warnings.
If you want to help, this is appreciated, but what we need it quality,
not quantity.



your right.. I do have this must get it fixed now, or else
cut your head of mentality.. causing me to rush through things..
who knows why I do this..(I dont know why I do this honestly)


Check out the tool cscope. (Or kscope, if you prefer a GUI.)


Or just LXR online if you don't want to install anything:

http://lxr.linux.no/linux
http://lxr.linux.no/#linux+v2.6.34/drivers/char/tpm/tpm.c#L451



At this point though gentlemen/ladies I'm pretty much crapped out now!!
so any answer is going to be skewed. but rushing through things is not 
good.


Justin P. Mattock

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 6/8]i2c:i2c_core Fix warning: variable 'dummy' set but not used

[Justin P. Mattock]

On 06/15/2010 04:43 AM, Jean Delvare wrote:

Hi Justin,

On Mon, 14 Jun 2010 14:06:12 -0700, Justin P. Mattock wrote:

On 06/14/2010 01:53 PM, Jean Delvare wrote:

Hi Justin,

On Mon, 14 Jun 2010 13:26:46 -0700, Justin P. Mattock wrote:

could be a right solution, could be wrong
here is the warning:
CC  drivers/i2c/i2c-core.o
drivers/i2c/i2c-core.c: In function 'i2c_register_adapter':
drivers/i2c/i2c-core.c:757:15: warning: variable 'dummy' set but not used

   Signed-off-by: Justin P. Mattockjustinmatt...@gmail.com

---
   drivers/i2c/i2c-core.c |2 ++
   1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
index 1cca263..79c6c26 100644
--- a/drivers/i2c/i2c-core.c
+++ b/drivers/i2c/i2c-core.c
@@ -794,6 +794,8 @@ static int i2c_register_adapter(struct i2c_adapter *adap)
mutex_lock(core_lock);
dummy = bus_for_each_drv(i2c_bus_type, NULL, adap,
 __process_new_adapter);
+   if(!dummy)
+   dummy = 0;


One word: scripts/checkpatch.pl


it was this, and/or just take the code out
(since I'm a newbie)


I was not (yet) arguing on the code itself, but on its format. Any
patch you send should pass the formatting tests performed by
scripts/checkpatch.pl. Thanks.




o.k.  I'll make sure I run everything through checkpatch.pl before 
sending anything.


Justin P. Mattock
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 7/8]ieee1394/sdp2 Fix warning: variable 'unit_characteristics' set but not used

[Justin P. Mattock]

On 06/15/2010 04:38 AM, Jean Delvare wrote:

On Mon, 14 Jun 2010 13:26:47 -0700, Justin P. Mattock wrote:

Temporary fix until something is resolved


This is wrong by design, sorry. Warnings aren't blocking, and thus need
no temporary fix. Such temporary fixes would be only hiding the
warning, cancelling the good work of gcc developers. Nack nack nack.



o.k.


to fix the below warning:
   CC [M]  drivers/ieee1394/sbp2.o
drivers/ieee1394/sbp2.c: In function 'sbp2_parse_unit_directory':
drivers/ieee1394/sbp2.c:1353:6: warning: variable 'unit_characteristics' set 
but not used
  Signed-off-by: Justin P. Mattockjustinmatt...@gmail.com

---
  drivers/ieee1394/sbp2.c |2 ++
  1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/ieee1394/sbp2.c b/drivers/ieee1394/sbp2.c
index 4565cb5..fcf8bd5 100644
--- a/drivers/ieee1394/sbp2.c
+++ b/drivers/ieee1394/sbp2.c
@@ -1356,6 +1356,8 @@ static void sbp2_parse_unit_directory(struct sbp2_lu *lu,

management_agent_addr = 0;
unit_characteristics = 0;
+   if (!unit_characteristics)
+   unit_characteristics = 0;
firmware_revision = SBP2_ROM_VALUE_MISSING;
model = ud-flags  UNIT_DIRECTORY_MODEL_ID ?
ud-model_id : SBP2_ROM_VALUE_MISSING;





Thanks for the response and info on this.

Justin P. Mattock
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/8]drivers:tmp.c Fix warning: variable 'rc' set but not used

[Justin P. Mattock]

On 06/15/2010 11:53 AM, Sergey V. wrote:

On Tuesday 15 of June 2010 00:26:44 Justin P. Mattock wrote:

Im getting this warning when compiling:
  CC  drivers/char/tpm/tpm.o
drivers/char/tpm/tpm.c: In function 'tpm_gen_interrupt':
drivers/char/tpm/tpm.c:508:10: warning: variable 'rc' set but not used

The below patch gets rid of the warning,
but I'm not sure if it's the best solution.

  Signed-off-by: Justin P. Mattockjustinmatt...@gmail.com

---
  drivers/char/tpm/tpm.c |2 ++
  1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/char/tpm/tpm.c b/drivers/char/tpm/tpm.c
index 05ad4a1..3d685dc 100644
--- a/drivers/char/tpm/tpm.c
+++ b/drivers/char/tpm/tpm.c
@@ -514,6 +514,8 @@ void tpm_gen_interrupt(struct tpm_chip *chip)

rc = transmit_cmd(chip,tpm_cmd, TPM_INTERNAL_RESULT_SIZE,
attempting to determine the timeouts);
+   if (!rc)
+   rc = 0;
  }
  EXPORT_SYMBOL_GPL(tpm_gen_interrupt);

--
1.7.1.rc1.21.gf3bd6



Hi Justin

IMHO
See code of functions tpm_transmit(), transmit_cmd and tpm_gen_interrupt().
In tpm_gen_interrupt() not need check rc for wrong value bacause if in function
transmit_cmd() len == TPM_ERROR_SIZE then put a debug message (dev_dbg()).
Again, if something wrong in tpm_transmit() then runs dev_err() and rc in
tpm_gen_interrupt() get -E* value.
So, we can remove unused rc variable in tpm_gen_interrupt().

See patch below. Note: I not tested it.


Subject: [PATCH] drivers: tpm.c: Remove unused variable 'rc'

---
  drivers/char/tpm/tpm.c |5 ++---
  1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/char/tpm/tpm.c b/drivers/char/tpm/tpm.c
index 05ad4a1..f9f5b47 100644
--- a/drivers/char/tpm/tpm.c
+++ b/drivers/char/tpm/tpm.c
@@ -505,15 +505,14 @@ ssize_t tpm_getcap(struct device *dev, __be32 subcap_id,
cap_t *cap,
  void tpm_gen_interrupt(struct tpm_chip *chip)
  {
struct  tpm_cmd_t tpm_cmd;
-   ssize_t rc;

tpm_cmd.header.in = tpm_getcap_header;
tpm_cmd.params.getcap_in.cap = TPM_CAP_PROP;
tpm_cmd.params.getcap_in.subcap_size = cpu_to_be32(4);
tpm_cmd.params.getcap_in.subcap = TPM_CAP_PROP_TIS_TIMEOUT;

-   rc = transmit_cmd(chip,tpm_cmd, TPM_INTERNAL_RESULT_SIZE,
-   attempting to determine the timeouts);
+   transmit_cmd(chip,tpm_cmd, TPM_INTERNAL_RESULT_SIZE,
+attempting to determine the timeouts);
  }
  EXPORT_SYMBOL_GPL(tpm_gen_interrupt);





o.k. applied this patch and rebuilt, here is what I see:

  CC [M]  drivers/char/ipmi/ipmi_poweroff.o
  CC  drivers/char/tpm/tpm.o
  CC  drivers/char/tpm/tpm_bios.o
  CC  drivers/char/tpm/tpm_tis.o
  LD  drivers/char/tpm/built-in.o


looks good over here Thanks for sending this..

Justin P. Mattock
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 0/8] Fix gcc 4.6.0 set but not used warning messages.

[Justin P. Mattock]

First and foremost, I must
thank anybody taking the time to even
look at these(I know you people have better
things to be doing).

And secondly here is my try at trying
to fix some of the warning messages
spammed by gcc 4.6.0 when building the
kernel. Some of them I removed, and
some of them I just shut off.

Note: Removing the code does seem like a
good approach(if it's actually dead),
but if not then something needs
to be fixed.
As for shutting off the code to shutup gcc
does seem like a temporary fix, but would
rather have a warning message, than see it get
lost in the sands of time.

In any case Thanks for taking the time,
and hopefully we can get fixes for all of
this mess generated by gcc..

Justin P. Mattock

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 8/8]tuners:tuner-simple Fix warning: variable 'tun' set but not used

[Justin P. Mattock]

not sure if this is correct or not for 
fixing this warning:
  CC [M]  drivers/media/common/tuners/tuner-simple.o
drivers/media/common/tuners/tuner-simple.c: In function 'simple_set_tv_freq':
drivers/media/common/tuners/tuner-simple.c:548:20: warning: variable 'tun' set 
but not used

 Signed-off-by: Justin P. Mattock justinmatt...@gmail.com

---
 drivers/media/common/tuners/tuner-simple.c |4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/drivers/media/common/tuners/tuner-simple.c 
b/drivers/media/common/tuners/tuner-simple.c
index 8abbcc5..4465b99 100644
--- a/drivers/media/common/tuners/tuner-simple.c
+++ b/drivers/media/common/tuners/tuner-simple.c
@@ -545,14 +545,12 @@ static int simple_set_tv_freq(struct dvb_frontend *fe,
struct tuner_simple_priv *priv = fe-tuner_priv;
u8 config, cb;
u16 div;
-   struct tunertype *tun;
u8 buffer[4];
int rc, IFPCoff, i;
enum param_type desired_type;
struct tuner_params *t_params;
 
-   tun = priv-tun;
-
+   
/* IFPCoff = Video Intermediate Frequency - Vif:
940  =16*58.75  NTSC/J (Japan)
732  =16*45.75  M/N STD
-- 
1.7.1.rc1.21.gf3bd6

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 7/8]ieee1394/sdp2 Fix warning: variable 'unit_characteristics' set but not used

[Justin P. Mattock]

Temporary fix until something is resolved
to fix the below warning:
  CC [M]  drivers/ieee1394/sbp2.o
drivers/ieee1394/sbp2.c: In function 'sbp2_parse_unit_directory':
drivers/ieee1394/sbp2.c:1353:6: warning: variable 'unit_characteristics' set 
but not used
 Signed-off-by: Justin P. Mattock justinmatt...@gmail.com

---
 drivers/ieee1394/sbp2.c |2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/ieee1394/sbp2.c b/drivers/ieee1394/sbp2.c
index 4565cb5..fcf8bd5 100644
--- a/drivers/ieee1394/sbp2.c
+++ b/drivers/ieee1394/sbp2.c
@@ -1356,6 +1356,8 @@ static void sbp2_parse_unit_directory(struct sbp2_lu *lu,
 
management_agent_addr = 0;
unit_characteristics = 0;
+   if (!unit_characteristics)
+   unit_characteristics = 0;
firmware_revision = SBP2_ROM_VALUE_MISSING;
model = ud-flags  UNIT_DIRECTORY_MODEL_ID ?
ud-model_id : SBP2_ROM_VALUE_MISSING;
-- 
1.7.1.rc1.21.gf3bd6

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 5/8]drm:drm_gem Fix warning: variable 'dev' set but not used

[Justin P. Mattock]

Probably not even a fix for this warning:

  CC [M]  drivers/gpu/drm/drm_gem.o
drivers/gpu/drm/drm_gem.c: In function 'drm_gem_handle_delete':
drivers/gpu/drm/drm_gem.c:188:21: warning: variable 'dev' set but not used

 Signed-off-by: Justin P. Mattock justinmatt...@gmail.com

---
 drivers/gpu/drm/drm_gem.c |2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
index 33dad3f..e8180c9 100644
--- a/drivers/gpu/drm/drm_gem.c
+++ b/drivers/gpu/drm/drm_gem.c
@@ -206,6 +206,8 @@ drm_gem_handle_delete(struct drm_file *filp, u32 handle)
return -EINVAL;
}
dev = obj-dev;
+   if (!dev)
+   dev = 0;
 
/* Release reference and decrement refcount. */
idr_remove(filp-object_idr, handle);
-- 
1.7.1.rc1.21.gf3bd6

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/8]reiserfs:stree.c Fix variable set but not used.

[Justin P. Mattock]

Not sure if this is correct or not.
the below patch gets rid of this warning message
produced by gcc 4.6.0

fs/reiserfs/stree.c: In function 'search_by_key':
fs/reiserfs/stree.c:602:6: warning: variable 'right_neighbor_of_leaf_node' set 
but not used

 Signed-off-by: Justin P. Mattock justinmatt...@gmail.com

---
 fs/reiserfs/stree.c |7 ++-
 1 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/fs/reiserfs/stree.c b/fs/reiserfs/stree.c
index 313d39d..73086ad 100644
--- a/fs/reiserfs/stree.c
+++ b/fs/reiserfs/stree.c
@@ -599,7 +599,6 @@ int search_by_key(struct super_block *sb, const struct 
cpu_key *key,/* Key to s
struct buffer_head *bh;
struct path_element *last_element;
int node_level, retval;
-   int right_neighbor_of_leaf_node;
int fs_gen;
struct buffer_head *reada_bh[SEARCH_BY_KEY_READA];
b_blocknr_t reada_blocks[SEARCH_BY_KEY_READA];
@@ -617,8 +616,7 @@ int search_by_key(struct super_block *sb, const struct 
cpu_key *key,/* Key to s
 
pathrelse(search_path);
 
-   right_neighbor_of_leaf_node = 0;
-
+   
/* With each iteration of this loop we search through the items in the
   current node, and calculate the next current node(next path element)
   for the next iteration of this loop.. */
@@ -695,8 +693,7 @@ int search_by_key(struct super_block *sb, const struct 
cpu_key *key,/* Key to s
   starting from the root. */
block_number = SB_ROOT_BLOCK(sb);
expected_level = -1;
-   right_neighbor_of_leaf_node = 0;
-
+   
/* repeat search from the root */
continue;
}
-- 
1.7.1.rc1.21.gf3bd6

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 3/8]char/hpet.c Fix variable 'hpet' set but not used

[Justin P. Mattock]

The below fixes this warning:
drivers/char/hpet.c: In function 'hpet_ioctl_common':
drivers/char/hpet.c:559:23: warning: variable 'hpet' set but not used

please have a look.
 Signed-off-by: Justin P. Mattock justinmatt...@gmail.com

---
 drivers/char/hpet.c |2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c
index a0a1829..7932858 100644
--- a/drivers/char/hpet.c
+++ b/drivers/char/hpet.c
@@ -556,7 +556,6 @@ static int
 hpet_ioctl_common(struct hpet_dev *devp, int cmd, unsigned long arg, int 
kernel)
 {
struct hpet_timer __iomem *timer;
-   struct hpet __iomem *hpet;
struct hpets *hpetp;
int err;
unsigned long v;
@@ -568,7 +567,6 @@ hpet_ioctl_common(struct hpet_dev *devp, int cmd, unsigned 
long arg, int kernel)
case HPET_DPI:
case HPET_IRQFREQ:
timer = devp-hd_timer;
-   hpet = devp-hd_hpet;
hpetp = devp-hd_hpets;
break;
case HPET_IE_ON:
-- 
1.7.1.rc1.21.gf3bd6

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 6/8]i2c:i2c_core Fix warning: variable 'dummy' set but not used

[Justin P. Mattock]

could be a right solution, could be wrong
here is the warning:
  CC  drivers/i2c/i2c-core.o
drivers/i2c/i2c-core.c: In function 'i2c_register_adapter':
drivers/i2c/i2c-core.c:757:15: warning: variable 'dummy' set but not used
 
 Signed-off-by: Justin P. Mattock justinmatt...@gmail.com

---
 drivers/i2c/i2c-core.c |2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
index 1cca263..79c6c26 100644
--- a/drivers/i2c/i2c-core.c
+++ b/drivers/i2c/i2c-core.c
@@ -794,6 +794,8 @@ static int i2c_register_adapter(struct i2c_adapter *adap)
mutex_lock(core_lock);
dummy = bus_for_each_drv(i2c_bus_type, NULL, adap,
 __process_new_adapter);
+   if(!dummy)
+   dummy = 0;
mutex_unlock(core_lock);
 
return 0;
-- 
1.7.1.rc1.21.gf3bd6

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 4/8]drivers:tmp.c Fix warning: variable 'rc' set but not used

[Justin P. Mattock]

Im getting this warning when compiling:
 CC  drivers/char/tpm/tpm.o
drivers/char/tpm/tpm.c: In function 'tpm_gen_interrupt':
drivers/char/tpm/tpm.c:508:10: warning: variable 'rc' set but not used

The below patch gets rid of the warning,
but I'm not sure if it's the best solution.

 Signed-off-by: Justin P. Mattock justinmatt...@gmail.com

---
 drivers/char/tpm/tpm.c |2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/char/tpm/tpm.c b/drivers/char/tpm/tpm.c
index 05ad4a1..3d685dc 100644
--- a/drivers/char/tpm/tpm.c
+++ b/drivers/char/tpm/tpm.c
@@ -514,6 +514,8 @@ void tpm_gen_interrupt(struct tpm_chip *chip)
 
rc = transmit_cmd(chip, tpm_cmd, TPM_INTERNAL_RESULT_SIZE,
attempting to determine the timeouts);
+   if (!rc)
+   rc = 0;
 }
 EXPORT_SYMBOL_GPL(tpm_gen_interrupt);
 
-- 
1.7.1.rc1.21.gf3bd6

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/8]bluetooth/hci_ldisc.c Fix warning: variable 'tty' set but not used

[Justin P. Mattock]

Im getting this while building:
  CC [M]  drivers/bluetooth/hci_ldisc.o
drivers/bluetooth/hci_ldisc.c: In function 'hci_uart_send_frame':
drivers/bluetooth/hci_ldisc.c:213:21: warning: variable 'tty' set but not used

the below fixed it for me, but am not sure if
it's correct.

 Signed-off-by: Justin P. Mattock justinmatt...@gmail.com

---
 drivers/bluetooth/hci_ldisc.c |4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/drivers/bluetooth/hci_ldisc.c b/drivers/bluetooth/hci_ldisc.c
index 76a1abb..f693dfe 100644
--- a/drivers/bluetooth/hci_ldisc.c
+++ b/drivers/bluetooth/hci_ldisc.c
@@ -210,7 +210,6 @@ static int hci_uart_close(struct hci_dev *hdev)
 static int hci_uart_send_frame(struct sk_buff *skb)
 {
struct hci_dev* hdev = (struct hci_dev *) skb-dev;
-   struct tty_struct *tty;
struct hci_uart *hu;
 
if (!hdev) {
@@ -222,8 +221,7 @@ static int hci_uart_send_frame(struct sk_buff *skb)
return -EBUSY;
 
hu = (struct hci_uart *) hdev-driver_data;
-   tty = hu-tty;
-
+   
BT_DBG(%s: type %d len %d, hdev-name, bt_cb(skb)-pkt_type, 
skb-len);
 
hu-proto-enqueue(hu, skb);
-- 
1.7.1.rc1.21.gf3bd6

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 6/8]i2c:i2c_core Fix warning: variable 'dummy' set but not used

[Justin P. Mattock]

On 06/14/2010 01:53 PM, Jean Delvare wrote:

Hi Justin,

On Mon, 14 Jun 2010 13:26:46 -0700, Justin P. Mattock wrote:

could be a right solution, could be wrong
here is the warning:
   CC  drivers/i2c/i2c-core.o
drivers/i2c/i2c-core.c: In function 'i2c_register_adapter':
drivers/i2c/i2c-core.c:757:15: warning: variable 'dummy' set but not used

  Signed-off-by: Justin P. Mattockjustinmatt...@gmail.com

---
  drivers/i2c/i2c-core.c |2 ++
  1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
index 1cca263..79c6c26 100644
--- a/drivers/i2c/i2c-core.c
+++ b/drivers/i2c/i2c-core.c
@@ -794,6 +794,8 @@ static int i2c_register_adapter(struct i2c_adapter *adap)
mutex_lock(core_lock);
dummy = bus_for_each_drv(i2c_bus_type, NULL, adap,
 __process_new_adapter);
+   if(!dummy)
+   dummy = 0;


One word: scripts/checkpatch.pl


it was this, and/or just take the code out
(since I'm a newbie)



In other news, the above is just plain wrong. First we force people to
read the result of bus_for_each_drv() and then when they do and don't
need the value, gcc complains, so we add one more layer of useless
code, which developers and possibly tools will later wonder and
complain about? I can easily imagine that a static code analyzer would
spot the above code as being a potential bug.

Let's stop this madness now please.



your telling me!! I haven't even compiled all the way
through the kernel yet.(lots of warnings)


Either __must_check goes away from bus_for_each_drv() and from every
other function which raises this problem, or we must disable that new
type of warning gcc 4.6.0 generates. Depends which warnings we value
more, as we can't sanely have both.


mutex_unlock(core_lock);

return 0;





up to you guys..
best thing now is deciphering what
and what not is an actual issue.

Justin P. Mattock
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/8]reiserfs:stree.c Fix variable set but not used.

[Justin P. Mattock]

On 06/14/2010 02:05 PM, Edward Shishkin wrote:

Justin P. Mattock wrote:

Not sure if this is correct or not.
the below patch gets rid of this warning message
produced by gcc 4.6.0

fs/reiserfs/stree.c: In function 'search_by_key':
fs/reiserfs/stree.c:602:6: warning: variable
'right_neighbor_of_leaf_node' set but not used

Signed-off-by: Justin P. Mattock justinmatt...@gmail.com


Acked-by: Edward Shishkin edward.shish...@gmail.com



o.k.!!
what about the whitespace issue?
from what I remember I did notice the +
that git does when making patches like this
but given some many of these warnings I just
did a quick workaround or however then figured
to worry later on that.


---
fs/reiserfs/stree.c | 7 ++-
1 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/fs/reiserfs/stree.c b/fs/reiserfs/stree.c
index 313d39d..73086ad 100644
--- a/fs/reiserfs/stree.c
+++ b/fs/reiserfs/stree.c
@@ -599,7 +599,6 @@ int search_by_key(struct super_block *sb, const
struct cpu_key *key, /* Key to s
struct buffer_head *bh;
struct path_element *last_element;
int node_level, retval;
- int right_neighbor_of_leaf_node;
int fs_gen;
struct buffer_head *reada_bh[SEARCH_BY_KEY_READA];
b_blocknr_t reada_blocks[SEARCH_BY_KEY_READA];
@@ -617,8 +616,7 @@ int search_by_key(struct super_block *sb, const
struct cpu_key *key, /* Key to s

pathrelse(search_path);

- right_neighbor_of_leaf_node = 0;
-
+
/* With each iteration of this loop we search through the items in the
current node, and calculate the next current node(next path element)
for the next iteration of this loop.. */
@@ -695,8 +693,7 @@ int search_by_key(struct super_block *sb, const
struct cpu_key *key, /* Key to s
starting from the root. */
block_number = SB_ROOT_BLOCK(sb);
expected_level = -1;
- right_neighbor_of_leaf_node = 0;
-
+
/* repeat search from the root */
continue;
}





--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/8]reiserfs:stree.c Fix variable set but not used.

[Justin P. Mattock]

On 06/14/2010 02:47 PM, Edward Shishkin wrote:

Justin P. Mattock wrote:

On 06/14/2010 02:05 PM, Edward Shishkin wrote:

Justin P. Mattock wrote:

Not sure if this is correct or not.
the below patch gets rid of this warning message
produced by gcc 4.6.0

fs/reiserfs/stree.c: In function 'search_by_key':
fs/reiserfs/stree.c:602:6: warning: variable
'right_neighbor_of_leaf_node' set but not used

Signed-off-by: Justin P. Mattock justinmatt...@gmail.com


Acked-by: Edward Shishkin edward.shish...@gmail.com



o.k.!!
what about the whitespace issue?


Whitespaces should be removed.
I recommend quilt package for managing patches:
quilt refresh --strip-trailing-whitespace is your friend..

Thanks,
Edward.



o.k. I resent this.. fixed the whitespace(hopefully)
and add your Acked to it.
as for quilt I'll have to look into that..
(using a lfs system, so if the sourcecode is easy
to deal with(build), then it's a good but if it becomes
a nightmare maybe not!!).


Justin P. Mattock
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/8]reiserfs:stree.c Fix variable set but not used.

[Justin P. Mattock]

On 06/14/2010 04:07 PM, Stefan Richter wrote:

On 14 Jun, Justin P. Mattock wrote:

On 06/14/2010 02:47 PM, Edward Shishkin wrote:

Whitespaces should be removed.
I recommend quilt package for managing patches:
quilt refresh --strip-trailing-whitespace is your friend..


o.k. I resent this.. fixed the whitespace(hopefully)
and add your Acked to it.
as for quilt I'll have to look into that..
(using a lfs system, so if the sourcecode is easy
to deal with(build), then it's a good but if it becomes
a nightmare maybe not!!).


Since you appear to generate the patches with git, you can use git diff
--check [...] for some basic whitespace checks (additions of trailing
space, additions of space before tab).  For more extensive checks, try
git diff [...] | scripts/checkpatch.pl -.  Check this before you
commit.  If you committed already, git commit --amend [-a] [...] lets
you alter the very last commit of course.



Thanks for the info on this, copied it
down in my book of commands...

Justin P. Mattock
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/8]drivers:tmp.c Fix warning: variable 'rc' set but not used

[Justin P. Mattock]

On 06/14/2010 05:13 PM, valdis.kletni...@vt.edu wrote:

On Mon, 14 Jun 2010 13:26:44 PDT, Justin P. Mattock said:

Im getting this warning when compiling:
  CC  drivers/char/tpm/tpm.o
drivers/char/tpm/tpm.c: In function 'tpm_gen_interrupt':
drivers/char/tpm/tpm.c:508:10: warning: variable 'rc' set but not used

The below patch gets rid of the warning,
but I'm not sure if it's the best solution.



rc = transmit_cmd(chip,tpm_cmd, TPM_INTERNAL_RESULT_SIZE,
attempting to determine the timeouts);
+   if (!rc)
+   rc = 0;
  }


Good thing that's a void function. ;)

Unless transmit_cmd() is marked 'must_check', maybe losing the 'rc =' would
be a better solution?



what I tried was this:

if (!rc)
printk(test\n)

and everything looked good,
but as a soon as I changed

rc = transmit_cmd(chip,tpm_cmd, TPM_INTERNAL_RESULT_SIZE,
attempting to determine the timeouts);

to this:

rc = transmit_cmd(chip,tpm_cmd, TPM_INTERNAL_RESULT_SIZE);

if (!rc)
printk(attempting to determine the timeouts\n);

I error out with transmit_cmd not having enough
functions to it.. so I just added the rc = 0;
and went on to the next.

Justin P. Mattock
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/8]drivers:tmp.c Fix warning: variable 'rc' set but not used

[Justin P. Mattock]

On 06/14/2010 08:49 PM, valdis.kletni...@vt.edu wrote:

On Mon, 14 Jun 2010 19:12:31 PDT, Justin P. Mattock said:


what I tried was this:

if (!rc)
printk(test\n)

and everything looked good,
but as a soon as I changed

rc = transmit_cmd(chip,tpm_cmd, TPM_INTERNAL_RESULT_SIZE,
attempting to determine the timeouts);

to this:

rc = transmit_cmd(chip,tpm_cmd, TPM_INTERNAL_RESULT_SIZE);

if (!rc)
printk(attempting to determine the timeouts\n);


*baffled* Why did you think that would work? transmit_cmd()s signature
has 4 parameters.


I have no manual in front of me. Did a quick google, but came up with 
(no hits) info on what that function does. grep showed too many entries 
to really see why/what this is. So I kind of just scrambled with this one.


Justin P. Mattock
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 8/8]tuners:tuner-simple Fix warning: variable 'tun' set but not used

[Justin P. Mattock]

On 06/14/2010 10:16 PM, Mauro Carvalho Chehab wrote:



Em 14-06-2010 23:26, Justin P. Mattock escreveu:

not sure if this is correct or not for
fixing this warning:
   CC [M]  drivers/media/common/tuners/tuner-simple.o
drivers/media/common/tuners/tuner-simple.c: In function 'simple_set_tv_freq':
drivers/media/common/tuners/tuner-simple.c:548:20: warning: variable 'tun' set 
but not used

  Signed-off-by: Justin P. Mattockjustinmatt...@gmail.com

---
  drivers/media/common/tuners/tuner-simple.c |4 +---
  1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/drivers/media/common/tuners/tuner-simple.c 
b/drivers/media/common/tuners/tuner-simple.c
index 8abbcc5..4465b99 100644
--- a/drivers/media/common/tuners/tuner-simple.c
+++ b/drivers/media/common/tuners/tuner-simple.c
@@ -545,14 +545,12 @@ static int simple_set_tv_freq(struct dvb_frontend *fe,
struct tuner_simple_priv *priv = fe-tuner_priv;
u8 config, cb;
u16 div;
-   struct tunertype *tun;
u8 buffer[4];
int rc, IFPCoff, i;
enum param_type desired_type;
struct tuner_params *t_params;

-   tun = priv-tun;
-
+   

Why are you adding an extra blank line here? Except for that, the patch
looks sane.



I think I was doing something wrong when creating these patches. i.g.
I just hightlight the code then move the cursor highlight all the way to 
the right before pressing x. normally would be o.k. but for some 
reason seems to be doing this. found if I highlight left to ; (or the 
end of the code I want to delete) then git commit creates the patch 
properly.



/* IFPCoff = Video Intermediate Frequency - Vif:
940  =16*58.75  NTSC/J (Japan)
732  =16*45.75  M/N STD





I'll resend this.

Thanks for having a look.

Justin P. Mattock
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 8/8]tuners:tuner-simple Fix warning: variable 'tun' set but not used

[Justin P. Mattock]

On 06/14/2010 10:16 PM, Mauro Carvalho Chehab wrote:



Em 14-06-2010 23:26, Justin P. Mattock escreveu:

not sure if this is correct or not for
fixing this warning:
   CC [M]  drivers/media/common/tuners/tuner-simple.o
drivers/media/common/tuners/tuner-simple.c: In function 'simple_set_tv_freq':
drivers/media/common/tuners/tuner-simple.c:548:20: warning: variable 'tun' set 
but not used

  Signed-off-by: Justin P. Mattockjustinmatt...@gmail.com

---
  drivers/media/common/tuners/tuner-simple.c |4 +---
  1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/drivers/media/common/tuners/tuner-simple.c 
b/drivers/media/common/tuners/tuner-simple.c
index 8abbcc5..4465b99 100644
--- a/drivers/media/common/tuners/tuner-simple.c
+++ b/drivers/media/common/tuners/tuner-simple.c
@@ -545,14 +545,12 @@ static int simple_set_tv_freq(struct dvb_frontend *fe,
struct tuner_simple_priv *priv = fe-tuner_priv;
u8 config, cb;
u16 div;
-   struct tunertype *tun;
u8 buffer[4];
int rc, IFPCoff, i;
enum param_type desired_type;
struct tuner_params *t_params;

-   tun = priv-tun;
-
+   

Why are you adding an extra blank line here? Except for that, the patch
looks sane.


/* IFPCoff = Video Intermediate Frequency - Vif:
940  =16*58.75  NTSC/J (Japan)
732  =16*45.75  M/N STD





o.k. resent this.. I ended up doing
a git reset do make sure things dont get
funky etc..

Justin P. Mattock
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/8]drivers:tmp.c Fix warning: variable 'rc' set but not used

[Justin P. Mattock]

On 06/14/2010 10:29 PM, Peter Stuge wrote:

Justin P. Mattock wrote:

*baffled* Why did you think that would work? transmit_cmd()s signature
has 4 parameters.


I have no manual in front of me. Did a quick google, but came up with
(no hits) info on what that function does. grep showed too many entries
to really see why/what this is.


Check out the tool cscope. (Or kscope, if you prefer a GUI.)


//Peter



thanks for this tool.. I think this is what I need.. running around not 
knowing what/where the manual is for a call is a bit daunting.

I'll give this a look.

Thanks for this..

Justin P. Mattock
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] uvcvideo: add another YUYV format GUID

[Justin P. Mattock]

On 12/03/09 18:05, Daniel Ritz wrote:

Hi Laurent

On Thu, 2009-12-03 at 21:15 +0100, Laurent Pinchart wrote:

Hi Daniel,

On Wednesday 02 December 2009 00:48:44 Daniel Ritz wrote:

For some unknown reason, on a MacBookPro5,3 the iSight


Could you please send me the output of lsusb -v both with the correct and
wrong GUID ?


sure. i attached three files:
   isight-good.txt, isight-bad.txt, isight-good2.txt

this is three reboots in a row from like 10 minutes ago. the first
boot into linux was actually rebooting from OSX...first cold boot
today directly into linux had the right GUID.




_sometimes_ report a different video format GUID.


Sometimes only ? Now that's weird. Is that completely random ?


yes, sometimes only. it seems to be related to reboots, but i don't
know what exactly triggers it. rmmod/modprobe doesn't trigger it.
also, when the wrong GUID is reported, the only way of fixing it is
to reboot. it really is just the GUID. even when the wrong one is
reported, the device works just fine.

i started with a plain ubuntu 9.10, kernel 2.6.31 which was supposed
to fail, so i upgraded to a 2.6.32-rc8 to fix the iSight and some other
things, just to see it fail again. a reboot later and it worked, some
time and reboot later it failed again...

rgds
-daniel


This patch add the other (wrong) GUID to the format table, making the iSight
work always w/o other problems.

What it should report: 32595559--0010-8000-00aa00389b71
What it often reports: 32595559--0010-8000-00389b71

Signed-off-by: Daniel Ritzdaniel.r...@gmx.ch


--
Regards,

Laurent Pinchart




I get weiredness whenever
I shutdown the machine and then boot.
If I boot, then reboot things work.

Justin P. Mattock
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html