Re: [PATCH 0/2] [media] c8sectpfe: Deletion of a few unnecessary checks
Hi Markus, On 11/05/2015 07:45 PM, SF Markus Elfring wrote: From: Markus Elfring Date: Thu, 5 Nov 2015 19:39:32 +0100 Another update suggestion was taken into account after a patch was applied from static source code analysis. Markus Elfring (2): Delete unnecessary checks before two function calls Combine three checks into a single if block drivers/media/platform/sti/c8sectpfe/c8sectpfe-common.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) For the series: Acked-by: Maxime Coquelin Thanks! Maxime -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/7] [media] use CONFIG_PM_SLEEP for suspend/resume
On 06/24/2015 12:49 PM, Mauro Carvalho Chehab wrote:
Using CONFIG_PM_SLEEP suppress the warnings when the driver is
compiled without PM sleep functions:
drivers/media/rc/st_rc.c:338:12: warning: ‘st_rc_suspend’ defined but not used
[-Wunused-function]
drivers/media/rc/st_rc.c:359:12: warning: ‘st_rc_resume’ defined but not used
[-Wunused-function]
Signed-off-by: Mauro Carvalho Chehab
diff --git a/drivers/media/rc/st_rc.c b/drivers/media/rc/st_rc.c
index 979b40561b3a..37d040158dff 100644
--- a/drivers/media/rc/st_rc.c
+++ b/drivers/media/rc/st_rc.c
@@ -334,7 +334,7 @@ err:
return ret;
}
-#ifdef CONFIG_PM
+#ifdef CONFIG_PM_SLEEP
static int st_rc_suspend(struct device *dev)
{
struct st_rc_device *rc_dev = dev_get_drvdata(dev);
Acked-by: Maxime Coquelin
Thanks!
Maxime
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv3 1/4] phy: phy-core: Make GENERIC_PHY an invisible option
Hi Kishon, Arun, On 05/29/2015 02:37 PM, Kishon Vijay Abraham I wrote: Tejun, Maxime, Sylwester, Kyungmin On Thursday 23 April 2015 04:34 AM, Arun Ramamurthy wrote: Most of the phy providers use "select" to enable GENERIC_PHY. Since select is only recommended when the config is not visible, GENERIC_PHY is changed an invisible option. To maintain consistency, all phy providers are changed to "select" GENERIC_PHY and all non-phy drivers use "depends on" when the phy framework is explicity required. USB_MUSB_OMAP2PLUS has a cyclic dependency, so it is left as "select". Signed-off-by: Arun Ramamurthy Need your ACK for this patch. For the STi part, you can add my: Acked-by: Maxime Coquelin Regards, Maxime -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [STLinux Kernel] [PATCH 1/3] media: st-rc: move to using reset_control_get_optional
Hi Srini, Peter, On 09/24/2014 10:12 AM, Srinivas Kandagatla wrote: > Hi Pete, > > On 23/09/14 19:02, Peter Griffin wrote: >> Hi Srini, >> >> On Mon, 22 Sep 2014, Srinivas Kandagatla wrote: >> >>> This patch fixes a compilation error while building with the >>> random kernel configuration. >>> >>> drivers/media/rc/st_rc.c: In function 'st_rc_probe': >>> drivers/media/rc/st_rc.c:281:2: error: implicit declaration of >>> function 'reset_control_get' [-Werror=implicit-function-declaration] >>>rc_dev->rstc = reset_control_get(dev, NULL); >>> >>> drivers/media/rc/st_rc.c:281:15: warning: assignment makes pointer >>> from integer without a cast [enabled by default] >>>rc_dev->rstc = reset_control_get(dev, NULL); >> >> Is managing the reset line actually optional though? I can't test atm >> as I don't have >> access to my board, but quite often if the IP's aren't taken out of >> reset reads / writes >> to the perhpiheral will hang the SoC. >> > Yes and No. > AFAIK reset line is optional on SOCs like 7108, 7141. > I think having the driver function without reset might is a value add in > case we plan to reuse the mainline driver for these SOCs. > > On latest ARM SOCs with SBC the IRB IP is moved to SBC and held in reset. > Am not sure, if the reset line is optional in next generation SOCs? I don't know for next SoCs, but I think it makes sense to make it optional. Regards, Maxime > >> If managing the reset line isn't optional then I think the correct fix >> is to add >> depends on RESET_CONTROLLER in the kconfig. > I agree. > This would make the COMPILE_TEST less useful though. > > > thanks, > srini >> >> This will then do the right thing for randconfig builds as well. >> >> regards, >> >> Peter. >> > > ___ > Kernel mailing list > ker...@stlinux.com > http://www.stlinux.com/mailman/listinfo/kernel -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/3] media:st-rc: Misc fixes.
Hi Srini, Thanks for sending these fixes. For the series, you can add my: Acked-by: Maxime Coquelin Regards, Maxime On 09/23/2014 12:21 AM, Srinivas Kandagatla wrote: Hi Mauro, Thankyou for the "[media] enable COMPILE_TEST for media drivers" patch which picked up few things in st-rc driver in linux-next testing. Here is a few minor fixes to the driver, could you consider them for the next merge window. Thanks, srini Srinivas Kandagatla (3): media: st-rc: move to using reset_control_get_optional media: st-rc: move pm ops setup out of conditional compilation. media: st-rc: Remove .owner field for driver drivers/media/rc/st_rc.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Linaro-mm-sig] [PATCHv16 0/9] Contiguous Memory Allocator
On 10/06/2011 03:54 PM, Marek Szyprowski wrote: Welcome everyone again, Once again I decided to post an updated version of the Contiguous Memory Allocator patches. This version provides mainly a bugfix for a very rare issue that might have changed migration type of the CMA page blocks resulting in dropping CMA features from the affected page block and causing memory allocation to fail. Also the issue reported by Dave Hansen has been fixed. This version also introduces basic support for x86 architecture, what allows wide testing on KVM/QEMU emulators and all common x86 boxes. I hope this will result in wider testing, comments and easier merging to mainline. I've also dropped an examplary patch for s5p-fimc platform device private memory declaration and added the one from real life. CMA device private memory regions are defined for s5p-mfc device to let it allocate buffers from two memory banks. ARM integration code has not been changed since last version, it provides implementation of all the ideas that has been discussed during Hello Marek, We are currently testing CMA (v16) on Snowball platform. This feature is very promising, thanks for pushing it! During our stress tests, we encountered some problems : 1) Contiguous allocation lockup: When system RAM is full of Anon pages, if we try to allocate a contiguous buffer greater than the min_free value, we face a dma_alloc_from_contiguous lockup. The expected result would be dma_alloc_from_contiguous() to fail. The problem is reproduced systematically on our side. 2) Contiguous allocation fail: We have developed a small driver and a shell script to allocate/release contiguous buffers. Sometimes, dma_alloc_from_contiguous() fails to allocate the contiguous buffer (about once every 30 runs). We have 270MB Memory passed to the kernel in our configuration, and the CMA pool is 90MB large. In this setup, the overall memory is either free or full of reclaimable pages. For now, we didn't had time to investigate further theses problems. Have you already faced this kind of issues? Could someone testing CMA on other boards confirm/infirm theses problems? Best regards, Maxime Patches in this patchset: mm: move some functions from memory_hotplug.c to page_isolation.c mm: alloc_contig_freed_pages() added Code "stolen" from Kamezawa. The first patch just moves code around and the second provide function for "allocates" already freed memory. mm: alloc_contig_range() added This is what Kamezawa asked: a function that tries to migrate all pages from given range and then use alloc_contig_freed_pages() (defined by the previous commit) to allocate those pages. mm: MIGRATE_CMA migration type added mm: MIGRATE_CMA isolation functions added Introduction of the new migratetype and support for it in CMA. MIGRATE_CMA works similar to ZONE_MOVABLE expect almost any memory range can be marked as one. mm: cma: Contiguous Memory Allocator added The code CMA code. Manages CMA contexts and performs memory allocations. X86: integrate CMA with DMA-mapping subsystem ARM: integrate CMA with dma-mapping subsystem Main clients of CMA framework. CMA serves as a alloc_pages() replacement. ARM: Samsung: use CMA for 2 memory banks for s5p-mfc device Use CMA device private memory regions instead of custom solution based on memblock_reserve() + dma_declare_coherent(). Patch summary: KAMEZAWA Hiroyuki (2): mm: move some functions from memory_hotplug.c to page_isolation.c mm: alloc_contig_freed_pages() added Marek Szyprowski (4): drivers: add Contiguous Memory Allocator ARM: integrate CMA with DMA-mapping subsystem ARM: Samsung: use CMA for 2 memory banks for s5p-mfc device X86: integrate CMA with DMA-mapping subsystem Michal Nazarewicz (3): mm: alloc_contig_range() added mm: MIGRATE_CMA migration type added mm: MIGRATE_CMA isolation functions added arch/Kconfig |3 + arch/arm/Kconfig |2 + arch/arm/include/asm/dma-contiguous.h | 16 ++ arch/arm/include/asm/mach/map.h |1 + arch/arm/mm/dma-mapping.c | 362 +-- arch/arm/mm/init.c|8 + arch/arm/mm/mm.h |3 + arch/arm/mm/mmu.c | 29 ++- arch/arm/plat-s5p/dev-mfc.c | 51 + arch/x86/Kconfig |1 + arch/x86/include/asm/dma-contiguous.h | 13 + arch/x86/include/asm/dma-mapping.h|4 + arch/x86/kernel/pci-dma.c | 18 ++- arch/x86/kernel/pci-nommu.c |8 +- arch/x86/kernel/setup.c |2 + drivers/base/Kconfig | 79 +++ drivers/base/Makefile |1 + drivers/base/dma-contiguous.c
