Re: [PATCH 09/10] MCDE: Add build files and bus

2010-12-01 Thread Peter Stuge
Russell King - ARM Linux wrote:
 I feel it would be better to allow the current situation to continue.

I think this misses the point, and is somewhat redundant; I think
everyone knows that it is easiest to never change anything. But
then nothing improves.


 If we start telling people that they can't use statically declared
 devices without first having an alternative,

I would consider it early warning that the way things have been done
before will go away. And I would thus write drivers in a way that
demonstrates and includes that understanding.

The same problem exists in hardware products needing any kind of
longish lifetime. Deal with evolving components by having clean
and simple interfaces, and by not relying on a particular interface
very deep on either side of the edge. Simple I think.


//Peter
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 4/8]drivers:tmp.c Fix warning: variable 'rc' set but not used

2010-06-14 Thread Peter Stuge
Justin P. Mattock wrote:
  *baffled* Why did you think that would work? transmit_cmd()s signature
  has 4 parameters.
 
 I have no manual in front of me. Did a quick google, but came up with 
 (no hits) info on what that function does. grep showed too many entries 
 to really see why/what this is.

Check out the tool cscope. (Or kscope, if you prefer a GUI.)


//Peter
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html