Re: [GIT PATCHES FOR 2.6.37] V4L documentation fixes
Hi, Since we are talking about V4L documentation, I would like to remind of the timestamps subject since this is a recurrent issue. The current spec refers to gettimeofday return value for the buffer timestamps and as already discussed in previous posts, gettimeofday, introduces a lot of issues, using ktime (monotonic) instead seems a much better approach. Uvcvideo and gspca already use it, but since the documentation has not been changed yet, it can cause some confusion between developers. NOTE: I see this topic is intended for discussion in the LPC: http://www.linuxtv.org/news.php?entry=2010-06-22.mchehab So I'm not sure if this should be put on hold until then. As a side note: if you need a similar timestamp to the one returned by ktime in user space, you can get it with: static struct timespec ts; clock_gettime(CLOCK_MONOTONIC, &ts); A conversion between timespec and timeval is needed but that is easy enough, for both drivers and user space. Best Regards Paulo 2010/9/23 Hans Verkuil : > On Wednesday, September 22, 2010 23:17:08 Mauro Carvalho Chehab wrote: >> Em 22-09-2010 17:06, Hans Verkuil escreveu: >> > On Wednesday, September 22, 2010 21:42:03 Mauro Carvalho Chehab wrote: >> >> Em 15-09-2010 04:23, Hans Verkuil escreveu: >> >>> The following changes since commit >> >>> 57fef3eb74a04716a8dd18af0ac510ec4f71bc05: >> >>> Richard Zidlicky (1): >> >>> V4L/DVB: dvb: fix smscore_getbuffer() logic >> >>> >> >>> are available in the git repository at: >> >>> >> >>> ssh://linuxtv.org/git/hverkuil/v4l-dvb.git misc2 >> >>> >> >>> Hans Verkuil (6): >> >>> V4L Doc: removed duplicate link >> >> >> >> This doesn't seem right. the entry for V4L2-PIX-FMT-BGR666 seems to be >> >> duplicated. >> >> We should remove the duplication, instead of just dropping the ID. >> > >> > No, this patch is correct. This section really duplicates the formats due >> > to >> > confusion about the byte order in memory. But only one of these format >> > tables >> > should have a valid ID. >> > >> > See table 2.4 and 2.5 here: >> > >> > http://www.xs4all.nl/~hverkuil/spec/media.html#packed-rgb >> > >> > As you can see here there is no BGR666 entry in either table since the >> > docbook >> > generation has been failing on this docbook error for some time now. >> > >> >> >> >>> V4L Doc: fix DocBook syntax errors. >> >>> V4L Doc: document V4L2_CAP_RDS_OUTPUT capability. >> >>> V4L Doc: correct the documentation for VIDIOC_QUERYMENU. >> >> >> >> Applied, thanks. >> >> >> >>> V4L Doc: rewrite the Device Naming section >> >> >> >> The new text is incomplete, as it assumes only the old non-dynamic device >> >> node >> >> creation. Also, some distros actually create /dev/v4l, as recommended. >> >> IMHO, we >> >> need to improve this section, proposing a better way to name devices. >> >> This may >> >> be an interesting theme for this year's LPC. >> > >> > No, the major is still 81 and the minors are still between 0 and 255. But >> > the minor >> > ranges are gone (unless you turn that on explicitly). So this text is >> > really correct >> > and way more understandable than the old text. >> >> Hmm... are the V4L core artificially limiting minor range to be between 0 >> and 255? > > Well, we do need to keep a mapping between minor and video_device (the > video_device > array in v4l2-dev.c) so we do need a maximum number of devices. Increasing > this number > is a matter of just increasing the VIDEO_NUM_DEVICES macro. > > Since we no longer split up the 256 minors into ranges for each video type > (video, > vbi, radio) we make full use of all minors. Nothing I've seen comes even > close to > filling up all those minors. > > That said, when we add support for the subdev device nodes we should probably > at the > same time double the number of reserved minors. Just in case. > > Regards, > > Hans > >> >> > >> >> >> >>> V4L Doc: clarify the V4L spec. >> >> >> >> This is a mix of several changes on the same patch. I want to do comments >> >> about it, >> >> but no time right now to write an email about that. It is a way harder to >> >> comment >> >> Docbook changes than patches, as the diff output is not user-friendly. >> >> I'll postpone this patch for a better analysis. >> > >> > No problem. >> > >> > Regards, >> > >> > Hans >> > >> >> I don't want to postpone the DocBook correction patches due to that, so >> >> I'm applying >> >> the patches I'm ok. >> >> >> >> Cheers, >> >> Mauro >> >> >> > >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-media" in >> the body of a message to majord...@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> >> > > -- > Hans Verkuil - video4linux developer - sponsored by TANDBERG, part of Cisco > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org
Re: [GIT PATCHES FOR 2.6.37] V4L documentation fixes
On Wednesday, September 22, 2010 23:17:08 Mauro Carvalho Chehab wrote: > Em 22-09-2010 17:06, Hans Verkuil escreveu: > > On Wednesday, September 22, 2010 21:42:03 Mauro Carvalho Chehab wrote: > >> Em 15-09-2010 04:23, Hans Verkuil escreveu: > >>> The following changes since commit > >>> 57fef3eb74a04716a8dd18af0ac510ec4f71bc05: > >>> Richard Zidlicky (1): > >>> V4L/DVB: dvb: fix smscore_getbuffer() logic > >>> > >>> are available in the git repository at: > >>> > >>> ssh://linuxtv.org/git/hverkuil/v4l-dvb.git misc2 > >>> > >>> Hans Verkuil (6): > >>> V4L Doc: removed duplicate link > >> > >> This doesn't seem right. the entry for V4L2-PIX-FMT-BGR666 seems to be > >> duplicated. > >> We should remove the duplication, instead of just dropping the ID. > > > > No, this patch is correct. This section really duplicates the formats due to > > confusion about the byte order in memory. But only one of these format > > tables > > should have a valid ID. > > > > See table 2.4 and 2.5 here: > > > > http://www.xs4all.nl/~hverkuil/spec/media.html#packed-rgb > > > > As you can see here there is no BGR666 entry in either table since the > > docbook > > generation has been failing on this docbook error for some time now. > > > >> > >>> V4L Doc: fix DocBook syntax errors. > >>> V4L Doc: document V4L2_CAP_RDS_OUTPUT capability. > >>> V4L Doc: correct the documentation for VIDIOC_QUERYMENU. > >> > >> Applied, thanks. > >> > >>> V4L Doc: rewrite the Device Naming section > >> > >> The new text is incomplete, as it assumes only the old non-dynamic device > >> node > >> creation. Also, some distros actually create /dev/v4l, as recommended. > >> IMHO, we > >> need to improve this section, proposing a better way to name devices. This > >> may > >> be an interesting theme for this year's LPC. > > > > No, the major is still 81 and the minors are still between 0 and 255. But > > the minor > > ranges are gone (unless you turn that on explicitly). So this text is > > really correct > > and way more understandable than the old text. > > Hmm... are the V4L core artificially limiting minor range to be between 0 and > 255? Well, we do need to keep a mapping between minor and video_device (the video_device array in v4l2-dev.c) so we do need a maximum number of devices. Increasing this number is a matter of just increasing the VIDEO_NUM_DEVICES macro. Since we no longer split up the 256 minors into ranges for each video type (video, vbi, radio) we make full use of all minors. Nothing I've seen comes even close to filling up all those minors. That said, when we add support for the subdev device nodes we should probably at the same time double the number of reserved minors. Just in case. Regards, Hans > > > > >> > >>> V4L Doc: clarify the V4L spec. > >> > >> This is a mix of several changes on the same patch. I want to do comments > >> about it, > >> but no time right now to write an email about that. It is a way harder to > >> comment > >> Docbook changes than patches, as the diff output is not user-friendly. > >> I'll postpone this patch for a better analysis. > > > > No problem. > > > > Regards, > > > > Hans > > > >> I don't want to postpone the DocBook correction patches due to that, so > >> I'm applying > >> the patches I'm ok. > >> > >> Cheers, > >> Mauro > >> > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- Hans Verkuil - video4linux developer - sponsored by TANDBERG, part of Cisco -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [GIT PATCHES FOR 2.6.37] V4L documentation fixes
Em 22-09-2010 17:06, Hans Verkuil escreveu: > On Wednesday, September 22, 2010 21:42:03 Mauro Carvalho Chehab wrote: >> Em 15-09-2010 04:23, Hans Verkuil escreveu: >>> The following changes since commit 57fef3eb74a04716a8dd18af0ac510ec4f71bc05: >>> Richard Zidlicky (1): >>> V4L/DVB: dvb: fix smscore_getbuffer() logic >>> >>> are available in the git repository at: >>> >>> ssh://linuxtv.org/git/hverkuil/v4l-dvb.git misc2 >>> >>> Hans Verkuil (6): >>> V4L Doc: removed duplicate link >> >> This doesn't seem right. the entry for V4L2-PIX-FMT-BGR666 seems to be >> duplicated. >> We should remove the duplication, instead of just dropping the ID. > > No, this patch is correct. This section really duplicates the formats due to > confusion about the byte order in memory. But only one of these format tables > should have a valid ID. > > See table 2.4 and 2.5 here: > > http://www.xs4all.nl/~hverkuil/spec/media.html#packed-rgb > > As you can see here there is no BGR666 entry in either table since the docbook > generation has been failing on this docbook error for some time now. > >> >>> V4L Doc: fix DocBook syntax errors. >>> V4L Doc: document V4L2_CAP_RDS_OUTPUT capability. >>> V4L Doc: correct the documentation for VIDIOC_QUERYMENU. >> >> Applied, thanks. >> >>> V4L Doc: rewrite the Device Naming section >> >> The new text is incomplete, as it assumes only the old non-dynamic device >> node >> creation. Also, some distros actually create /dev/v4l, as recommended. IMHO, >> we >> need to improve this section, proposing a better way to name devices. This >> may >> be an interesting theme for this year's LPC. > > No, the major is still 81 and the minors are still between 0 and 255. But the > minor > ranges are gone (unless you turn that on explicitly). So this text is really > correct > and way more understandable than the old text. Hmm... are the V4L core artificially limiting minor range to be between 0 and 255? > >> >>> V4L Doc: clarify the V4L spec. >> >> This is a mix of several changes on the same patch. I want to do comments >> about it, >> but no time right now to write an email about that. It is a way harder to >> comment >> Docbook changes than patches, as the diff output is not user-friendly. >> I'll postpone this patch for a better analysis. > > No problem. > > Regards, > > Hans > >> I don't want to postpone the DocBook correction patches due to that, so I'm >> applying >> the patches I'm ok. >> >> Cheers, >> Mauro >> > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [GIT PATCHES FOR 2.6.37] V4L documentation fixes
On Wednesday, September 22, 2010 22:06:11 Hans Verkuil wrote: > On Wednesday, September 22, 2010 21:42:03 Mauro Carvalho Chehab wrote: > > Em 15-09-2010 04:23, Hans Verkuil escreveu: > > > The following changes since commit > > > 57fef3eb74a04716a8dd18af0ac510ec4f71bc05: > > > Richard Zidlicky (1): > > > V4L/DVB: dvb: fix smscore_getbuffer() logic > > > > > > are available in the git repository at: > > > > > > ssh://linuxtv.org/git/hverkuil/v4l-dvb.git misc2 > > > > > > Hans Verkuil (6): > > > V4L Doc: removed duplicate link > > > > This doesn't seem right. the entry for V4L2-PIX-FMT-BGR666 seems to be > > duplicated. > > We should remove the duplication, instead of just dropping the ID. > > No, this patch is correct. This section really duplicates the formats due to > confusion about the byte order in memory. But only one of these format tables > should have a valid ID. > > See table 2.4 and 2.5 here: > > http://www.xs4all.nl/~hverkuil/spec/media.html#packed-rgb > > As you can see here there is no BGR666 entry in either table since the docbook > generation has been failing on this docbook error for some time now. FYI: for the daily build I make a nochunks version of the docs like this: make DOCBOOKS=media.xml htmldocs xmlto html-nochunks -m Documentation/DocBook/stylesheet.xsl -o Documentation/DocBook/media Documentation/DocBook/media.xml The second step finds some docbook bugs that the first step doesn't. Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG, part of Cisco -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [GIT PATCHES FOR 2.6.37] V4L documentation fixes
On Wednesday, September 22, 2010 21:42:03 Mauro Carvalho Chehab wrote: > Em 15-09-2010 04:23, Hans Verkuil escreveu: > > The following changes since commit 57fef3eb74a04716a8dd18af0ac510ec4f71bc05: > > Richard Zidlicky (1): > > V4L/DVB: dvb: fix smscore_getbuffer() logic > > > > are available in the git repository at: > > > > ssh://linuxtv.org/git/hverkuil/v4l-dvb.git misc2 > > > > Hans Verkuil (6): > > V4L Doc: removed duplicate link > > This doesn't seem right. the entry for V4L2-PIX-FMT-BGR666 seems to be > duplicated. > We should remove the duplication, instead of just dropping the ID. No, this patch is correct. This section really duplicates the formats due to confusion about the byte order in memory. But only one of these format tables should have a valid ID. See table 2.4 and 2.5 here: http://www.xs4all.nl/~hverkuil/spec/media.html#packed-rgb As you can see here there is no BGR666 entry in either table since the docbook generation has been failing on this docbook error for some time now. > > > V4L Doc: fix DocBook syntax errors. > > V4L Doc: document V4L2_CAP_RDS_OUTPUT capability. > > V4L Doc: correct the documentation for VIDIOC_QUERYMENU. > > Applied, thanks. > > > V4L Doc: rewrite the Device Naming section > > The new text is incomplete, as it assumes only the old non-dynamic device node > creation. Also, some distros actually create /dev/v4l, as recommended. IMHO, > we > need to improve this section, proposing a better way to name devices. This may > be an interesting theme for this year's LPC. No, the major is still 81 and the minors are still between 0 and 255. But the minor ranges are gone (unless you turn that on explicitly). So this text is really correct and way more understandable than the old text. > > > V4L Doc: clarify the V4L spec. > > This is a mix of several changes on the same patch. I want to do comments > about it, > but no time right now to write an email about that. It is a way harder to > comment > Docbook changes than patches, as the diff output is not user-friendly. > I'll postpone this patch for a better analysis. No problem. Regards, Hans > I don't want to postpone the DocBook correction patches due to that, so I'm > applying > the patches I'm ok. > > Cheers, > Mauro > -- Hans Verkuil - video4linux developer - sponsored by TANDBERG, part of Cisco -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [GIT PATCHES FOR 2.6.37] V4L documentation fixes
Em 15-09-2010 04:23, Hans Verkuil escreveu: > The following changes since commit 57fef3eb74a04716a8dd18af0ac510ec4f71bc05: > Richard Zidlicky (1): > V4L/DVB: dvb: fix smscore_getbuffer() logic > > are available in the git repository at: > > ssh://linuxtv.org/git/hverkuil/v4l-dvb.git misc2 > > Hans Verkuil (6): > V4L Doc: removed duplicate link This doesn't seem right. the entry for V4L2-PIX-FMT-BGR666 seems to be duplicated. We should remove the duplication, instead of just dropping the ID. > V4L Doc: fix DocBook syntax errors. > V4L Doc: document V4L2_CAP_RDS_OUTPUT capability. > V4L Doc: correct the documentation for VIDIOC_QUERYMENU. Applied, thanks. > V4L Doc: rewrite the Device Naming section The new text is incomplete, as it assumes only the old non-dynamic device node creation. Also, some distros actually create /dev/v4l, as recommended. IMHO, we need to improve this section, proposing a better way to name devices. This may be an interesting theme for this year's LPC. > V4L Doc: clarify the V4L spec. This is a mix of several changes on the same patch. I want to do comments about it, but no time right now to write an email about that. It is a way harder to comment Docbook changes than patches, as the diff output is not user-friendly. I'll postpone this patch for a better analysis. I don't want to postpone the DocBook correction patches due to that, so I'm applying the patches I'm ok. Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PATCHES FOR 2.6.37] V4L documentation fixes
The following changes since commit 57fef3eb74a04716a8dd18af0ac510ec4f71bc05: Richard Zidlicky (1): V4L/DVB: dvb: fix smscore_getbuffer() logic are available in the git repository at: ssh://linuxtv.org/git/hverkuil/v4l-dvb.git misc2 Hans Verkuil (6): V4L Doc: removed duplicate link V4L Doc: fix DocBook syntax errors. V4L Doc: document V4L2_CAP_RDS_OUTPUT capability. V4L Doc: clarify the V4L spec. V4L Doc: correct the documentation for VIDIOC_QUERYMENU. V4L Doc: rewrite the Device Naming section Documentation/DocBook/v4l/common.xml | 197 +--- Documentation/DocBook/v4l/controls.xml |3 - Documentation/DocBook/v4l/pixfmt-packed-rgb.xml|2 +- Documentation/DocBook/v4l/pixfmt.xml |4 +- Documentation/DocBook/v4l/vidioc-g-dv-preset.xml |3 +- Documentation/DocBook/v4l/vidioc-g-dv-timings.xml |3 +- .../DocBook/v4l/vidioc-query-dv-preset.xml |2 +- Documentation/DocBook/v4l/vidioc-querycap.xml |7 +- Documentation/DocBook/v4l/vidioc-queryctrl.xml | 18 ++- 9 files changed, 73 insertions(+), 166 deletions(-) -- Hans Verkuil - video4linux developer - sponsored by TANDBERG, part of Cisco -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
