Re: [GIT PULL] HVR-900 R2 and PCTV 330e DVB support
Hi Devin, Em 25-03-2011 13:09, Devin Heitmueller escreveu: On Fri, Mar 25, 2011 at 11:50 AM, Mauro Carvalho Chehab mche...@redhat.com wrote: I've added a patch for it at the end of the series. Could you please double check if everything is ok, for me to move this upstream? Thanks! Mauro Sure, I will find some time this weekend to try out your tree. Any news? Thanks! Mauro -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [GIT PULL] HVR-900 R2 and PCTV 330e DVB support
Hi Devin,
Em 24-03-2011 14:05, Devin Heitmueller escreveu:
This patch series finally merges in Ralph Metzler's drx-d driver and
brings up the PCTV 330e and
HVR-900R2. The patches have been tested for quite some time by users
on the Kernel Labs blog,
and they have been quite happy with them.
The firmware required can be found here:
http://kernellabs.com/firmware/drxd/
The following changes since commit 41f3becb7bef489f9e8c35284dd88a1ff59b190c:
[media] V4L DocBook: update V4L2 version (2011-03-11 18:09:02 -0300)
are available in the git repository at:
git://sol.kernellabs.com/dheitmueller/drx.git drxd
Devin Heitmueller (12):
drx: add initial drx-d driver
drxd: add driver to Makefile and Kconfig
drxd: provide ability to control rs byte
em28xx: enable support for the drx-d on the HVR-900 R2
drxd: provide ability to disable the i2c gate control function
em28xx: fix GPIO problem with HVR-900R2 getting out of sync with drx-d
em28xx: include model number for PCTV 330e
em28xx: add digital support for PCTV 330e
drxd: move firmware to binary blob
em28xx: remove not validated flag for PCTV 330e
em28xx: add remote control support for PCTV 330e
drxd: Run lindent across sources
Still lots of CodingStyle issues, but they could be easily cleaned by a few
scripting.
I've cleaned them and added at my experimental tree:
http://git.linuxtv.org/mchehab/experimental.git?a=shortlog;h=refs/heads/drxd
It compiles fine, and I don't think that any of the changes would break DRX-D,
but, in
any case, it would be great if you could double check.
I noticed just one issue with the drxd driver: it is still using a semaphore
instead
of a mutex:
+ struct semaphore mutex;
...
+static int HI_CfgCommand(struct drxd_state *state)
+{
+ int status = 0;
+
+ down(state-mutex);
It should be doing:
s/struct semaphore/struct mutex/
s/down/mutex_lock/
s/up/mutex_unlock/
s/sema_init/mutex_init/
at the places it occur.
I've added a patch for it at the end of the series.
Could you please double check if everything is ok, for me to move this upstream?
Thanks!
Mauro
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [GIT PULL] HVR-900 R2 and PCTV 330e DVB support
On Fri, Mar 25, 2011 at 11:50 AM, Mauro Carvalho Chehab mche...@redhat.com wrote: I've added a patch for it at the end of the series. Could you please double check if everything is ok, for me to move this upstream? Thanks! Mauro Sure, I will find some time this weekend to try out your tree. http://git.linuxtv.org/mchehab/experimental.git?a=blobdiff;f=drivers/media/dvb/frontends/drxd.h;h=7113535844f2304f58e24571f538b9a71528cfb9;hp=d3d6c9246535def0e309f0714c9acbec0f350e25;hb=cf36b96eac59311f37b7881a6f48b465d1522fe9;hpb=df1bf4caabf1284289a4f6d7c1516e74c4e944c8 This patch is a bit funny, because the latest version of Lindent actually introduced the space between * and off. Might be something for you to consider looking at in the tool. Devin -- Devin J. Heitmueller - Kernel Labs http://www.kernellabs.com -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [GIT PULL] HVR-900 R2 and PCTV 330e DVB support
Em 25-03-2011 13:09, Devin Heitmueller escreveu: On Fri, Mar 25, 2011 at 11:50 AM, Mauro Carvalho Chehab mche...@redhat.com wrote: I've added a patch for it at the end of the series. Could you please double check if everything is ok, for me to move this upstream? Thanks! Mauro Sure, I will find some time this weekend to try out your tree. Ok, thanks! http://git.linuxtv.org/mchehab/experimental.git?a=blobdiff;f=drivers/media/dvb/frontends/drxd.h;h=7113535844f2304f58e24571f538b9a71528cfb9;hp=d3d6c9246535def0e309f0714c9acbec0f350e25;hb=cf36b96eac59311f37b7881a6f48b465d1522fe9;hpb=df1bf4caabf1284289a4f6d7c1516e74c4e944c8 This patch is a bit funny, because the latest version of Lindent actually introduced the space between * and off. Might be something for you to consider looking at in the tool. indent tool has some drawbacks. Sometimes, it does bad things, but when the code has lots of issues, it is still better than nothing. Maybe it believed that off is some keyword. Devin -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PULL] HVR-900 R2 and PCTV 330e DVB support
This patch series finally merges in Ralph Metzler's drx-d driver and brings up the PCTV 330e and HVR-900R2. The patches have been tested for quite some time by users on the Kernel Labs blog, and they have been quite happy with them. The firmware required can be found here: http://kernellabs.com/firmware/drxd/ The following changes since commit 41f3becb7bef489f9e8c35284dd88a1ff59b190c: [media] V4L DocBook: update V4L2 version (2011-03-11 18:09:02 -0300) are available in the git repository at: git://sol.kernellabs.com/dheitmueller/drx.git drxd Devin Heitmueller (12): drx: add initial drx-d driver drxd: add driver to Makefile and Kconfig drxd: provide ability to control rs byte em28xx: enable support for the drx-d on the HVR-900 R2 drxd: provide ability to disable the i2c gate control function em28xx: fix GPIO problem with HVR-900R2 getting out of sync with drx-d em28xx: include model number for PCTV 330e em28xx: add digital support for PCTV 330e drxd: move firmware to binary blob em28xx: remove not validated flag for PCTV 330e em28xx: add remote control support for PCTV 330e drxd: Run lindent across sources Documentation/video4linux/CARDLIST.em28xx |2 +- drivers/media/dvb/frontends/Kconfig | 11 + drivers/media/dvb/frontends/Makefile|2 + drivers/media/dvb/frontends/drxd.h | 61 + drivers/media/dvb/frontends/drxd_firm.c | 929 ++ drivers/media/dvb/frontends/drxd_firm.h | 118 + drivers/media/dvb/frontends/drxd_hard.c | 2806 ++ drivers/media/dvb/frontends/drxd_map_firm.h |12694 +++ drivers/media/video/em28xx/em28xx-cards.c | 21 +- drivers/media/video/em28xx/em28xx-dvb.c | 22 +- drivers/media/video/em28xx/em28xx.h |2 +- 11 files changed, 16649 insertions(+), 19 deletions(-) create mode 100644 drivers/media/dvb/frontends/drxd.h create mode 100644 drivers/media/dvb/frontends/drxd_firm.c create mode 100644 drivers/media/dvb/frontends/drxd_firm.h create mode 100644 drivers/media/dvb/frontends/drxd_hard.c create mode 100644 drivers/media/dvb/frontends/drxd_map_firm.h -- Devin J. Heitmueller - Kernel Labs http://www.kernellabs.com -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [GIT PULL] HVR-900 R2 and PCTV 330e DVB support
Em 24-03-2011 14:05, Devin Heitmueller escreveu: This patch series finally merges in Ralph Metzler's drx-d driver and brings up the PCTV 330e and HVR-900R2. The patches have been tested for quite some time by users on the Kernel Labs blog, and they have been quite happy with them. The firmware required can be found here: http://kernellabs.com/firmware/drxd/ The following changes since commit 41f3becb7bef489f9e8c35284dd88a1ff59b190c: [media] V4L DocBook: update V4L2 version (2011-03-11 18:09:02 -0300) are available in the git repository at: git://sol.kernellabs.com/dheitmueller/drx.git drxd The pull request went fine. I'll be handling the series right now. One quick note for your next pull requests: Please don't add: Priority: normal Meta-tag on git patches. All patches are handled by default as normal patches. If you want to send me fixes, please use a separate pull request. Also, if a patch is meant to be sent also to stable kernels, just add: Cc: sta...@kernel.org And upstream stable team will take care on it, when the patch arrives Linus tree. Devin Heitmueller (12): drx: add initial drx-d driver drxd: add driver to Makefile and Kconfig drxd: provide ability to control rs byte em28xx: enable support for the drx-d on the HVR-900 R2 drxd: provide ability to disable the i2c gate control function em28xx: fix GPIO problem with HVR-900R2 getting out of sync with drx-d em28xx: include model number for PCTV 330e em28xx: add digital support for PCTV 330e drxd: move firmware to binary blob em28xx: remove not validated flag for PCTV 330e em28xx: add remote control support for PCTV 330e drxd: Run lindent across sources Documentation/video4linux/CARDLIST.em28xx |2 +- drivers/media/dvb/frontends/Kconfig | 11 + drivers/media/dvb/frontends/Makefile|2 + drivers/media/dvb/frontends/drxd.h | 61 + drivers/media/dvb/frontends/drxd_firm.c | 929 ++ drivers/media/dvb/frontends/drxd_firm.h | 118 + drivers/media/dvb/frontends/drxd_hard.c | 2806 ++ drivers/media/dvb/frontends/drxd_map_firm.h |12694 +++ drivers/media/video/em28xx/em28xx-cards.c | 21 +- drivers/media/video/em28xx/em28xx-dvb.c | 22 +- drivers/media/video/em28xx/em28xx.h |2 +- 11 files changed, 16649 insertions(+), 19 deletions(-) create mode 100644 drivers/media/dvb/frontends/drxd.h create mode 100644 drivers/media/dvb/frontends/drxd_firm.c create mode 100644 drivers/media/dvb/frontends/drxd_firm.h create mode 100644 drivers/media/dvb/frontends/drxd_hard.c create mode 100644 drivers/media/dvb/frontends/drxd_map_firm.h -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [GIT PULL] HVR-900 R2 and PCTV 330e DVB support
On Thu, Mar 24, 2011 at 1:34 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: One quick note for your next pull requests: Please don't add: Priority: normal Sure, no problem. I actually knew that but just forgot to strip the priority tags from the patches when I converted the tree from hg to git. Thanks, Devin -- Devin J. Heitmueller - Kernel Labs http://www.kernellabs.com -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
