Re: [GIT PULL for 3.6-rc1] media updates part 2
Hi, On 08/09/2012 10:03 PM, David Rientjes wrote: On Thu, 9 Aug 2012, Mauro Carvalho Chehab wrote: Yeah, that would work as well, although the code would look uglier. IMHO, using select/depend is better. Agreed, I think it should be depends on LEDS_CLASS rather than select it if there is a hard dependency that cannot be fixed with extracting the led support in the driver to #ifdef CONFIG_LEDS_CLASS code. The led support could be #ifdef CONFIG_LEDS_CLASS, the problem with that approach is the whole module versus build-in thing: led-class shark enable-led-support build-inbuild-inyes build-inmodule yes module build-inno module module yes Now this can be coded into #ifdef magic, but it won't be pretty, of course we only need the non pretty version once at the top to set a SHARK_USE_LEDS define, but still. I'm fine with either solution (depends or ifdef magic), although I think that people will get unpleasantly surprised if they want to use the shark driver and they don't get to see it in the menu because they don't have leds enabled. Regards, Hans -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [GIT PULL for 3.6-rc1] media updates part 2
Em 08-08-2012 19:28, David Rientjes escreveu: On Tue, 31 Jul 2012, Mauro Carvalho Chehab wrote: [media] radio-shark: New driver for the Griffin radioSHARK USB radio receiver This one gives me a build warning if CONFIG_LEDS_CLASS is disabled: ERROR: led_classdev_register [drivers/media/radio/shark2.ko] undefined! ERROR: led_classdev_unregister [drivers/media/radio/shark2.ko] undefined! Could you please test the enclosed patch? Thanks! Mauro - [media] radio-shark: make sure LEDS_CLASS is selected As reported by David: ERROR: led_classdev_register [drivers/media/radio/shark2.ko] undefined! ERROR: led_classdev_unregister [drivers/media/radio/shark2.ko] undefined! Reported-by: Dadiv Rientjes rient...@google.com Cc: Hans de Goede hdego...@redhat.com Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com diff --git a/drivers/media/radio/Kconfig b/drivers/media/radio/Kconfig index 8090b87..be68ec2 100644 --- a/drivers/media/radio/Kconfig +++ b/drivers/media/radio/Kconfig @@ -60,6 +60,7 @@ config RADIO_MAXIRADIO config RADIO_SHARK tristate Griffin radioSHARK USB radio receiver depends on USB SND + select LEDS_CLASS ---help--- Choose Y here if you have this radio receiver. @@ -77,6 +78,7 @@ config RADIO_SHARK config RADIO_SHARK2 tristate Griffin radioSHARK2 USB radio receiver depends on USB + select LEDS_CLASS ---help--- Choose Y here if you have this radio receiver. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [GIT PULL for 3.6-rc1] media updates part 2
Hi, My bad, sorry about this. Mauro's patch looks good. An alternative fix would be to #ifdefify the led code in the drivers themselves. Regards, Hans On 08/09/2012 01:38 PM, Mauro Carvalho Chehab wrote: Em 08-08-2012 19:28, David Rientjes escreveu: On Tue, 31 Jul 2012, Mauro Carvalho Chehab wrote: [media] radio-shark: New driver for the Griffin radioSHARK USB radio receiver This one gives me a build warning if CONFIG_LEDS_CLASS is disabled: ERROR: led_classdev_register [drivers/media/radio/shark2.ko] undefined! ERROR: led_classdev_unregister [drivers/media/radio/shark2.ko] undefined! Could you please test the enclosed patch? Thanks! Mauro - [media] radio-shark: make sure LEDS_CLASS is selected As reported by David: ERROR: led_classdev_register [drivers/media/radio/shark2.ko] undefined! ERROR: led_classdev_unregister [drivers/media/radio/shark2.ko] undefined! Reported-by: Dadiv Rientjes rient...@google.com Cc: Hans de Goede hdego...@redhat.com Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com diff --git a/drivers/media/radio/Kconfig b/drivers/media/radio/Kconfig index 8090b87..be68ec2 100644 --- a/drivers/media/radio/Kconfig +++ b/drivers/media/radio/Kconfig @@ -60,6 +60,7 @@ config RADIO_MAXIRADIO config RADIO_SHARK tristate Griffin radioSHARK USB radio receiver depends on USB SND + select LEDS_CLASS ---help--- Choose Y here if you have this radio receiver. @@ -77,6 +78,7 @@ config RADIO_SHARK config RADIO_SHARK2 tristate Griffin radioSHARK2 USB radio receiver depends on USB + select LEDS_CLASS ---help--- Choose Y here if you have this radio receiver. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [GIT PULL for 3.6-rc1] media updates part 2
Em 09-08-2012 09:00, Hans de Goede escreveu: Hi, My bad, sorry about this. Mauro's patch looks good. Hmm... menuconfig NEW_LEDS bool LED Support help Say Y to enable Linux LED support. This allows control of supported LEDs from both userspace and optionally, by kernel events (triggers). This is not related to standard keyboard LEDs which are controlled via the input system. if NEW_LEDS config LEDS_CLASS ... It seems that the patch also need to select or depend on NEW_LEDS. An alternative fix would be to #ifdefify the led code in the drivers themselves. Yeah, that would work as well, although the code would look uglier. IMHO, using select/depend is better. Regards, Mauro Regards, Hans On 08/09/2012 01:38 PM, Mauro Carvalho Chehab wrote: Em 08-08-2012 19:28, David Rientjes escreveu: On Tue, 31 Jul 2012, Mauro Carvalho Chehab wrote: [media] radio-shark: New driver for the Griffin radioSHARK USB radio receiver This one gives me a build warning if CONFIG_LEDS_CLASS is disabled: ERROR: led_classdev_register [drivers/media/radio/shark2.ko] undefined! ERROR: led_classdev_unregister [drivers/media/radio/shark2.ko] undefined! Could you please test the enclosed patch? Thanks! Mauro - [media] radio-shark: make sure LEDS_CLASS is selected As reported by David: ERROR: led_classdev_register [drivers/media/radio/shark2.ko] undefined! ERROR: led_classdev_unregister [drivers/media/radio/shark2.ko] undefined! Reported-by: Dadiv Rientjes rient...@google.com Cc: Hans de Goede hdego...@redhat.com Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com diff --git a/drivers/media/radio/Kconfig b/drivers/media/radio/Kconfig index 8090b87..be68ec2 100644 --- a/drivers/media/radio/Kconfig +++ b/drivers/media/radio/Kconfig @@ -60,6 +60,7 @@ config RADIO_MAXIRADIO config RADIO_SHARK tristate Griffin radioSHARK USB radio receiver depends on USB SND +select LEDS_CLASS ---help--- Choose Y here if you have this radio receiver. @@ -77,6 +78,7 @@ config RADIO_SHARK config RADIO_SHARK2 tristate Griffin radioSHARK2 USB radio receiver depends on USB +select LEDS_CLASS ---help--- Choose Y here if you have this radio receiver. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [GIT PULL for 3.6-rc1] media updates part 2
On Thu, 9 Aug 2012, Mauro Carvalho Chehab wrote: Yeah, that would work as well, although the code would look uglier. IMHO, using select/depend is better. Agreed, I think it should be depends on LEDS_CLASS rather than select it if there is a hard dependency that cannot be fixed with extracting the led support in the driver to #ifdef CONFIG_LEDS_CLASS code. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [GIT PULL for 3.6-rc1] media updates part 2
On Tue, 31 Jul 2012, Mauro Carvalho Chehab wrote: [media] radio-shark: New driver for the Griffin radioSHARK USB radio receiver This one gives me a build warning if CONFIG_LEDS_CLASS is disabled: ERROR: led_classdev_register [drivers/media/radio/shark2.ko] undefined! ERROR: led_classdev_unregister [drivers/media/radio/shark2.ko] undefined! -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PULL for 3.6-rc1] media updates part 2
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media v4l_for_linus For the second part of media patches: - radio API: add support to work with radio frequency bands; - new AM/FM radio drivers: radio-shark, radio-shark2; - new Remote Controller USB driver: iguanair; - conversion of several drivers to the v4l2 core control framework; - new board additions at existing drivers; - the remaining (and vast majority of the patches) are due to drivers/DocBook fixes/cleanups. - - The following changes since commit 2cefabc00ffdc1f22f960df946ae41b163081d5e: v4l: Export v4l2-common.h in include/linux/Kbuild (2012-07-12 03:27:39 -0300) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media v4l_for_linus for you to fetch changes up to 4d98015eef6fa97b0cbba7310041ab75b223524b: [media] tlg2300: Declare MODULE_FIRMWARE usage (2012-07-30 23:46:53 -0300) - Alan Cox (3): [media] ov9640: fix missing break [media] cx25821,medusa: incorrect check on decoder type [media] az6007: fix incorrect memcpy Anton Blanchard (3): [media] cx23885: Silence unknown command warnings [media] winbond-cir: Fix txandrx module info [media] winbond-cir: Initialise timeout, driver_type and allowed_protos Antonio Ospite (2): [media] gspca_kinect: remove traces of the gspca control mechanism [media] gspca_ov534: Convert to the control framework Dan Carpenter (4): [media] tvp5150: signedness bug in tvp5150_selmux() [media] tuner-xc2028: fix = vs == typo [media] tuner-xc2028: unlock on error in xc2028_get_afc() [media] dib8000: move dereference after check for NULL Daniel Drake (1): [media] via-camera: pass correct format settings to sensor David Dillow (1): [media] cx231xx: don't DMA to random addresses Devendra Naga (2): [media] staging/media/dt3155v4l: use module_pci_driver macro [media] staging/media/solo6x10: use module_pci_driver macro Devin Heitmueller (6): [media] cx25840: fix regression in HVR-1800 analog support [media] cx25840: fix regression in analog support hue/saturation controls [media] cx25840: fix regression in HVR-1800 analog audio [media] cx25840: fix vsrc/hsrc usage on cx23888 designs [media] cx23885: make analog support work for HVR_1250 (cx23885 variant) [media] cx23885: add support for HVR-1255 analog (cx23888 variant) Douglas Bagnall (1): [media] Avoid sysfs oops when an rc_dev's raw device is absent Dror Cohen (1): [media] media/video: vpif: fixed vpfe-vpif typo Du, Changbin (1): [media] rc: ati_remote.c: code style fixing Duan Jiong (2): [media] smiapp-core.c: remove duplicated include [media] pms.c: remove duplicated include Emil Goode (1): [media] lirc: fix non-ANSI function declaration warning Ezequiel García (11): [media] saa7164: Remove useless struct i2c_algo_bit_data [media] cx23885: Remove useless struct i2c_algo_bit_data [media] cx231xx: Remove useless struct i2c_algo_bit_data [media] cx25821: Remove useless struct i2c_algo_bit_data [media] saa7164: Remove unused saa7164_call_i2c_clients() [media] saa7164: Replace struct memcpy with struct assignment [media] cx23885: Replace struct memcpy with struct assignment [media] cx231xx: Replace struct memcpy with struct assignment [media] cx25821: Replace struct memcpy with struct assignment [media] v4l2-dev.c: Move video_put() after debug printk [media] cx25821: Remove bad strcpy to read-only char* Federico Vaga (1): [media] adv7180.c: convert to v4l2 control framework Fengguang Wu (1): [media] pms: fix build error in pms_probe() Hans Verkuil (49): [media] Fix VIDIOC_TRY_EXT_CTRLS regression [media] gspca-conex: convert to the control framework [media] gspca-cpia1: convert to the control framework [media] gspca-etoms: convert to the control framework [media] gspca-jeilinj: convert to the control framework [media] gspca-konica: convert to the control framework [media] gspca-mr97310a: convert to the control framework [media] nw80x: convert to the control framework [media] ov519: convert to the control framework [media] ov534_9: convert to the control framework [media] es401: convert to the control framework [media] spca1528: convert to the control framework [media] spca500: convert to the control framework [media] spca501: convert to the control framework [media] gspca-spca501: remove old function prototypes [media] spca505: convert to the control framework [media] spca506: convert to the control framework [media] spca508: convert to
Re: [GIT PULL for 3.6-rc1] media updates part 2
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Em 31-07-2012 12:15, Mauro Carvalho Chehab escreveu: Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media v4l_for_linus For the second part of media patches: - radio API: add support to work with radio frequency bands; - new AM/FM radio drivers: radio-shark, radio-shark2; - new Remote Controller USB driver: iguanair; - conversion of several drivers to the v4l2 core control framework; - new board additions at existing drivers; - the remaining (and vast majority of the patches) are due to drivers/DocBook fixes/cleanups. Linus, Randy pointed me a compilation breakage due to a 64 bit division, so I added one extra patch there: [media] radio-tea5777: use library for 64bits div So, please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media v4l_for_linus For the above plus the fix. Thank you! Mauro - - The following changes since commit 2cefabc00ffdc1f22f960df946ae41b163081d5e: v4l: Export v4l2-common.h in include/linux/Kbuild (2012-07-12 03:27:39 -0300) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media v4l_for_linus for you to fetch changes up to adfe1560de1c696324554fba70c92f2d7c947ff7: [media] radio-tea5777: use library for 64bits div (2012-07-31 18:24:44 -0300) - Alan Cox (3): [media] ov9640: fix missing break [media] cx25821,medusa: incorrect check on decoder type [media] az6007: fix incorrect memcpy Anton Blanchard (3): [media] cx23885: Silence unknown command warnings [media] winbond-cir: Fix txandrx module info [media] winbond-cir: Initialise timeout, driver_type and allowed_protos Antonio Ospite (2): [media] gspca_kinect: remove traces of the gspca control mechanism [media] gspca_ov534: Convert to the control framework Dan Carpenter (4): [media] tvp5150: signedness bug in tvp5150_selmux() [media] tuner-xc2028: fix = vs == typo [media] tuner-xc2028: unlock on error in xc2028_get_afc() [media] dib8000: move dereference after check for NULL Daniel Drake (1): [media] via-camera: pass correct format settings to sensor David Dillow (1): [media] cx231xx: don't DMA to random addresses Devendra Naga (2): [media] staging/media/dt3155v4l: use module_pci_driver macro [media] staging/media/solo6x10: use module_pci_driver macro Devin Heitmueller (6): [media] cx25840: fix regression in HVR-1800 analog support [media] cx25840: fix regression in analog support hue/saturation controls [media] cx25840: fix regression in HVR-1800 analog audio [media] cx25840: fix vsrc/hsrc usage on cx23888 designs [media] cx23885: make analog support work for HVR_1250 (cx23885 variant) [media] cx23885: add support for HVR-1255 analog (cx23888 variant) Douglas Bagnall (1): [media] Avoid sysfs oops when an rc_dev's raw device is absent Dror Cohen (1): [media] media/video: vpif: fixed vpfe-vpif typo Du, Changbin (1): [media] rc: ati_remote.c: code style fixing Duan Jiong (2): [media] smiapp-core.c: remove duplicated include [media] pms.c: remove duplicated include Emil Goode (1): [media] lirc: fix non-ANSI function declaration warning Ezequiel García (11): [media] saa7164: Remove useless struct i2c_algo_bit_data [media] cx23885: Remove useless struct i2c_algo_bit_data [media] cx231xx: Remove useless struct i2c_algo_bit_data [media] cx25821: Remove useless struct i2c_algo_bit_data [media] saa7164: Remove unused saa7164_call_i2c_clients() [media] saa7164: Replace struct memcpy with struct assignment [media] cx23885: Replace struct memcpy with struct assignment [media] cx231xx: Replace struct memcpy with struct assignment [media] cx25821: Replace struct memcpy with struct assignment [media] v4l2-dev.c: Move video_put() after debug printk [media] cx25821: Remove bad strcpy to read-only char* Federico Vaga (1): [media] adv7180.c: convert to v4l2 control framework Fengguang Wu (1): [media] pms: fix build error in pms_probe() Hans Verkuil (49): [media] Fix VIDIOC_TRY_EXT_CTRLS regression [media] gspca-conex: convert to the control framework [media] gspca-cpia1: convert to the control framework [media] gspca-etoms: convert to the control framework [media] gspca-jeilinj: convert to the control framework [media] gspca-konica: convert to the control framework [media] gspca-mr97310a: convert to the control framework [media] nw80x: convert to the control framework [media] ov519: convert to the control framework [media] ov534_9: convert to the control framework [media] es401: convert to the control
