Re: [PATCH] Fix Warning ISO C90 forbids mixed declarations and code - cx88-dvb
On Wednesday 24 March 2010 14:45:50 Douglas Schilling Landgraf wrote: Hello Ricardo, On Wed, Mar 24, 2010 at 10:27 AM, Ricardo Maraschini xrma...@gmail.com wrote: Signed-off-by: Ricardo Maraschini ricardo.marasch...@gmail.com --- a/linux/drivers/media/video/cx88/cx88-dvb.c Tue Mar 23 17:52:23 2010 -0300 +++ b/linux/drivers/media/video/cx88/cx88-dvb.c Wed Mar 24 09:57:06 2010 -0300 @@ -1401,8 +1401,6 @@ case CX88_BOARD_SAMSUNG_SMT_7020: dev-ts_gen_cntrl = 0x08; - struct cx88_core *core = dev-core; - cx_set(MO_GP0_IO, 0x0101); cx_clear(MO_GP0_IO, 0x01); This version seems ok to my eyes. And also to my eyes. Mauro, can you please merge this? This patch didn't turn up in patchwork for some reason. This will fix an annoying compile warning. Regards, Hans Thanks Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Hans Verkuil - video4linux developer - sponsored by TANDBERG -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Fix Warning ISO C90 forbids mixed declarations and code - cx88-dvb
Signed-off-by: Ricardo Maraschini ricardo.marasch...@gmail.com --- a/linux/drivers/media/video/cx88/cx88-dvb.c Tue Mar 23 17:52:23 2010 -0300 +++ b/linux/drivers/media/video/cx88/cx88-dvb.c Wed Mar 24 09:57:06 2010 -0300 @@ -1401,8 +1401,6 @@ case CX88_BOARD_SAMSUNG_SMT_7020: dev-ts_gen_cntrl = 0x08; - struct cx88_core *core = dev-core; - cx_set(MO_GP0_IO, 0x0101); cx_clear(MO_GP0_IO, 0x01); -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Fix Warning ISO C90 forbids mixed declarations and code - cx88-dvb
Hello Ricardo, On Wed, Mar 24, 2010 at 10:27 AM, Ricardo Maraschini xrma...@gmail.com wrote: Signed-off-by: Ricardo Maraschini ricardo.marasch...@gmail.com --- a/linux/drivers/media/video/cx88/cx88-dvb.c Tue Mar 23 17:52:23 2010 -0300 +++ b/linux/drivers/media/video/cx88/cx88-dvb.c Wed Mar 24 09:57:06 2010 -0300 @@ -1401,8 +1401,6 @@ case CX88_BOARD_SAMSUNG_SMT_7020: dev-ts_gen_cntrl = 0x08; - struct cx88_core *core = dev-core; - cx_set(MO_GP0_IO, 0x0101); cx_clear(MO_GP0_IO, 0x01); This version seems ok to my eyes. Thanks Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Fix Warning ISO C90 forbids mixed declarations and code - cx88-dvb
Ricardo Maraschini wrote: --- a/linux/drivers/media/video/cx88/cx88-dvb.c Tue Mar 23 16:17:11 2010 -0300 +++ b/linux/drivers/media/video/cx88/cx88-dvb.c Tue Mar 23 17:29:29 2010 -0300 @@ -1401,7 +1401,8 @@ case CX88_BOARD_SAMSUNG_SMT_7020: dev-ts_gen_cntrl = 0x08; - struct cx88_core *core = dev-core; + struct cx88_core *core; + core = dev-core; cx_set(MO_GP0_IO, 0x0101); Signed-off-by: Ricardo Maraschini ricardo.marasch...@gmail.com For any comments, please CC me in the message. I am waiting moderator approval to subscribe to this mailing list -- Hi, Did you test this patch (by building this driver)? I think not. Also, the Signed-off-by: line should be before the patch, not after it. ~Randy -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Fix Warning ISO C90 forbids mixed declarations and code - cx88-dvb
Hi Randy, On Tue, Mar 23, 2010 at 4:45 PM, Randy Dunlap randy.dun...@oracle.com wrote: Did you test this patch (by building this driver)? I think not. I tried to compile with the patch, but in a wrong way. Sorry. I'm going to adjust the patch and send again. Also, the Signed-off-by: line should be before the patch, not after it. Thanks, I will remember this. -rm -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Fix Warning ISO C90 forbids mixed declarations and code - cx88-dvb
On Tue, Mar 23, 2010 at 5:48 PM, Devin Heitmueller dheitmuel...@kernellabs.com wrote: How do you think this actually addresses the warning in question? You still have the declaration of the variable in the middle of the switch statement. My mistake, sorry. I'm working on it. Thanks for your tip, I really appreciate that. -rm -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
