Re: [PATCH] Input: Add missing event codes for common IR remote buttons

[kbuild test robot]

Hi Derek,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on input/next]
[also build test WARNING on v4.19 next-20181102]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Derek-Kelly/Input-Add-missing-event-codes-for-common-IR-remote-buttons/20181103-135217
base:   https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
config: powerpc-defconfig (attached as .config)
compiler: powerpc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=powerpc 

All warnings (new ones prefixed by >>):

   In file included from sound/ppc/pmac.h:39:0,
from sound/ppc/beep.c:30:
>> arch/powerpc/include/asm/dbdma.h:70:0: warning: "KEY_SYSTEM" redefined
#define KEY_SYSTEM 0x600 /* system memory-mapped space */

   In file included from include/uapi/linux/input.h:20:0,
from include/linux/input.h:13,
from sound/ppc/beep.c:25:
   include/uapi/linux/input-event-codes.h:698:0: note: this is the location of 
the previous definition
#define KEY_SYSTEM   0x2ed /* Open systems menu/display */


vim +/KEY_SYSTEM +70 arch/powerpc/include/asm/dbdma.h

^1da177e include/asm-ppc/dbdma.h Linus Torvalds 2005-04-16  63  
^1da177e include/asm-ppc/dbdma.h Linus Torvalds 2005-04-16  64  /* Key values 
in command field */
^1da177e include/asm-ppc/dbdma.h Linus Torvalds 2005-04-16  65  #define 
KEY_STREAM0 0   /* usual data stream */
^1da177e include/asm-ppc/dbdma.h Linus Torvalds 2005-04-16  66  #define 
KEY_STREAM1 0x100   /* control/status stream */
^1da177e include/asm-ppc/dbdma.h Linus Torvalds 2005-04-16  67  #define 
KEY_STREAM2 0x200   /* device-dependent stream */
^1da177e include/asm-ppc/dbdma.h Linus Torvalds 2005-04-16  68  #define 
KEY_STREAM3 0x300   /* device-dependent stream */
^1da177e include/asm-ppc/dbdma.h Linus Torvalds 2005-04-16  69  #define 
KEY_REGS0x500   /* device register space */
^1da177e include/asm-ppc/dbdma.h Linus Torvalds 2005-04-16 @70  #define 
KEY_SYSTEM  0x600   /* system memory-mapped space */
^1da177e include/asm-ppc/dbdma.h Linus Torvalds 2005-04-16  71  #define 
KEY_DEVICE  0x700   /* device memory-mapped space */
^1da177e include/asm-ppc/dbdma.h Linus Torvalds 2005-04-16  72  

:: The code at line 70 was first introduced by commit
:: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2

:: TO: Linus Torvalds 
:: CC: Linus Torvalds 

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

[PATCH] Input: Add missing event codes for common IR remote buttons

[Derek Kelly]

The following patch adds event codes for common buttons found on various
provider and universal remote controls. They represent functions not
covered by existing event codes. Once added, rc_keymaps can be updated
accordingly where applicable.

Signed-off-by: Derek Kelly 
---
 include/uapi/linux/input-event-codes.h | 13 +
 1 file changed, 13 insertions(+)

diff --git a/include/uapi/linux/input-event-codes.h 
b/include/uapi/linux/input-event-codes.h
index 53fbae27b280..c68d022163e5 100644
--- a/include/uapi/linux/input-event-codes.h
+++ b/include/uapi/linux/input-event-codes.h
@@ -689,6 +689,19 @@
 #define BTN_TRIGGER_HAPPY390x2e6
 #define BTN_TRIGGER_HAPPY400x2e7
 
+/* Remote control buttons found across provider & universal remotes */
+#define KEY_LIVE_TV0x2e8   /* Jump to live tv viewing */
+#define KEY_OPTIONS0x2e9   /* Jump to options */
+#define KEY_INTERACTIVE0x2ea   /* Jump to interactive 
system/menu/item */
+#define KEY_MIC_INPUT  0x2eb   /* Trigger MIC input/listen 
mode */
+#define KEY_SCREEN_INPUT   0x2ec   /* Open on-screen input system 
*/
+#define KEY_SYSTEM 0x2ed   /* Open systems menu/display */
+#define KEY_SERVICES   0x2ee   /* Open services menu/display */
+#define KEY_DISPLAY_FORMAT 0x2ef   /* Cycle display formats */
+#define KEY_PIP0x2f0   /* Toggle 
Picture-in-Picture on/off */
+#define KEY_PIP_SWAP   0x2f1   /* Swap contents between main 
view and PIP window */
+#define KEY_PIP_POSITION   0x2f2   /* Cycle PIP window position */
+
 /* We avoid low common keys in module aliases so they don't get huge. */
 #define KEY_MIN_INTERESTINGKEY_MUTE
 #define KEY_MAX0x2ff
-- 
2.19.1