Re: [PATCH] V4L/DVB: mantis: Fix IR_CORE dependency
Em 24-08-2010 16:30, Ingo Molnar escreveu: > > * Randy Dunlap wrote: > >> On 08/24/10 01:45, Ingo Molnar wrote: >>> >>> * Mauro Carvalho Chehab wrote: >>> >>>> Linus, >>>> >>>> Please pull from: >>>> ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git >>>> v4l_for_linus >>>> >>>> For 3 build fixes. >>>> >>>> Cheers, >>>> Mauro. >>>> >>>> The following changes since commit >>>> ad41a1e0cab07c5125456e8d38e5b1ab148d04aa: >>>> >>>> Merge branch 'io_remap_pfn_range' of git://www.jni.nu/cris (2010-08-12 >>>> 10:17:19 -0700) >>>> >>>> are available in the git repository at: >>>> >>>> ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git >>>> v4l_for_linus >>>> >>>> Mauro Carvalho Chehab (2): >>>> V4L/DVB: Fix IR_CORE dependencies >>>> V4L/DVB: fix Kconfig to depends on VIDEO_IR >>>> >>>> Randy Dunlap (1): >>>> V4L/DVB: v4l2-ctrls.c: needs to include slab.h >>> >>> FYI, there's one more IR_CORE related build bug which triggers >>> frequently in randconfig tests - see the fix below. >>> >>> Thanks, >>> >>> Ingo >>> >>> ---> >>> From c56aef270d7ec01564c632c1f7ebab6b8f9f032c Mon Sep 17 00:00:00 2001 >>> From: Ingo Molnar >>> Date: Tue, 24 Aug 2010 10:41:33 +0200 >>> Subject: [PATCH] V4L/DVB: mantis: Fix IR_CORE dependency >>> >>> This build bug triggers: >>> >>> drivers/built-in.o: In function `mantis_exit': >>> (.text+0x377413): undefined reference to `ir_input_unregister' >>> drivers/built-in.o: In function `mantis_input_init': >>> (.text+0x3774ff): undefined reference to `__ir_input_register' >>> >>> If MANTIS_CORE is enabled but IR_CORE is not. Add the correct >>> dependency. >>> >>> Signed-off-by: Ingo Molnar >>> --- >>> drivers/media/dvb/mantis/Kconfig |2 +- >>> 1 files changed, 1 insertions(+), 1 deletions(-) >>> >>> diff --git a/drivers/media/dvb/mantis/Kconfig >>> b/drivers/media/dvb/mantis/Kconfig >>> index decdeda..fd0830e 100644 >>> --- a/drivers/media/dvb/mantis/Kconfig >>> +++ b/drivers/media/dvb/mantis/Kconfig >>> @@ -1,6 +1,6 @@ >>> config MANTIS_CORE >>> tristate "Mantis/Hopper PCI bridge based devices" >>> - depends on PCI && I2C && INPUT >>> + depends on PCI && I2C && INPUT && IR_CORE >>> >>> help >>> Support for PCI cards based on the Mantis and Hopper PCi bridge. >> >> >> Acked-by: Randy Dunlap >> http://lkml.org/lkml/2010/8/17/341 > > Your patch came first :-) > > Btw., the reason i missed your patch is that i grepped lkml for the > static build failure - while your changelog contained the modular one. > Oh well :) I've added this patch earlier today on my tree: http://git.linuxtv.org/media_tree.git?a=commit;h=3a057c36346f60bd0fb4fe7d7a68c4d931d8768f and the other IR_CORE fixup at staging/tm6000: http://git.linuxtv.org/media_tree.git?a=commit;h=926a2496438f44268130f72f5e102dcac484573d I'll be sending them today to my linux-next tree and likely tomorrow to upstream, together with a few other fixes. > > Thanks, > > Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] V4L/DVB: mantis: Fix IR_CORE dependency
* Randy Dunlap wrote: > On 08/24/10 01:45, Ingo Molnar wrote: > > > > * Mauro Carvalho Chehab wrote: > > > >> Linus, > >> > >> Please pull from: > >> ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git > >> v4l_for_linus > >> > >> For 3 build fixes. > >> > >> Cheers, > >> Mauro. > >> > >> The following changes since commit > >> ad41a1e0cab07c5125456e8d38e5b1ab148d04aa: > >> > >> Merge branch 'io_remap_pfn_range' of git://www.jni.nu/cris (2010-08-12 > >> 10:17:19 -0700) > >> > >> are available in the git repository at: > >> > >> ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git > >> v4l_for_linus > >> > >> Mauro Carvalho Chehab (2): > >> V4L/DVB: Fix IR_CORE dependencies > >> V4L/DVB: fix Kconfig to depends on VIDEO_IR > >> > >> Randy Dunlap (1): > >> V4L/DVB: v4l2-ctrls.c: needs to include slab.h > > > > FYI, there's one more IR_CORE related build bug which triggers > > frequently in randconfig tests - see the fix below. > > > > Thanks, > > > > Ingo > > > > ---> > > From c56aef270d7ec01564c632c1f7ebab6b8f9f032c Mon Sep 17 00:00:00 2001 > > From: Ingo Molnar > > Date: Tue, 24 Aug 2010 10:41:33 +0200 > > Subject: [PATCH] V4L/DVB: mantis: Fix IR_CORE dependency > > > > This build bug triggers: > > > > drivers/built-in.o: In function `mantis_exit': > > (.text+0x377413): undefined reference to `ir_input_unregister' > > drivers/built-in.o: In function `mantis_input_init': > > (.text+0x3774ff): undefined reference to `__ir_input_register' > > > > If MANTIS_CORE is enabled but IR_CORE is not. Add the correct > > dependency. > > > > Signed-off-by: Ingo Molnar > > --- > > drivers/media/dvb/mantis/Kconfig |2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/media/dvb/mantis/Kconfig > > b/drivers/media/dvb/mantis/Kconfig > > index decdeda..fd0830e 100644 > > --- a/drivers/media/dvb/mantis/Kconfig > > +++ b/drivers/media/dvb/mantis/Kconfig > > @@ -1,6 +1,6 @@ > > config MANTIS_CORE > > tristate "Mantis/Hopper PCI bridge based devices" > > - depends on PCI && I2C && INPUT > > + depends on PCI && I2C && INPUT && IR_CORE > > > > help > > Support for PCI cards based on the Mantis and Hopper PCi bridge. > > > Acked-by: Randy Dunlap > http://lkml.org/lkml/2010/8/17/341 Your patch came first :-) Btw., the reason i missed your patch is that i grepped lkml for the static build failure - while your changelog contained the modular one. Oh well :) Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] V4L/DVB: mantis: Fix IR_CORE dependency
On 08/24/10 01:45, Ingo Molnar wrote: > > * Mauro Carvalho Chehab wrote: > >> Linus, >> >> Please pull from: >> ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git >> v4l_for_linus >> >> For 3 build fixes. >> >> Cheers, >> Mauro. >> >> The following changes since commit ad41a1e0cab07c5125456e8d38e5b1ab148d04aa: >> >> Merge branch 'io_remap_pfn_range' of git://www.jni.nu/cris (2010-08-12 >> 10:17:19 -0700) >> >> are available in the git repository at: >> >> ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git >> v4l_for_linus >> >> Mauro Carvalho Chehab (2): >> V4L/DVB: Fix IR_CORE dependencies >> V4L/DVB: fix Kconfig to depends on VIDEO_IR >> >> Randy Dunlap (1): >> V4L/DVB: v4l2-ctrls.c: needs to include slab.h > > FYI, there's one more IR_CORE related build bug which triggers > frequently in randconfig tests - see the fix below. > > Thanks, > > Ingo > > ---> > From c56aef270d7ec01564c632c1f7ebab6b8f9f032c Mon Sep 17 00:00:00 2001 > From: Ingo Molnar > Date: Tue, 24 Aug 2010 10:41:33 +0200 > Subject: [PATCH] V4L/DVB: mantis: Fix IR_CORE dependency > > This build bug triggers: > > drivers/built-in.o: In function `mantis_exit': > (.text+0x377413): undefined reference to `ir_input_unregister' > drivers/built-in.o: In function `mantis_input_init': > (.text+0x3774ff): undefined reference to `__ir_input_register' > > If MANTIS_CORE is enabled but IR_CORE is not. Add the correct > dependency. > > Signed-off-by: Ingo Molnar > --- > drivers/media/dvb/mantis/Kconfig |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/media/dvb/mantis/Kconfig > b/drivers/media/dvb/mantis/Kconfig > index decdeda..fd0830e 100644 > --- a/drivers/media/dvb/mantis/Kconfig > +++ b/drivers/media/dvb/mantis/Kconfig > @@ -1,6 +1,6 @@ > config MANTIS_CORE > tristate "Mantis/Hopper PCI bridge based devices" > - depends on PCI && I2C && INPUT > + depends on PCI && I2C && INPUT && IR_CORE > > help > Support for PCI cards based on the Mantis and Hopper PCi bridge. Acked-by: Randy Dunlap http://lkml.org/lkml/2010/8/17/341 thanks, -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] V4L/DVB: mantis: Fix IR_CORE dependency
* Mauro Carvalho Chehab wrote: > Linus, > > Please pull from: > ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git > v4l_for_linus > > For 3 build fixes. > > Cheers, > Mauro. > > The following changes since commit ad41a1e0cab07c5125456e8d38e5b1ab148d04aa: > > Merge branch 'io_remap_pfn_range' of git://www.jni.nu/cris (2010-08-12 > 10:17:19 -0700) > > are available in the git repository at: > > ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git > v4l_for_linus > > Mauro Carvalho Chehab (2): > V4L/DVB: Fix IR_CORE dependencies > V4L/DVB: fix Kconfig to depends on VIDEO_IR > > Randy Dunlap (1): > V4L/DVB: v4l2-ctrls.c: needs to include slab.h FYI, there's one more IR_CORE related build bug which triggers frequently in randconfig tests - see the fix below. Thanks, Ingo ---> >From c56aef270d7ec01564c632c1f7ebab6b8f9f032c Mon Sep 17 00:00:00 2001 From: Ingo Molnar Date: Tue, 24 Aug 2010 10:41:33 +0200 Subject: [PATCH] V4L/DVB: mantis: Fix IR_CORE dependency This build bug triggers: drivers/built-in.o: In function `mantis_exit': (.text+0x377413): undefined reference to `ir_input_unregister' drivers/built-in.o: In function `mantis_input_init': (.text+0x3774ff): undefined reference to `__ir_input_register' If MANTIS_CORE is enabled but IR_CORE is not. Add the correct dependency. Signed-off-by: Ingo Molnar --- drivers/media/dvb/mantis/Kconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/dvb/mantis/Kconfig b/drivers/media/dvb/mantis/Kconfig index decdeda..fd0830e 100644 --- a/drivers/media/dvb/mantis/Kconfig +++ b/drivers/media/dvb/mantis/Kconfig @@ -1,6 +1,6 @@ config MANTIS_CORE tristate "Mantis/Hopper PCI bridge based devices" - depends on PCI && I2C && INPUT + depends on PCI && I2C && INPUT && IR_CORE help Support for PCI cards based on the Mantis and Hopper PCi bridge. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
