Re: [PATCH] V4L2 SDR: Add Real U8 format (V4L2_SDR_FMT_RU8)

[Philipp Zabel]

Hi Bertold,

On Mon, 2017-04-24 at 00:45 +0200, Bertold Van den Bergh wrote:
> This patch adds support for the Real U8 format to the V4L2 SDR framework.
> This will be used for a piece of hardware we are developing.
> 
> Signed-off-by: Bertold Van den Bergh 
> ---
>  drivers/media/v4l2-core/v4l2-ioctl.c | 1 +
>  include/uapi/linux/videodev2.h   | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c 
> b/drivers/media/v4l2-core/v4l2-ioctl.c
> index e5a2187..8b6e097 100644
> --- a/drivers/media/v4l2-core/v4l2-ioctl.c
> +++ b/drivers/media/v4l2-core/v4l2-ioctl.c
> @@ -1229,6 +1229,7 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt)
>   case V4L2_SDR_FMT_CS8:  descr = "Complex S8"; break;
>   case V4L2_SDR_FMT_CS14LE:   descr = "Complex S14LE"; break;
>   case V4L2_SDR_FMT_RU12LE:   descr = "Real U12LE"; break;
> + case V4L2_SDR_FMT_RU8:  descr = "Real U8"; break;
>   case V4L2_TCH_FMT_DELTA_TD16:   descr = "16-bit signed deltas"; break;
>   case V4L2_TCH_FMT_DELTA_TD08:   descr = "8-bit signed deltas"; break;
>   case V4L2_TCH_FMT_TU16: descr = "16-bit unsigned touch data"; 
> break;
> diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
> index 2b8feb8..50c3ef4 100644
> --- a/include/uapi/linux/videodev2.h
> +++ b/include/uapi/linux/videodev2.h
> @@ -669,6 +669,7 @@ struct v4l2_pix_format {
>  #define V4L2_SDR_FMT_CS8  v4l2_fourcc('C', 'S', '0', '8') /* complex 
> s8 */
>  #define V4L2_SDR_FMT_CS14LE   v4l2_fourcc('C', 'S', '1', '4') /* complex 
> s14le */
>  #define V4L2_SDR_FMT_RU12LE   v4l2_fourcc('R', 'U', '1', '2') /* real 
> u12le */
> +#define V4L2_SDR_FMT_RU8  v4l2_fourcc('R', 'U', '0', '8') /* real u8 
> */

When adding new SDR formats, could you also add an entry to
Documentation/media/uapi/v4l/sdr-formats.rst ? See for example
Documentation/media/uapi/v4l/pixfmt-sdr-ru12le.rst.

Also maybe V4L2_SDR_FMT_RU8 should be ordered above V4L2_SDR_FMT_RU12LE?
I'm not sure from the context.

regards
Philipp

[PATCH] V4L2 SDR: Add Real U8 format (V4L2_SDR_FMT_RU8)

[Bertold Van den Bergh]

This patch adds support for the Real U8 format to the V4L2 SDR framework.
This will be used for a piece of hardware we are developing.

Signed-off-by: Bertold Van den Bergh 
---
 drivers/media/v4l2-core/v4l2-ioctl.c | 1 +
 include/uapi/linux/videodev2.h   | 1 +
 2 files changed, 2 insertions(+)

diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c 
b/drivers/media/v4l2-core/v4l2-ioctl.c
index e5a2187..8b6e097 100644
--- a/drivers/media/v4l2-core/v4l2-ioctl.c
+++ b/drivers/media/v4l2-core/v4l2-ioctl.c
@@ -1229,6 +1229,7 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt)
case V4L2_SDR_FMT_CS8:  descr = "Complex S8"; break;
case V4L2_SDR_FMT_CS14LE:   descr = "Complex S14LE"; break;
case V4L2_SDR_FMT_RU12LE:   descr = "Real U12LE"; break;
+   case V4L2_SDR_FMT_RU8:  descr = "Real U8"; break;
case V4L2_TCH_FMT_DELTA_TD16:   descr = "16-bit signed deltas"; break;
case V4L2_TCH_FMT_DELTA_TD08:   descr = "8-bit signed deltas"; break;
case V4L2_TCH_FMT_TU16: descr = "16-bit unsigned touch data"; 
break;
diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
index 2b8feb8..50c3ef4 100644
--- a/include/uapi/linux/videodev2.h
+++ b/include/uapi/linux/videodev2.h
@@ -669,6 +669,7 @@ struct v4l2_pix_format {
 #define V4L2_SDR_FMT_CS8  v4l2_fourcc('C', 'S', '0', '8') /* complex 
s8 */
 #define V4L2_SDR_FMT_CS14LE   v4l2_fourcc('C', 'S', '1', '4') /* complex 
s14le */
 #define V4L2_SDR_FMT_RU12LE   v4l2_fourcc('R', 'U', '1', '2') /* real 
u12le */
+#define V4L2_SDR_FMT_RU8  v4l2_fourcc('R', 'U', '0', '8') /* real u8 */
 
 /* Touch formats - used for Touch devices */
 #define V4L2_TCH_FMT_DELTA_TD16v4l2_fourcc('T', 'D', '1', '6') /* 
16-bit signed deltas */
-- 
1.9.1