Re: [PATCH] cobalt: do not register subdev nodes

[Sakari Ailus]

On Mon, Aug 28, 2017 at 10:45:58AM +0200, Hans Verkuil wrote:
> In the distant past the adv7604 driver used private controls. In order to 
> access
> them the v4l-subdevX nodes were needed. Later the is_private tag was removed 
> in
> the adv7604 driver and the need for v4l-subdevX device nodes disappeared.
> 
> Remove the creation of those device nodes from this driver.
> 
> Note: the cobalt card is only used inside Cisco and we never actually used the
> v4l-subdevX nodes for anything. So this API change can be done safely without
> breaking anything.
> 
> Signed-off-by: Hans Verkuil 

Acked-by: Sakari Ailus 

-- 
Sakari Ailus
e-mail: sakari.ai...@iki.fi

[PATCH] cobalt: do not register subdev nodes

[Hans Verkuil]

In the distant past the adv7604 driver used private controls. In order to access
them the v4l-subdevX nodes were needed. Later the is_private tag was removed in
the adv7604 driver and the need for v4l-subdevX device nodes disappeared.

Remove the creation of those device nodes from this driver.

Note: the cobalt card is only used inside Cisco and we never actually used the
v4l-subdevX nodes for anything. So this API change can be done safely without
breaking anything.

Signed-off-by: Hans Verkuil 
---
diff --git a/drivers/media/pci/cobalt/cobalt-driver.c 
b/drivers/media/pci/cobalt/cobalt-driver.c
index 98b6cb9505d1..c9d8006ff697 100644
--- a/drivers/media/pci/cobalt/cobalt-driver.c
+++ b/drivers/media/pci/cobalt/cobalt-driver.c
@@ -738,9 +738,6 @@ static int cobalt_probe(struct pci_dev *pci_dev,
goto err_i2c;
}

-   retval = v4l2_device_register_subdev_nodes(&cobalt->v4l2_dev);
-   if (retval)
-   goto err_i2c;
retval = cobalt_nodes_register(cobalt);
if (retval) {
cobalt_err("Error %d registering device nodes\n", retval);