[PATCH] davinci: vpif: capture/display: fix race condition

2012-09-14 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar@ti.com

channel_first_int[][] variable is used as a flag for the ISR,
This flag was being set after enabling the interrupts, There
where suitaions when the isr ocuurend even before the flag was set
dues to which it was causing the applicaiotn hang.
This patch sets  channel_first_int[][] flag just before enabling the
interrupt.

Reported-by: David Oleszkiewicz doles...@adsyscontrols.com
Signed-off-by: Lad, Prabhakar prabhakar@ti.com
Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com
Cc: Hans Verkuil hans.verk...@cisco.com
---
 drivers/media/platform/davinci/vpif_capture.c |2 +-
 drivers/media/platform/davinci/vpif_display.c |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/platform/davinci/vpif_capture.c 
b/drivers/media/platform/davinci/vpif_capture.c
index 1b625b0..f64919b 100644
--- a/drivers/media/platform/davinci/vpif_capture.c
+++ b/drivers/media/platform/davinci/vpif_capture.c
@@ -339,6 +339,7 @@ static int vpif_start_streaming(struct vb2_queue *vq, 
unsigned int count)
 * Set interrupt for both the fields in VPIF Register enable channel in
 * VPIF register
 */
+   channel_first_int[VPIF_VIDEO_INDEX][ch-channel_id] = 1;
if ((VPIF_CHANNEL0_VIDEO == ch-channel_id)) {
channel0_intr_assert();
channel0_intr_enable(1);
@@ -350,7 +351,6 @@ static int vpif_start_streaming(struct vb2_queue *vq, 
unsigned int count)
channel1_intr_enable(1);
enable_channel1(1);
}
-   channel_first_int[VPIF_VIDEO_INDEX][ch-channel_id] = 1;
 
return 0;
 }
diff --git a/drivers/media/platform/davinci/vpif_display.c 
b/drivers/media/platform/davinci/vpif_display.c
index 4a24848..523a840 100644
--- a/drivers/media/platform/davinci/vpif_display.c
+++ b/drivers/media/platform/davinci/vpif_display.c
@@ -302,6 +302,7 @@ static int vpif_start_streaming(struct vb2_queue *vq, 
unsigned int count)
 
/* Set interrupt for both the fields in VPIF
Register enable channel in VPIF register */
+   channel_first_int[VPIF_VIDEO_INDEX][ch-channel_id] = 1;
if (VPIF_CHANNEL2_VIDEO == ch-channel_id) {
channel2_intr_assert();
channel2_intr_enable(1);
@@ -318,7 +319,6 @@ static int vpif_start_streaming(struct vb2_queue *vq, 
unsigned int count)
if (vpif_config_data-ch3_clip_en)
channel3_clipping_enable(1);
}
-   channel_first_int[VPIF_VIDEO_INDEX][ch-channel_id] = 1;
 
return 0;
 }
-- 
1.7.4.1

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] davinci: vpif: capture/display: fix race condition

2012-09-14 Thread Sergei Shtylyov
Hello.

On 09/14/2012 05:53 PM, Prabhakar Lad wrote:

 From: Lad, Prabhakar prabhakar@ti.com

 channel_first_int[][] variable is used as a flag for the ISR,
 This flag was being set after enabling the interrupts, There
 where suitaions when the isr ocuurend even before the flag was set

   s/suitaions/situations/, s/ocuurend/occured/

 dues to which it was causing the applicaiotn hang.

   Application.

 This patch sets  channel_first_int[][] flag just before enabling the
 interrupt.

 Reported-by: David Oleszkiewicz doles...@adsyscontrols.com
 Signed-off-by: Lad, Prabhakar prabhakar@ti.com
 Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com
 Cc: Hans Verkuil hans.verk...@cisco.com

WBR, Sergei

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html