[PATCH] drivers/media: Remove unnecessary semicolon
Remove unnecessary semicolon And: drivers/media/dvb-frontends/stv0900_core.c: remove unnecessary whitespace before a quoted newline Found by http://coccinelle.lip6.fr/ Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com --- drivers/media/dvb-core/dvb_frontend.c |2 drivers/media/dvb-frontends/a8293.c |2 drivers/media/dvb-frontends/af9013.c |6 +- drivers/media/dvb-frontends/bcm3510.c |2 drivers/media/dvb-frontends/cx24110.c |6 +- drivers/media/dvb-frontends/drxd_hard.c |2 drivers/media/dvb-frontends/isl6405.c |2 drivers/media/dvb-frontends/isl6421.c |2 drivers/media/dvb-frontends/itd1000.c |2 drivers/media/dvb-frontends/lnbp21.c |4 - drivers/media/dvb-frontends/lnbp22.c |2 drivers/media/dvb-frontends/si21xx.c |4 - drivers/media/dvb-frontends/sp8870.c |6 +- drivers/media/dvb-frontends/sp887x.c |6 +- drivers/media/dvb-frontends/stv0299.c |6 +- drivers/media/dvb-frontends/stv0900_core.c|2 drivers/media/dvb-frontends/tda8083.c |4 - drivers/media/i2c/cx25840/cx25840-core.c |2 drivers/media/pci/bt8xx/dst_ca.c |2 drivers/media/pci/cx23885/altera-ci.c |4 - drivers/media/pci/cx23885/cimax2.c|2 drivers/media/pci/cx88/cx88-blackbird.c |6 +- drivers/media/pci/cx88/cx88-dvb.c |2 drivers/media/pci/cx88/cx88-mpeg.c|2 drivers/media/pci/cx88/cx88-tvaudio.c |4 - drivers/media/pci/cx88/cx88-video.c |2 drivers/media/pci/saa7134/saa7134-video.c |2 drivers/media/platform/davinci/vpif_capture.c | 78 +- drivers/media/platform/exynos-gsc/gsc-regs.c |4 - drivers/media/platform/fsl-viu.c | 18 +++--- drivers/media/platform/vivi.c |2 drivers/media/radio/si470x/radio-si470x-i2c.c |2 drivers/media/radio/si470x/radio-si470x-usb.c |2 drivers/media/radio/si4713-i2c.c | 12 ++-- drivers/media/usb/dvb-usb-v2/af9015.c |4 - drivers/media/usb/dvb-usb-v2/af9035.c |2 drivers/media/usb/dvb-usb/cinergyT2-fe.c |6 -- 37 files changed, 106 insertions(+), 112 deletions(-) diff -u -p a/drivers/media/i2c/cx25840/cx25840-core.c b/drivers/media/i2c/cx25840/cx25840-core.c --- a/drivers/media/i2c/cx25840/cx25840-core.c +++ b/drivers/media/i2c/cx25840/cx25840-core.c @@ -599,7 +599,7 @@ static void cx23885_initialize(struct i2 cx25840_write4(client, 0x114, 0x01bf0c9e); cx25840_write4(client, 0x110, 0x000a030c); break; - }; + } /* ADC2 input select */ cx25840_write(client, 0x102, 0x10); diff -u -p a/drivers/media/usb/dvb-usb-v2/af9015.c b/drivers/media/usb/dvb-usb-v2/af9015.c --- a/drivers/media/usb/dvb-usb-v2/af9015.c +++ b/drivers/media/usb/dvb-usb-v2/af9015.c @@ -500,7 +500,7 @@ static int af9015_read_config(struct dvb case 3: state-af9013_config[i].clock = 2500; break; - }; + } dev_dbg(d-udev-dev, %s: [%d] xtal=%d set clock=%d\n, __func__, i, val, state-af9013_config[i].clock); @@ -568,7 +568,7 @@ static int af9015_read_config(struct dvb supported, please report!\n, KBUILD_MODNAME, val); return -ENODEV; - }; + } state-af9013_config[i].tuner = val; dev_dbg(d-udev-dev, %s: [%d] tuner id=%d\n, diff -u -p a/drivers/media/usb/dvb-usb-v2/af9035.c b/drivers/media/usb/dvb-usb-v2/af9035.c --- a/drivers/media/usb/dvb-usb-v2/af9035.c +++ b/drivers/media/usb/dvb-usb-v2/af9035.c @@ -519,7 +519,7 @@ static int af9035_read_config(struct dvb dev_warn(d-udev-dev, %s: tuner id=%02x not \ supported, please report!, KBUILD_MODNAME, tmp); - }; + } /* tuner IF frequency */ ret = af9035_rd_reg(d, EEPROM_1_IFFREQ_L + eeprom_shift, tmp); diff -u -p a/drivers/media/dvb-core/dvb_frontend.c b/drivers/media/dvb-core/dvb_frontend.c --- a/drivers/media/dvb-core/dvb_frontend.c +++ b/drivers/media/dvb-core/dvb_frontend.c @@ -2288,7 +2288,7 @@ static int dvb_frontend_ioctl_legacy(str fepriv-tune_mode_flags = (unsigned long) parg; err = 0; break; - }; + } return err; } diff -u -p a/drivers/media/radio/si470x/radio-si470x-i2c.c b/drivers/media/radio/si470x/radio-si470x-i2c.c --- a/drivers/media/radio/si470x/radio-si470x-i2c.c
Re: [PATCH] drivers/media: Remove unnecessary semicolon
Hi Peter, Thanks for the patch. On Thu, Sep 27, 2012 at 5:00 PM, Peter Senna Tschudin peter.se...@gmail.com wrote: Remove unnecessary semicolon And: drivers/media/dvb-frontends/stv0900_core.c: remove unnecessary whitespace before a quoted newline Found by http://coccinelle.lip6.fr/ Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com --- drivers/media/dvb-core/dvb_frontend.c |2 drivers/media/dvb-frontends/a8293.c |2 drivers/media/dvb-frontends/af9013.c |6 +- drivers/media/dvb-frontends/bcm3510.c |2 drivers/media/dvb-frontends/cx24110.c |6 +- drivers/media/dvb-frontends/drxd_hard.c |2 drivers/media/dvb-frontends/isl6405.c |2 drivers/media/dvb-frontends/isl6421.c |2 drivers/media/dvb-frontends/itd1000.c |2 drivers/media/dvb-frontends/lnbp21.c |4 - drivers/media/dvb-frontends/lnbp22.c |2 drivers/media/dvb-frontends/si21xx.c |4 - drivers/media/dvb-frontends/sp8870.c |6 +- drivers/media/dvb-frontends/sp887x.c |6 +- drivers/media/dvb-frontends/stv0299.c |6 +- drivers/media/dvb-frontends/stv0900_core.c|2 drivers/media/dvb-frontends/tda8083.c |4 - drivers/media/i2c/cx25840/cx25840-core.c |2 drivers/media/pci/bt8xx/dst_ca.c |2 drivers/media/pci/cx23885/altera-ci.c |4 - drivers/media/pci/cx23885/cimax2.c|2 drivers/media/pci/cx88/cx88-blackbird.c |6 +- drivers/media/pci/cx88/cx88-dvb.c |2 drivers/media/pci/cx88/cx88-mpeg.c|2 drivers/media/pci/cx88/cx88-tvaudio.c |4 - drivers/media/pci/cx88/cx88-video.c |2 drivers/media/pci/saa7134/saa7134-video.c |2 drivers/media/platform/davinci/vpif_capture.c | 78 +- I dont see any diff for this file in the patch. drivers/media/platform/exynos-gsc/gsc-regs.c |4 - drivers/media/platform/fsl-viu.c | 18 +++--- ditto drivers/media/platform/vivi.c |2 ditto and some more Is it a valid patch or is it that I am missing something ? Regards, --Prabhakar Lad drivers/media/radio/si470x/radio-si470x-i2c.c |2 drivers/media/radio/si470x/radio-si470x-usb.c |2 drivers/media/radio/si4713-i2c.c | 12 ++-- drivers/media/usb/dvb-usb-v2/af9015.c |4 - drivers/media/usb/dvb-usb-v2/af9035.c |2 drivers/media/usb/dvb-usb/cinergyT2-fe.c |6 -- 37 files changed, 106 insertions(+), 112 deletions(-) diff -u -p a/drivers/media/i2c/cx25840/cx25840-core.c b/drivers/media/i2c/cx25840/cx25840-core.c --- a/drivers/media/i2c/cx25840/cx25840-core.c +++ b/drivers/media/i2c/cx25840/cx25840-core.c @@ -599,7 +599,7 @@ static void cx23885_initialize(struct i2 cx25840_write4(client, 0x114, 0x01bf0c9e); cx25840_write4(client, 0x110, 0x000a030c); break; - }; + } /* ADC2 input select */ cx25840_write(client, 0x102, 0x10); diff -u -p a/drivers/media/usb/dvb-usb-v2/af9015.c b/drivers/media/usb/dvb-usb-v2/af9015.c --- a/drivers/media/usb/dvb-usb-v2/af9015.c +++ b/drivers/media/usb/dvb-usb-v2/af9015.c @@ -500,7 +500,7 @@ static int af9015_read_config(struct dvb case 3: state-af9013_config[i].clock = 2500; break; - }; + } dev_dbg(d-udev-dev, %s: [%d] xtal=%d set clock=%d\n, __func__, i, val, state-af9013_config[i].clock); @@ -568,7 +568,7 @@ static int af9015_read_config(struct dvb supported, please report!\n, KBUILD_MODNAME, val); return -ENODEV; - }; + } state-af9013_config[i].tuner = val; dev_dbg(d-udev-dev, %s: [%d] tuner id=%d\n, diff -u -p a/drivers/media/usb/dvb-usb-v2/af9035.c b/drivers/media/usb/dvb-usb-v2/af9035.c --- a/drivers/media/usb/dvb-usb-v2/af9035.c +++ b/drivers/media/usb/dvb-usb-v2/af9035.c @@ -519,7 +519,7 @@ static int af9035_read_config(struct dvb dev_warn(d-udev-dev, %s: tuner id=%02x not \ supported, please report!, KBUILD_MODNAME, tmp); - }; + } /* tuner IF frequency */ ret = af9035_rd_reg(d, EEPROM_1_IFFREQ_L + eeprom_shift, tmp); diff -u -p a/drivers/media/dvb-core/dvb_frontend.c b/drivers/media/dvb-core/dvb_frontend.c --- a/drivers/media/dvb-core/dvb_frontend.c +++ b/drivers/media/dvb-core/dvb_frontend.c @@ -2288,7 +2288,7 @@
Re: [PATCH] drivers/media: Remove unnecessary semicolon
On Thu, Sep 27, 2012 at 1:55 PM, Prabhakar Lad prabhakar.cse...@gmail.com wrote: Hi Peter, Thanks for the patch. On Thu, Sep 27, 2012 at 5:00 PM, Peter Senna Tschudin peter.se...@gmail.com wrote: Remove unnecessary semicolon And: drivers/media/dvb-frontends/stv0900_core.c: remove unnecessary whitespace before a quoted newline Found by http://coccinelle.lip6.fr/ Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com --- drivers/media/dvb-core/dvb_frontend.c |2 drivers/media/dvb-frontends/a8293.c |2 drivers/media/dvb-frontends/af9013.c |6 +- drivers/media/dvb-frontends/bcm3510.c |2 drivers/media/dvb-frontends/cx24110.c |6 +- drivers/media/dvb-frontends/drxd_hard.c |2 drivers/media/dvb-frontends/isl6405.c |2 drivers/media/dvb-frontends/isl6421.c |2 drivers/media/dvb-frontends/itd1000.c |2 drivers/media/dvb-frontends/lnbp21.c |4 - drivers/media/dvb-frontends/lnbp22.c |2 drivers/media/dvb-frontends/si21xx.c |4 - drivers/media/dvb-frontends/sp8870.c |6 +- drivers/media/dvb-frontends/sp887x.c |6 +- drivers/media/dvb-frontends/stv0299.c |6 +- drivers/media/dvb-frontends/stv0900_core.c|2 drivers/media/dvb-frontends/tda8083.c |4 - drivers/media/i2c/cx25840/cx25840-core.c |2 drivers/media/pci/bt8xx/dst_ca.c |2 drivers/media/pci/cx23885/altera-ci.c |4 - drivers/media/pci/cx23885/cimax2.c|2 drivers/media/pci/cx88/cx88-blackbird.c |6 +- drivers/media/pci/cx88/cx88-dvb.c |2 drivers/media/pci/cx88/cx88-mpeg.c|2 drivers/media/pci/cx88/cx88-tvaudio.c |4 - drivers/media/pci/cx88/cx88-video.c |2 drivers/media/pci/saa7134/saa7134-video.c |2 drivers/media/platform/davinci/vpif_capture.c | 78 +- I dont see any diff for this file in the patch. drivers/media/platform/exynos-gsc/gsc-regs.c |4 - drivers/media/platform/fsl-viu.c | 18 +++--- ditto drivers/media/platform/vivi.c |2 ditto and some more Is it a valid patch or is it that I am missing something ? I've sent V2 fixing this. Regards, --Prabhakar Lad drivers/media/radio/si470x/radio-si470x-i2c.c |2 drivers/media/radio/si470x/radio-si470x-usb.c |2 drivers/media/radio/si4713-i2c.c | 12 ++-- drivers/media/usb/dvb-usb-v2/af9015.c |4 - drivers/media/usb/dvb-usb-v2/af9035.c |2 drivers/media/usb/dvb-usb/cinergyT2-fe.c |6 -- 37 files changed, 106 insertions(+), 112 deletions(-) diff -u -p a/drivers/media/i2c/cx25840/cx25840-core.c b/drivers/media/i2c/cx25840/cx25840-core.c --- a/drivers/media/i2c/cx25840/cx25840-core.c +++ b/drivers/media/i2c/cx25840/cx25840-core.c @@ -599,7 +599,7 @@ static void cx23885_initialize(struct i2 cx25840_write4(client, 0x114, 0x01bf0c9e); cx25840_write4(client, 0x110, 0x000a030c); break; - }; + } /* ADC2 input select */ cx25840_write(client, 0x102, 0x10); diff -u -p a/drivers/media/usb/dvb-usb-v2/af9015.c b/drivers/media/usb/dvb-usb-v2/af9015.c --- a/drivers/media/usb/dvb-usb-v2/af9015.c +++ b/drivers/media/usb/dvb-usb-v2/af9015.c @@ -500,7 +500,7 @@ static int af9015_read_config(struct dvb case 3: state-af9013_config[i].clock = 2500; break; - }; + } dev_dbg(d-udev-dev, %s: [%d] xtal=%d set clock=%d\n, __func__, i, val, state-af9013_config[i].clock); @@ -568,7 +568,7 @@ static int af9015_read_config(struct dvb supported, please report!\n, KBUILD_MODNAME, val); return -ENODEV; - }; + } state-af9013_config[i].tuner = val; dev_dbg(d-udev-dev, %s: [%d] tuner id=%d\n, diff -u -p a/drivers/media/usb/dvb-usb-v2/af9035.c b/drivers/media/usb/dvb-usb-v2/af9035.c --- a/drivers/media/usb/dvb-usb-v2/af9035.c +++ b/drivers/media/usb/dvb-usb-v2/af9035.c @@ -519,7 +519,7 @@ static int af9035_read_config(struct dvb dev_warn(d-udev-dev, %s: tuner id=%02x not \ supported, please report!, KBUILD_MODNAME, tmp); - }; + } /* tuner IF frequency */ ret = af9035_rd_reg(d, EEPROM_1_IFFREQ_L + eeprom_shift, tmp); diff -u -p a/drivers/media/dvb-core/dvb_frontend.c
