Re: [PATCH] media: platform: vsp1: vsp1_hsit: Remove unused function

2015-01-02 Thread Laurent Pinchart
Hi Rickard,

Thank you for the patch.

On Thursday 01 January 2015 18:51:30 Rickard Strandqvist wrote:
 Remove the function vsp1_hsit_read() that is not used anywhere.
 
 This was partially found by using a static code analysis program called
 cppcheck.
 
 Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se

Acked-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com

I've taken the patch in my tree and will send a pull request for v3.20.

 ---
  drivers/media/platform/vsp1/vsp1_hsit.c |5 -
  1 file changed, 5 deletions(-)
 
 diff --git a/drivers/media/platform/vsp1/vsp1_hsit.c
 b/drivers/media/platform/vsp1/vsp1_hsit.c index db2950a..9fb003b 100644
 --- a/drivers/media/platform/vsp1/vsp1_hsit.c
 +++ b/drivers/media/platform/vsp1/vsp1_hsit.c
 @@ -26,11 +26,6 @@
   * Device Access
   */
 
 -static inline u32 vsp1_hsit_read(struct vsp1_hsit *hsit, u32 reg)
 -{
 - return vsp1_read(hsit-entity.vsp1, reg);
 -}
 -
  static inline void vsp1_hsit_write(struct vsp1_hsit *hsit, u32 reg, u32
 data) {
   vsp1_write(hsit-entity.vsp1, reg, data);

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH] media: platform: vsp1: vsp1_hsit: Remove unused function

2015-01-01 Thread Rickard Strandqvist
Remove the function vsp1_hsit_read() that is not used anywhere.

This was partially found by using a static code analysis program called 
cppcheck.

Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se
---
 drivers/media/platform/vsp1/vsp1_hsit.c |5 -
 1 file changed, 5 deletions(-)

diff --git a/drivers/media/platform/vsp1/vsp1_hsit.c 
b/drivers/media/platform/vsp1/vsp1_hsit.c
index db2950a..9fb003b 100644
--- a/drivers/media/platform/vsp1/vsp1_hsit.c
+++ b/drivers/media/platform/vsp1/vsp1_hsit.c
@@ -26,11 +26,6 @@
  * Device Access
  */
 
-static inline u32 vsp1_hsit_read(struct vsp1_hsit *hsit, u32 reg)
-{
-   return vsp1_read(hsit-entity.vsp1, reg);
-}
-
 static inline void vsp1_hsit_write(struct vsp1_hsit *hsit, u32 reg, u32 data)
 {
vsp1_write(hsit-entity.vsp1, reg, data);
-- 
1.7.10.4

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html