Re: [PATCH] media: tm6000: add error handling for dvb_register_adapter

[Alexandre-Xavier Labonté-Lamoureux]

"adater" should be "adapter".

Have a nice day,
Alexandre-Xavier

On Mon, Jun 11, 2018 at 12:39 AM, Zhouyang Jia  wrote:
> When dvb_register_adapter fails, the lack of error-handling code may
> cause unexpected results.
>
> This patch adds error-handling code after calling dvb_register_adapter.
>
> Signed-off-by: Zhouyang Jia 
> ---
>  drivers/media/usb/tm6000/tm6000-dvb.c | 5 +
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/media/usb/tm6000/tm6000-dvb.c 
> b/drivers/media/usb/tm6000/tm6000-dvb.c
> index c811fc6..ff35d4b 100644
> --- a/drivers/media/usb/tm6000/tm6000-dvb.c
> +++ b/drivers/media/usb/tm6000/tm6000-dvb.c
> @@ -266,6 +266,11 @@ static int register_dvb(struct tm6000_core *dev)
>
> ret = dvb_register_adapter(>adapter, "Trident TVMaster 6000 
> DVB-T",
> THIS_MODULE, >udev->dev, 
> adapter_nr);
> +   if (ret < 0) {
> +   printk(KERN_ERR "tm6000: couldn't register the adater!\n");
> +   goto err;
> +   }
> +
> dvb->adapter.priv = dev;
>
> if (dvb->frontend) {
> --
> 2.7.4
>

[PATCH] media: tm6000: add error handling for dvb_register_adapter

[Zhouyang Jia]

When dvb_register_adapter fails, the lack of error-handling code may
cause unexpected results.

This patch adds error-handling code after calling dvb_register_adapter.

Signed-off-by: Zhouyang Jia 
---
 drivers/media/usb/tm6000/tm6000-dvb.c | 5 +
 1 file changed, 5 insertions(+)

diff --git a/drivers/media/usb/tm6000/tm6000-dvb.c 
b/drivers/media/usb/tm6000/tm6000-dvb.c
index c811fc6..ff35d4b 100644
--- a/drivers/media/usb/tm6000/tm6000-dvb.c
+++ b/drivers/media/usb/tm6000/tm6000-dvb.c
@@ -266,6 +266,11 @@ static int register_dvb(struct tm6000_core *dev)
 
ret = dvb_register_adapter(>adapter, "Trident TVMaster 6000 DVB-T",
THIS_MODULE, >udev->dev, 
adapter_nr);
+   if (ret < 0) {
+   printk(KERN_ERR "tm6000: couldn't register the adater!\n");
+   goto err;
+   }
+
dvb->adapter.priv = dev;
 
if (dvb->frontend) {
-- 
2.7.4