Re: [PATCH] media: uvc: add support for Toshiba FHD Webcam

2014-10-28 Thread Laurent Pinchart
Hi Arend,

Thank you for the patch.

On Tuesday 28 October 2014 23:30:18 Arend van Spriel wrote:
> The webcam is identified as Toshiba webcam although it seems a module
> from Chicony Electronics. Not sure about the model so just refering
> to it as Toshiba webcam that is in Portege z30 laptop.
> 
> Signed-off-by: Arend van Spriel 
> ---
>  drivers/media/usb/uvc/uvc_driver.c | 8 
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/media/usb/uvc/uvc_driver.c
> b/drivers/media/usb/uvc/uvc_driver.c index 7c8322d..f0b7eab 100644
> --- a/drivers/media/usb/uvc/uvc_driver.c
> +++ b/drivers/media/usb/uvc/uvc_driver.c
> @@ -2193,6 +2193,14 @@ static struct usb_device_id uvc_ids[] = {
> .bInterfaceSubClass   = 1,
> .bInterfaceProtocol   = 0,
> .driver_info  = UVC_QUIRK_RESTRICT_FRAME_RATE },
> + /* Chicony (Toshiba FHD Webcam) */
> + { .match_flags  = USB_DEVICE_ID_MATCH_DEVICE
> + | USB_DEVICE_ID_MATCH_INT_INFO,
> +   .idVendor = 0x04f2,
> +   .idProduct= 0xb3b2,
> +   .bInterfaceClass  = USB_CLASS_VIDEO,
> +   .bInterfaceSubClass   = 1,
> +   .bInterfaceProtocol   = 0 },

Is this really needed ? Isn't the camera properly detected and supported 
without this patch ?

>   /* Alcor Micro AU3820 (Future Boy PC USB Webcam) */
>   { .match_flags  = USB_DEVICE_ID_MATCH_DEVICE
> 
>   | USB_DEVICE_ID_MATCH_INT_INFO,

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH] media: uvc: add support for Toshiba FHD Webcam

2014-10-28 Thread Arend van Spriel
The webcam is identified as Toshiba webcam although it seems a module
from Chicony Electronics. Not sure about the model so just refering
to it as Toshiba webcam that is in Portege z30 laptop.

Signed-off-by: Arend van Spriel 
---
 drivers/media/usb/uvc/uvc_driver.c | 8 
 1 file changed, 8 insertions(+)

diff --git a/drivers/media/usb/uvc/uvc_driver.c 
b/drivers/media/usb/uvc/uvc_driver.c
index 7c8322d..f0b7eab 100644
--- a/drivers/media/usb/uvc/uvc_driver.c
+++ b/drivers/media/usb/uvc/uvc_driver.c
@@ -2193,6 +2193,14 @@ static struct usb_device_id uvc_ids[] = {
  .bInterfaceSubClass   = 1,
  .bInterfaceProtocol   = 0,
  .driver_info  = UVC_QUIRK_RESTRICT_FRAME_RATE },
+   /* Chicony (Toshiba FHD Webcam) */
+   { .match_flags  = USB_DEVICE_ID_MATCH_DEVICE
+   | USB_DEVICE_ID_MATCH_INT_INFO,
+ .idVendor = 0x04f2,
+ .idProduct= 0xb3b2,
+ .bInterfaceClass  = USB_CLASS_VIDEO,
+ .bInterfaceSubClass   = 1,
+ .bInterfaceProtocol   = 0 },
/* Alcor Micro AU3820 (Future Boy PC USB Webcam) */
{ .match_flags  = USB_DEVICE_ID_MATCH_DEVICE
| USB_DEVICE_ID_MATCH_INT_INFO,
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html