Re: [PATCH] media: vimc: cleanup a few warnings

2017-07-14 Thread Javier Martinez Canillas 
On Thu, Jul 13, 2017 at 5:47 PM, Javier Martinez Canillas
 wrote:
> On Thu, Jul 13, 2017 at 5:38 PM, Sakari Ailus  wrote:

[snip]

>>
>> Shouldn't these be set to the corresponding driver structs' id_table
>> fields? Or do I miss something...?
>>
>
> Agreed, the real problem is that the .id_table is not set for these
> drivers. The match only works because the platform subsystem fallbacks
> to the driver's name if an .id_table isn't defined:
>

I just posted a patch fixing the build warning in the driver as
suggested by Sakari:

https://patchwork.linuxtv.org/patch/42480/

Best regards,
Javier

Re: [PATCH] media: vimc: cleanup a few warnings

2017-07-13 Thread Javier Martinez Canillas 
On Thu, Jul 13, 2017 at 5:38 PM, Sakari Ailus  wrote:

[snip]

>>
>> -static const struct platform_device_id vimc_sen_driver_ids[] = {
>> +static const __maybe_unused
>> +struct platform_device_id vimc_sen_driver_ids[] = {
>>   {
>>   .name   = VIMC_SEN_DRV_NAME,
>>   },
>
> Shouldn't these be set to the corresponding driver structs' id_table
> fields? Or do I miss something...?
>

Agreed, the real problem is that the .id_table is not set for these
drivers. The match only works because the platform subsystem fallbacks
to the driver's name if an .id_table isn't defined:

http://elixir.free-electrons.com/linux/latest/source/drivers/base/platform.c#L964

Best regards,
Javier

Re: [PATCH] media: vimc: cleanup a few warnings

2017-07-13 Thread Sakari Ailus 
Hi Mauro,

On Wed, Jul 12, 2017 at 08:46:30AM -0300, Mauro Carvalho Chehab wrote:
> The const structs uded by MODULE_DEVICE_TABLE()
> may never be used with COMPILE_TEST:
> 
> drivers/media/platform/vimc/vimc-capture.c:528:40: warning: 
> 'vimc_cap_driver_ids' defined but not used [-Wunused-const-variable=]
>  static const struct platform_device_id vimc_cap_driver_ids[] = {
> ^~~
> drivers/media/platform/vimc/vimc-debayer.c:588:40: warning: 
> 'vimc_deb_driver_ids' defined but not used [-Wunused-const-variable=]
>  static const struct platform_device_id vimc_deb_driver_ids[] = {
> ^~~
> drivers/media/platform/vimc/vimc-scaler.c:442:40: warning: 
> 'vimc_sca_driver_ids' defined but not used [-Wunused-const-variable=]
>  static const struct platform_device_id vimc_sca_driver_ids[] = {
> ^~~
> drivers/media/platform/vimc/vimc-sensor.c:376:40: warning: 
> 'vimc_sen_driver_ids' defined but not used [-Wunused-const-variable=]
>  static const struct platform_device_id vimc_sen_driver_ids[] = {
> ^~~
> 
> So, add the proper notation to avoid warnings.
> 
> Signed-off-by: Mauro Carvalho Chehab 
> ---
>  drivers/media/platform/vimc/vimc-capture.c | 3 ++-
>  drivers/media/platform/vimc/vimc-debayer.c | 3 ++-
>  drivers/media/platform/vimc/vimc-scaler.c  | 3 ++-
>  drivers/media/platform/vimc/vimc-sensor.c  | 3 ++-
>  4 files changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/media/platform/vimc/vimc-capture.c 
> b/drivers/media/platform/vimc/vimc-capture.c
> index 14cb32e21130..c6f4a407e019 100644
> --- a/drivers/media/platform/vimc/vimc-capture.c
> +++ b/drivers/media/platform/vimc/vimc-capture.c
> @@ -525,7 +525,8 @@ static struct platform_driver vimc_cap_pdrv = {
>   },
>  };
>  
> -static const struct platform_device_id vimc_cap_driver_ids[] = {
> +static const __maybe_unused
> +struct platform_device_id vimc_cap_driver_ids[] = {
>   {
>   .name   = VIMC_CAP_DRV_NAME,
>   },
> diff --git a/drivers/media/platform/vimc/vimc-debayer.c 
> b/drivers/media/platform/vimc/vimc-debayer.c
> index 35b15bd4d61d..428454e33b75 100644
> --- a/drivers/media/platform/vimc/vimc-debayer.c
> +++ b/drivers/media/platform/vimc/vimc-debayer.c
> @@ -585,7 +585,8 @@ static struct platform_driver vimc_deb_pdrv = {
>   },
>  };
>  
> -static const struct platform_device_id vimc_deb_driver_ids[] = {
> +static const __maybe_unused
> +struct platform_device_id vimc_deb_driver_ids[] = {
>   {
>   .name   = VIMC_DEB_DRV_NAME,
>   },
> diff --git a/drivers/media/platform/vimc/vimc-scaler.c 
> b/drivers/media/platform/vimc/vimc-scaler.c
> index fe77505d2679..35bf3b32108f 100644
> --- a/drivers/media/platform/vimc/vimc-scaler.c
> +++ b/drivers/media/platform/vimc/vimc-scaler.c
> @@ -439,7 +439,8 @@ static struct platform_driver vimc_sca_pdrv = {
>   },
>  };
>  
> -static const struct platform_device_id vimc_sca_driver_ids[] = {
> +static const __maybe_unused
> +struct platform_device_id vimc_sca_driver_ids[] = {
>   {
>   .name   = VIMC_SCA_DRV_NAME,
>   },
> diff --git a/drivers/media/platform/vimc/vimc-sensor.c 
> b/drivers/media/platform/vimc/vimc-sensor.c
> index ebdbbe8c05ed..9ad2be111a14 100644
> --- a/drivers/media/platform/vimc/vimc-sensor.c
> +++ b/drivers/media/platform/vimc/vimc-sensor.c
> @@ -373,7 +373,8 @@ static struct platform_driver vimc_sen_pdrv = {
>   },
>  };
>  
> -static const struct platform_device_id vimc_sen_driver_ids[] = {
> +static const __maybe_unused
> +struct platform_device_id vimc_sen_driver_ids[] = {
>   {
>   .name   = VIMC_SEN_DRV_NAME,
>   },

Shouldn't these be set to the corresponding driver structs' id_table
fields? Or do I miss something...?

-- 
Regards,

Sakari Ailus
e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk

[PATCH] media: vimc: cleanup a few warnings

2017-07-12 Thread Mauro Carvalho Chehab 
The const structs uded by MODULE_DEVICE_TABLE()
may never be used with COMPILE_TEST:

drivers/media/platform/vimc/vimc-capture.c:528:40: warning: 
'vimc_cap_driver_ids' defined but not used [-Wunused-const-variable=]
 static const struct platform_device_id vimc_cap_driver_ids[] = {
^~~
drivers/media/platform/vimc/vimc-debayer.c:588:40: warning: 
'vimc_deb_driver_ids' defined but not used [-Wunused-const-variable=]
 static const struct platform_device_id vimc_deb_driver_ids[] = {
^~~
drivers/media/platform/vimc/vimc-scaler.c:442:40: warning: 
'vimc_sca_driver_ids' defined but not used [-Wunused-const-variable=]
 static const struct platform_device_id vimc_sca_driver_ids[] = {
^~~
drivers/media/platform/vimc/vimc-sensor.c:376:40: warning: 
'vimc_sen_driver_ids' defined but not used [-Wunused-const-variable=]
 static const struct platform_device_id vimc_sen_driver_ids[] = {
^~~

So, add the proper notation to avoid warnings.

Signed-off-by: Mauro Carvalho Chehab 
---
 drivers/media/platform/vimc/vimc-capture.c | 3 ++-
 drivers/media/platform/vimc/vimc-debayer.c | 3 ++-
 drivers/media/platform/vimc/vimc-scaler.c  | 3 ++-
 drivers/media/platform/vimc/vimc-sensor.c  | 3 ++-
 4 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/drivers/media/platform/vimc/vimc-capture.c 
b/drivers/media/platform/vimc/vimc-capture.c
index 14cb32e21130..c6f4a407e019 100644
--- a/drivers/media/platform/vimc/vimc-capture.c
+++ b/drivers/media/platform/vimc/vimc-capture.c
@@ -525,7 +525,8 @@ static struct platform_driver vimc_cap_pdrv = {
},
 };
 
-static const struct platform_device_id vimc_cap_driver_ids[] = {
+static const __maybe_unused
+struct platform_device_id vimc_cap_driver_ids[] = {
{
.name   = VIMC_CAP_DRV_NAME,
},
diff --git a/drivers/media/platform/vimc/vimc-debayer.c 
b/drivers/media/platform/vimc/vimc-debayer.c
index 35b15bd4d61d..428454e33b75 100644
--- a/drivers/media/platform/vimc/vimc-debayer.c
+++ b/drivers/media/platform/vimc/vimc-debayer.c
@@ -585,7 +585,8 @@ static struct platform_driver vimc_deb_pdrv = {
},
 };
 
-static const struct platform_device_id vimc_deb_driver_ids[] = {
+static const __maybe_unused
+struct platform_device_id vimc_deb_driver_ids[] = {
{
.name   = VIMC_DEB_DRV_NAME,
},
diff --git a/drivers/media/platform/vimc/vimc-scaler.c 
b/drivers/media/platform/vimc/vimc-scaler.c
index fe77505d2679..35bf3b32108f 100644
--- a/drivers/media/platform/vimc/vimc-scaler.c
+++ b/drivers/media/platform/vimc/vimc-scaler.c
@@ -439,7 +439,8 @@ static struct platform_driver vimc_sca_pdrv = {
},
 };
 
-static const struct platform_device_id vimc_sca_driver_ids[] = {
+static const __maybe_unused
+struct platform_device_id vimc_sca_driver_ids[] = {
{
.name   = VIMC_SCA_DRV_NAME,
},
diff --git a/drivers/media/platform/vimc/vimc-sensor.c 
b/drivers/media/platform/vimc/vimc-sensor.c
index ebdbbe8c05ed..9ad2be111a14 100644
--- a/drivers/media/platform/vimc/vimc-sensor.c
+++ b/drivers/media/platform/vimc/vimc-sensor.c
@@ -373,7 +373,8 @@ static struct platform_driver vimc_sen_pdrv = {
},
 };
 
-static const struct platform_device_id vimc_sen_driver_ids[] = {
+static const __maybe_unused
+struct platform_device_id vimc_sen_driver_ids[] = {
{
.name   = VIMC_SEN_DRV_NAME,
},
-- 
2.13.0