Re: [PATCH] radio-bcm2048: Fix region selection
On Friday 05 June 2015 13:36:40 Hans Verkuil wrote: > On 05/15/2015 11:32 PM, Pali Rohár wrote: > > From: maxx > > > > This actually fixes region selection for BCM2048 FM receiver. To select > > the japanese FM-band an additional bit in FM_CTRL register needs to be > > set. This might not sound so important but it enables at least me to > > listen to some 'very interesting' radio transmission below normal > > FM-band. > > > > Patch writen by m...@spaceboyz.net > > > > Signed-off-by: Pali Rohár > > Cc: m...@spaceboyz.net > > Looks good to me. If someone can repost with correct names and SoBs, then I'll > apply. > Jan, will you resend patch in correct format with correct names? -- Pali Rohár pali.ro...@gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] radio-bcm2048: Fix region selection
On 05/15/2015 11:32 PM, Pali Rohár wrote:
> From: maxx
>
> This actually fixes region selection for BCM2048 FM receiver. To select
> the japanese FM-band an additional bit in FM_CTRL register needs to be
> set. This might not sound so important but it enables at least me to
> listen to some 'very interesting' radio transmission below normal
> FM-band.
>
> Patch writen by m...@spaceboyz.net
>
> Signed-off-by: Pali Rohár
> Cc: m...@spaceboyz.net
Looks good to me. If someone can repost with correct names and SoBs, then I'll
apply.
Regards,
Hans
> ---
> drivers/staging/media/bcm2048/radio-bcm2048.c | 13 +
> 1 file changed, 13 insertions(+)
>
> diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c
> b/drivers/staging/media/bcm2048/radio-bcm2048.c
> index aeb6c3c..1482d4b 100644
> --- a/drivers/staging/media/bcm2048/radio-bcm2048.c
> +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
> @@ -739,7 +739,20 @@ static int bcm2048_set_region(struct bcm2048_device
> *bdev, u8 region)
> return -EINVAL;
>
> mutex_lock(&bdev->mutex);
> +
> bdev->region_info = region_configs[region];
> +
> + bdev->cache_fm_ctrl &= ~BCM2048_BAND_SELECT;
> + if (region > 2) {
> + bdev->cache_fm_ctrl |= BCM2048_BAND_SELECT;
> + err = bcm2048_send_command(bdev, BCM2048_I2C_FM_CTRL,
> + bdev->cache_fm_ctrl);
> + if (err) {
> + mutex_unlock(&bdev->mutex);
> + goto done;
> + }
> + }
> +
> mutex_unlock(&bdev->mutex);
>
> if (bdev->frequency < region_configs[region].bottom_frequency ||
>
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] radio-bcm2048: Fix region selection
On Sat 2015-05-16 17:20:50, Jan Roemisch wrote:
> Removed "Japan wide band" region since this is impossible to do just
> like that. Additionally it's now possible to go back to non-Japanese regions
> without having to reload the module.
Acked-by: Pavel Machek
But note that you'll probably need to do one more resend, with
Signed-off-by:
line.
Thanks and best regards,
Pavel
> Greetings
> Jan Roemisch
>
> On Sat, May 16, 2015 at 07:06:17AM -0700, Greg KH wrote:
> > On Sat, May 16, 2015 at 01:22:27PM +0200, Jan Roemisch wrote:
> > > Oh sorry, the real name is Jan Roemisch.
> >
> > Ok, thanks, can someone please fix up the patches and resend them?
> >
> > greg k-h
> >
> diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c
> b/drivers/staging/media/bcm2048/radio-bcm2048.c
> index 5382506..d2e7f1e 100644
> --- a/drivers/staging/media/bcm2048/radio-bcm2048.c
> +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
> @@ -342,14 +342,6 @@ static struct region_info region_configs[] = {
> .deemphasis = 50,
> .region = 3,
> },
> - /* Japan wide band */
> - {
> - .channel_spacing= 10,
> - .bottom_frequency = 76000,
> - .top_frequency = 108000,
> - .deemphasis = 50,
> - .region = 4,
> - },
> };
>
> /*
> @@ -741,6 +733,18 @@ static int bcm2048_set_region(struct bcm2048_device
> *bdev, u8 region)
>
> mutex_lock(&bdev->mutex);
> bdev->region_info = region_configs[region];
> +
> + if (region_configs[region].bottom_frequency < 87500)
> + bdev->cache_fm_ctrl |= BCM2048_BAND_SELECT;
> + else
> + bdev->cache_fm_ctrl &= ~BCM2048_BAND_SELECT;
> +
> + err = bcm2048_send_command(bdev, BCM2048_I2C_FM_CTRL,
> + bdev->cache_fm_ctrl);
> + if (err) {
> + mutex_unlock(&bdev->mutex);
> + goto done;
> + }
> mutex_unlock(&bdev->mutex);
>
> if (bdev->frequency < region_configs[region].bottom_frequency ||
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] radio-bcm2048: Fix region selection
Removed "Japan wide band" region since this is impossible to do just
like that. Additionally it's now possible to go back to non-Japanese regions
without having to reload the module.
Greetings
Jan Roemisch
On Sat, May 16, 2015 at 07:06:17AM -0700, Greg KH wrote:
> On Sat, May 16, 2015 at 01:22:27PM +0200, Jan Roemisch wrote:
> > Oh sorry, the real name is Jan Roemisch.
>
> Ok, thanks, can someone please fix up the patches and resend them?
>
> greg k-h
>
diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c
b/drivers/staging/media/bcm2048/radio-bcm2048.c
index 5382506..d2e7f1e 100644
--- a/drivers/staging/media/bcm2048/radio-bcm2048.c
+++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
@@ -342,14 +342,6 @@ static struct region_info region_configs[] = {
.deemphasis = 50,
.region = 3,
},
- /* Japan wide band */
- {
- .channel_spacing= 10,
- .bottom_frequency = 76000,
- .top_frequency = 108000,
- .deemphasis = 50,
- .region = 4,
- },
};
/*
@@ -741,6 +733,18 @@ static int bcm2048_set_region(struct bcm2048_device *bdev,
u8 region)
mutex_lock(&bdev->mutex);
bdev->region_info = region_configs[region];
+
+ if (region_configs[region].bottom_frequency < 87500)
+ bdev->cache_fm_ctrl |= BCM2048_BAND_SELECT;
+ else
+ bdev->cache_fm_ctrl &= ~BCM2048_BAND_SELECT;
+
+ err = bcm2048_send_command(bdev, BCM2048_I2C_FM_CTRL,
+ bdev->cache_fm_ctrl);
+ if (err) {
+ mutex_unlock(&bdev->mutex);
+ goto done;
+ }
mutex_unlock(&bdev->mutex);
if (bdev->frequency < region_configs[region].bottom_frequency ||
Re: [PATCH] radio-bcm2048: Fix region selection
On Sat, May 16, 2015 at 01:22:27PM +0200, Jan Roemisch wrote: > Oh sorry, the real name is Jan Roemisch. Ok, thanks, can someone please fix up the patches and resend them? greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] radio-bcm2048: Fix region selection
Oh sorry, the real name is Jan Roemisch. Greetings Jan -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] radio-bcm2048: Fix region selection
On Fri, May 15, 2015 at 11:32:51PM +0200, Pali Rohár wrote: > From: maxx I need a real name here, sorry. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] radio-bcm2048: Fix region selection
From: maxx
This actually fixes region selection for BCM2048 FM receiver. To select
the japanese FM-band an additional bit in FM_CTRL register needs to be
set. This might not sound so important but it enables at least me to
listen to some 'very interesting' radio transmission below normal
FM-band.
Patch writen by m...@spaceboyz.net
Signed-off-by: Pali Rohár
Cc: m...@spaceboyz.net
---
drivers/staging/media/bcm2048/radio-bcm2048.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c
b/drivers/staging/media/bcm2048/radio-bcm2048.c
index aeb6c3c..1482d4b 100644
--- a/drivers/staging/media/bcm2048/radio-bcm2048.c
+++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
@@ -739,7 +739,20 @@ static int bcm2048_set_region(struct bcm2048_device *bdev,
u8 region)
return -EINVAL;
mutex_lock(&bdev->mutex);
+
bdev->region_info = region_configs[region];
+
+ bdev->cache_fm_ctrl &= ~BCM2048_BAND_SELECT;
+ if (region > 2) {
+ bdev->cache_fm_ctrl |= BCM2048_BAND_SELECT;
+ err = bcm2048_send_command(bdev, BCM2048_I2C_FM_CTRL,
+ bdev->cache_fm_ctrl);
+ if (err) {
+ mutex_unlock(&bdev->mutex);
+ goto done;
+ }
+ }
+
mutex_unlock(&bdev->mutex);
if (bdev->frequency < region_configs[region].bottom_frequency ||
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
