Re: [PATCH] radio-bcm2048: remove unused var

[Pali Rohár]

On Tuesday 28 April 2015 09:03:41 Mauro Carvalho Chehab wrote:
> drivers/staging/media/bcm2048/radio-bcm2048.c: In function 
> 'bcm2048_i2c_driver_probe':
> drivers/staging/media/bcm2048/radio-bcm2048.c:2596:11: warning: variable 
> 'skip_release' set but not used [-Wunused-but-set-variable]
>   int err, skip_release = 0;
>^
> 
> Signed-off-by: Mauro Carvalho Chehab 
> 
> diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c 
> b/drivers/staging/media/bcm2048/radio-bcm2048.c
> index e9d0691b21d3..5e11a78ceef3 100644
> --- a/drivers/staging/media/bcm2048/radio-bcm2048.c
> +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
> @@ -2593,7 +2593,7 @@ static int bcm2048_i2c_driver_probe(struct i2c_client 
> *client,
>   const struct i2c_device_id *id)
>  {
>   struct bcm2048_device *bdev;
> - int err, skip_release = 0;
> + int err;
>  
>   bdev = kzalloc(sizeof(*bdev), GFP_KERNEL);
>   if (!bdev) {
> @@ -2646,7 +2646,6 @@ free_sysfs:
>   bcm2048_sysfs_unregister_properties(bdev, ARRAY_SIZE(attrs));
>  free_registration:
>   video_unregister_device(&bdev->videodev);
> - skip_release = 1;
>  free_irq:
>   if (client->irq)
>   free_irq(client->irq, bdev);

Looks good to me, so

Acked-by: Pali Rohár 

-- 
Pali Rohár
pali.ro...@gmail.com
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] radio-bcm2048: remove unused var

[Pavel Machek]

On Tue 2015-04-28 09:03:41, Mauro Carvalho Chehab wrote:
> drivers/staging/media/bcm2048/radio-bcm2048.c: In function 
> 'bcm2048_i2c_driver_probe':
> drivers/staging/media/bcm2048/radio-bcm2048.c:2596:11: warning: variable 
> 'skip_release' set but not used [-Wunused-but-set-variable]
>   int err, skip_release = 0;
>^
> 
> Signed-off-by: Mauro Carvalho Chehab 

Acked-by: Pavel Machek 

> diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c 
> b/drivers/staging/media/bcm2048/radio-bcm2048.c
> index e9d0691b21d3..5e11a78ceef3 100644
> --- a/drivers/staging/media/bcm2048/radio-bcm2048.c
> +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
> @@ -2593,7 +2593,7 @@ static int bcm2048_i2c_driver_probe(struct i2c_client 
> *client,
>   const struct i2c_device_id *id)
>  {
>   struct bcm2048_device *bdev;
> - int err, skip_release = 0;
> + int err;
>  
>   bdev = kzalloc(sizeof(*bdev), GFP_KERNEL);
>   if (!bdev) {
> @@ -2646,7 +2646,6 @@ free_sysfs:
>   bcm2048_sysfs_unregister_properties(bdev, ARRAY_SIZE(attrs));
>  free_registration:
>   video_unregister_device(&bdev->videodev);
> - skip_release = 1;
>  free_irq:
>   if (client->irq)
>   free_irq(client->irq, bdev);

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) 
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] radio-bcm2048: remove unused var

[Mauro Carvalho Chehab]

drivers/staging/media/bcm2048/radio-bcm2048.c: In function 
'bcm2048_i2c_driver_probe':
drivers/staging/media/bcm2048/radio-bcm2048.c:2596:11: warning: variable 
'skip_release' set but not used [-Wunused-but-set-variable]
  int err, skip_release = 0;
   ^

Signed-off-by: Mauro Carvalho Chehab 

diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c 
b/drivers/staging/media/bcm2048/radio-bcm2048.c
index e9d0691b21d3..5e11a78ceef3 100644
--- a/drivers/staging/media/bcm2048/radio-bcm2048.c
+++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
@@ -2593,7 +2593,7 @@ static int bcm2048_i2c_driver_probe(struct i2c_client 
*client,
const struct i2c_device_id *id)
 {
struct bcm2048_device *bdev;
-   int err, skip_release = 0;
+   int err;
 
bdev = kzalloc(sizeof(*bdev), GFP_KERNEL);
if (!bdev) {
@@ -2646,7 +2646,6 @@ free_sysfs:
bcm2048_sysfs_unregister_properties(bdev, ARRAY_SIZE(attrs));
 free_registration:
video_unregister_device(&bdev->videodev);
-   skip_release = 1;
 free_irq:
if (client->irq)
free_irq(client->irq, bdev);
-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html