tcm825x.c:
ERROR: Macros with complex values should be enclosed in parenthesis
WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then
dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
tcm825x.h:
ERROR: Macros with complex values should be enclosed in parenthesis
Signed-off-by: Vitaly Osipov vitaly.osi...@gmail.com
---
drivers/staging/media/omap24xx/tcm825x.c | 40 +++---
drivers/staging/media/omap24xx/tcm825x.h |4 +--
2 files changed, 22 insertions(+), 22 deletions(-)
diff --git a/drivers/staging/media/omap24xx/tcm825x.c
b/drivers/staging/media/omap24xx/tcm825x.c
index f4dd32d..48186a4 100644
--- a/drivers/staging/media/omap24xx/tcm825x.c
+++ b/drivers/staging/media/omap24xx/tcm825x.c
@@ -89,10 +89,10 @@ static const struct tcm825x_reg rgb565 = { 0x02,
TCM825X_PICFMT };
/* Our own specific controls */
#define V4L2_CID_ALC V4L2_CID_PRIVATE_BASE
-#define V4L2_CID_H_EDGE_EN V4L2_CID_PRIVATE_BASE + 1
-#define V4L2_CID_V_EDGE_EN V4L2_CID_PRIVATE_BASE + 2
-#define V4L2_CID_LENS V4L2_CID_PRIVATE_BASE + 3
-#define V4L2_CID_MAX_EXPOSURE_TIME V4L2_CID_PRIVATE_BASE + 4
+#define V4L2_CID_H_EDGE_EN (V4L2_CID_PRIVATE_BASE + 1)
+#define V4L2_CID_V_EDGE_EN (V4L2_CID_PRIVATE_BASE + 2)
+#define V4L2_CID_LENS (V4L2_CID_PRIVATE_BASE + 3)
+#define V4L2_CID_MAX_EXPOSURE_TIME (V4L2_CID_PRIVATE_BASE + 4)
#define V4L2_CID_LAST_PRIV V4L2_CID_MAX_EXPOSURE_TIME
/* Video controls */
@@ -350,8 +350,8 @@ static int tcm825x_write_default_regs(struct i2c_client
*client,
int err;
const struct tcm825x_reg *next = reglist;
- while (!((next-reg == TCM825X_REG_TERM)
- (next-val == TCM825X_VAL_TERM))) {
+ while (!((next-reg == TCM825X_REG_TERM)
+(next-val == TCM825X_VAL_TERM))) {
err = tcm825x_write_reg(client, next-reg, next-val);
if (err) {
dev_err(client-dev, register writing failed\n);
@@ -472,7 +472,7 @@ static int tcm825x_configure(struct v4l2_int_device *s)
}
static int ioctl_queryctrl(struct v4l2_int_device *s,
- struct v4l2_queryctrl *qc)
+ struct v4l2_queryctrl *qc)
{
struct vcontrol *control;
@@ -487,7 +487,7 @@ static int ioctl_queryctrl(struct v4l2_int_device *s,
}
static int ioctl_g_ctrl(struct v4l2_int_device *s,
-struct v4l2_control *vc)
+ struct v4l2_control *vc)
{
struct tcm825x_sensor *sensor = s-priv;
struct i2c_client *client = sensor-i2c_client;
@@ -532,7 +532,7 @@ static int ioctl_g_ctrl(struct v4l2_int_device *s,
}
static int ioctl_s_ctrl(struct v4l2_int_device *s,
-struct v4l2_control *vc)
+ struct v4l2_control *vc)
{
struct tcm825x_sensor *sensor = s-priv;
struct i2c_client *client = sensor-i2c_client;
@@ -571,7 +571,7 @@ static int ioctl_s_ctrl(struct v4l2_int_device *s,
}
static int ioctl_enum_fmt_cap(struct v4l2_int_device *s,
- struct v4l2_fmtdesc *fmt)
+ struct v4l2_fmtdesc *fmt)
{
int index = fmt-index;
@@ -637,7 +637,7 @@ static int ioctl_try_fmt_cap(struct v4l2_int_device *s,
}
static int ioctl_s_fmt_cap(struct v4l2_int_device *s,
- struct v4l2_format *f)
+ struct v4l2_format *f)
{
struct tcm825x_sensor *sensor = s-priv;
struct v4l2_pix_format *pix = f-fmt.pix;
@@ -655,7 +655,7 @@ static int ioctl_s_fmt_cap(struct v4l2_int_device *s,
}
static int ioctl_g_fmt_cap(struct v4l2_int_device *s,
- struct v4l2_format *f)
+ struct v4l2_format *f)
{
struct tcm825x_sensor *sensor = s-priv;
@@ -665,7 +665,7 @@ static int ioctl_g_fmt_cap(struct v4l2_int_device *s,
}
static int ioctl_g_parm(struct v4l2_int_device *s,
-struct v4l2_streamparm *a)
+ struct v4l2_streamparm *a)
{
struct tcm825x_sensor *sensor = s-priv;
struct v4l2_captureparm *cparm = a-parm.capture;
@@ -683,7 +683,7 @@ static int ioctl_g_parm(struct v4l2_int_device *s,
}
static int ioctl_s_parm(struct v4l2_int_device *s,
-struct v4l2_streamparm *a)
+ struct v4l2_streamparm *a)
{
struct tcm825x_sensor *sensor = s-priv;
struct v4l2_fract *timeperframe = a-parm.capture.timeperframe;
@@ -693,8 +693,8 @@ static int ioctl_s_parm(struct v4l2_int_device *s,
if (a-type != V4L2_BUF_TYPE_VIDEO_CAPTURE)
return -EINVAL;
- if ((timeperframe-numerator == 0)
- ||
