Re: [PATCH -mmotm] media: video/adp1653.c needs module.h

2011-08-03 Thread Stephen Rothwell
Hi Randy,

On Wed, 3 Aug 2011 10:12:26 -0700 Randy Dunlap  wrote:
>
> From: Randy Dunlap 
> 
> adp1653.c uses interfaces that are provided by 
> and needs to include that header file to fix build errors.
> 
> drivers/media/video/adp1653.c:453: warning: data definition has no type or 
> storage class
> drivers/media/video/adp1653.c:453: warning: parameter names (without types) 
> in function declaration
> drivers/media/video/adp1653.c:474: error: 'THIS_MODULE' undeclared (first use 
> in this function)
> and more.
> 
> Signed-off-by: Randy Dunlap 

That is a bug that is now in Linus' tree and this fix is pending in the
moduleh tree in linux-next.  So this patch should go to Linus.

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/


pgpS3jAhceHBc.pgp
Description: PGP signature


[PATCH -mmotm] media: video/adp1653.c needs module.h

2011-08-03 Thread Randy Dunlap
From: Randy Dunlap 

adp1653.c uses interfaces that are provided by 
and needs to include that header file to fix build errors.

drivers/media/video/adp1653.c:453: warning: data definition has no type or 
storage class
drivers/media/video/adp1653.c:453: warning: parameter names (without types) in 
function declaration
drivers/media/video/adp1653.c:474: error: 'THIS_MODULE' undeclared (first use 
in this function)
and more.

Signed-off-by: Randy Dunlap 
---
 drivers/media/video/adp1653.c |1 +
 1 file changed, 1 insertion(+)

--- mmotm-2011-0802-1619.orig/drivers/media/video/adp1653.c
+++ mmotm-2011-0802-1619/drivers/media/video/adp1653.c
@@ -32,6 +32,7 @@
 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html