Re: [PATCH -next] [media] bdisp: fix error return code in bdisp_probe()

[Fabien DESSENNE]

Hi Wei,


Thank you for the patch.


On 09/21/2016 05:09 PM, Wei Yongjun wrote:
> From: Wei Yongjun 
>
> Fix to return error code -EINVAL from the platform_get_resource() error
> handling case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun 

Reviewed-by: Fabien Dessenne 

> ---
>   drivers/media/platform/sti/bdisp/bdisp-v4l2.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/sti/bdisp/bdisp-v4l2.c 
> b/drivers/media/platform/sti/bdisp/bdisp-v4l2.c
> index 45f82b5..8236081 100644
> --- a/drivers/media/platform/sti/bdisp/bdisp-v4l2.c
> +++ b/drivers/media/platform/sti/bdisp/bdisp-v4l2.c
> @@ -1337,6 +1337,7 @@ static int bdisp_probe(struct platform_device *pdev)
>   res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
>   if (!res) {
>   dev_err(dev, "failed to get IRQ resource\n");
> + ret = -EINVAL;
>   goto err_clk;
>   }
>
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH -next] [media] bdisp: fix error return code in bdisp_probe()

[Wei Yongjun]

From: Wei Yongjun 

Fix to return error code -EINVAL from the platform_get_resource() error
handling case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun 
---
 drivers/media/platform/sti/bdisp/bdisp-v4l2.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/media/platform/sti/bdisp/bdisp-v4l2.c 
b/drivers/media/platform/sti/bdisp/bdisp-v4l2.c
index 45f82b5..8236081 100644
--- a/drivers/media/platform/sti/bdisp/bdisp-v4l2.c
+++ b/drivers/media/platform/sti/bdisp/bdisp-v4l2.c
@@ -1337,6 +1337,7 @@ static int bdisp_probe(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
if (!res) {
dev_err(dev, "failed to get IRQ resource\n");
+   ret = -EINVAL;
goto err_clk;
}

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html