Re: [PATCH 0/2] gspca sn9c20x subdriver rev2
> shouldn't there be a check when allocating jpg_hdr? or i am missing something? > > > sd->jpeg_hdr = kmalloc(JPEG_HDR_SZ, GFP_KERNEL); > jpeg_define(sd->jpeg_hdr, height, width, 0x21); > jpeg_set_qual(sd->jpeg_hdr, sd->quality); Yes probably there should be a check there. I'll one more minor revision with this plus the changes Jean-Francois mentioned previously in a bit. Brian Johnson -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] gspca sn9c20x subdriver rev2
Hi, shouldn't there be a check when allocating jpg_hdr? or i am missing something? sd->jpeg_hdr = kmalloc(JPEG_HDR_SZ, GFP_KERNEL); jpeg_define(sd->jpeg_hdr, height, width, 0x21); jpeg_set_qual(sd->jpeg_hdr, sd->quality); Best Regards. Nice to see microdia project here :) On Sat, Jul 18, 2009 at 11:19 AM, Brian Johnson wrote: >> - in the 1st patch, in gspca.c, why is the get_chip_ident check needed >> in vidioc_g_register / vidioc_s_register)? >> > According the the current v4l2 spec regarding the set and get > register ioctls drivers that support them must also support the get > chip ident ioctl. As such in the vidioc_s/g_register ioctls I do the > check to ensure that the driver also defines the get_chip_ident ioctl. > > > Brian Johnson > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] gspca sn9c20x subdriver rev2
> - in the 1st patch, in gspca.c, why is the get_chip_ident check needed > in vidioc_g_register / vidioc_s_register)? > According the the current v4l2 spec regarding the set and get register ioctls drivers that support them must also support the get chip ident ioctl. As such in the vidioc_s/g_register ioctls I do the check to ensure that the driver also defines the get_chip_ident ioctl. Brian Johnson -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] gspca sn9c20x subdriver rev2
On Fri, 17 Jul 2009 16:51:41 -0400 Brian Johnson wrote: > Mauro, > Here is the updated version of the gspca sn9c20x subdriver. > > I've removed the custom debugging support and replaced it with support > for the v4l2 debugging ioctls. The first patch in this set adds > support to the gspca core for those ioctls. Also included are the > fixes Hans sent in his last email. > > Regards, > Brian Johnson Hello Brian and Mauro, Thanks, Brian. I have just a few remarks: - in the 1st patch, in gspca.c, why is the get_chip_ident check needed in vidioc_g_register / vidioc_s_register)? - in the 1st patch, in gspca.h, the operations set/get_register in the sd descriptor should not exist if not CONFIG_VIDEO_ADV_DEBUG. - in the 2nd patch, I would have preferred hexadecimal letters in lower case. - in the 2nd patch, the list of the new handled webcams (linux/Documentation/video4linux/gspca.txt) is lacking. Anyway, this is not important and may be done later. So, Mauro, if it is OK for you (don't confirm), I will handle these patch series. Cheers. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/2] gspca sn9c20x subdriver rev2
Mauro, Here is the updated version of the gspca sn9c20x subdriver. I've removed the custom debugging support and replaced it with support for the v4l2 debugging ioctls. The first patch in this set adds support to the gspca core for those ioctls. Also included are the fixes Hans sent in his last email. Regards, Brian Johnson -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
