Re: [PATCH 0/5] Further clean up libdvbv5

2014-08-25 Thread Mauro Carvalho Chehab
Hi Gregor,

Em Sat, 23 Aug 2014 18:42:38 +0200
Gregor Jasny gja...@googlemail.com escreveu:

 Hello,
 
 Here you'll find some patches to clean up libdvbv5. I tried to
 reduce exported symbols of the shared library to easy
 maintenance in the future.
 
 Thanks,
 Gregor
 
 Gregor Jasny (5):
   libdvbv5: Remove dvbsat_polarization_name (same as dvb_sat_pol_name)
   libdvbv5: Rename and hide charset definitions
   libdvbv5: Hide unused and unexposed cnr_to_qual_s tables
   libdvbv5: Make dvb_xxx_charset const strings
   libdvbv5: Make dummy_fe static

All patches except patch 4 is ok. I merged them upstream already.

With regards to patch 4 (Make dvb_xxx_charset const strings), those
strings should not be const, but, instead, configurable, as the
default charset decoding may actually var from Country to Country.

For example, on ISDB-T, Japan uses one default, while Brazil uses
another one.

Also, the system may not be using UTF-8 as its charset.

So, the best is to add two functions that would allow the applications
based on libdvbv5 to set it, overriding the default.

I'll work on such patches and post at ML for you to take a look.

Regards,
Mauro

 
  lib/include/libdvbv5/descriptors.h |  2 --
  lib/include/libdvbv5/dvb-sat.h |  2 --
  lib/libdvbv5/descriptors.c |  3 ---
  lib/libdvbv5/descriptors/desc_event_extended.c |  2 +-
  lib/libdvbv5/descriptors/desc_event_short.c|  4 ++--
  lib/libdvbv5/descriptors/desc_network_name.c   |  2 +-
  lib/libdvbv5/descriptors/desc_service.c|  4 ++--
  lib/libdvbv5/descriptors/desc_ts_info.c|  2 +-
  lib/libdvbv5/dvb-fe.c  |  6 +++---
  lib/libdvbv5/dvb-sat.c |  7 ---
  lib/libdvbv5/parse_string.c| 12 
  lib/libdvbv5/parse_string.h|  7 +--
  lib/libdvbv5/tables/vct.c  |  2 +-
  13 files changed, 24 insertions(+), 31 deletions(-)
 
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH 0/5] Further clean up libdvbv5

2014-08-23 Thread Gregor Jasny
Hello,

Here you'll find some patches to clean up libdvbv5. I tried to
reduce exported symbols of the shared library to easy
maintenance in the future.

Thanks,
Gregor

Gregor Jasny (5):
  libdvbv5: Remove dvbsat_polarization_name (same as dvb_sat_pol_name)
  libdvbv5: Rename and hide charset definitions
  libdvbv5: Hide unused and unexposed cnr_to_qual_s tables
  libdvbv5: Make dvb_xxx_charset const strings
  libdvbv5: Make dummy_fe static

 lib/include/libdvbv5/descriptors.h |  2 --
 lib/include/libdvbv5/dvb-sat.h |  2 --
 lib/libdvbv5/descriptors.c |  3 ---
 lib/libdvbv5/descriptors/desc_event_extended.c |  2 +-
 lib/libdvbv5/descriptors/desc_event_short.c|  4 ++--
 lib/libdvbv5/descriptors/desc_network_name.c   |  2 +-
 lib/libdvbv5/descriptors/desc_service.c|  4 ++--
 lib/libdvbv5/descriptors/desc_ts_info.c|  2 +-
 lib/libdvbv5/dvb-fe.c  |  6 +++---
 lib/libdvbv5/dvb-sat.c |  7 ---
 lib/libdvbv5/parse_string.c| 12 
 lib/libdvbv5/parse_string.h|  7 +--
 lib/libdvbv5/tables/vct.c  |  2 +-
 13 files changed, 24 insertions(+), 31 deletions(-)

-- 
2.1.0

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html