Re: [PATCH 0/6] uvcvideo: V4L2 compliance fixes

2012-11-16 Thread Hans Verkuil
Hi Laurent,

My apologies for the long delay before I got around to reviewing these.

On Thu September 27 2012 17:16:14 Laurent Pinchart wrote:
 Hi everybody,
 
 Here are 6 patches that fix V4L2 compliance issues in the uvcvideo driver 
 found
 by the v4l2-compliance tool.
 
 I'm working on the last remaining issue (control classes not implemented).
 
 Laurent Pinchart (6):
   uvcvideo: Set error_idx properly for extended controls API failures
   uvcvideo: Return -EACCES when trying to access a read/write-only
 control
   uvcvideo: Don't fail when an unsupported format is requested
   uvcvideo: Set device_caps in VIDIOC_QUERYCAP
   uvcvideo: Return -ENOTTY for unsupported ioctls
   uvcvideo: Add VIDIOC_[GS]_PRIORITY support
 
  drivers/media/usb/uvc/uvc_ctrl.c   |   21 +
  drivers/media/usb/uvc/uvc_driver.c |8 +++
  drivers/media/usb/uvc/uvc_v4l2.c   |   89 ---
  drivers/media/usb/uvc/uvc_video.c  |1 +
  drivers/media/usb/uvc/uvcvideo.h   |4 ++
  5 files changed, 96 insertions(+), 27 deletions(-)
 
 

For patches 1, 2, 3 and 5:

Acked-by: Hans Verkuil hans.verk...@cisco.com

I've got some comments for patches 4 and 6. See my reply to those.

Regards,

Hans
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH 0/6] uvcvideo: V4L2 compliance fixes

2012-09-27 Thread Laurent Pinchart
Hi everybody,

Here are 6 patches that fix V4L2 compliance issues in the uvcvideo driver found
by the v4l2-compliance tool.

I'm working on the last remaining issue (control classes not implemented).

Laurent Pinchart (6):
  uvcvideo: Set error_idx properly for extended controls API failures
  uvcvideo: Return -EACCES when trying to access a read/write-only
control
  uvcvideo: Don't fail when an unsupported format is requested
  uvcvideo: Set device_caps in VIDIOC_QUERYCAP
  uvcvideo: Return -ENOTTY for unsupported ioctls
  uvcvideo: Add VIDIOC_[GS]_PRIORITY support

 drivers/media/usb/uvc/uvc_ctrl.c   |   21 +
 drivers/media/usb/uvc/uvc_driver.c |8 +++
 drivers/media/usb/uvc/uvc_v4l2.c   |   89 ---
 drivers/media/usb/uvc/uvc_video.c  |1 +
 drivers/media/usb/uvc/uvcvideo.h   |4 ++
 5 files changed, 96 insertions(+), 27 deletions(-)

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html