[PATCH 0/9 v3] IR: few fixes, additions and ENE driver

2010-07-30 Thread Maxim Levitsky

Hi,

This is mostly same patchset.

I addressed the comments of Andy Walls.

Now IR decoding is done by a separate thread, and this fixes
the race, and unnesesary performance loss due to it.

Best regards,
Maxim Levitsky

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 0/9 v3] IR: few fixes, additions and ENE driver

2010-07-30 Thread Mauro Carvalho Chehab
Em 30-07-2010 08:38, Maxim Levitsky escreveu:
 Hi,
 
 This is mostly same patchset.
 
 I addressed the comments of Andy Walls.
 
 Now IR decoding is done by a separate thread, and this fixes
 the race, and unnesesary performance loss due to it.
 
 Best regards,
   Maxim Levitsky
 

Hmm... some change at this changeset is trying to divide a 64 bits integer
at the LIRC driver. This is causing the following error:

Jul 30 16:45:23 agua kernel: [23834.179871] lirc_dev: IR Remote Control driver 
registered, major 251 
Jul 30 16:45:23 agua kernel: [23834.181884] ir_lirc_codec: Unknown symbol 
__udivdi3 (err 0)

you should, instead use do_div for doing that. Another fix would be to define 
the timeout
constants as int or u32.

Cheers,
Mauro
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 0/9 v3] IR: few fixes, additions and ENE driver

2010-07-30 Thread Maxim Levitsky
On Fri, 2010-07-30 at 16:33 -0300, Mauro Carvalho Chehab wrote: 
 Em 30-07-2010 08:38, Maxim Levitsky escreveu:
  Hi,
  
  This is mostly same patchset.
  
  I addressed the comments of Andy Walls.
  
  Now IR decoding is done by a separate thread, and this fixes
  the race, and unnesesary performance loss due to it.
  
  Best regards,
  Maxim Levitsky
  
 
 Hmm... some change at this changeset is trying to divide a 64 bits integer
 at the LIRC driver. This is causing the following error:
 
 Jul 30 16:45:23 agua kernel: [23834.179871] lirc_dev: IR Remote Control 
 driver registered, major 251 
 Jul 30 16:45:23 agua kernel: [23834.181884] ir_lirc_codec: Unknown symbol 
 __udivdi3 (err 0)
 
 you should, instead use do_div for doing that. Another fix would be to define 
 the timeout
 constants as int or u32.
I know about that, but forgot, sorry.

Sure, will do.

Best regards,
Maxim Levitsky

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html