Re: [PATCH 1/1] [media] radio-sf16fmr2: Remove redundant dev_set_drvdata

2013-09-30 Thread Hans Verkuil 
On 09/20/2013 10:37 AM, Sachin Kamat wrote:
> Driver core sets driver data to NULL upon failure or remove.
> 
> Signed-off-by: Sachin Kamat 

Acked-by: Hans Verkuil 

Regards,

Hans

> ---
>  drivers/media/radio/radio-sf16fmr2.c |1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/media/radio/radio-sf16fmr2.c 
> b/drivers/media/radio/radio-sf16fmr2.c
> index f1e3714..448cac9 100644
> --- a/drivers/media/radio/radio-sf16fmr2.c
> +++ b/drivers/media/radio/radio-sf16fmr2.c
> @@ -295,7 +295,6 @@ static void fmr2_remove(struct fmr2 *fmr2)
>  static int fmr2_isa_remove(struct device *pdev, unsigned int ndev)
>  {
>   fmr2_remove(dev_get_drvdata(pdev));
> - dev_set_drvdata(pdev, NULL);
>  
>   return 0;
>  }
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/1] [media] radio-sf16fmr2: Remove redundant dev_set_drvdata

2013-09-20 Thread Sachin Kamat 
Driver core sets driver data to NULL upon failure or remove.

Signed-off-by: Sachin Kamat 
---
 drivers/media/radio/radio-sf16fmr2.c |1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/media/radio/radio-sf16fmr2.c 
b/drivers/media/radio/radio-sf16fmr2.c
index f1e3714..448cac9 100644
--- a/drivers/media/radio/radio-sf16fmr2.c
+++ b/drivers/media/radio/radio-sf16fmr2.c
@@ -295,7 +295,6 @@ static void fmr2_remove(struct fmr2 *fmr2)
 static int fmr2_isa_remove(struct device *pdev, unsigned int ndev)
 {
fmr2_remove(dev_get_drvdata(pdev));
-   dev_set_drvdata(pdev, NULL);
 
return 0;
 }
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html