Re: [PATCH 1/2] media: usb: uvc: remove duplicate & operation

[Laurent Pinchart]

Hello Jaejoong,

Thank you for the patch.

On Friday, 20 October 2017 10:25:27 EET Jaejoong Kim wrote:
> usb_endpoint_maxp() has an inline keyword and searches for bits[10:0]
> by & operation with 0x7ff. So, we can remove the duplicate & operation
> with 0x7ff.
> 
> Signed-off-by: Jaejoong Kim 

Reviewed-by: Laurent Pinchart 

and applied to my tree.

> ---
>  drivers/media/usb/uvc/uvc_video.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/usb/uvc/uvc_video.c
> b/drivers/media/usb/uvc/uvc_video.c index fb86d6a..f4ace63 100644
> --- a/drivers/media/usb/uvc/uvc_video.c
> +++ b/drivers/media/usb/uvc/uvc_video.c
> @@ -1469,13 +1469,13 @@ static unsigned int uvc_endpoint_max_bpi(struct
> usb_device *dev, case USB_SPEED_HIGH:
>   psize = usb_endpoint_maxp(>desc);
>   mult = usb_endpoint_maxp_mult(>desc);
> - return (psize & 0x07ff) * mult;
> + return psize * mult;
>   case USB_SPEED_WIRELESS:
>   psize = usb_endpoint_maxp(>desc);
>   return psize;
>   default:
>   psize = usb_endpoint_maxp(>desc);
> - return psize & 0x07ff;
> + return psize;
>   }
>  }


-- 
Regards,

Laurent Pinchart

Re: [PATCH 1/2] media: usb: uvc: remove duplicate & operation

[Jaejoong Kim]

Hi, Laurent

Could you please review this patch?

Thanks, jaejoong

2017-10-20 16:25 GMT+09:00 Jaejoong Kim :
> usb_endpoint_maxp() has an inline keyword and searches for bits[10:0]
> by & operation with 0x7ff. So, we can remove the duplicate & operation
> with 0x7ff.
>
> Signed-off-by: Jaejoong Kim 
> ---
>  drivers/media/usb/uvc/uvc_video.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/usb/uvc/uvc_video.c 
> b/drivers/media/usb/uvc/uvc_video.c
> index fb86d6a..f4ace63 100644
> --- a/drivers/media/usb/uvc/uvc_video.c
> +++ b/drivers/media/usb/uvc/uvc_video.c
> @@ -1469,13 +1469,13 @@ static unsigned int uvc_endpoint_max_bpi(struct 
> usb_device *dev,
> case USB_SPEED_HIGH:
> psize = usb_endpoint_maxp(>desc);
> mult = usb_endpoint_maxp_mult(>desc);
> -   return (psize & 0x07ff) * mult;
> +   return psize * mult;
> case USB_SPEED_WIRELESS:
> psize = usb_endpoint_maxp(>desc);
> return psize;
> default:
> psize = usb_endpoint_maxp(>desc);
> -   return psize & 0x07ff;
> +   return psize;
> }
>  }
>
> --
> 2.7.4
>

[PATCH 1/2] media: usb: uvc: remove duplicate & operation

[Jaejoong Kim]

usb_endpoint_maxp() has an inline keyword and searches for bits[10:0]
by & operation with 0x7ff. So, we can remove the duplicate & operation
with 0x7ff.

Signed-off-by: Jaejoong Kim 
---
 drivers/media/usb/uvc/uvc_video.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/usb/uvc/uvc_video.c 
b/drivers/media/usb/uvc/uvc_video.c
index fb86d6a..f4ace63 100644
--- a/drivers/media/usb/uvc/uvc_video.c
+++ b/drivers/media/usb/uvc/uvc_video.c
@@ -1469,13 +1469,13 @@ static unsigned int uvc_endpoint_max_bpi(struct 
usb_device *dev,
case USB_SPEED_HIGH:
psize = usb_endpoint_maxp(>desc);
mult = usb_endpoint_maxp_mult(>desc);
-   return (psize & 0x07ff) * mult;
+   return psize * mult;
case USB_SPEED_WIRELESS:
psize = usb_endpoint_maxp(>desc);
return psize;
default:
psize = usb_endpoint_maxp(>desc);
-   return psize & 0x07ff;
+   return psize;
}
 }
 
-- 
2.7.4