Re: [PATCH 1/2] saa7164: change Si2168 reglen to 0 bit

2015-06-11 Thread Steven Toth 
On Sat, Jun 6, 2015 at 3:44 AM, Olli Salonen  wrote:
> The i2c_reg_len for Si2168 should be 0 for correct I2C communication.
>
> Signed-off-by: Olli Salonen 

Tested-By: Steven Toth 

Checked with a HVR-2205 and a HVR-2215, firmware loads as expected.

-- 
Steven Toth - Kernel Labs
http://www.kernellabs.com
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] saa7164: change Si2168 reglen to 0 bit

2015-06-06 Thread Antti Palosaari 

On 06/06/2015 10:44 AM, Olli Salonen wrote:

The i2c_reg_len for Si2168 should be 0 for correct I2C communication.

Signed-off-by: Olli Salonen 


Reviewed-by: Antti Palosaari 

PS. As I mentioned few times already, that kind I2C client register map 
layout information does not belongs to adapter level at all. I wonder 
why it is here. Likely some further clean-ups are possible.


regards
Antti



---
  drivers/media/pci/saa7164/saa7164-cards.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/pci/saa7164/saa7164-cards.c 
b/drivers/media/pci/saa7164/saa7164-cards.c
index 8a6455d..c2b7382 100644
--- a/drivers/media/pci/saa7164/saa7164-cards.c
+++ b/drivers/media/pci/saa7164/saa7164-cards.c
@@ -621,7 +621,7 @@ struct saa7164_board saa7164_boards[] = {
.name   = "SI2168-1",
.i2c_bus_nr = SAA7164_I2C_BUS_2,
.i2c_bus_addr   = 0xc8 >> 1,
-   .i2c_reg_len= REGLEN_8bit,
+   .i2c_reg_len= REGLEN_0bit,
}, {
.id = 0x25,
.type   = SAA7164_UNIT_TUNER,
@@ -635,7 +635,7 @@ struct saa7164_board saa7164_boards[] = {
.name   = "SI2168-2",
.i2c_bus_nr = SAA7164_I2C_BUS_2,
.i2c_bus_addr   = 0xcc >> 1,
-   .i2c_reg_len= REGLEN_8bit,
+   .i2c_reg_len= REGLEN_0bit,
} },
},
  };



--
http://palosaari.fi/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/2] saa7164: change Si2168 reglen to 0 bit

2015-06-06 Thread Olli Salonen 
The i2c_reg_len for Si2168 should be 0 for correct I2C communication.

Signed-off-by: Olli Salonen 
---
 drivers/media/pci/saa7164/saa7164-cards.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/pci/saa7164/saa7164-cards.c 
b/drivers/media/pci/saa7164/saa7164-cards.c
index 8a6455d..c2b7382 100644
--- a/drivers/media/pci/saa7164/saa7164-cards.c
+++ b/drivers/media/pci/saa7164/saa7164-cards.c
@@ -621,7 +621,7 @@ struct saa7164_board saa7164_boards[] = {
.name   = "SI2168-1",
.i2c_bus_nr = SAA7164_I2C_BUS_2,
.i2c_bus_addr   = 0xc8 >> 1,
-   .i2c_reg_len= REGLEN_8bit,
+   .i2c_reg_len= REGLEN_0bit,
}, {
.id = 0x25,
.type   = SAA7164_UNIT_TUNER,
@@ -635,7 +635,7 @@ struct saa7164_board saa7164_boards[] = {
.name   = "SI2168-2",
.i2c_bus_nr = SAA7164_I2C_BUS_2,
.i2c_bus_addr   = 0xcc >> 1,
-   .i2c_reg_len= REGLEN_8bit,
+   .i2c_reg_len= REGLEN_0bit,
} },
},
 };
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html