Re: [PATCH 1/3] [media] s5p-mfc: use mfc_err instead of printk
Hi Sachin, On 01/07/2013 05:09 AM, Sachin Kamat wrote: > Hi Sylwester, > > On 3 January 2013 00:00, Kamil Debski wrote: >> Hi Sachin, >> >> Thank you for your patch. >> >> Best wishes, >> -- >> Kamil Debski >> Linux Platform Group >> Samsung Poland R&D Center >> >>> From: linux-media-ow...@vger.kernel.org [mailto:linux-media- >>> ow...@vger.kernel.org] On Behalf Of Sachin Kamat >>> Sent: Friday, December 28, 2012 11:18 AM >>> To: linux-media@vger.kernel.org >>> Cc: k.deb...@samsung.com; s.nawro...@samsung.com; >>> sylvester.nawro...@gmail.com; sachin.ka...@linaro.org; >>> patc...@linaro.org >>> Subject: [PATCH 1/3] [media] s5p-mfc: use mfc_err instead of printk >>> >>> Use mfc_err for consistency. Also silences checkpatch warning. >>> >> >> Acked-by: Kamil Debski >> >>> Signed-off-by: Sachin Kamat >>> --- > > Probably you missed to apply this patch to your tree. Hmm, not really, I intended it for a second v3.9 pull request. However I checked it yesterday and it doesn't apply any more. Since one of Kamil's patches includes same change. Thanks, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 1/3] [media] s5p-mfc: use mfc_err instead of printk
Hi Sachin,
Thank you for your patch.
Best wishes,
--
Kamil Debski
Linux Platform Group
Samsung Poland R&D Center
> From: linux-media-ow...@vger.kernel.org [mailto:linux-media-
> ow...@vger.kernel.org] On Behalf Of Sachin Kamat
> Sent: Friday, December 28, 2012 11:18 AM
> To: linux-media@vger.kernel.org
> Cc: k.deb...@samsung.com; s.nawro...@samsung.com;
> sylvester.nawro...@gmail.com; sachin.ka...@linaro.org;
> patc...@linaro.org
> Subject: [PATCH 1/3] [media] s5p-mfc: use mfc_err instead of printk
>
> Use mfc_err for consistency. Also silences checkpatch warning.
>
Acked-by: Kamil Debski
> Signed-off-by: Sachin Kamat
> ---
> drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c |3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c
> b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c
> index bf7d010..bb99d3d 100644
> --- a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c
> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c
> @@ -187,8 +187,7 @@ int s5p_mfc_alloc_codec_buffers_v5(struct
> s5p_mfc_ctx *ctx)
> dev->alloc_ctx[MFC_BANK1_ALLOC_CTX], ctx->bank1_size);
> if (IS_ERR(ctx->bank1_buf)) {
> ctx->bank1_buf = NULL;
> - printk(KERN_ERR
> -"Buf alloc for decoding failed (port A)\n");
> + mfc_err("Buf alloc for decoding failed (port A)\n");
> return -ENOMEM;
> }
> ctx->bank1_phys = s5p_mfc_mem_cookie(
> --
> 1.7.4.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media"
> in the body of a message to majord...@vger.kernel.org More majordomo
> info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 1/3] [media] s5p-mfc: use mfc_err instead of printk
Use mfc_err for consistency. Also silences checkpatch warning.
Signed-off-by: Sachin Kamat
---
drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c
b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c
index bf7d010..bb99d3d 100644
--- a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c
+++ b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c
@@ -187,8 +187,7 @@ int s5p_mfc_alloc_codec_buffers_v5(struct s5p_mfc_ctx *ctx)
dev->alloc_ctx[MFC_BANK1_ALLOC_CTX], ctx->bank1_size);
if (IS_ERR(ctx->bank1_buf)) {
ctx->bank1_buf = NULL;
- printk(KERN_ERR
- "Buf alloc for decoding failed (port A)\n");
+ mfc_err("Buf alloc for decoding failed (port A)\n");
return -ENOMEM;
}
ctx->bank1_phys = s5p_mfc_mem_cookie(
--
1.7.4.1
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
