Re: [PATCH 11/14] drivers/media/usb/stk1160/stk1160-i2c.c: fix error return code

2012-09-07 Thread Ezequiel Garcia 
On Thu, Sep 6, 2012 at 12:23 PM, Peter Senna Tschudin
peter.se...@gmail.com wrote:
 From: Peter Senna Tschudin peter.se...@gmail.com

 Convert a nonnegative error return code to a negative one, as returned
 elsewhere in the function.

 A simplified version of the semantic match that finds this problem is as
 follows: (http://coccinelle.lip6.fr/)

 // smpl
 (
 if@p1 (\(ret  0\|ret != 0\))
  { ... return ret; }
 |
 ret@p1 = 0
 )
 ... when != ret = e1
 when != ret
 *if(...)
 {
   ... when != ret = e2
   when forall
  return ret;
 }

 // /smpl

 Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com

 ---
  drivers/media/usb/stk1160/stk1160-i2c.c |2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

 diff --git a/drivers/media/usb/stk1160/stk1160-i2c.c 
 b/drivers/media/usb/stk1160/stk1160-i2c.c
 index 176ac93..850cf28 100644
 --- a/drivers/media/usb/stk1160/stk1160-i2c.c
 +++ b/drivers/media/usb/stk1160/stk1160-i2c.c
 @@ -116,7 +116,7 @@ static int stk1160_i2c_read_reg(struct stk1160 *dev, u8 
 addr,
 if (rc  0)
 return rc;

 -   stk1160_read_reg(dev, STK1160_SBUSR_RD, value);
 +   rc = stk1160_read_reg(dev, STK1160_SBUSR_RD, value);
 if (rc  0)
 return rc;


 --

Acked-by: Ezequiel Garcia elezegar...@gmail.com
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 11/14] drivers/media/usb/stk1160/stk1160-i2c.c: fix error return code

2012-09-06 Thread Peter Senna Tschudin 
From: Peter Senna Tschudin peter.se...@gmail.com

Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// smpl
(
if@p1 (\(ret  0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
when != ret
*if(...)
{
  ... when != ret = e2
  when forall
 return ret;
}

// /smpl

Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com

---
 drivers/media/usb/stk1160/stk1160-i2c.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/usb/stk1160/stk1160-i2c.c 
b/drivers/media/usb/stk1160/stk1160-i2c.c
index 176ac93..850cf28 100644
--- a/drivers/media/usb/stk1160/stk1160-i2c.c
+++ b/drivers/media/usb/stk1160/stk1160-i2c.c
@@ -116,7 +116,7 @@ static int stk1160_i2c_read_reg(struct stk1160 *dev, u8 
addr,
if (rc  0)
return rc;
 
-   stk1160_read_reg(dev, STK1160_SBUSR_RD, value);
+   rc = stk1160_read_reg(dev, STK1160_SBUSR_RD, value);
if (rc  0)
return rc;
 

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html