Re: [PATCH 2/2] staging: nokia_h4p: nokia_core.c - removed IRQF_DISABLED macro
On Wednesday 09 July 2014 05:16 PM, Pavel Machek wrote: > I wonder if it would maek sense to do > ./include/linux/interrupt.h:#define IRQF_DISABLED 0 to make it extra > clear that it is nop now? Pavel yes - it makes sense. there are still a few references to the macro in the code. Cheers, Anil -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/2] staging: nokia_h4p: nokia_core.c - removed IRQF_DISABLED macro
On Wed 2014-07-09 11:36:38, Anil Belur wrote: > From: Anil Belur > > - this patch removes the IRQF_DISABLED macro, as this is > deprecated/noop. > > Signed-off-by: Anil Belur Acked-by: Pavel Machek I wonder if it would maek sense to do ./include/linux/interrupt.h:#define IRQF_DISABLED 0 to make it extra clear that it is nop now? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 2/2] staging: nokia_h4p: nokia_core.c - removed IRQF_DISABLED macro
From: Anil Belur - this patch removes the IRQF_DISABLED macro, as this is deprecated/noop. Signed-off-by: Anil Belur --- drivers/staging/nokia_h4p/nokia_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/nokia_h4p/nokia_core.c b/drivers/staging/nokia_h4p/nokia_core.c index 5e19cd6..840cc66 100644 --- a/drivers/staging/nokia_h4p/nokia_core.c +++ b/drivers/staging/nokia_h4p/nokia_core.c @@ -1141,7 +1141,7 @@ static int hci_h4p_probe(struct platform_device *pdev) err = devm_request_irq(&pdev->dev, gpio_to_irq(info->host_wakeup_gpio), hci_h4p_wakeup_interrupt, IRQF_TRIGGER_FALLING | - IRQF_TRIGGER_RISING | IRQF_DISABLED, + IRQF_TRIGGER_RISING, "hci_h4p_wkup", info); if (err < 0) { dev_err(info->dev, "hci_h4p: unable to get wakeup IRQ %d\n", -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html