Re: [PATCH 2/2 v2] gspca: Add MR97310A driver

2009-01-16 Thread Jean-Francois Moine
On Thu, 15 Jan 2009 22:36:49 -0600
Kyle Guinn ely...@gmail.com wrote:

 This patch adds support for USB webcams based on the MR97310A chip.
 It was tested with an Aiptek PenCam VGA+ webcam.

Hi Kyle,

I added your driver to my repository.

I just found a little bug. At line 250/251

data[8] = 0x01;
err_code = reg_w(gspca_dev, 10);

you set 9 values and you output 10 values.

BTW, as many of these USB control messages are constant, you should
better use static data or a table format (byte count, values)*.

Regards.

-- 
Ken ar c'hentan | ** Breizh ha Linux atav! **
Jef |   http://moinejf.free.fr/
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 2/2 v2] gspca: Add MR97310A driver

2009-01-16 Thread Kyle Guinn
On Friday 16 January 2009 02:47:31 Jean-Francois Moine wrote:
 On Thu, 15 Jan 2009 22:36:49 -0600
 Kyle Guinn ely...@gmail.com wrote:
  This patch adds support for USB webcams based on the MR97310A chip.
  It was tested with an Aiptek PenCam VGA+ webcam.

 Hi Kyle,

 I added your driver to my repository.

 I just found a little bug. At line 250/251

   data[8] = 0x01;
   err_code = reg_w(gspca_dev, 10);

 you set 9 values and you output 10 values.


Good catch.  Yes, that should be 9.

Also that data[8] should be set to 0x00.  I must have been asleep at the 
keyboard :)  I'll send a patch.

 BTW, as many of these USB control messages are constant, you should
 better use static data or a table format (byte count, values)*.


I'll look into this.  Those may not all be costants, I believe the camera 
supports gamma adjustment and autoexposure and maybe some other controls.  I 
plan on gathering some traces to figure that out next week.

Regards,
-Kyle
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html