Re: [PATCH 2/4] v4l: Helper function for obtaining timestamps

[Hans Verkuil]

On Thu November 15 2012 23:06:45 Sakari Ailus wrote:
> v4l2_get_timestamp() produces a monotonic timestamp but unlike
> ktime_get_ts(), it uses struct timeval instead of struct timespec, saving
> the drivers the conversion job when getting timestamps for v4l2_buffer's
> timestamp field.
> 
> Signed-off-by: Sakari Ailus 
> ---
>  drivers/media/v4l2-core/v4l2-common.c |   10 ++
>  include/media/v4l2-common.h   |2 ++
>  2 files changed, 12 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/media/v4l2-core/v4l2-common.c 
> b/drivers/media/v4l2-core/v4l2-common.c
> index 380ddd8..614316f 100644
> --- a/drivers/media/v4l2-core/v4l2-common.c
> +++ b/drivers/media/v4l2-core/v4l2-common.c
> @@ -978,3 +978,13 @@ const struct v4l2_frmsize_discrete 
> *v4l2_find_nearest_format(
>   return best;
>  }
>  EXPORT_SYMBOL_GPL(v4l2_find_nearest_format);
> +
> +void v4l2_get_timestamp(struct timeval *tv)
> +{
> + struct timespec ts;
> +
> + ktime_get_ts(&ts);
> + tv->tv_sec = ts.tv_sec;
> + tv->tv_usec = ts.tv_nsec / NSEC_PER_USEC;
> +}
> +EXPORT_SYMBOL_GPL(v4l2_get_timestamp);
> diff --git a/include/media/v4l2-common.h b/include/media/v4l2-common.h
> index 1a0b2db..ec7c9c0 100644
> --- a/include/media/v4l2-common.h
> +++ b/include/media/v4l2-common.h
> @@ -225,4 +225,6 @@ bool v4l2_detect_gtf(unsigned frame_height, unsigned 
> hfreq, unsigned vsync,
>  
>  struct v4l2_fract v4l2_calc_aspect_ratio(u8 hor_landscape, u8 vert_portrait);
>  
> +void v4l2_get_timestamp(struct timeval *tv);
> +
>  #endif /* V4L2_COMMON_H_ */
> 

Acked-by: Hans Verkuil 

Regards,

Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/4] v4l: Helper function for obtaining timestamps

[Sakari Ailus]

v4l2_get_timestamp() produces a monotonic timestamp but unlike
ktime_get_ts(), it uses struct timeval instead of struct timespec, saving
the drivers the conversion job when getting timestamps for v4l2_buffer's
timestamp field.

Signed-off-by: Sakari Ailus 
---
 drivers/media/v4l2-core/v4l2-common.c |   10 ++
 include/media/v4l2-common.h   |2 ++
 2 files changed, 12 insertions(+), 0 deletions(-)

diff --git a/drivers/media/v4l2-core/v4l2-common.c 
b/drivers/media/v4l2-core/v4l2-common.c
index 380ddd8..614316f 100644
--- a/drivers/media/v4l2-core/v4l2-common.c
+++ b/drivers/media/v4l2-core/v4l2-common.c
@@ -978,3 +978,13 @@ const struct v4l2_frmsize_discrete 
*v4l2_find_nearest_format(
return best;
 }
 EXPORT_SYMBOL_GPL(v4l2_find_nearest_format);
+
+void v4l2_get_timestamp(struct timeval *tv)
+{
+   struct timespec ts;
+
+   ktime_get_ts(&ts);
+   tv->tv_sec = ts.tv_sec;
+   tv->tv_usec = ts.tv_nsec / NSEC_PER_USEC;
+}
+EXPORT_SYMBOL_GPL(v4l2_get_timestamp);
diff --git a/include/media/v4l2-common.h b/include/media/v4l2-common.h
index 1a0b2db..ec7c9c0 100644
--- a/include/media/v4l2-common.h
+++ b/include/media/v4l2-common.h
@@ -225,4 +225,6 @@ bool v4l2_detect_gtf(unsigned frame_height, unsigned hfreq, 
unsigned vsync,
 
 struct v4l2_fract v4l2_calc_aspect_ratio(u8 hor_landscape, u8 vert_portrait);
 
+void v4l2_get_timestamp(struct timeval *tv);
+
 #endif /* V4L2_COMMON_H_ */
-- 
1.7.2.5

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html