Re: [PATCH 3/3] [media] az6007: handle CI during suspend/resume
Em 06-08-2012 09:21, Antti Palosaari escreveu: On 08/05/2012 08:44 PM, Mauro Carvalho Chehab wrote: The dvb-usb-v2 core doesn't know anything about CI. So, the driver needs to handle it by hand. This patch stops CI just before stopping URB's/RC, and restarts it before URB/RC start. It should be noticed that suspend/resume is not yet working properly, as the PM model requires the implementation of reset_resume: dvb_usb_az6007 1-6:1.0: no reset_resume for driver dvb_usb_az6007? But this is not implemented there at dvb-usb-v2 yet. That is true, but it is coming: http://blog.palosaari.fi/2012/07/dvb-power-management-on-suspend.html http://git.linuxtv.org/anttip/media_tree.git/shortlog/refs/heads/dvb_core3 At the time I added initial suspend/resume support for dvb-usb-v2 I left those out purposely as I saw some study and changes are needed for DVB-core/frontend. Normally suspend keeps USB-device powered and calls .resume() on resume. But on certain conditions USB device could lose power during suspend and on that case reset_resume() is called, and if there is no reset_resume() is calls disconnect() (and probe() after that). This should depend on BIOS settings, and what of the following type of suspend[1] was done: S1: All processor caches are flushed, and the CPU(s) stops executing instructions. Power to the CPU(s) and RAM is maintained; devices that do not indicate they must remain on may be powered down. S2: CPU powered off. Dirty cache is flushed to RAM. S3: Commonly referred to as Standby, Sleep, or Suspend to RAM. RAM remains powered S4: Hibernation or Suspend to Disk. All content of main memory is saved to non-volatile memory such as a hard drive, and is powered down. [1] http://en.wikipedia.org/wiki/Advanced_Configuration_and_Power_Interface There are also some per-device sysfs nodes that control how PM will work for them. See: $ tree /sys/devices/pci:00/:00:1d.7/usb1/1-8/dvb/dvb0.frontend0 /sys/devices/pci:00/:00:1d.7/usb1/1-8/dvb/dvb0.frontend0 ├── dev ├── device - ../../../1-8 ├── power │ ├── async │ ├── autosuspend_delay_ms │ ├── control │ ├── runtime_active_kids │ ├── runtime_active_time │ ├── runtime_enabled │ ├── runtime_status │ ├── runtime_suspended_time │ └── runtime_usage ├── subsystem - ../../../../../../../class/dvb └── uevent There are a number of pm functions that can change the power management behavior as well. Not sure how to control it, but, IMHO, for a media device, it only makes sense to keep it powered on suspend if the device has IR and if the power button of the IR could be used to wake up the hardware. Otherwise, the better is to just power it off, to save battery (for notebooks). Maybe it makes sense to talk with Raphael Wysocki to be sure that it will cover all possible cases: auto-suspend, S1/S2/S3/S4 and wake on IR). regards Antti -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/3] [media] az6007: handle CI during suspend/resume
On 08/07/2012 02:41 PM, Mauro Carvalho Chehab wrote: Em 06-08-2012 09:21, Antti Palosaari escreveu: On 08/05/2012 08:44 PM, Mauro Carvalho Chehab wrote: The dvb-usb-v2 core doesn't know anything about CI. So, the driver needs to handle it by hand. This patch stops CI just before stopping URB's/RC, and restarts it before URB/RC start. It should be noticed that suspend/resume is not yet working properly, as the PM model requires the implementation of reset_resume: dvb_usb_az6007 1-6:1.0: no reset_resume for driver dvb_usb_az6007? But this is not implemented there at dvb-usb-v2 yet. That is true, but it is coming: http://blog.palosaari.fi/2012/07/dvb-power-management-on-suspend.html http://git.linuxtv.org/anttip/media_tree.git/shortlog/refs/heads/dvb_core3 At the time I added initial suspend/resume support for dvb-usb-v2 I left those out purposely as I saw some study and changes are needed for DVB-core/frontend. Normally suspend keeps USB-device powered and calls .resume() on resume. But on certain conditions USB device could lose power during suspend and on that case reset_resume() is called, and if there is no reset_resume() is calls disconnect() (and probe() after that). This should depend on BIOS settings, and what of the following type of suspend[1] was done: S1: All processor caches are flushed, and the CPU(s) stops executing instructions. Power to the CPU(s) and RAM is maintained; devices that do not indicate they must remain on may be powered down. S2: CPU powered off. Dirty cache is flushed to RAM. S3: Commonly referred to as Standby, Sleep, or Suspend to RAM. RAM remains powered S4: Hibernation or Suspend to Disk. All content of main memory is saved to non-volatile memory such as a hard drive, and is powered down. [1] http://en.wikipedia.org/wiki/Advanced_Configuration_and_Power_Interface That was something I was already aware. There is even S5 and S4b mentioned by Kernel documentation. But in real life you have to care only: S3, Suspend, suspend to ram S4, Hibernation, suspend to disk And from the USB-driver point of view those are covered by there three callbacks: .suspend() .resume() .reset_resume() * if reset_resume() does not exits .disconnect() + .probe() is called instead What is my current understanding S3 level leaves USB/PCI powered normally, but device driver should drop device to low power state. In case of DVB -device this means all sub-drivers should put sleep. S4 naturally powers everything off. Also worth to mention laptops will switch from S3 to S4 if battery drains empty during S3. There are also some per-device sysfs nodes that control how PM will work for them. See: $ tree /sys/devices/pci:00/:00:1d.7/usb1/1-8/dvb/dvb0.frontend0 /sys/devices/pci:00/:00:1d.7/usb1/1-8/dvb/dvb0.frontend0 ├── dev ├── device - ../../../1-8 ├── power │ ├── async │ ├── autosuspend_delay_ms │ ├── control │ ├── runtime_active_kids │ ├── runtime_active_time │ ├── runtime_enabled │ ├── runtime_status │ ├── runtime_suspended_time │ └── runtime_usage ├── subsystem - ../../../../../../../class/dvb └── uevent There are a number of pm functions that can change the power management behavior as well. Not sure how to control it, but, IMHO, for a media device, it only makes sense to keep it powered on suspend if the device has IR and if the power button of the IR could be used to wake up the hardware. Otherwise, the better is to just power it off, to save battery (for notebooks). yeah, and it was already done. Maybe it makes sense to talk with Raphael Wysocki to be sure that it will cover all possible cases: auto-suspend, S1/S2/S3/S4 and wake on IR). That IR was something I wasn't noticed at all. Currently it stops IR polling too. If that kind of functionality is needed it is surely some more work as you cannot stop IR-polling. Maybe I will skip it that time as I don't have time for it currently :) If someone wish to learn how USB polling remote could be used for wake-up computer then feel free to do that. regards Antti -- http://palosaari.fi/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/3] [media] az6007: handle CI during suspend/resume
Em 07-08-2012 09:12, Antti Palosaari escreveu: On 08/07/2012 02:41 PM, Mauro Carvalho Chehab wrote: Em 06-08-2012 09:21, Antti Palosaari escreveu: On 08/05/2012 08:44 PM, Mauro Carvalho Chehab wrote: The dvb-usb-v2 core doesn't know anything about CI. So, the driver needs to handle it by hand. This patch stops CI just before stopping URB's/RC, and restarts it before URB/RC start. It should be noticed that suspend/resume is not yet working properly, as the PM model requires the implementation of reset_resume: dvb_usb_az6007 1-6:1.0: no reset_resume for driver dvb_usb_az6007? But this is not implemented there at dvb-usb-v2 yet. That is true, but it is coming: http://blog.palosaari.fi/2012/07/dvb-power-management-on-suspend.html http://git.linuxtv.org/anttip/media_tree.git/shortlog/refs/heads/dvb_core3 At the time I added initial suspend/resume support for dvb-usb-v2 I left those out purposely as I saw some study and changes are needed for DVB-core/frontend. Normally suspend keeps USB-device powered and calls .resume() on resume. But on certain conditions USB device could lose power during suspend and on that case reset_resume() is called, and if there is no reset_resume() is calls disconnect() (and probe() after that). This should depend on BIOS settings, and what of the following type of suspend[1] was done: S1: All processor caches are flushed, and the CPU(s) stops executing instructions. Power to the CPU(s) and RAM is maintained; devices that do not indicate they must remain on may be powered down. S2: CPU powered off. Dirty cache is flushed to RAM. S3: Commonly referred to as Standby, Sleep, or Suspend to RAM. RAM remains powered S4: Hibernation or Suspend to Disk. All content of main memory is saved to non-volatile memory such as a hard drive, and is powered down. [1] http://en.wikipedia.org/wiki/Advanced_Configuration_and_Power_Interface That was something I was already aware. There is even S5 and S4b mentioned by Kernel documentation. But in real life you have to care only: S3, Suspend, suspend to ram S4, Hibernation, suspend to disk At least on some of my machines, BIOS allow to select between S1 and S3 for suspend. Not sure how USB PM suspend works for either case. And from the USB-driver point of view those are covered by there three callbacks: .suspend() .resume() .reset_resume() * if reset_resume() does not exits .disconnect() + .probe() is called instead What is my current understanding S3 level leaves USB/PCI powered normally, but device driver should drop device to low power state. In case of DVB -device this means all sub-drivers should put sleep. Yes. It might make sense to keep IR working (maybe at a lower polling rate, for non- interrupt based drivers), in order to wake machine up, if the power button is pressed, but this would be an additional feature, and I've no idea how this would be implemented. S4 naturally powers everything off. Also worth to mention laptops will switch from S3 to S4 if battery drains empty during S3. I'm not a PM expert, but as BIOS may support features like wake on LAN, it would make sense to keep USB power, at least on those devices that may wake up the device (hid and network devices, for example). There are also some per-device sysfs nodes that control how PM will work for them. See: $ tree /sys/devices/pci:00/:00:1d.7/usb1/1-8/dvb/dvb0.frontend0 /sys/devices/pci:00/:00:1d.7/usb1/1-8/dvb/dvb0.frontend0 ├── dev ├── device - ../../../1-8 ├── power │ ├── async │ ├── autosuspend_delay_ms │ ├── control │ ├── runtime_active_kids │ ├── runtime_active_time │ ├── runtime_enabled │ ├── runtime_status │ ├── runtime_suspended_time │ └── runtime_usage ├── subsystem - ../../../../../../../class/dvb └── uevent There are a number of pm functions that can change the power management behavior as well. Not sure how to control it, but, IMHO, for a media device, it only makes sense to keep it powered on suspend if the device has IR and if the power button of the IR could be used to wake up the hardware. Otherwise, the better is to just power it off, to save battery (for notebooks). yeah, and it was already done. Maybe it makes sense to talk with Raphael Wysocki to be sure that it will cover all possible cases: auto-suspend, S1/S2/S3/S4 and wake on IR). That IR was something I wasn't noticed at all. Currently it stops IR polling too. If that kind of functionality is needed it is surely some more work as you cannot stop IR-polling. Yes. There's also an addidional case: dib0700, for example, doesn't do IR polling. Instead, they send an URB on a separate endpoint. When a key is pressed, the device answers to that pending URB request with the keypress. Maybe I will skip it that time as I don't have time for it currently :) If someone wish to learn how
Re: [PATCH 3/3] [media] az6007: handle CI during suspend/resume
On 08/05/2012 08:44 PM, Mauro Carvalho Chehab wrote: The dvb-usb-v2 core doesn't know anything about CI. So, the driver needs to handle it by hand. This patch stops CI just before stopping URB's/RC, and restarts it before URB/RC start. It should be noticed that suspend/resume is not yet working properly, as the PM model requires the implementation of reset_resume: dvb_usb_az6007 1-6:1.0: no reset_resume for driver dvb_usb_az6007? But this is not implemented there at dvb-usb-v2 yet. That is true, but it is coming: http://blog.palosaari.fi/2012/07/dvb-power-management-on-suspend.html http://git.linuxtv.org/anttip/media_tree.git/shortlog/refs/heads/dvb_core3 At the time I added initial suspend/resume support for dvb-usb-v2 I left those out purposely as I saw some study and changes are needed for DVB-core/frontend. Normally suspend keeps USB-device powered and calls .resume() on resume. But on certain conditions USB device could lose power during suspend and on that case reset_resume() is called, and if there is no reset_resume() is calls disconnect() (and probe() after that). regards Antti -- http://palosaari.fi/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 3/3] [media] az6007: handle CI during suspend/resume
The dvb-usb-v2 core doesn't know anything about CI. So, the
driver needs to handle it by hand. This patch stops CI just
before stopping URB's/RC, and restarts it before URB/RC start.
It should be noticed that suspend/resume is not yet working properly,
as the PM model requires the implementation of reset_resume:
dvb_usb_az6007 1-6:1.0: no reset_resume for driver dvb_usb_az6007?
But this is not implemented there at dvb-usb-v2 yet.
Cc: Antti Palosaari cr...@iki.fi
Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com
---
drivers/media/dvb/dvb-usb-v2/az6007.c | 25 +++--
1 file changed, 23 insertions(+), 2 deletions(-)
diff --git a/drivers/media/dvb/dvb-usb-v2/az6007.c
b/drivers/media/dvb/dvb-usb-v2/az6007.c
index 4a0ee64..420cb62 100644
--- a/drivers/media/dvb/dvb-usb-v2/az6007.c
+++ b/drivers/media/dvb/dvb-usb-v2/az6007.c
@@ -876,16 +876,37 @@ static struct usb_device_id az6007_usb_table[] = {
MODULE_DEVICE_TABLE(usb, az6007_usb_table);
+static int az6007_suspend(struct usb_interface *intf, pm_message_t msg)
+{
+ struct dvb_usb_device *d = usb_get_intfdata(intf);
+
+ az6007_ci_uninit(d);
+ return dvb_usbv2_suspend(intf, msg);
+}
+
+static int az6007_resume(struct usb_interface *intf)
+{
+ struct dvb_usb_device *d = usb_get_intfdata(intf);
+ struct dvb_usb_adapter *adap = d-adapter[0];
+
+ az6007_ci_init(adap);
+ return dvb_usbv2_resume(intf);
+}
+
/* usb specific object needed to register this driver with the usb subsystem */
static struct usb_driver az6007_usb_driver = {
.name = KBUILD_MODNAME,
.id_table = az6007_usb_table,
.probe = dvb_usbv2_probe,
.disconnect = az6007_usb_disconnect,
- .suspend= dvb_usbv2_suspend,
- .resume = dvb_usbv2_resume,
.no_dynamic_id = 1,
.soft_unbind= 1,
+ /*
+* FIXME: need to implement reset_resume, likely with
+* dvb-usb-v2 core support
+*/
+ .suspend= az6007_suspend,
+ .resume = az6007_resume,
};
module_usb_driver(az6007_usb_driver);
--
1.7.11.2
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
