Re: [PATCH 4/4] media-ctl: add colorimetry support

[Sakari Ailus]

On Tue, Feb 07, 2017 at 05:08:50PM +0100, Philipp Zabel wrote:
> media-ctl can be used to propagate v4l2 subdevice pad formats from
> source pads of one subdevice to another one's sink pads. These formats
> include colorimetry information, so media-ctl should be able to print
> or change it using the --set/get-v4l2 option.
> 
> Signed-off-by: Philipp Zabel 

Acked-by: Sakari Ailus 

-- 
Sakari Ailus
e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk

[PATCH 4/4] media-ctl: add colorimetry support

[Philipp Zabel]

media-ctl can be used to propagate v4l2 subdevice pad formats from
source pads of one subdevice to another one's sink pads. These formats
include colorimetry information, so media-ctl should be able to print
or change it using the --set/get-v4l2 option.

Signed-off-by: Philipp Zabel 
---
 utils/media-ctl/libv4l2subdev.c | 263 
 utils/media-ctl/media-ctl.c |  17 +++
 utils/media-ctl/options.c   |  22 +++-
 utils/media-ctl/v4l2subdev.h|  80 
 4 files changed, 381 insertions(+), 1 deletion(-)

diff --git a/utils/media-ctl/libv4l2subdev.c b/utils/media-ctl/libv4l2subdev.c
index 81d6420f..f01ed89c 100644
--- a/utils/media-ctl/libv4l2subdev.c
+++ b/utils/media-ctl/libv4l2subdev.c
@@ -511,6 +511,118 @@ static struct media_pad *v4l2_subdev_parse_pad_format(
continue;
}
 
+   if (strhazit("colorspace:", )) {
+   enum v4l2_colorspace colorspace;
+   char *strfield;
+
+   for (end = (char *)p; isalnum(*end) || *end == '-';
+++end);
+
+   strfield = strndup(p, end - p);
+   if (!strfield) {
+   *endp = (char *)p;
+   return NULL;
+   }
+
+   colorspace = v4l2_subdev_string_to_colorspace(strfield);
+   free(strfield);
+   if (colorspace == (enum v4l2_colorspace)-1) {
+   media_dbg(media, "Invalid colorspace value 
'%*s'\n",
+ end - p, p);
+   *endp = (char *)p;
+   return NULL;
+   }
+
+   format->colorspace = colorspace;
+
+   p = end;
+   continue;
+   }
+
+   if (strhazit("xfer:", )) {
+   enum v4l2_xfer_func xfer_func;
+   char *strfield;
+
+   for (end = (char *)p; isalnum(*end) || *end == '-';
+++end);
+
+   strfield = strndup(p, end - p);
+   if (!strfield) {
+   *endp = (char *)p;
+   return NULL;
+   }
+
+   xfer_func = v4l2_subdev_string_to_xfer_func(strfield);
+   free(strfield);
+   if (xfer_func == (enum v4l2_xfer_func)-1) {
+   media_dbg(media, "Invalid transfer function 
value '%*s'\n",
+ end - p, p);
+   *endp = (char *)p;
+   return NULL;
+   }
+
+   format->xfer_func = xfer_func;
+
+   p = end;
+   continue;
+   }
+
+   if (strhazit("ycbcr:", )) {
+   enum v4l2_ycbcr_encoding ycbcr_enc;
+   char *strfield;
+
+   for (end = (char *)p; isalnum(*end) || *end == '-';
+++end);
+
+   strfield = strndup(p, end - p);
+   if (!strfield) {
+   *endp = (char *)p;
+   return NULL;
+   }
+
+   ycbcr_enc = 
v4l2_subdev_string_to_ycbcr_encoding(strfield);
+   free(strfield);
+   if (ycbcr_enc == (enum v4l2_ycbcr_encoding)-1) {
+   media_dbg(media, "Invalid YCbCr encoding value 
'%*s'\n",
+ end - p, p);
+   *endp = (char *)p;
+   return NULL;
+   }
+
+   format->ycbcr_enc = ycbcr_enc;
+
+   p = end;
+   continue;
+   }
+
+   if (strhazit("quantization:", )) {
+   enum v4l2_quantization quantization;
+   char *strfield;
+
+   for (end = (char *)p; isalnum(*end) || *end == '-';
+++end);
+
+   strfield = strndup(p, end - p);
+   if (!strfield) {
+   *endp = (char *)p;
+   return NULL;
+   }
+
+   quantization = 
v4l2_subdev_string_to_quantization(strfield);
+   free(strfield);
+   if (quantization == (enum v4l2_quantization)-1) {
+   media_dbg(media, "Invalid quantization value 
'%*s'\n",
+ end - p, p);
+