On Tue, Sep 7, 2010 at 5:51 PM, David Härdeman <da...@hardeman.nu> wrote: > This patch merges the ir_input_dev and ir_dev_props structs into a single > struct called rc_dev. The drivers and various functions in rc-core used > by the drivers are also changed to use rc_dev as the primary interface > when dealing with rc-core. > > This means that the input_dev is abstracted away from the drivers which > is necessary if we ever want to support multiple input devs per rc device. > > The new API is similar to what the input subsystem uses, i.e: > rc_device_alloc() > rc_device_free() > rc_device_register() > rc_device_unregister() > > Signed-off-by: David Härdeman <da...@hardeman.nu>
I've only looked at the core pieces of the patch and spot-checked the drivers and decoders I'm most familiar with thus far, but I'm *very* much in favor of this patch. The parts I've looked at are a very nice improvement that greatly simplifies the interface, and should eliminate multiple possible coding failure points and reduce duplication (a few sections of imon, mceusb and streamzap all looked pretty damned similar, this patch removes the bulk of that duplication and abstracts it away). With the caveat that I haven't actually functionally tested it yet, nor looked at every single bit of it: Acked-by: Jarod Wilson <ja...@redhat.com> -- Jarod Wilson ja...@wilsonet.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
